Subject: bug#41556: closed (Re: [bug#41556] [PATCH] gnu: aegis: Update homepage link and fix build failure)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 27 May 2020 11:35:02 +0000

Your bug report

#41556: [PATCH]     gnu: aegis: Update homepage link and fix build failure

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41556: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41556
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#41556] [PATCH] gnu: aegis: Update homepage link and fix build failure
From: Tobias Geerinckx-Rice <[email-masked]>
To: Josh Marshall <[email-masked]>
Cc: [email-masked]
Date: Wed, 27 May 2020 13:34:28 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Josh,

Josh Marshall 写道：
>     * gnu/packages/version-control.scm (aegis):
  ^^^^

‘git log’ adds 4 leading spaces to commit message bodies but you 
don't need to add (or, I presume, copy/paste :-) them yourself.

> Update homepage link and fix build failure

Thanks!  I've split these two unrelated changes into two commits.

SF project pages aren't goot home pages but this project looks 
very dead indeed.  Are you fixing this because you use it?

> @@ -1885,7 +1885,10 @@ accessed and migrated on modern 
> systems.")
>         ("ed" ,ed)))
>      (arguments
>       `(#:configure-flags (list "--with-no-aegis-configured"
> - 
> "--sharedstatedir=/var/com/aegis")
> + 
> "--sharedstatedir=/var/com/aegis"
> +			       ;; Uses the old 'throw()' specifier 
> with 'new'
> +			       ;; which changed in C++11.
> +			       "CXXFLAGS=-std=c++03")
    ^^^^…

It's worth running ‘guix lint’ even after trivial changes: these 
are tabs & we're a spaces family.  Changed and pushed as 
812dad08764af5ae4d80394732dcc1481742db3a et al.

Kind regards,

T G-R

Subject: [PATCH] gnu: aegis: Update homepage link and fix build failure
From: Josh Marshall <[email-masked]>
To: [email-masked]
Cc: Josh Marshall <[email-masked]>
Date: Tue, 26 May 2020 23:12:26 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

    * gnu/packages/version-control.scm (aegis): Update homepage link and fix build failure
---
 gnu/packages/version-control.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 09ffd8f271..deb746db26 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1885,7 +1885,10 @@ accessed and migrated on modern systems.")
        ("ed" ,ed)))
     (arguments
      `(#:configure-flags (list "--with-no-aegis-configured"
-                               "--sharedstatedir=/var/com/aegis")
+                               "--sharedstatedir=/var/com/aegis"
+			       ;; Uses the old 'throw()' specifier with 'new'
+			       ;; which changed in C++11.
+			       "CXXFLAGS=-std=c++03")
        #:parallel-build? #f ; There are some nasty racy rules in the Makefile.
        #:phases
        (modify-phases %standard-phases
@@ -1928,7 +1931,7 @@ accessed and migrated on modern systems.")
 
                ;; The author decided to call the check rule "sure".
                (invoke "make" "sure")))))))
-    (home-page "http://aegis.sourceforge.net")
+    (home-page "https://sourceforge.net/projects/aegis/")
     (synopsis "Project change supervisor")
     (description "Aegis is a project change supervisor, and performs some of
 the Software Configuration Management needed in a CASE environment.  Aegis
-- 
2.26.2