Subject: bug#41553: closed (Re: [bug#41553] [PATCH] gnu: Add spectacle-analyzer.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 30 May 2020 11:46:02 +0000

Your bug report

#41553: [PATCH] gnu: Add spectacle-analyzer.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41553: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41553
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#41553] [PATCH] gnu: Add spectacle-analyzer.
From: Marius Bakke <[email-masked]>
To: Alexandros Theodotou <[email-masked]>, [email-masked]
Date: Sat, 30 May 2020 13:45:14 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Alexandros Theodotou <[email-masked]> writes:

> Hi,
>
> This patch adds spectacle analyzer, an LV2 graphical spectrum analyzer
> (audio plugin).

Thanks!  Applied with the following changes:

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 08b9c19ec9..ac149a804c 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -141,6 +141,7 @@
   #:use-module (gnu packages tls)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages wxwidgets)
   #:use-module (gnu packages xml)
@@ -4945,17 +4946,17 @@ and debugging of event signal flows inside plugin graphs.")
     (name "spectacle-analyzer")
     (version "1.0")
     (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-               (url "https://github.com/jpcima/spectacle.git")
-               (commit (string-append "v" version))
-               ;; Bundles a specific commit of the DISTRHO plugin framework.
-               (recursive? #t)))
-        (file-name (git-file-name name version))
-        (sha256
-          (base32
-            "0xiqa6z8g68lcvnwhws4j7c4py35r9d20cirrili7ycyp3a6149a"))))
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jpcima/spectacle.git")
+             (commit (string-append "v" version))
+             ;; Bundles a specific commit of the DISTRHO plugin framework.
+             (recursive? #t)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0xiqa6z8g68lcvnwhws4j7c4py35r9d20cirrili7ycyp3a6149a"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f                      ; no check target
@@ -4969,17 +4970,19 @@ and debugging of event signal flows inside plugin graphs.")
      `(("pkg-config" ,pkg-config)
        ("xxd" ,xxd)))
     (inputs
-      `(("cairo", cairo)
-        ("fftw", fftw)
-        ("fftwf", fftwf)
-        ("jack", jack-1)
-        ("lv2", lv2)
-        ("mesa", mesa)))
+     `(("cairo", cairo)
+       ("fftw", fftw)
+       ("fftwf", fftwf)
+       ("jack", jack-1)
+       ("lv2", lv2)
+       ("mesa", mesa)))
     (synopsis "Realtime graphical spectrum analyzer")
     (description "Spectacle is a real-time spectral analyzer using the
 short-time Fourier transform, available as LV2 audio plugin and JACK client.")
     (home-page "https://github.com/jpcima/spectacle")
-    (license license:isc)))
+    ;; The project is licensed under the ISC license, and files in
+    ;; sources/plugin carry the Expat license.
+    (license (list license:isc license:expat))))
 
 (define-public x42-plugins
   (package

Subject: [PATCH] gnu: Add spectacle-analyzer.
From: Alexandros Theodotou <[email-masked]>
To: Guix patches <[email-masked]>
Date: Wed, 27 May 2020 01:44:02 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

This patch adds spectacle analyzer, an LV2 graphical spectrum analyzer
(audio plugin).

Thanks,
Alex
From 8fa72560cb851d63eff6c8c77a1bc05bd4f5c820 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <[email-masked]>
Date: Wed, 27 May 2020 01:41:39 +0100
Subject: [PATCH] gnu: Add spectacle-analyzer.

* gnu/packages/music.scm (spectacle-analyzer): new variable.
---
 gnu/packages/music.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 9cfda8e88c..4edb4dccf3 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4935,6 +4935,47 @@ and debugging of event signal flows inside plugin graphs.")
     (home-page "https://open-music-kontrollers.ch/lv2/sherlock/")
     (license license:artistic2.0)))
 
+(define-public spectacle-analyzer
+  (package
+    (name "spectacle-analyzer")
+    (version "1.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/jpcima/spectacle.git")
+               (commit (string-append "v" version))
+               ;; Bundles a specific commit of the DISTRHO plugin framework.
+               (recursive? #t)))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0xiqa6z8g68lcvnwhws4j7c4py35r9d20cirrili7ycyp3a6149a"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                      ; no check target
+       #:make-flags
+       (list "CC=gcc"
+             (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("xxd" ,xxd)))
+    (inputs
+      `(("cairo", cairo)
+        ("fftw", fftw)
+        ("fftwf", fftwf)
+        ("jack", jack-1)
+        ("lv2", lv2)
+        ("mesa", mesa)))
+    (synopsis "Realtime graphical spectrum analyzer")
+    (description "Spectacle is a real-time spectral analyzer using the
+short-time Fourier transform, available as LV2 audio plugin and JACK client.")
+    (home-page "https://github.com/jpcima/spectacle")
+    (license license:isc)))
+
 (define-public x42-plugins
   (package
     (name "x42-plugins")
-- 
2.26.2