Subject: Re: [bug#41552] [PATCH] gnu: Add remid-lv2.

From: Marius Bakke <[email-masked]>
Date: Sat, 30 May 2020 13:33:17 +0200

Alexandros Theodotou <[email-masked]> writes:

> Hi,
>
> This patch adds the reMID LV2 plugin.

Thanks!

[...]

> +(define-public remid-lv2
> +  (package
> +    (name "remid-lv2")
> +    (version "0.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://github.com/ssj71/"
> +                            "reMID.lv2/archive/v"
> +                            version ".tar.gz"))

The GitHub /archive/ URLs are not stable: they might fall out of GitHubs
cache and be regenerated, with different time stamps.  So we should use
git-fetch here instead.

This is different from "/releases/", which are uploaded.  Unfortunately
GitHubs UI makes it difficult to tell the difference short of looking at
the URL.

> +        (file-name (string-append name "-" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f))                      ; no tests included
> +    (inputs
> +     `(("glib" ,glib)
> +       ("alsa-lib" ,alsa-lib)
> +       ("jack" ,jack-1)
> +       ("lv2" ,lv2)))

Nit: we usually sort inputs.  Helpful when there are dozens.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "https://github.com/ssj71/reMID.lv2")
> +    (synopsis
> +      "MIDI-controlled implementation of the SID 6581 chip used in the
> +Commodore 64")
> +    (description
> +      "The 6581 SID chip is the sound chip used in the Commodore 64 computer.
> +reMID is a MIDI implementation of the 6581 SID chip using the reSID library
> +to provide a virtual SID-based synthesizer, controllable in real-time via
> +MIDI.  It includes support for scripted instruments that allow complex sonic
> +control of the chip.")

Why yes, I know some of these words :-) would it make sense to define
"SID" here with @acronym?

> +    (license license:gpl2)))

This is actually GPL2+, because none of the source files say "version 2
only" (and some actually say explicitly GPL2-or-later).

Can you send an updated patch?