GNU bug report logs - #41551
[PATCH] gnu: Add emacs-bm.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41551 in the body.
You can then email your comments to 41551 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-bm.
Date: Wed, 27 May 2020 01:41:05 +0200

[0001-gnu-Add-emacs-bm.patch (text/x-patch, inline)]

From edd01faf84a59499a9a83b336d55828aadd6bfa3 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Wed, 27 May 2020 01:37:42 +0200
Subject: [PATCH] gnu: Add emacs-bm.

* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b99acb7815..34afc73d8e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1860,6 +1860,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text
 searches.  Unlike code@{emacs-wiki.el}, it can be combined with any format.")
     (license license:gpl1+)))
 
+(define-public emacs-bm
+  (package
+    (name "emacs-bm")
+    (version "201905")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/joodland/bm.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/joodland/bm")
+    (synopsis "Visual Bookmarks for Emacs")
+    (description "This package provides visible, buffer local, bookmarks and
+the ability to jump forward and backward to the next bookmark.")
+    (license license:gpl2+)))
+
 (define-public emacs-calfw
   (package
     (name "emacs-calfw")
-- 
2.26.2

[Message part 2 (text/plain, inline)]

-- 
There are three kinds of people: men, women, and unix.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41551 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>, 41551 <at> debbugs.gnu.org
Subject: Re: [bug#41551] [PATCH] gnu: Add emacs-bm.
Date: Sat, 30 May 2020 13:50:37 +0200

[Message part 1 (text/plain, inline)]

Michael Rohleder <mike <at> rohleder.de> writes:

> From edd01faf84a59499a9a83b336d55828aadd6bfa3 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Wed, 27 May 2020 01:37:42 +0200
> Subject: [PATCH] gnu: Add emacs-bm.
>
> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.

Thanks!  It LGTM but no longer applies, can you rebase it on the current
master branch?
  
> +(define-public emacs-bm
> +  (package
> +    (name "emacs-bm")
> +    (version "201905")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/joodland/bm.git")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/joodland/bm")
> +    (synopsis "Visual Bookmarks for Emacs")
                        ^^^
              Lowercase 'b'.

> +    (description "This package provides visible, buffer local, bookmarks and
> +the ability to jump forward and backward to the next bookmark.")

The description reads a bit weird, I wonder if...

  "visible, buffer local bookmarks" (without the second comma)

...is more correct?

Can you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41551 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Marius Bakke <marius <at> gnu.org>
Cc: 41551 <at> debbugs.gnu.org
Subject: Re: [bug#41551] [PATCH] gnu: Add emacs-bm.
Date: Sat, 30 May 2020 19:55:31 +0200

[Message part 1 (text/plain, inline)]

Hi Marius,

you have an impressive pensum!
Thanks for the review!

Marius Bakke <marius <at> gnu.org> writes:
>> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
>
> Thanks!  It LGTM but no longer applies, can you rebase it on the current
> master branch?

done.

>> +    (synopsis "Visual Bookmarks for Emacs")
>                         ^^^
>               Lowercase 'b'.

done.

>> +    (description "This package provides visible, buffer local, bookmarks and
>> +the ability to jump forward and backward to the next bookmark.")
>
> The description reads a bit weird, I wonder if...
>
>   "visible, buffer local bookmarks" (without the second comma)
>
> ...is more correct?

seems more correct, yes => done.

[0001-gnu-Add-emacs-bm.patch (text/x-patch, inline)]

From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Sat, 30 May 2020 19:50:02 +0200
Subject: [PATCH] gnu: Add emacs-bm.

* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6d82e1921c..9cf4cdd6a1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1918,6 +1918,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text
 searches.  Unlike code@{emacs-wiki.el}, it can be combined with any format.")
     (license license:gpl1+)))
 
+(define-public emacs-bm
+  (package
+    (name "emacs-bm")
+    (version "201905")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/joodland/bm.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/joodland/bm")
+    (synopsis "Visual bookmarks for Emacs")
+    (description "This package provides visible, buffer local bookmarks and
+the ability to jump forward and backward to the next bookmark.")
+    (license license:gpl2+)))
+
 (define-public emacs-calfw
   (package
     (name "emacs-calfw")
-- 
2.26.2

[Message part 3 (text/plain, inline)]

-- 
In short, I think gcc should be fixed, or at the very least it should be a
_documented_ bug at which point I have no gripe with fixing it in the
kernel. But I refuse to work around undocumented bugs - that starts to
smell too much like microsoft, and then I might as well start using
Windows myself. 
                Linus

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 41551-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 41551-done <at> debbugs.gnu.org
Subject: Re: [bug#41551] [PATCH] gnu: Add emacs-bm.
Date: Sat, 30 May 2020 23:16:56 +0200

[Message part 1 (text/plain, inline)]

Michael Rohleder <mike <at> rohleder.de> writes:

> Hi Marius,
>
> you have an impressive pensum!

Heh, not sure if that's meant as a compliment, but I'll take it.  ;-)

> Thanks for the review!

You are welcome!

[...]

> From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Sat, 30 May 2020 19:50:02 +0200
> Subject: [PATCH] gnu: Add emacs-bm.
>
> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.

Applied, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.