GNU bug report logs - #41541
merge wip-hurd-vm

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: 41541 <at> debbugs.gnu.org
Subject: [bug#41541] [PATCH 7/8] services: hurd: Add `hurd-etc-service'.
Date: Sun, 07 Jun 2020 22:02:05 +0200

Hi,

Jan Nieuwenhuizen <janneke <at> gnu.org> skribis:

> From 4cef6e73ce9fd137640c1c00f98958cdc41dda90 Mon Sep 17 00:00:00 2001
> From: "Jan (janneke) Nieuwenhuizen" <janneke <at> gnu.org>
> Date: Sat, 25 Apr 2020 11:55:56 +0200
> Subject: [PATCH] services: Support etc-service for the Hurd.
>
> * gnu/system.scm (operating-system-etc-service): Cater for missing nsswitch
> and missing sudoers-file.  For the Hurd, add "login" and "motd".
> (hurd-default-essential-services): Add operating-system-etc-service.

Perfect!
  
[...]

> +       ,@(if sudoers `(("sudoers" ,sudoers)) '())
> +       ,@(if hurd `(("login" ,(file-append hurd "/etc/login"))
> +                    ("motd"  ,(file-append hurd "/etc/motd"))))))))

We’re missing the ‘else’ branch  here.

Apart from that, LGTM!

Thank you,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.