Subject: Re: bug#41541: [PATCH 7/8] services: hurd: Add `hurd-etc-service'.

From: Ludovic Courtès <[email-masked]>
Date: Sun, 07 Jun 2020 22:02:05 +0200

Hi,

Jan Nieuwenhuizen <[email-masked]> skribis:

> From 4cef6e73ce9fd137640c1c00f98958cdc41dda90 Mon Sep 17 00:00:00 2001
> From: "Jan (janneke) Nieuwenhuizen" <[email-masked]>
> Date: Sat, 25 Apr 2020 11:55:56 +0200
> Subject: [PATCH] services: Support etc-service for the Hurd.
>
> * gnu/system.scm (operating-system-etc-service): Cater for missing nsswitch
> and missing sudoers-file.  For the Hurd, add "login" and "motd".
> (hurd-default-essential-services): Add operating-system-etc-service.

Perfect!
  
[...]

> +       ,@(if sudoers `(("sudoers" ,sudoers)) '())
> +       ,@(if hurd `(("login" ,(file-append hurd "/etc/login"))
> +                    ("motd"  ,(file-append hurd "/etc/motd"))))))))

We’re missing the ‘else’ branch  here.

Apart from that, LGTM!

Thank you,
Ludo’.