From unknown Tue Jun 17 22:18:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41511: [PATCH] Decode group name before matching against gnus-parameters Resent-From: =?UTF-8?Q?=C5=81ukasz?= Stelmach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 May 2020 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41511 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 41511@debbugs.gnu.org Cc: =?UTF-8?Q?=C5=81ukasz?= Stelmach X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159033962211556 (code B ref -1); Sun, 24 May 2020 17:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 May 2020 17:00:22 +0000 Received: from localhost ([127.0.0.1]:38564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jctz3-00030K-Vz for submit@debbugs.gnu.org; Sun, 24 May 2020 13:00:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:43674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jctz2-00030D-OI for submit@debbugs.gnu.org; Sun, 24 May 2020 13:00:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jctz2-0002Us-Fe for bug-gnu-emacs@gnu.org; Sun, 24 May 2020 13:00:20 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.233]:40320) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jctyz-0000o3-5t for bug-gnu-emacs@gnu.org; Sun, 24 May 2020 13:00:19 -0400 X-Interia-R: Interia X-Interia-R-IP: 185.220.101.9 X-Interia-R-Helo: Received: from localhost (unknown [185.220.101.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by www.poczta.fm (INTERIA.PL) with ESMTPSA; Sun, 24 May 2020 19:00:10 +0200 (CEST) From: =?UTF-8?Q?=C5=81ukasz?= Stelmach Date: Sun, 24 May 2020 18:59:40 +0200 Message-Id: <20200524165940.13507-1-stlman@poczta.fm> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Interia-Antivirus: OK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1590339611; bh=d4JbX1q+7PY2VbwgPEFNKps9HOnVs942HtNGTBVmKMM=; h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:From:To:Cc:Subject: Date:Message-Id:X-Mailer:MIME-Version:Content-Type: Content-Transfer-Encoding:X-Interia-Antivirus; b=l8ry7A6KJ9n317+WDrboJodUciXK9sMQUSfuraGgcsJAGmzgVXpdAxbexyEOmz79D ueNslolse7hpRMsjqHbES3Qp3M2iNzOhykZNPUvXnCq6vuyM9RhFzsdZvdsGFh/Hoy Id1z9oTidmbwSLgDyZA7wyausx1ycCbo44FJ0fnY= Received-SPF: pass client-ip=217.74.65.233; envelope-from=stlman@poczta.fm; helo=smtpo.poczta.interia.pl X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/24 13:00:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Group names in Gnus are stored and processed as strings of bytes (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in gnus-parameters are encoded as multibyte strings (e.g. "=?UTF-8?Q?Wiadomo=C5=9B?= [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: interia.pl] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stlman[at]poczta.fm) 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=stlman%40poczta.fm;ip=209.51.188.17;r=debbugs.gnu.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) Group names in Gnus are stored and processed as strings of bytes (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in gnus-parameters are encoded as multibyte strings (e.g. "Wiadomości-śmieci") and matching the latter aginst the former doesn't work. Parameters set for groups with non-ascii characters in their names cannot be retrieved. To fix this problem group name needs to be decoded before being matched against a regexp. * gnus.el (gnus-parameters-get-parameter, gnus-group-fast-parameter, gnus-define-group-parameter): Decode a group name before matching against a regexp. --- lisp/gnus/gnus.el | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index caeab7f55a..e7621872d8 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -947,6 +947,7 @@ REST is a plist of following: (string-match ,variable name)) (,variable (let ((alist ,variable) + (decoded-name (gnus-group-decoded-name name)) elem value) (while (setq elem (pop alist)) (when (and name @@ -959,6 +960,7 @@ REST is a plist of following: (and name (or (gnus-group-find-parameter name ',param ,(and type t)) (let ((alist ,variable) + (decoded-name (gnus-group-decoded-name name)) elem value) (while (setq elem (pop alist)) (when (and name @@ -3513,9 +3515,10 @@ You should probably use `gnus-find-method-for-group' instead." (let ((case-fold-search (if (eq gnus-parameters-case-fold-search 'default) case-fold-search gnus-parameters-case-fold-search)) + (decoded-group (gnus-group-decoded-name group)) params-list) (dolist (elem gnus-parameters) - (when (string-match (car elem) group) + (when (string-match (car elem) decoded-group) (setq params-list (nconc (gnus-expand-group-parameters (car elem) (cdr elem) group) @@ -3569,7 +3572,8 @@ The function `gnus-group-find-parameter' will do that for you." (let* ((params (funcall gnus-group-get-parameter-function group)) ;; Start easy, check the "real" group parameters. (simple-results - (gnus-group-parameter-value params symbol allow-list t))) + (gnus-group-parameter-value params symbol allow-list t)) + (decoded-group (gnus-group-decoded-name group))) (if simple-results ;; Found results; return them. (car simple-results) @@ -3582,7 +3586,7 @@ The function `gnus-group-find-parameter' will do that for you." (setq head (car tail) tail (cdr tail)) ;; The car is regexp matching for matching the group name. - (when (string-match (car head) group) + (when (string-match (car head) decoded-group) ;; The cdr is the parameters. (let ((this-result (gnus-group-parameter-value (cdr head) symbol allow-list t))) -- 2.20.1 From unknown Tue Jun 17 22:18:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41511: [PATCH v2] Decode group name before matching against gnus-parameters Resent-From: =?UTF-8?Q?=C5=81ukasz?= Stelmach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 May 2020 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41511 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 41511@debbugs.gnu.org Cc: =?UTF-8?Q?=C5=81ukasz?= Stelmach Received: via spool by 41511-submit@debbugs.gnu.org id=B41511.159034059313021 (code B ref 41511); Sun, 24 May 2020 17:17:02 +0000 Received: (at 41511) by debbugs.gnu.org; 24 May 2020 17:16:33 +0000 Received: from localhost ([127.0.0.1]:38583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcuEj-0003Nx-2x for submit@debbugs.gnu.org; Sun, 24 May 2020 13:16:33 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.233]:50938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcuEg-0003Ni-Ai for 41511@debbugs.gnu.org; Sun, 24 May 2020 13:16:31 -0400 X-Interia-R: Interia X-Interia-R-IP: 185.220.101.146 X-Interia-R-Helo: Received: from localhost (unknown [185.220.101.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by www.poczta.fm (INTERIA.PL) with ESMTPSA; Sun, 24 May 2020 19:16:22 +0200 (CEST) From: =?UTF-8?Q?=C5=81ukasz?= Stelmach Date: Sun, 24 May 2020 19:16:15 +0200 Message-Id: <20200524171615.14557-1-stlman@poczta.fm> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200524165940.13507-1-stlman@poczta.fm> References: <20200524165940.13507-1-stlman@poczta.fm> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Interia-Antivirus: OK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1590340583; bh=jOFdxu0yWlBNdAMs2Cyv2P/AFELtPAQ9Y67Pv7ZoYpw=; h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:From:To:Cc:Subject: Date:Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Interia-Antivirus; b=v4FSY5uZihbtlOEzA52P2+AMGhDeX7hLEQOVWvLsoPmXyahXsnmg8lC3VdN/sOufw PugXTR/c+776tOf3jn6zCNZ1IazmMuS09YcknPCZEFHES3aiN0cIdN6ZEPe8zQKTss LEjbybjWxWLdvUGeaohsj1WUMEkHjlQntGRL7qoE= X-Spam-Score: 4.1 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Group names in Gnus are stored and processed as strings of bytes (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in gnus-parameters are encoded as multibyte strings (e.g. "=?UTF-8?Q?Wiadomo=C5=9B?= [...] Content analysis details: (4.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: interia.pl] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.220.101.146 listed in zen.spamhaus.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.74.65.233 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.74.65.233 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stlman[at]poczta.fm) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.1 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Group names in Gnus are stored and processed as strings of bytes (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in gnus-parameters are encoded as multibyte strings (e.g. "=?UTF-8?Q?Wiadomo=C5=9B?= [...] Content analysis details: (3.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: interia.pl] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.74.65.233 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.74.65.233 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.220.101.146 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stlman[at]poczta.fm) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Group names in Gnus are stored and processed as strings of bytes (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in gnus-parameters are encoded as multibyte strings (e.g. "Wiadomości-śmieci") and matching the latter aginst the former doesn't work. Parameters set for groups with non-ascii characters in their names cannot be retrieved. To fix this problem group name needs to be decoded before being matched against a regexp. * gnus.el (gnus-parameters-get-parameter, gnus-group-fast-parameter, gnus-define-group-parameter): Decode a group name before matching against a regexp. --- lisp/gnus/gnus.el | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) v2: - actually use the decoded-name instead of name in gnus-define-group-parameter diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index caeab7f55a..e1fea35fdd 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -947,10 +947,11 @@ REST is a plist of following: (string-match ,variable name)) (,variable (let ((alist ,variable) + (decoded-name (gnus-group-decoded-name name)) elem value) (while (setq elem (pop alist)) (when (and name - (string-match (car elem) name)) + (string-match (car elem) decoded-name)) (setq alist nil value (cdr elem)))) (if (consp value) (car value) value)))))) @@ -959,10 +960,11 @@ REST is a plist of following: (and name (or (gnus-group-find-parameter name ',param ,(and type t)) (let ((alist ,variable) + (decoded-name (gnus-group-decoded-name name)) elem value) (while (setq elem (pop alist)) (when (and name - (string-match (car elem) name)) + (string-match (car elem) decoded-name)) (setq alist nil value (cdr elem)))) ,(if type @@ -3513,9 +3515,10 @@ You should probably use `gnus-find-method-for-group' instead." (let ((case-fold-search (if (eq gnus-parameters-case-fold-search 'default) case-fold-search gnus-parameters-case-fold-search)) + (decoded-group (gnus-group-decoded-name group)) params-list) (dolist (elem gnus-parameters) - (when (string-match (car elem) group) + (when (string-match (car elem) decoded-group) (setq params-list (nconc (gnus-expand-group-parameters (car elem) (cdr elem) group) @@ -3569,7 +3572,8 @@ The function `gnus-group-find-parameter' will do that for you." (let* ((params (funcall gnus-group-get-parameter-function group)) ;; Start easy, check the "real" group parameters. (simple-results - (gnus-group-parameter-value params symbol allow-list t))) + (gnus-group-parameter-value params symbol allow-list t)) + (decoded-group (gnus-group-decoded-name group))) (if simple-results ;; Found results; return them. (car simple-results) @@ -3582,7 +3586,7 @@ The function `gnus-group-find-parameter' will do that for you." (setq head (car tail) tail (cdr tail)) ;; The car is regexp matching for matching the group name. - (when (string-match (car head) group) + (when (string-match (car head) decoded-group) ;; The cdr is the parameters. (let ((this-result (gnus-group-parameter-value (cdr head) symbol allow-list t))) -- 2.20.1 From unknown Tue Jun 17 22:18:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41511: [PATCH v2] Decode group name before matching against gnus-parameters Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 May 2020 22:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41511 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=C5=81ukasz?= Stelmach Cc: 41511@debbugs.gnu.org Received: via spool by 41511-submit@debbugs.gnu.org id=B41511.159035786932496 (code B ref 41511); Sun, 24 May 2020 22:05:02 +0000 Received: (at 41511) by debbugs.gnu.org; 24 May 2020 22:04:29 +0000 Received: from localhost ([127.0.0.1]:38980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcyjN-0008S4-BQ for submit@debbugs.gnu.org; Sun, 24 May 2020 18:04:29 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:40170 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcyjL-0008Rr-Pn for 41511@debbugs.gnu.org; Sun, 24 May 2020 18:04:28 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A5BBFFA086; Sun, 24 May 2020 22:04:21 +0000 (UTC) From: Eric Abrahamsen References: <20200524165940.13507-1-stlman@poczta.fm> <20200524171615.14557-1-stlman@poczta.fm> Date: Sun, 24 May 2020 15:04:19 -0700 In-Reply-To: <20200524171615.14557-1-stlman@poczta.fm> ("=?UTF-8?Q?=C5=81ukasz?= Stelmach"'s message of "Sun, 24 May 2020 19:16:15 +0200") Message-ID: <87blmduh0c.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) =C5=81ukasz Stelmach writes: > Group names in Gnus are stored and processed as strings of bytes > (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in > gnus-parameters are encoded as multibyte strings (e.g. "Wiadomo=C5=9Bci-= =C5=9Bmieci") > and matching the latter aginst the former doesn't work. Parameters set > for groups with non-ascii characters in their names cannot be retrieved. Group names in Gnus have been fully decoded strings for six months or more -- are you seeing this bug in master? From unknown Tue Jun 17 22:18:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41511: [PATCH v2] Decode group name before matching against gnus-parameters Resent-From: =?UTF-8?Q?=C5=81ukasz?= Stelmach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 May 2020 07:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41511 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eric Abrahamsen Cc: 41511@debbugs.gnu.org Received: via spool by 41511-submit@debbugs.gnu.org id=B41511.15903917695463 (code B ref 41511); Mon, 25 May 2020 07:30:03 +0000 Received: (at 41511) by debbugs.gnu.org; 25 May 2020 07:29:29 +0000 Received: from localhost ([127.0.0.1]:39642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd7Y8-0001Q3-PY for submit@debbugs.gnu.org; Mon, 25 May 2020 03:29:29 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.233]:57701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd7Y5-0001Pn-Kx for 41511@debbugs.gnu.org; Mon, 25 May 2020 03:29:26 -0400 X-Interia-R: Interia X-Interia-R-IP: 185.220.101.207 X-Interia-R-Helo: Received: from localhost (unknown [185.220.101.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by www.poczta.fm (INTERIA.PL) with ESMTPSA; Mon, 25 May 2020 09:29:17 +0200 (CEST) From: =?UTF-8?Q?=C5=81ukasz?= Stelmach References: <20200524165940.13507-1-stlman@poczta.fm> <20200524171615.14557-1-stlman@poczta.fm> <87blmduh0c.fsf@ericabrahamsen.net> X-Hashcash: 1:24:200525:41511@debbugs.gnu.org::+YD5D8T6hHjZ3CyK:fcmE X-Hashcash: 1:24:200525:eric@ericabrahamsen.net::JJBlUAkq+botm0MC:05GOj Date: Mon, 25 May 2020 09:29:07 +0200 In-Reply-To: <87blmduh0c.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 24 May 2020 15:04:19 -0700") Message-ID: <875zck4gn0.fsf%stlman@poczta.fm> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Interia-Antivirus: OK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1590391758; bh=0KVMGn/3ewoegJcC/IVNJv5323DqyZp/nvlIpz/QRvk=; h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:From:To:Cc:Subject: References:X-Hashcash:X-Hashcash:Date:In-Reply-To:Message-ID: User-Agent:MIME-Version:Content-Type:X-Interia-Antivirus; b=nawAQAUsXPZsZlZYnWcxPx+alJNzKotvD6gi/a09GIXPUV4frDO4GDhcGl6VzHZPe u7jzlR35uJXECrMGnK5iHq53piRpv8pS8uNwoVv8+XdXtgovWEWMSVJNDBJ6X4r56D Pv7F++O4nz2YR0REWTmLcCfKmTN/khO6WhD1qE74= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eric Abrahamsen writes: > =C5=81ukasz Stelmach writes: > >> Group names in Gnus are stored and processed as strings of bytes >> (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in >> gnus-parameters are encoded as multibyte strings (e.g. "Wiadomo=C5=9Bci-= =C5=9Bmieci") >> and matching the latter aginst the former doesn't work. Parameters set >> for groups with non-ascii characters in their names cannot be retrieved. > > Group names in Gnus have been fully decoded strings for six months or > more -- are you seeing this bug in master? Shame on me. I created the patch on 26.1, cherry-picked it to master, tested and assumed it was still needed because it applied without issues and worked as expected. This bug can be closed then. Kind regards, =2D-=20 Mi=C5=82ego dnia, =C5=81ukasz Stelmach --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEkPlMeih05HaDBMFPALaXbGOR03EFAl7Lc8VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDkw Rjk0QzdBMjg3NEU0NzY4MzA0QzE0RjAwQjY5NzZDNjM5MUQzNzEACgkQALaXbGOR 03GAFwf+LTorDol+UWE0T80tB/dccHgJ6HLRn82UfKQx/1IZ9lp2OK/lKcNP2M+/ v99Jg6Dxz9fHZl03DaOuHgsP61NJi2dMH1502eL+QLNZu56F6DPhJaWFeVeO3dYE z1+K1uRNYKVasPV79+URC2IxpeSdjf6lWAdrvUt5svaPjrG3+dtq0Vkv5DSqEQ3E H0bAtqQQx9htBfzOsFf2O8p08dnWtQBzE8dsyG3wDMtqw1uYSUdTl54bcBxArqUy tx8StU7MRyo8DdKUlVY5iRHThAQa+XVfFB54EALM+5wTIBa0AhbUwPFY/4E3H1IN aVaaZIyzIhq3vMqQ8iMg/hJwr1ym4w== =gC0m -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 17 22:18:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41511: [PATCH v2] Decode group name before matching against gnus-parameters Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 May 2020 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41511 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=C5=81ukasz?= Stelmach Cc: Debbugs control , 41511@debbugs.gnu.org Received: via spool by 41511-submit@debbugs.gnu.org id=B41511.15904177997596 (code B ref 41511); Mon, 25 May 2020 14:44:01 +0000 Received: (at 41511) by debbugs.gnu.org; 25 May 2020 14:43:19 +0000 Received: from localhost ([127.0.0.1]:42092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdEJy-0001yR-RE for submit@debbugs.gnu.org; Mon, 25 May 2020 10:43:19 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:57104 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdEJx-0001yB-MJ; Mon, 25 May 2020 10:43:18 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 6AADFFA0E2; Mon, 25 May 2020 14:43:10 +0000 (UTC) From: Eric Abrahamsen References: <20200524165940.13507-1-stlman@poczta.fm> <20200524171615.14557-1-stlman@poczta.fm> <87blmduh0c.fsf@ericabrahamsen.net> <875zck4gn0.fsf%stlman@poczta.fm> Date: Mon, 25 May 2020 07:43:08 -0700 In-Reply-To: <875zck4gn0.fsf%stlman@poczta.fm> ("=?UTF-8?Q?=C5=81ukasz?= Stelmach"'s message of "Mon, 25 May 2020 09:29:07 +0200") Message-ID: <87mu5wt6rn.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 41511 thanks =C5=81ukasz Stelmach writes: > Eric Abrahamsen writes: >> =C5=81ukasz Stelmach writes: >> >>> Group names in Gnus are stored and processed as strings of bytes >>> (e.g. "Wiadomo\305\233ci-\305\233mieci") while regular expressions in >>> gnus-parameters are encoded as multibyte strings (e.g. "Wiadomo=C5=9Bci= -=C5=9Bmieci") >>> and matching the latter aginst the former doesn't work. Parameters set >>> for groups with non-ascii characters in their names cannot be retrieved. >> >> Group names in Gnus have been fully decoded strings for six months or >> more -- are you seeing this bug in master? > > Shame on me. I created the patch on 26.1, cherry-picked it to master, > tested and assumed it was still needed because it applied without issues > and worked as expected. Good news! You had me very worried for a second there :)