GNU bug report logs - #41489
`package-dir-info' fails on a directory with a non-saved file

Previous Next

Full log

Message #23 received at 41489 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 41489 <at> debbugs.gnu.org
Subject: Re: bug#41489: `package-dir-info' fails on a directory with a
 non-saved file
Date: Tue, 26 May 2020 10:51:14 +0200

Paul Pogonyshev <pogonyshev <at> gmail.com> writes:

>> Do we really want to ignore *any* error from insert-file-contents here?
>
> Well, maybe that should be limited to `file-missing' instead (what actually
> happens when it tries to read a lock file).

Sounds good.

>> Should we really run package-buffer-info if inserting the file fails?
>> Won't that reach (error "Package lacks a file header") and signal an
>> error anyways, just a different and more cryptic one?
>
> `package-buffer-info' is already inside a different `ignore-errors', so it
> will signal an error, but that error will be ignored and the file skipped.

Thanks for clarifying.  I didn't study this code recently.

> I'm not attached to any particular way this bug is fixed. Please adjust it
> yourself, the patch is only an example of how it could be done. This will
> be faster than if we try to negotiate the best way and recreate the patch.

I don't mean to discourage you from working on this, on the contrary.
We appreciate that you're working on a fix.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.