From unknown Sun Jun 22 11:47:21 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4148: mode: for a minor mode should turn on, not toggle the mode Reply-To: Dan Nicolaescu , 4148@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 15 Aug 2009 07:15:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4148 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125032009829768 (code B ref -1); Sat, 15 Aug 2009 07:15:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Aug 2009 07:08:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7F78Gpk029765 for ; Sat, 15 Aug 2009 00:08:17 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1McDNA-0000YS-AJ for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1McDN4-0000YF-Qs for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:15 -0400 Received: from [199.232.76.173] (port=58623 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1McDN4-0000YC-Mj for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:46952) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1McDN4-0000Td-44 for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:10 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1McDLb-0003rg-3Q for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:06:39 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7F75Qsq020616 for ; Sat, 15 Aug 2009 00:05:26 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7F75QHF004092; Sat, 15 Aug 2009 00:05:26 -0700 (PDT) Date: Sat, 15 Aug 2009 00:05:26 -0700 (PDT) Message-Id: <200908150705.n7F75QHF004092@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Lines: 11 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7F75Qsq020616 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Detected-Operating-System: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) A well known long standing problem: using mode: SOME_MINOR_MODE in a local variable section (or in .dir-locals.el) toggles the minor mode, it should turn it on. So if the user sets a hook to turn on the minor mode in her emacs, when using a file that sets the same minor mode, the minor mode ends up being disable. From unknown Sun Jun 22 11:47:21 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4148: mode: for a minor mode should turn on, not toggle the mode Reply-To: Chong Yidong , 4148@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 15 Aug 2009 17:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4148 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4148-submit@emacsbugs.donarmstrong.com id=B4148.125035794910818 (code B ref 4148); Sat, 15 Aug 2009 17:45:04 +0000 Received: (at 4148) by emacsbugs.donarmstrong.com; 15 Aug 2009 17:39:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.6 required=4.0 tests=AWL,FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7FHd8iH010815 for <4148@emacsbugs.donarmstrong.com>; Sat, 15 Aug 2009 10:39:09 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id C9CA657E21C; Sat, 15 Aug 2009 13:40:06 -0400 (EDT) From: Chong Yidong To: Dan Nicolaescu Cc: 4148@debbugs.gnu.org Date: Sat, 15 Aug 2009 13:40:06 -0400 Message-ID: <874os9vuvd.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > A well known long standing problem: > using > mode: SOME_MINOR_MODE > in a local variable section (or in .dir-locals.el) toggles the minor > mode, it should turn it on. > So if the user sets a hook to turn on the minor mode in her emacs, when > using a file that sets the same minor mode, the minor mode ends up being > disable. Does this patch DTRT? *** trunk/lisp/files.el.~1.1066.~ 2009-08-14 19:37:09.000000000 -0400 --- trunk/lisp/files.el 2009-08-15 13:37:24.000000000 -0400 *************** *** 3189,3195 **** "-mode")))) (unless (eq (indirect-function mode) (indirect-function major-mode)) ! (funcall mode)))) ((eq var 'eval) (save-excursion (eval val))) (t --- 3189,3199 ---- "-mode")))) (unless (eq (indirect-function mode) (indirect-function major-mode)) ! (if (memq mode minor-mode-list) ! ;; For a minor mode, enable unconditionally instead ! ;; of toggling (since the mode may already be on). ! (funcall mode 1) ! (funcall mode))))) ((eq var 'eval) (save-excursion (eval val))) (t From unknown Sun Jun 22 11:47:21 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4148: mode: for a minor mode should turn on, not toggle the mode Reply-To: Dan Nicolaescu , 4148@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 15 Aug 2009 19:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4148 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4148-submit@emacsbugs.donarmstrong.com id=B4148.125036248723709 (code B ref 4148); Sat, 15 Aug 2009 19:00:04 +0000 Received: (at 4148) by emacsbugs.donarmstrong.com; 15 Aug 2009 18:54:47 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7FIskew023701 for <4148@emacsbugs.donarmstrong.com>; Sat, 15 Aug 2009 11:54:47 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7FIsSpR025445; Sat, 15 Aug 2009 11:54:28 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7FIsSHk009145; Sat, 15 Aug 2009 11:54:28 -0700 (PDT) Date: Sat, 15 Aug 2009 11:54:28 -0700 (PDT) Message-Id: <200908151854.n7FIsSHk009145@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Chong Yidong Cc: 4148@debbugs.gnu.org References: <874os9vuvd.fsf@cyd.mit.edu> In-Reply-To: <874os9vuvd.fsf@cyd.mit.edu> (Chong Yidong's message of "Sat, 15 Aug 2009 13:40:06 -0400") Lines: 44 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7FIsSpR025445 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Chong Yidong writes: > > A well known long standing problem: > > using > > mode: SOME_MINOR_MODE > > > in a local variable section (or in .dir-locals.el) toggles the minor > > mode, it should turn it on. > > > So if the user sets a hook to turn on the minor mode in her emacs, when > > using a file that sets the same minor mode, the minor mode ends up being > > disable. > > Does this patch DTRT? > > *** trunk/lisp/files.el.~1.1066.~ 2009-08-14 19:37:09.000000000 -0400 > --- trunk/lisp/files.el 2009-08-15 13:37:24.000000000 -0400 > *************** > *** 3189,3195 **** > "-mode")))) > (unless (eq (indirect-function mode) > (indirect-function major-mode)) > ! (funcall mode)))) > ((eq var 'eval) > (save-excursion (eval val))) > (t > --- 3189,3199 ---- > "-mode")))) > (unless (eq (indirect-function mode) > (indirect-function major-mode)) > ! (if (memq mode minor-mode-list) > ! ;; For a minor mode, enable unconditionally instead > ! ;; of toggling (since the mode may already be on). > ! (funcall mode 1) > ! (funcall mode))))) > ((eq var 'eval) > (save-excursion (eval val))) > (t Thanks, it seems to work fine. After this gets checked in, we can re-add (mode . bug-reference) to emacs/.dir-locals.el Any chance this patch can get onto the next release branch? From unknown Sun Jun 22 11:47:21 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4148: mode: for a minor mode should turn on, not toggle the mode Reply-To: Chong Yidong , 4148@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 17 Aug 2009 01:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4148 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4148-submit@emacsbugs.donarmstrong.com id=B4148.125047129915887 (code B ref 4148); Mon, 17 Aug 2009 01:15:03 +0000 Received: (at 4148) by emacsbugs.donarmstrong.com; 17 Aug 2009 01:08:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7H18IOD015884 for <4148@emacsbugs.donarmstrong.com>; Sun, 16 Aug 2009 18:08:19 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 1AF5E57E25D; Sun, 16 Aug 2009 21:09:18 -0400 (EDT) From: Chong Yidong To: Dan Nicolaescu Cc: 4148@debbugs.gnu.org References: <874os9vuvd.fsf@cyd.mit.edu> <200908151854.n7FIsSHk009145@godzilla.ics.uci.edu> Date: Sun, 16 Aug 2009 21:09:18 -0400 In-Reply-To: <200908151854.n7FIsSHk009145@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sat, 15 Aug 2009 11:54:28 -0700 (PDT)") Message-ID: <87tz07gsap.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Dan Nicolaescu writes: > Thanks, it seems to work fine. > > After this gets checked in, we can re-add (mode . bug-reference) to > emacs/.dir-locals.el > > Any chance this patch can get onto the next release branch? I'm having trouble coming up with a test-case for testing this patch. Do you have one? From unknown Sun Jun 22 11:47:21 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4148: mode: for a minor mode should turn on, not toggle the mode Reply-To: Dan Nicolaescu , 4148@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 17 Aug 2009 01:55:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4148 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4148-submit@emacsbugs.donarmstrong.com id=B4148.125047380622908 (code B ref 4148); Mon, 17 Aug 2009 01:55:05 +0000 Received: (at 4148) by emacsbugs.donarmstrong.com; 17 Aug 2009 01:50:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.3 required=4.0 tests=AWL,HAS_BUG_NUMBER, IMPRONONCABLE_2,MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7H1o5XL022764 for <4148@emacsbugs.donarmstrong.com>; Sun, 16 Aug 2009 18:50:06 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7H1nrn1009882; Sun, 16 Aug 2009 18:49:53 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7H1nrbV022668; Sun, 16 Aug 2009 18:49:53 -0700 (PDT) Date: Sun, 16 Aug 2009 18:49:53 -0700 (PDT) Message-Id: <200908170149.n7H1nrbV022668@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Chong Yidong Cc: 4148@debbugs.gnu.org References: <874os9vuvd.fsf@cyd.mit.edu> <200908151854.n7FIsSHk009145@godzilla.ics.uci.edu> <87tz07gsap.fsf@cyd.mit.edu> In-Reply-To: <87tz07gsap.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 16 Aug 2009 21:09:18 -0400") Lines: 41 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7H1nrn1009882 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Chong Yidong writes: > Dan Nicolaescu writes: > > > Thanks, it seems to work fine. > > > > After this gets checked in, we can re-add (mode . bug-reference) to > > emacs/.dir-locals.el > > > > Any chance this patch can get onto the next release branch? > > I'm having trouble coming up with a test-case for testing this patch. > Do you have one? Here's one: $ cat foo.el (add-hook 'change-log-mode-hook (lambda () (bug-reference-mode 1))) $ cat emacs/.dir-locals.el ((nil . ((tab-width . 8) (fill-column . 70))) (c-mode . ((c-file-style . "GNU"))) (text-mode . ((mode . auto-fill))) (change-log-mode . ((add-log-time-zone-rule . t) (fill-column . 74) (bug-reference-url-format . "http://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s") (mode . bug-reference)))) ;; arch-tag: fb93c160-e9fe-4184-aad1-e4f5daa11cbd $ emacs -Q -l foo.el C-x C-f emacs/lisp/ChangeLog C-h v bug-reference-mode RET before your patch bug-reference-mode is nil, after it's t From unknown Sun Jun 22 11:47:21 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Dan Nicolaescu Subject: bug#4148 closed by Chong Yidong (Re: bug#4148: mode: for a minor mode should turn on, not toggle the mode) Message-ID: References: <87prauhud0.fsf@stupidchicken.com> <200908150705.n7F75QHF004092@godzilla.ics.uci.edu> X-Emacs-PR-Message: they-closed 4148 X-Emacs-PR-Package: emacs Reply-To: 4148@debbugs.gnu.org Date: Thu, 20 Aug 2009 20:30:14 +0000 Content-Type: multipart/mixed; boundary="----------=_1250800214-15864-1" This is a multi-part message in MIME format... ------------=_1250800214-15864-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4148: mode: for a minor mode should turn on, not toggle the mode It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 4148: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4148 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1250800214-15864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4148-done) by emacsbugs.donarmstrong.com; 17 Aug 2009 23:51:46 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.9 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po44.its.yale.edu (pantheon-po44.its.yale.edu [130.132.50.78]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HNpiEI031635 for <4148-done@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 16:51:46 -0700 Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n7HNpd8R021943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 17 Aug 2009 19:51:39 -0400 Received: by furry (Postfix, from userid 1000) id 7CF5CC070; Mon, 17 Aug 2009 19:51:39 -0400 (EDT) From: Chong Yidong To: Dan Nicolaescu Cc: 4148-done@debbugs.gnu.org Subject: Re: bug#4148: mode: for a minor mode should turn on, not toggle the mode References: <874os9vuvd.fsf@cyd.mit.edu> <200908151854.n7FIsSHk009145@godzilla.ics.uci.edu> <87tz07gsap.fsf@cyd.mit.edu> <200908170149.n7H1nrbV022668@godzilla.ics.uci.edu> Date: Mon, 17 Aug 2009 19:51:39 -0400 In-Reply-To: <200908170149.n7H1nrbV022668@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 16 Aug 2009 18:49:53 -0700 (PDT)") Message-ID: <87prauhud0.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) Dan Nicolaescu writes: > > I'm having trouble coming up with a test-case for testing this patch. > > Do you have one? > > Here's one: Thanks. I've checked in the patch. ------------=_1250800214-15864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 15 Aug 2009 07:08:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7F78Gpk029765 for ; Sat, 15 Aug 2009 00:08:17 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1McDNA-0000YS-AJ for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1McDN4-0000YF-Qs for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:15 -0400 Received: from [199.232.76.173] (port=58623 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1McDN4-0000YC-Mj for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:46952) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1McDN4-0000Td-44 for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:08:10 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1McDLb-0003rg-3Q for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2009 03:06:39 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7F75Qsq020616 for ; Sat, 15 Aug 2009 00:05:26 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7F75QHF004092; Sat, 15 Aug 2009 00:05:26 -0700 (PDT) Date: Sat, 15 Aug 2009 00:05:26 -0700 (PDT) Message-Id: <200908150705.n7F75QHF004092@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: mode: for a minor mode should turn on, not toggle the mode X-Debbugs-No-Ack: yes Lines: 11 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7F75Qsq020616 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Detected-Operating-System: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) A well known long standing problem: using mode: SOME_MINOR_MODE in a local variable section (or in .dir-locals.el) toggles the minor mode, it should turn it on. So if the user sets a hook to turn on the minor mode in her emacs, when using a file that sets the same minor mode, the minor mode ends up being disable. ------------=_1250800214-15864-1--