GNU bug report logs - #41461
[PATCH 0/3] Update go-github-com-stretchr-testify

Previous Next

Package: guix-patches;

Reported by: Jakub Kądziołka <kuba <at> kadziolka.net>

Date: Fri, 22 May 2020 16:06:02 UTC

Severity: normal

Tags: patch

Done: Jakub Kądziołka <kuba <at> kadziolka.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Subject: bug#41461: closed (Re: [bug#41461] [PATCH 1/3] gnu: Add
 go-github-com-stretchr-objx.)
Date: Sun, 07 Jun 2020 19:56:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#41461: [PATCH 0/3] Update go-github-com-stretchr-testify

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41461 <at> debbugs.gnu.org.

-- 
41461: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41461
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41461-done <at> debbugs.gnu.org
Subject: Re: [bug#41461] [PATCH 1/3] gnu: Add go-github-com-stretchr-objx.
Date: Sun, 7 Jun 2020 21:55:27 +0200
[Message part 3 (text/plain, inline)]
On Wed, Jun 03, 2020 at 05:53:49PM +0200, Ludovic Courtès wrote:
> Hello,
> 
> Jakub Kądziołka <kuba <at> kadziolka.net> skribis:
> 
> > * gnu/packages/golang.scm (go-github-com-stretchr-objx): New variable.
> 
> [...]
> 
> > +    (synopsis "Go package for dealing with maps, slices, JSON and other data")
> > +    (description "Go package for dealing with maps, slices, JSON and other data")
> 
> Please write a full sentence (or two :-)) for the description (info
> "(guix) Synopses and Descriptions").
> 
> Otherwise the three patches LGTM!

Thanks for your review! I wrote a fuller description and pushed the
patches.

Regards,
Jakub Kądziołka
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Update go-github-com-stretchr-testify
Date: Fri, 22 May 2020 18:04:49 +0200
While debugging a test failure of a package I was adding, I have guessed
that the old version of testify is to blame. I was wrong, but since it
takes a bit more than a version bump, perhaps we should upgrade it
anyway?

I have tested building all dependent packages and haven't encountered
any issues.

Jakub Kądziołka (3):
  gnu: Add go-github-com-stretchr-objx.
  gnu: go-github-com-davecgh-go-spew: Update to 1.1.1.
  gnu: go-github-com-stretchr-testify: Update to 1.5.1.

 gnu/packages/golang.scm | 114 ++++++++++++++++++++++++----------------
 1 file changed, 68 insertions(+), 46 deletions(-)

-- 
2.26.2




This bug report was last modified 5 years and 41 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.