GNU bug report logs -
#41455
[PATCH] gnu: Add python-daemux
Previous Next
Reported by: Edouard Klein <edk <at> beaver-labs.com>
Date: Fri, 22 May 2020 13:11:02 UTC
Severity: normal
Tags: patch
Merged with 41208
Done: Marius Bakke <marius <at> gnu.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Edouard Klein <edou <at> rdklein.fr> writes:
>>> + (file-name (git-file-name name version))
>>> + (sha256
>>> + (base32 "0cb8v552f2hkwz6d3hwsmrz3gd28jikga3lcc3r1zlw8ra7804ph"))))
>>> + (build-system python-build-system)
>>> + (arguments
>>> + `(#:phases (modify-phases %standard-phases
>>> + (replace 'check
>>> + (lambda _
>>> + (mkdir-p "tmptmux")
>>> + (setenv "TMUX_TMPDIR" (string-append (getcwd) "/tmptmux"))
>>> + (invoke "tmux" "new-session" "-d")
>>> + (invoke "make" "test"))))))
>>
>> Nice! I guess 'tmux' needs to be a native-input if we don't propagate
>> it from libtmux.
>>
>
> I'm not sure what you mean. tmux is indeed a propagated input of
> python-libtmux, which is in turn a propagated input of python-daemux. Do
> you mean that it should be added explicitly here instead of being
> implicit ?
Yes, because in another review I recommended against propagating tmux.
The reason is that I (and presumably others) sometimes add custom
patches to my local packages. If the vanilla tmux is propagated, I
would not be able to use python-daemux with my installed patched tmux.
Does that make sense?
[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 4 years and 335 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.