Subject: [bug#41455] [PATCH 2/2] gnu: Add python-daemux

From: Marius Bakke <[email-masked]>
Date: Sat, 30 May 2020 14:04:25 +0200

Edouard Klein <[email-masked]> writes:

>>> +       (file-name (git-file-name name version))
>>> +       (sha256
>>> +        (base32 "0cb8v552f2hkwz6d3hwsmrz3gd28jikga3lcc3r1zlw8ra7804ph"))))
>>> +    (build-system python-build-system)
>>> +    (arguments
>>> +     `(#:phases (modify-phases %standard-phases
>>> +                  (replace 'check
>>> +                    (lambda _
>>> +                      (mkdir-p "tmptmux")
>>> +                      (setenv "TMUX_TMPDIR" (string-append (getcwd) "/tmptmux"))
>>> +                      (invoke "tmux" "new-session" "-d")
>>> +                      (invoke "make" "test"))))))
>>
>> Nice!  I guess 'tmux' needs to be a native-input if we don't propagate
>> it from libtmux.
>>
>
> I'm not sure what you mean. tmux is indeed a propagated input of
> python-libtmux, which is in turn a propagated input of python-daemux. Do
> you mean that it should be added explicitly here instead of being
> implicit ?

Yes, because in another review I recommended against propagating tmux.
The reason is that I (and presumably others) sometimes add custom
patches to my local packages.  If the vanilla tmux is propagated, I
would not be able to use python-daemux with my installed patched tmux.

Does that make sense?