GNU bug report logs - #41454
28.0.50; [".+" 0 font-shape-gstring] composition rule breaks paren highlighting

Previous Next

Full log

Message #23 received at 41454 <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 41454 <at> debbugs.gnu.org
Subject: Re: bug#41454: 28.0.50; [".+" 0 font-shape-gstring] composition rule
 breaks paren highlighting
Date: Sun, 31 May 2020 19:58:09 +0000

[Message part 1 (text/plain, inline)]

On Sun, May 31, 2020 at 6:01 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > Date: Sun, 31 May 2020 20:50:07 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > Cc: 41454 <at> debbugs.gnu.org
> >
> > The problem is that the entire sequence of characters that matches
> > the regexp is passed to the shaper, and the result is stored as a
> > single composition.  And we have special code in the display engine
> > not to break sequences of potentially-composed characters when
> > handling faces (see compute_stop_pos).  So I think there might be
> > some bug there which shows when a composition comprises more than a
> > single grapheme cluster, and some face is applied to them.
>
> On second thought, I'm not sure this is the right place to look at.
> It could be fill_gstring_glyph_string and BUILD_GSTRING_GLYPH_STRING
> instead (and the respective *term.c display functions).

Thanks for the hint! You were absolutely correct.

[0001-Don-t-get-confused-by-mid-gstring-face-changes-bug-4.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.