GNU bug report logs - #41446
[PATCH 0/2 staging] dconf: Enable tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41446 in the body.
You can then email your comments to 41446 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] dconf: Enable tests.
Date: Fri, 22 May 2020 10:15:14 +0200

Brice Waegeneire (2):
  gnu: dconf: Appease 'guix lint'.
  gnu: dconf: Enable tests.

 gnu/packages/gnome.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.26.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 2/2] gnu: dconf: Enable tests.
Date: Fri, 22 May 2020 10:21:54 +0200

* gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
---
 gnu/packages/gnome.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e9d2965f70..803ac8fe5a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3432,9 +3432,7 @@ and RDP protocols.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (arguments
-     `(#:tests? #f ; To contact dbus it needs to load /var/lib/dbus/machine-id
-                   ; or /etc/machine-id.
-       #:glib-or-gtk? #t
+     `(#:glib-or-gtk? #t
        #:configure-flags '("-Denable-gtk-doc=true")))
     (home-page "https://developer.gnome.org/dconf/")
     (synopsis "Low-level GNOME configuration system")
-- 
2.26.2

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: dconf: Appease 'guix lint'.
Date: Fri, 22 May 2020 10:21:53 +0200

* gnu/packages/gnome.scm (dconf)[homepage]: Avoid permanent redirect.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ed668c280b..e9d2965f70 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3436,7 +3436,7 @@ and RDP protocols.")
                    ; or /etc/machine-id.
        #:glib-or-gtk? #t
        #:configure-flags '("-Denable-gtk-doc=true")))
-    (home-page "https://developer.gnome.org/dconf")
+    (home-page "https://developer.gnome.org/dconf/")
     (synopsis "Low-level GNOME configuration system")
     (description "Dconf is a low-level configuration system.  Its main purpose
 is to provide a backend to GSettings on platforms that don't already have
-- 
2.26.2

Message #16 received at 41446 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Brice Waegeneire <brice <at> waegenei.re>, 41446 <at> debbugs.gnu.org
Subject: Re: [bug#41446] [PATCH 2/2] gnu: dconf: Enable tests.
Date: Sat, 23 May 2020 19:42:25 +0200

[Message part 1 (text/plain, inline)]

Brice Waegeneire <brice <at> waegenei.re> writes:

> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.

dconf has over 400 dependent packages, so this should wait for the next
'staging' branch.  Can you fork off the current branch and push a
'staging-next' so it does not get forgotten?

Otherwise LGTM.  The other patch can go directly on 'master'.

Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #21 received at 41446-done <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 41446-done <at> debbugs.gnu.org
Subject: Re: [bug#41446] [PATCH 2/2] gnu: dconf: Enable tests.
Date: Sat, 23 May 2020 20:05:42 +0000

On 2020-05-23 17:42, Marius Bakke wrote:
> Brice Waegeneire <brice <at> waegenei.re> writes:
> 
>> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
> 
> dconf has over 400 dependent packages, so this should wait for the next
> 'staging' branch.  Can you fork off the current branch and push a
> 'staging-next' so it does not get forgotten?
> 
> Otherwise LGTM.  The other patch can go directly on 'master'.
> 
> Thanks!

Pushed the first patch on master as 
79d7b5277f803d474f8934b1680ce598c9c27e2d.
And the second on staging-next as 
27106f465382fc95f0f19e1cd3147cab5716a173.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.