GNU bug report logs - #41444
[PATCH] Fix guile-fibers resource leak

Previous Next

Package: guix-patches;

Reported by: Caleb Ristvedt <caleb.ristvedt <at> cune.org>

Date: Fri, 22 May 2020 01:53:02 UTC

Severity: normal

Tags: patch

Done: Caleb Ristvedt <caleb.ristvedt <at> cune.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41444 in the body.
You can then email your comments to 41444 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#41444; Package guix-patches. (Fri, 22 May 2020 01:53:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Caleb Ristvedt <caleb.ristvedt <at> cune.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 22 May 2020 01:53:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Fix guile-fibers resource leak
Date: Thu, 21 May 2020 20:52:38 -0500
[Message part 1 (text/plain, inline)]
This adds a patch to guile-fibers to fix a resource leak that caused
file descriptors to be opened and never closed with each invocation of
`run-fibers'.  This is presumably what was causing the tests to fail, as
guile will abort when it gets EMFILE while attempting to create a new
thread.  I've verified that it builds on my system, but it's only a
4-core machine, and the rate at which file descriptors leak scales with
the number of cores, so it's possible it would have built successfully
here regardless.  Could someone with access to a system with more cores
verify that it now builds properly there?

Hopefully a bug fix release will show up soon enough and we can get rid
of this.

- reepca

[0001-gnu-guile-fibers-Add-patch-to-fix-resource-leak.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#41444; Package guix-patches. (Fri, 22 May 2020 17:46:01 GMT) Full text and rfc822 format available.

Message #8 received at 41444 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Caleb Ristvedt <caleb.ristvedt <at> cune.org>, 41444 <at> debbugs.gnu.org
Subject: Re: [bug#41444] [PATCH] Fix guile-fibers resource leak
Date: Fri, 22 May 2020 18:44:59 +0100
[Message part 1 (text/plain, inline)]
Caleb Ristvedt <caleb.ristvedt <at> cune.org> writes:

> This adds a patch to guile-fibers to fix a resource leak that caused
> file descriptors to be opened and never closed with each invocation of
> `run-fibers'.  This is presumably what was causing the tests to fail, as
> guile will abort when it gets EMFILE while attempting to create a new
> thread.  I've verified that it builds on my system, but it's only a
> 4-core machine, and the rate at which file descriptors leak scales with
> the number of cores, so it's possible it would have built successfully
> here regardless.  Could someone with access to a system with more cores
> verify that it now builds properly there?

I've tried this on bayfront.guix.gnu.org which has 32 cores and I'm very
glad to say it seems to work!

Maybe tweak the capitalisation in the commit message, "New patch", "Add
it ...", "Use it", but yeah, I'm all for merging this, with it I'll be
able to reconfigure bayfront hopefully. Are you set to tweak the commit
message and push?

Thanks,

Chris
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#41444; Package guix-patches. (Fri, 22 May 2020 19:39:02 GMT) Full text and rfc822 format available.

Message #11 received at 41444 <at> debbugs.gnu.org (full text, mbox):

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 41444 <at> debbugs.gnu.org
Subject: Re: [bug#41444] [PATCH] Fix guile-fibers resource leak
Date: Fri, 22 May 2020 14:38:42 -0500
Christopher Baines <mail <at> cbaines.net> writes:

> I've tried this on bayfront.guix.gnu.org which has 32 cores and I'm very
> glad to say it seems to work!

Excellent.

> Maybe tweak the capitalisation in the commit message, "New patch", "Add
> it ...", "Use it",

Done.

> Are you set to tweak the commit message and push?

Indeed, tweaked and pushed as 9af90aafdfd8afd5fb7b5377ca5daf2215d38d7a.

- reepca




Reply sent to Caleb Ristvedt <caleb.ristvedt <at> cune.org>:
You have taken responsibility. (Fri, 22 May 2020 19:40:02 GMT) Full text and rfc822 format available.

Notification sent to Caleb Ristvedt <caleb.ristvedt <at> cune.org>:
bug acknowledged by developer. (Fri, 22 May 2020 19:40:02 GMT) Full text and rfc822 format available.

Message #16 received at 41444-done <at> debbugs.gnu.org (full text, mbox):

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: 41444-done <at> debbugs.gnu.org
Subject: done
Date: Fri, 22 May 2020 14:39:16 -0500
closed.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 20 Jun 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 58 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.