GNU bug report logs - #4144
23.1.50; VC Annotate for bzr files broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4144 in the body.
You can then email your comments to 4144 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: ofv <at> wanadoo.es (Óscar Fuentes)
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; VC Annotate for bzr files broken
Date: Fri, 14 Aug 2009 21:52:39 +0200

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug <at> gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

The Annotate view of bzr files doesn't show author and revision #
information. Seems that emacs does not understand the annotate output of
bzr.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/share/emacs/23.1.50/etc/DEBUG for instructions.


In GNU Emacs 23.1.50.3 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2009-07-31 on qcore
Windowing system distributor `The X.Org Foundation', version 11.0.60900000
configured using `configure  '--with-x-toolkit=lucid''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  show-paren-mode: t
  diff-auto-refine-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t

Recent input:
<right> <right> <right> <backspace> <return> <tab> 
C-y C-x C-s C-x b l l v m - c <return> <backspace> 
C-x C-s C-x b <return> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> C-e <left> 
<left> <left> <left> <left> <left> c m a k e . C-x 
C-s C-x b C-g C-x b <return> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> e c h o SPC " r 
p u e <backspace> <backspace> <backspace> <backspace> 
r p <backspace> <backspace> p r u e b a " SPC > > C-x 
C-s M-x g n u s <return> <down> <return> d q <return> 
d q q y C-x b s t a t u <return> <down> g <down> <down> 
m m <up> <up> <down> C-u D y e s <return> <up> m <down> 
m <up> r y e s <return> M-x g n s <backspace> u s <return> 
<return> d q <down> <return> d q <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> q q y <help-echo> h C-x C-c <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:
Destroying external MIME viewers
Saving file /home/oscar/.newsrc...
Wrote /home/oscar/.newsrc
Saving /home/oscar/.newsrc.eld...
Saving file /home/oscar/.newsrc.eld...
Wrote /home/oscar/.newsrc.eld
Saving /home/oscar/.newsrc.eld...done
When done with this frame, type C-x 5 0
(No files need saving)
When done with this frame, type C-x 5 0

Load-path shadows:
None found.

-- 
Óscar Fuentes
Desarrollo de Software

Message #8 received at 4144 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: =C3=93scar?= Fuentes <ofv <at> wanadoo.es.=?UTF-8?Q?>
Cc: 4144 <at> debbugs.gnu.org
Subject: Re: bug#4144: 23.1.50; VC Annotate for bzr files broken
Date: Fri, 14 Aug 2009 23:24:19 -0700 (PDT)

ofv <at> wanadoo.es. "(Óscar" Fuentes) writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the emacs-pretest-bug <at> gnu.org mailing list.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug:
  > 
  > The Annotate view of bzr files doesn't show author and revision #
  > information. Seems that emacs does not understand the annotate output of
  > bzr.

Try putting the mouse of the version number on the left side of the
buffer, you will get a tooltip with that info.
It's (mis)feature of the vc-bzr backend, and it's annoying that it's
turned on by default, making the vc-annotate output different that for
any other backend...

  > 
  > If Emacs crashed, and you have the Emacs process in the gdb debugger,
  > please include the output from the following gdb commands:
  >     `bt full' and `xbacktrace'.
  > If you would like to further debug the crash, please read the file
  > /usr/local/share/emacs/23.1.50/etc/DEBUG for instructions.
  > 
  > 
  > In GNU Emacs 23.1.50.3 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
  >  of 2009-07-31 on qcore
  > Windowing system distributor `The X.Org Foundation', version 11.0.60900000
  > configured using `configure  '--with-x-toolkit=lucid''
  > 
  > Important settings:
  >   value of $LC_ALL: nil
  >   value of $LC_COLLATE: nil
  >   value of $LC_CTYPE: nil
  >   value of $LC_MESSAGES: nil
  >   value of $LC_MONETARY: nil
  >   value of $LC_NUMERIC: nil
  >   value of $LC_TIME: nil
  >   value of $LANG: en_US.UTF-8
  >   value of $XMODIFIERS: nil
  >   locale-coding-system: utf-8-unix
  >   default-enable-multibyte-characters: t
  > 
  > Major mode: Lisp Interaction
  > 
  > Minor modes in effect:
  >   show-paren-mode: t
  >   diff-auto-refine-mode: t
  >   iswitchb-mode: t
  >   tooltip-mode: t
  >   mouse-wheel-mode: t
  >   menu-bar-mode: t
  >   file-name-shadow-mode: t
  >   global-font-lock-mode: t
  >   font-lock-mode: t
  >   global-auto-composition-mode: t
  >   auto-composition-mode: t
  >   auto-encryption-mode: t
  >   auto-compression-mode: t
  >   column-number-mode: t
  >   line-number-mode: t
  > 
  > Recent input:
  > <right> <right> <right> <backspace> <return> <tab> 
  > C-y C-x C-s C-x b l l v m - c <return> <backspace> 
  > C-x C-s C-x b <return> <down> <down> <down> <down> 
  > <down> <down> <down> <down> <down> <down> <down> <down> 
  > <down> <down> <down> <down> <down> <down> C-e <left> 
  > <left> <left> <left> <left> <left> c m a k e . C-x 
  > C-s C-x b C-g C-x b <return> <left> <left> <left> <left> 
  > <left> <left> <left> <left> <left> <left> <left> <left> 
  > <left> <left> <left> <left> <left> <left> <left> <left> 
  > <left> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> e c h o SPC " r 
  > p u e <backspace> <backspace> <backspace> <backspace> 
  > r p <backspace> <backspace> p r u e b a " SPC > > C-x 
  > C-s M-x g n u s <return> <down> <return> d q <return> 
  > d q q y C-x b s t a t u <return> <down> g <down> <down> 
  > m m <up> <up> <down> C-u D y e s <return> <up> m <down> 
  > m <up> r y e s <return> M-x g n s <backspace> u s <return> 
  > <return> d q <down> <return> d q <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> q q y <help-echo> h C-x C-c <help-echo> 
  > <help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
  > <help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
  > <menu-bar> <help-menu> <send-emacs-bug-report>
  > 
  > Recent messages:
  > Destroying external MIME viewers
  > Saving file /home/oscar/.newsrc...
  > Wrote /home/oscar/.newsrc
  > Saving /home/oscar/.newsrc.eld...
  > Saving file /home/oscar/.newsrc.eld...
  > Wrote /home/oscar/.newsrc.eld
  > Saving /home/oscar/.newsrc.eld...done
  > When done with this frame, type C-x 5 0
  > (No files need saving)
  > When done with this frame, type C-x 5 0
  > 
  > Load-path shadows:
  > None found.
  > 
  > -- 
  > Óscar Fuentes
  > Desarrollo de Software

Message #13 received at 4144 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: 4144 <at> debbugs.gnu.org
Subject: Re: 23.1.50; VC Annotate for bzr files broken
Date: Mon, 07 Sep 2009 07:17:34 +0200

The breakage is caused by commits with empty `committer' field (in this
case coming from conversions from other VCS). This confuses the regexp
used by vc-bzr-annotate-command for determining revision id, author and
date.

Some experimentation shows that this regexp works on the case of empty
committer field too:

*** /usr/local/share/emacs/23.1.50/lisp/vc-bzr.el.gz
--- /tmp/buffer-content-191724Q
***************
*** 547,553 ****
      ;; to allow saving space by sharing the text properties.
      (setq vc-bzr-annotation-table (make-hash-table :test 'equal))
      (goto-char (point-min))
!     (while (re-search-forward "^\\( *[0-9.]+ *\\) \\([^\n ]+\\) +\\([0-9]\\{8\\}\\) |"
                                nil t)
        (let* ((rev (match-string 1))
               (author (match-string 2))
--- 547,554 ----
      ;; to allow saving space by sharing the text properties.
      (setq vc-bzr-annotation-table (make-hash-table :test 'equal))
      (goto-char (point-min))
!     ;;; `author' field may be empty:
!     (while (re-search-forward "^\\( *[0-9.]+\\) *\\([^\n ]* *?\\) +\\([0-9]\\{8\\}\\) |"
                                nil t)
        (let* ((rev (match-string 1))
               (author (match-string 2))

Message #20 received at 4144-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Óscar Fuentes <ofv <at> wanadoo.es>
Cc: Dan Nicolaescu <dann <at> ics.uci.edu>, 4144-done <at> debbugs.gnu.org
Subject: Re: bug#4144: 23.1.50; VC Annotate for bzr files broken
Date: Sun, 06 Dec 2009 15:24:28 -0500

> The breakage is caused by commits with empty `committer' field (in
> this case coming from conversions from other VCS). This confuses the
> regexp used by vc-bzr-annotate-command for determining revision id,
> author and date.

Thanks.  I checked this change into CVS.

Also, as Dan pointed out, the Bzr backend shouldn't be hiding the author
annotation, so I put it back in.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.