GNU bug report logs - #41423
27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest]

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, andrés ramírez <rrandresf <at> gmail.com>, 41423 <at> debbugs.gnu.org
Subject: bug#41423: Installing the fix for bug#41423 on emacs-27
Date: Mon, 01 Feb 2021 10:59:07 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

Hi,

> IIUC Michael had marked this bug as "blocking" for Emacs-27, so this
> argues for installing it on the `emacs-27` branch.
>
> The patch is not without risks seeing how it changes a function from
> returning a list to returning a function and how it fundamentally
> changes *when* the code is executed.  So I'm not sure whether it should
> go on the `emacs-27` branch:
>
> A- For non-Eshell users it is "obviously safe".
> B- For Eshell-over-Tramp users it should be a clear improvement even if
>    it turns out to introduce some unforeseen regressions in some cases.
> C- Finally, Eshell-not-over-Tramp users should hopefully see no
>    difference at all, which mostly means no improvement to make up for
>    any risk of regression.
>
> So, is the improvement in B worth the risk in C?

For me, the patch is not trivial enough that I can read it fluently. So
I propose to keep the bug open as blocking for Emacs 27, and backport
the patch to the emacs-27 branch only after the 27.2 release. Whether
there will be an Emacs 27.3 doesn't matter then.

>         Stefan

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.