From debbugs-submit-bounces@debbugs.gnu.org Wed May 20 12:22:10 2020 Received: (at submit) by debbugs.gnu.org; 20 May 2020 16:22:10 +0000 Received: from localhost ([127.0.0.1]:54108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbRTt-0007tm-Lw for submit@debbugs.gnu.org; Wed, 20 May 2020 12:22:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:54768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbRTs-0007tf-KN for submit@debbugs.gnu.org; Wed, 20 May 2020 12:22:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbRTs-0005TC-89 for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 12:22:08 -0400 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]:43984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbRTr-0008TB-4b for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 12:22:07 -0400 Received: by mail-qk1-x72d.google.com with SMTP id i14so4096258qka.10 for ; Wed, 20 May 2020 09:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=YCz0HIodYUG6KZMSd/yBFpLnbOJsv304sS4kQQdSYt8=; b=FtkjQj6pJsYoYDCQTCYVc3pbokRHhDt7zeVMUuyYWt43m7bvk9h2C9seS3qui3hvCL Lx3OZfAIZILJ/6jJC4h8i+YP5JU4l1zDXW5ef7IGBdDgm54GPOtUF/MnRd/r7yG70jYA MWLdDZUtsyupR8LUcM3/5mS9AxyXbb5BQezKevOeE6EQ/+3VRqFve3CodvoJDKfOBM6l kuz2cKw+Aw0BLNfTYnnKWWYj1R1ShoPtttPi2AGucEjJvV3F2gqGzV/xUixStJ8yyCzX BlGMIAcx5xnjlJybWhCgRlAdYIks1MY96hJI+8G1oPf62Xplyb0YxGWadH6wA0zr9ExZ 6ogA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=YCz0HIodYUG6KZMSd/yBFpLnbOJsv304sS4kQQdSYt8=; b=Xg5zwuE4HTcUCu3G+LvMYiK04VygaVpqrjsjRLkqUfe7dtZWMg8CWodWydC3TPgidd dtWJb8F4vNb7tSzuU3oMeHMVMFCq2Y6lvLDlC/k9pN1FrhDhyqYlds49HDLd9j+1D1LZ F0o966T+FEnwgISRaw9SarUCr2ii101Ev93fMMYtQGjMzk6uBCo225xaPcwgiQrvSZL3 eSzdl7Ovom8r4gKIvO/fyRzYaqBfihsrbVh7Jmh6Se0w/eryXvdxNzE8Crctd0MIBkjZ se2bMMnOdvg60hmEltcMr/bAi9LI1WIPaxbPVjvzVynKL89/l2f/9U3Y8GlblO1y4SsB lwQg== X-Gm-Message-State: AOAM532MDGcokPGK6WE/7TMIBdq7q+6qYM5eepWsJV7I55irU1A6dPXg ZI8jTIatVR4QEtrXiVNemF5TJRn8 X-Google-Smtp-Source: ABdhPJy40b0GVZY8G1b+/CczE79CbBr/HK0lQJdVh1gVRAYgFcJ760P15utYDjjlHz9+As0rJnxytg== X-Received: by 2002:a05:620a:482:: with SMTP id 2mr5600992qkr.327.1589991725361; Wed, 20 May 2020 09:22:05 -0700 (PDT) Received: from sacsa ([190.236.255.69]) by smtp.gmail.com with ESMTPSA id z185sm2699571qka.79.2020.05.20.09.22.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 09:22:04 -0700 (PDT) From: rrandresf@gmail.com To: bug-gnu-emacs@gnu.org Subject: 27.0.91; tramp regression on pretest Date: Wed, 20 May 2020 16:20:44 +0000 Message-ID: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::72d; envelope-from=rrandresf@gmail.com; helo=mail-qk1-x72d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) 1. emacs -Q 2. Evaluate snippet below: --8<---------------cut here---------------start------------->8--- (let ((default-directory "/ssh:user@5quince:~/")) (eshell)) --8<---------------cut here---------------end--------------->8--- 3. On the eshell buffer I do --8<---------------cut here---------------start------------->8--- cd dev/c/h {hit TAB key for getting completion do its job and press Return key} --8<---------------cut here---------------end--------------->8--- Observation: On emacs-26.3 it is inmediate. But on pretest it takes almost 3m to complete same the action. andres.ramirez ps: just in case completion does cd dev/c/hildon/ In GNU Emacs 27.0.91 (build 1, armv7l-unknown-linux-gnueabihf, X toolkit, Xaw3d scroll bars) System Description: Arch Linux ARM Recent messages: Loading em-basic...done Loading em-cmpl...done Loading em-dirs...done Loading em-glob...done Loading em-hist...done Loading em-ls...done Loading em-prompt...done Loading em-script...done Loading em-term...done Loading em-unix...done # Configured using: 'configure '--program-transform-name=s/^ctags$/ctags.emacs/' --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/usr/share --with-x-toolkit=lucid --mandir=/usr/share/man --pdfdir=/usr/share/doc/emacs --with-modules --with-xft --without-gconf --without-gsettings --with-imagemagick --without-xwidgets --without-pop --with-gameuser=:games --disable-build-details 'CFLAGS=-march=armv7-a -mfloat-abi=hard -mfpu=vfpv3-d16 -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LC_COLLATE: C value of $LANG: C locale-coding-system: nil Major mode: Eshell Minor modes in effect: eshell-prompt-mode: t eshell-hist-mode: t eshell-pred-mode: t eshell-cmpl-mode: t eshell-proc-mode: t eshell-arg-mode: t shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils pcmpl-unix em-unix em-term term easymenu ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-dirs esh-var em-cmpl em-basic em-banner em-alias tramp-cache tramp-sh esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete comint ansi-color ring parse-time iso8601 time-date ls-lisp format-spec auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs cl-loaddefs cl-lib password-cache json subr-x map seq term/screen term/xterm xterm byte-opt gv bytecomp byte-compile cconv disp-table tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 141067 10597) (symbols 24 9524 1) (strings 16 41154 2442) (string-bytes 1 1131300) (vectors 8 19393) (vector-slots 4 599625 10098) (floats 8 51 242) (intervals 28 265 162) (buffers 576 13)) From debbugs-submit-bounces@debbugs.gnu.org Wed May 20 13:35:46 2020 Received: (at 41423) by debbugs.gnu.org; 20 May 2020 17:35:46 +0000 Received: from localhost ([127.0.0.1]:54203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbSd8-0001Y6-K8 for submit@debbugs.gnu.org; Wed, 20 May 2020 13:35:46 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:42485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbSd7-0001Xs-Mg for 41423@debbugs.gnu.org; Wed, 20 May 2020 13:35:46 -0400 Received: by mail-qk1-f177.google.com with SMTP id s1so4384621qkf.9 for <41423@debbugs.gnu.org>; Wed, 20 May 2020 10:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:organization:references:date:message-id :mime-version; bh=2V1gwaSt0r/e09tWdrOVcteWn//ztZaz7c37QtNLzVA=; b=XbkK71Ik85yNVVdAvxrTaRtm8OfjJ3eVS0I1Br/VcM3CfzjwJOJApF4zuA4YiWXJ5Y qh5JZBfHGx6bhRiN2LwVQfY4yf+Orw8gKpg4pVZV2JXhfRJZu9ysyarSyA+IUZL8dHlN 5KOH1by5h+IhSKMy7nftiwW2iX86a1NzCoGidJXROks71ZrMCEKn2TkfAyTK6J6KmTVk WZsrc8dpkVkcw9lp1lyLouQ5nvM7Gr0f6lW0+SLYnDkewNePAvCQb7vozpHu/KkGTPog infDvgrSMnfCDMnEUXC9R5jpOO3DCZ7/v/kpg5GIVOIjBJIIoYUUXv6oMHuUp/5KAOy3 fhuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:organization :references:date:message-id:mime-version; bh=2V1gwaSt0r/e09tWdrOVcteWn//ztZaz7c37QtNLzVA=; b=VRrnXm1zaFCDU9UVISoXoirNB5Of2mnn8xe7iv/cKqvMEcZroDkAuMFAvckkZDiiC2 OmwoGcxZFRZybWVT8p4EgePALPAfkZFlLXDPduUCKQ4+kwK17e8s7lrWyWpHwm/ub9RU jwYuxO1Tyh0LnAesCc/K/JTFyiWkPvj04ZZbbJQYNV6rN1HFKduzbQkvhbUSCbqkQ4X+ 8fgyvPh7ebTnLAW3xo1BiILHKbIhdoviv/bMQtXJvh6q36mswU4arT/BA4btDlCrUXe7 DOm+yzGZBFMpJr+LIVrDu1aHZRwcnRbVGVunHIa/zaafWDOvSyb8osajT5BSfLhPa/pl AQww== X-Gm-Message-State: AOAM533SfvrcfaPBRT4JJxBEOUuqw8slWAJNcZbGrUSLuV7sEHdqoaZW 3q+5gWA1C2S7K6GT/YnueCOHsiSZ X-Google-Smtp-Source: ABdhPJyOcZMO0vu3qS8l/TP/qn7cL2hXdnh/gcy4FqqOTi/CBSkXfQ+sNT0tj12vckVaXMZTN9n6hA== X-Received: by 2002:a37:943:: with SMTP id 64mr5717197qkj.14.1589996139765; Wed, 20 May 2020 10:35:39 -0700 (PDT) Received: from sacsa.n800.arm.processor.yandex.fm ([190.236.255.69]) by smtp.gmail.com with ESMTPSA id 206sm2735992qki.48.2020.05.20.10.35.38 for <41423@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 10:35:39 -0700 (PDT) From: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= To: 41423@debbugs.gnu.org Subject: additional info In-Reply-To: Organization: bien.comun.org References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> X-Attribution: INKA Date: Wed, 20 May 2020 17:35:36 +0000 Message-ID: <86tv0aecgn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41423 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) More info. It also delays if I replace cd by find-file on the eshell buffer. BTW completion needs to happen for the delay to appear. andres.ramirez From debbugs-submit-bounces@debbugs.gnu.org Mon May 25 12:56:57 2020 Received: (at control) by debbugs.gnu.org; 25 May 2020 16:56:57 +0000 Received: from localhost ([127.0.0.1]:42341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdGPJ-00017e-C2 for submit@debbugs.gnu.org; Mon, 25 May 2020 12:56:57 -0400 Received: from mail-il1-f175.google.com ([209.85.166.175]:34050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdGPI-00017S-Gw for control@debbugs.gnu.org; Mon, 25 May 2020 12:56:56 -0400 Received: by mail-il1-f175.google.com with SMTP id v11so445099ilh.1 for ; Mon, 25 May 2020 09:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=XtcJYF9Wj2G3qY2biArBvP6bil1XoMmdSVXGljVekqw=; b=VcC361cOz7l44M6q4kddea1yQ7CKTLQ4jwy20XfaoptwH2WEY3TJq2Ub7vkaU8D1CC JQQRNI2k8EJGjZmUxh6n2Bvn5csV8hDEBXr5b5oyLlOJAOji5r19NQhw6O6viuPc3rVI ODk1x4tMI8KwSEzKWMiGe+yXct0QlJaNfejhdpDeWuFe0p+MdMekg+PuYEA4vNWhyxro Mgc1xD+XVGsXADLEVpEfIDetIJeIRbJtSqmnsXEangfKpLOE9O6Pg3eSWnoqtI1pCJr8 dXvUkk89gi8deordRqTE38HRUcjnEuCc6+pSq04lX4CUcBBzaFItT4YlJ2ArogdvDnY+ 1CIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=XtcJYF9Wj2G3qY2biArBvP6bil1XoMmdSVXGljVekqw=; b=cjal53T60wgoHvp2jYF1KyhxsmmYpLSseVr+X2d3deWk9uV2PtMKCpbO3o0Em0K2A+ Gkth2q4sXYKEKA7RUoqg08YkHuN2mzXhbn0j089CCeSCUUdqVeiEN4cj8/9asSZHY4lt mNmA6BHhU//WFwLqKzcYEF9JaHWi8xwX7PDXJi4ut4dap0GnUX8wYlbZg6XpCuEMwSdY ZG5Vp3muNEvMB4QkyIrD86OEbM/qCCjbpu2EFi1dUlxWSjVV6T7il3P4b7gAtjsPSgp6 JIDQKjIlDtNk1zbUd7CDMBlaUtcn9q5sYMwbCHAApH/ax3z58pqa/EHuY8Ne6B2qQCPP xzWQ== X-Gm-Message-State: AOAM5309SYhC1eUX97u6s+JoNbTJO/h/mqrEFsrGV+Aj093s+nlBWuJe b6LoLWg1NkcpyiiGTKj0+oLUfgqc X-Google-Smtp-Source: ABdhPJy0o/GW7q2WduxkdXiBDP+is5QywcPi4LLODt4EWWm2JYylah3a8jm7og1wNPc+Gz8mrFlAkg== X-Received: by 2002:a92:5a5d:: with SMTP id o90mr25320607ilb.206.1590425810656; Mon, 25 May 2020 09:56:50 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id u21sm7749911iot.5.2020.05.25.09.56.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 May 2020 09:56:50 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #41423 Date: Mon, 25 May 2020 12:56:50 -0400 Message-ID: <85k110t0kt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 41423 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] quit From debbugs-submit-bounces@debbugs.gnu.org Thu May 28 07:48:15 2020 Received: (at 41423) by debbugs.gnu.org; 28 May 2020 11:48:15 +0000 Received: from localhost ([127.0.0.1]:51199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeH1D-0004cN-Em for submit@debbugs.gnu.org; Thu, 28 May 2020 07:48:15 -0400 Received: from mout.gmx.net ([212.227.15.18]:42853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeH1C-0004cA-6s for 41423@debbugs.gnu.org; Thu, 28 May 2020 07:48:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1590666484; bh=9UiR6CPVRC2+eHcUTws2KufalAc/NuN5uxx+YzinOH8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=B7qKqeqPCu0pvI+y0Snp5fj0sdEoz+deLQS3se6ggbpJVVY+c/syOZV5sLRqa020s 8TCKJ3lI9J+8lAJ90dQ76efy4D2TpIfa/XalfTSyN1FH2Ccv7l1LxGw4SVB+th4Lys X05GpXrGRKq+At1gEE1TfPjCQzCFKiifIypjTlik= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.119.31]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mk0Ne-1jBVlc0x7A-00kQEL; Thu, 28 May 2020 13:48:04 +0200 From: Michael Albinus To: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= Subject: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] (was: bug#41423: additional info) References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> Date: Thu, 28 May 2020 13:48:02 +0200 In-Reply-To: <86tv0aecgn.fsf@gmail.com> (=?utf-8?Q?=22andr=C3=A9s_ram?= =?utf-8?Q?=C3=ADrez=22's?= message of "Wed, 20 May 2020 17:35:36 +0000") Message-ID: <87r1v4z3f1.fsf_-_@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cUL25lJOyq8s1a4pXpWnNwiMTHXx2emd85RrVfZJjJMWxLnfXch fDOs5wndmuQz25w6FcpFitRTQQ9m23+jgALSdnAPJyR3jBnOYdxDU3gnoOV8ZdimZUGyDaA OBHg3xa77wjgYm4+fkzABI5SeThYZGTlO/TErvzH13oYcRyMwJkUdB6GlOa21Y8wiDtL7AF zowFiA1xXttWfH+4Bjr6w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JvaMFd2tnu8=:bpETMyYpXn3m8ZLjsqpp14 8GSyAtgKc1y7/z/74s6HvCiU+fPvenNN1USbjJhVgyEDrhtCbidVDqMuk+ON0/wWNn9onnhLT GWhzzNfzoTICrlA29JoxN2cvAhLYtkqCtG/vzm8TbrnbTZgBRPaYQffJ6VAzRnQVTAmLxdFsG ljCIp7qXVObOsDvIbnySuWUtWQY6WaHdPokWLrlxJudG+gWgaQ44IpDlpGT3q4AqOlvm7cqOl 05FYYTk6sAweyLGhCXL0EIrS4ysDdUIw9L1/GIpWF6cjJ6wsKzQE9boNiwnUfjvvrUU7T05hY 1mBSPAiLxcTJGUXoeRVeh+iA2VT8SB4AgCHVv27anOWM/IJ7fzuVMesoQP0+Si8am/MJNfoOo 3khGDAFqqFnbB4KKbRGykGM1yrZxP0H1+l4zVP9NlSmOexHO1oZleWNOKkjNFWzg2f99SBBZT ooNP1JnF1plz9Jm0gzuc7EOt1kclhXEnYM+9dMqRcGhCvHbwF6G7g+ji6/QIy7FF9psr3ff0I NjVX/VsqLdXWhRUev/fOu6o0GHeQn1LD1AzaRAg4L9gE8vF1nJ+xhxoiaNidIdfALdzqBDtMX rormDGxCh7ks2jyLnnoBQ+/UWH7AW0mxRSe6GXb8tXTXEiFcy6YZ02xysI3UhXkIaB8e2Wu0x ZVPzTu4E23xeHTGW61pEyxdJXLRBfSXBaRnqrh0CNLi5xLfyrs+3xuPvp8zsOD0dn+slzYVnw sII0sDy/NN/zuRC4r0riF7RxQQ8GfXhgwG+eSruDT3OaL57wXNlogYpm+6ION3Ps2fhDjaCy1 UDLUpj5pNgMAtQT2aWSrIDTxbXYrsFEISf9OT8o+qvsbekagpKR+zE4YU24vVuns9tjKs6P5k 0bdc77hRWnKqhUe9dwzrkC4JyMstDiIwuGB/1YuYBWYFVUuHCrldJLwsPXkrFn6F2rE80IML6 MUc/ZMr0OLWN8r+yBpAksT0/bNVbJj3EiDh6ny7ImmwGtMpDl+OAzYE/89y6lQAez6jdAlcji XRinaFFaKSB0SptEGr4S9zUU+ZKVUxEDrSt31V/isHH2MEcLzzMC8LQt7/mBNZ2PQm9KpwmWh jkzzUsyAz6/um9LZx4XvFlYcp19eJEk4Chbfs07wxRH3HER6DTgCLKMUM2Tbj/rZkpajP3YGp EblL5bkVzcdcLH/5Rc2luNrnNog+1yqg2Hioxo1FUBOagzoqaISPztv3fh0hv5X1YVzCIlxkB r+O+GrUA66w7MixdP X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41423 Cc: 41423@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) andr=C3=A9s ram=C3=ADrez writes: Hi, > It also delays if I replace cd by find-file on the eshell buffer. BTW > completion needs to happen for the delay to appear. I've bisected the emacs-27 branch for this. The first bad commit is --8<---------------cut here---------------start------------->8--- commit 047c1b19353ff58d8cd45935c7b44c911b70e312 (HEAD, refs/bisect/bad) Author: Stefan Monnier Date: Tue Mar 19 23:41:20 2019 -0400 * lisp/eshell/em-cmpl.el: Use completion-at-point i.s.o pcomplete --8<---------------cut here---------------end--------------->8--- Since this is a serious regression, I'm marking this as blocking for Emacs 27. (Sorry Eli, but you can always overrule me) > andres.ramirez Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu May 28 07:52:29 2020 Received: (at control) by debbugs.gnu.org; 28 May 2020 11:52:29 +0000 Received: from localhost ([127.0.0.1]:51203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeH5I-0004jm-Uu for submit@debbugs.gnu.org; Thu, 28 May 2020 07:52:29 -0400 Received: from mout.gmx.net ([212.227.15.15]:53909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeH5H-0004jZ-Tg for control@debbugs.gnu.org; Thu, 28 May 2020 07:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1590666742; bh=bzM4q5VMLfFbU0S2fAuNBFqPzvYLEegEKLMJSjqWHBQ=; h=X-UI-Sender-Class:Date:To:From:Subject; b=CX1HR0IKGNlFz7DWsBSeGNr8tc5EB2S/wdlTmTc322hk3zEwLJ6TbeKuGSvIN6saY nXwR5y8CAeS37EF5vntkk3CPLXPXwJ/pJs+6xkIT/z9OTTJjhbtAuofWfcVfUZElxZ qaR630Xrl6jwBas3+wHOnHTPl7gqI0NI8CBvZloY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.119.31]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N9dsV-1izD4S3JBN-015W3B for ; Thu, 28 May 2020 13:52:21 +0200 Date: Thu, 28 May 2020 13:52:21 +0200 Message-Id: <87pnaoz37u.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #39200 X-Provags-ID: V03:K1:3UEZdyXwShMoO8IfhEf+D8cAZMfk2TQe5Vko8CF6AW48jqxjMiU 481eYj6C/57KlqLx+dylNuzHoX1goEaJPScKftVlX9qlUoSozweziVqQlbQxqGb0lwpnN9D O76Zu/clF33UyUj+boZ1bpUQ/dIdS4+qUWAYt4YloeXKxoub3nDRI2nghhpxdkrQnLrdptp bh1Cua7QGNiHmkioja1TQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fOXCEbBfXi0=:hDdIgcnVBg1dwfl3naOWnN flsHf4MEvPt/O4M+1ATDuD14ylfAIy8cWeINWUXnKlJCIr+ui7kRY68NzzeD0MvvzQ1/N6+mh aot+XYuv92BnKwshXdIYUR+Wvdo43U8prXhfFPT+ftjS3YPZPXvVhtZMmuIaqxCCprU/QM24p T4ys1neFAoYDoJGL0Dee3gc8/H1O058mzG8wq6gYKhv+9CBBPl553UNhfA0alYj06Wha877G9 3lOvMbPjDPb1Q13T4pcL9J/xyHbUQpRkvsHn2OJw2iNNiu6kVDmpeoeUdvgx2ojtAeaRKssuA GrZImCN+v1S43imwQHkqAzFues0Wp+FrJb2yUJMrlL+tgwBVMw5/SFj2wc9pXMVYS9BFxL/gn YNIJqnt7OJpvxB+rHSaQARU125PpictPBI/UXo2HOgChShGFBXvOqzpuL2E4ftupargHBGEfH +MxWNAyG3D9xnbhFxC5Q3SZ4RejXqHmBAml5Z+kA4Zg/jfMhNlOTeyrNJhs/N8c+AhjJ62Jy3 HngVKjzLD5Mo+7T3tzQRpRxZ8YuAcrlXOjSvj+d7f3O1jxbAREEaYyguW/wLX2P4tUt2b+ZVW i7hvqRUBRHQIAZkCGf1iMm0Ooc+ONQU1a2d4kq+xmIWgFmxLeodnalrY/e0bzovrU3Hg8ba0Q IrNSa3LmvD/XCDqXLuihnUB+nxgc6y5RxnG5+0nZnEOU3BPNneP1/fIMDSnKrpK2ewNVTosQE 6p2y50XztZoQDvKAmqwFllPM3Kt1Utb3zNNjpgRRYQT76GowulEe3Mnl4bD7vwWXnp5aOGZDd DQwWE60rhbXy55DmCazDJNl9v7//nS0J6n2SuBuFtPHkoai97fGiBz5LwhqGlZjiaaUfNngKC Fsx+tG+MhIiSjhBNF8zjxVMt7mhpapClh82RAAnFubIJExMfX7sVhyUpeRxBcI7dzGgBJZy3U ssE+VUDwoghdiRt7x3jWK+0U/cHZCcaUERVy1ONmAfNyCiNR5KGbxUswOYG8bLzV49PKmYpg0 9s1fTXKVkyG8UO5cwbh2me6LskNAHweYqV+ywxe/1QkP+eritJDTCmaYgJZI2n0OJDDM1WJkl 2JSeEIBgPyAu9r4nbmpB1cZczBi5z+qv8ndBgINXJSaP82XL6pOKcAOEbN3gdOQllmJa6UbXY y7kbggSjaLSWIqJuYrweOkzlfP79iQOI6eZk7ganiuIyJbjMxdU6nvQS78SgouQSLO4zQGiRp 2aW5idYCfOX8W4bwS X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) block 39200 by 41423 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 13:53:34 2020 Received: (at 41423) by debbugs.gnu.org; 19 Aug 2020 17:53:34 +0000 Received: from localhost ([127.0.0.1]:40939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8SHF-0006s7-5b for submit@debbugs.gnu.org; Wed, 19 Aug 2020 13:53:34 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8LGg-0005yw-0H for 41423@debbugs.gnu.org; Wed, 19 Aug 2020 06:24:31 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 04DBA5C0160 for <41423@debbugs.gnu.org>; Wed, 19 Aug 2020 06:24:24 -0400 (EDT) Received: from imap34 ([10.202.2.84]) by compute1.internal (MEProxy); Wed, 19 Aug 2020 06:24:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ughan.xyz; h= mime-version:message-id:date:from:to:subject:content-type; s= fm3; bh=e9QZsnQIwHqaysmtYzP047oU6Z7ABrUzrg1IBbBjOKQ=; b=iwAhFfox 3Fo0sYlWoi178gpz4J0GMeZsWrHGjUfKyFZx3KM2wtJozgI0M+MB6xqmtATWTlQK jPty42bL89dLDng2lhDsUBE3ukzGQlV5EmUuyN5K5AO8r1Tbdw4ydXeQA+7znAsD 0Gu97nBXIKLOv0QetPczc8WNZR0+U9wfFu2llWAfVI8WreazKx0eS7E5/DxSlmoi b3krwL0z6EU2H2CxNQIfZILhkvm138RqHPLs9t28zDiXD1JL7Z4y7Ow6OoIPbx7G 5i3AEdbshpglZrtewyRqP7tkKWUqhwfkGYkIpJGcAIwdkiBmhP/KQJLsFZ2yyIdG EaDAfYC8xgpuNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=e9QZsnQIwHqaysmtYzP047oU6Z7AB rUzrg1IBbBjOKQ=; b=iRbhdeU1G7t3M5I65AByKFAujBlM4J0F4BMjdHsaFxx3s Gh0S0IfwZ+u+JijSA+e2Q9NxqTQ/j5ikG34B8lrBGp6Kk4PZs0Av2AiOZKgoiLW3 tYpnXkJ+vkIsY70G66jwB7wQHw3xDN8WJ687t7xH1f/Q4QiAgXKrDe9NbQmqudAF TN9fwJIQdJR4VRYBaj2Lw8YkXfHtPMHdm8+lW8zjLQRMJWnJ6TwIEYbozKUuTY/P 7y7MsojD4ZIZ8NG/vEToEq74EquuXMrQRa2eFqjsukToLfmJ4/Pd6hrBde8fX+cL mnxd8d/nBhpg1OI9olsblCgNsCaFNFeCrmDuLdBaQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddtkedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdlfeehmdenucfjughrpefofg ggkfffhffvufgtsehttdertderreejnecuhfhrohhmpedfvfhimhcugggruhhghhgrnhdf uceothhimhhvsehughhhrghnrdighiiiqeenucggtffrrghtthgvrhhnpefhueejiedvhf egfeegffetteehveehleffudffieetgfdttdehveffieetfffgveenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehtihhmvhesuhhghhgrnhdrgi ihii X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id AFFAA1460062; Wed, 19 Aug 2020 06:24:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-191-gef79d59-fm-20200818.001-gef79d590 Mime-Version: 1.0 Message-Id: <4272ba22-6331-4bdc-914a-82df3ab870f1@www.fastmail.com> Date: Wed, 19 Aug 2020 12:24:03 +0200 From: "Tim Vaughan" To: 41423@debbugs.gnu.org Subject: =?UTF-8?Q?bug#41423:_27.0.91; _eshell_file_completion_in_tramp_dir_is_slo?= =?UTF-8?Q?w_(3_minutes)_[regression_on_pretest]?= Content-Type: text/plain X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Just a heads up: I believe I'm experiencing this bug under 27.1. (Before finding this bug report I also did a bisection and found the same culprit commit that Andres did.). Thus I expect it somehow ma [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 T_PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ughan.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.29 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.29 listed in list.dnswl.org] 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 41423 X-Mailman-Approved-At: Wed, 19 Aug 2020 13:53:31 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) Just a heads up: I believe I'm experiencing this bug under 27.1. (Before finding this bug report I also did a bisection and found the same culprit commit that Andres did.). Thus I expect it somehow manage to escape pretest. Additionally, I've noticed that although the effect is severe only in tramp directories, there is a noticeable (~0.5s) pause when executing commands in local directories, provided autocompletion has been used to create the command string. (The exact same command does not seem to cause the delay when typed in without invoking autocompletion.) I'm not at all familiar with the eshell code, but I spent some time trying to identify the cause. Weirdly the behaviour does not seem to occur when I instrument `eshell-send-input', making it a bit of a heisenbug. Tim From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 24 07:18:03 2020 Received: (at control) by debbugs.gnu.org; 24 Aug 2020 11:18:03 +0000 Received: from localhost ([127.0.0.1]:56269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAAUF-00089V-Cr for submit@debbugs.gnu.org; Mon, 24 Aug 2020 07:18:03 -0400 Received: from mout.gmx.net ([212.227.17.21]:39497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAAUD-00088V-7P for control@debbugs.gnu.org; Mon, 24 Aug 2020 07:18:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598267875; bh=JMGvMdWH/oPWra6FDxguw1NDLMrydMJQEMrsAGHHZ5I=; h=X-UI-Sender-Class:Date:To:From:Subject; b=faJzSiNaDPyrWa0h05ZBdiPIPI1KZRzpxkeKQrPfd1AY/+S+dx2myR7zBXPgJixMR ZvsdVqztVNWQRqbwUMxwNAO3eYWEgpWfibKMbuC4/3scN1TpqrX9Y8VpDEPOwbL8w0 vdxZKTET6O5n0U7PMtbJhtA3eMcBYUti5pJls/UM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.44.17]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Md6Mt-1kiP6f3maZ-00aBpN for ; Mon, 24 Aug 2020 13:17:55 +0200 Date: Mon, 24 Aug 2020 13:17:54 +0200 Message-Id: <87eenwi97h.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #43018 X-Provags-ID: V03:K1:tu2cQ+kmHVu99cLR7m3qEIu/hGayMBofJbDu6XwXvWf09dvyKoV 5TSGp7smigamHpQu9axHTZ0IDwhgbJtuLMBdhslEIQ7udICv82m9HPohLvRbSoAYDr7Nnt1 OGSknQFL0KhhhcWgesGPl3kzfMNrpO4+pAut+O0OU1b0qwzpdmxPbBz+xAs0eC6reBkup8U IB7xBLIU/9ru109s3xV4g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jke+oN1q14E=:3vQ4vmssMfbSJRw0etQFw8 FoBDJIXfyR5cLnAOErtSh1rifakWHmwWXc6ng4DoXu1MnrLy7cnuTRYOg2BnXq0dtrf9Amro8 tvwGfVH1JrGM6GUBK1X/qT5Ir5bOvSihWFkATcm6+lUzeL3tOXmOmWKm6W0qdzVjJ9tC9mMfc pmUST5kEWmczB67LziDIeLtDFT8dKbGs+SzmfH9sl6argZ/o9l8RrCfP/F0L377o4anMAtdK8 sHKH5H/1foKKhcdsqtdt2Tk+YireqAs6dQcg3nt4DbzKrAmkNoe3Mhn0w0PHGubDbk79jsVMu qhM1WaQwYrAo4akzTvQw8pQB8Pks7QT9qCPx12x2oqWDvff/mvXaxvj8odRpFmY5SZx9p5mkj G0nFz3fITKIc5qWXTmp47Fy27iapu8JJrST/Oafi5VNNc+KGQ9GMr7t+1FKG4EYObu0Xlk7sS NrhKQdjFGji086w/zVOaNttvcjE/v0xES4YNts/uLTBjUGdaK4ddcO30fWkwLlvi9Xxdr44e+ QIW1M6BXxRNeD8+RQut3whduH9BbYFVG1DsQk9rTLq0tJ0BNPHYOYoLtv3uJB0limFwVTn8xd +W9a6QfPHxLixw24C9ZHVt8EiXPReo9vPV8apnc+yhC3/A2b5opEDoI/P3dcc/JbK+SWEx6KC YY91+xXQG4tSlbors9U8zBVh1Gkz00Z4L8Rr/A1tAkkZV/4tAOaNjbXhQqM+BcBZaNnsSDmUP 7ITrl96uYKK75twaF1XLP5SVR1yYTw+xvRtJpnGdU2F3iuEo7LH6j4+JGPcLH306rrpudtCal ndHPVLAhd8serA8fB8gc2Ok/fJfnZB/yWAtvXgeaYySTtLS6bdmIAe7eYsn2OH8ibWWXfpFm4 zUXkzL9oDztgzMWhQof7LkTPZTda8lss3FZGNLyiNdeGkEeCdPTUtI5z3rrIsxZvkLFz8e9EQ 7eETKRqHwUJocESEYgMNocz7GNWpmU6A+DFOQ5+qIfHCu7ElEz+fG2QzFoll+1RPbDhfm59FI /vMlj3NPuc+C0vNImSxcyrYNXT/Ck5JqC+K4MbRnoQM9xTpzM0KLCO4SINfbKIgrKCMw9d5vW xbGMPMrFkRYzd1508mAHMq5ehFJvHr+Mmx4GgvQ8gMIDYi6nyu5GjNnsTfnUg+/6hqj2ouuuR ttKRvhpdhCoaCVHrID4pFqRYZdiQ/fBnHVy/Qq5/dM/BQ+GJ12YNoInZCMX8Y1JC94BDYyysP 0Wd54JkP5Z4KxA1TeehQbjErRqS5iJbhg9LRrtw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) block 43018 by 41423 36006 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 27 10:38:39 2020 Received: (at 41423) by debbugs.gnu.org; 27 Aug 2020 14:38:39 +0000 Received: from localhost ([127.0.0.1]:43583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBJ31-0006dU-Eh for submit@debbugs.gnu.org; Thu, 27 Aug 2020 10:38:39 -0400 Received: from mx.sdf.org ([205.166.94.24]:62120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBJ2x-0006dH-Bd for 41423@debbugs.gnu.org; Thu, 27 Aug 2020 10:38:37 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07REcYF0007132 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 27 Aug 2020 14:38:34 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07REcYNY005244; Thu, 27 Aug 2020 14:38:34 GMT Date: Thu, 27 Aug 2020 14:38:32 +0000 From: Gregory Heytings To: 41423@debbugs.gnu.org Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The root of this bug is that `eshell-complete-commands-list' loops through all executables *on the remote server* with (while comps-in-path ...). That means typically 1000-2000 commands to check, one by one, hence the 3 minutes delay. The easy fix is to hit C-g, which stops this loop. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 05:32:55 2020 Received: (at 41423) by debbugs.gnu.org; 28 Aug 2020 09:32:55 +0000 Received: from localhost ([127.0.0.1]:45099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBakh-0005kg-E4 for submit@debbugs.gnu.org; Fri, 28 Aug 2020 05:32:55 -0400 Received: from mx.sdf.org ([205.166.94.24]:57569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBakf-0005kW-G1 for 41423@debbugs.gnu.org; Fri, 28 Aug 2020 05:32:54 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07S9WoBi001963 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 28 Aug 2020 09:32:51 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07S9WoXl022017; Fri, 28 Aug 2020 09:32:50 GMT Date: Fri, 28 Aug 2020 09:32:48 +0000 From: Gregory Heytings To: 41423@debbugs.gnu.org Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > The root of this bug is that `eshell-complete-commands-list' loops > through all executables *on the remote server* with (while comps-in-path > ...). That means typically 1000-2000 commands to check, one by one, > hence the 3 minutes delay. > > The easy fix is to hit C-g, which stops this loop. > Another note: in fact this bug exists because `eshell-complete-commands-list' is, in this context, called in Emacs 27, but not in Emacs 26 and earlier. The backtrace is: * eshell-complete-commands-list() #f(compiled-function () #)() pcomplete--here(#f(compiled-function () #) nil nil nil) #f(compiled-function () #)() pcomplete-completions() pcomplete-completions-at-point() #f(compiled-function () #)() completion-in-region--postch() In Emacs 26 `pcomplete--here' is called only once, with `pcomplete-entries' and `file-directory-p' in its `form' argument, and `pcomplete-completions' returns. In Emacs 27 `pcomplete--here' is called twice with these arguments, and a third time with `eshell-complete-commands-list' as its `form' argument. It is this third call which takes about three minutes to complete. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 09:17:30 2020 Received: (at 41423) by debbugs.gnu.org; 28 Aug 2020 13:17:30 +0000 Received: from localhost ([127.0.0.1]:45604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBeG1-0007QG-VH for submit@debbugs.gnu.org; Fri, 28 Aug 2020 09:17:30 -0400 Received: from mx.sdf.org ([205.166.94.24]:60326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBeFz-0007Q5-Cn for 41423@debbugs.gnu.org; Fri, 28 Aug 2020 09:17:28 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07SDHORK025628 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 28 Aug 2020 13:17:24 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07SDHNLG003722; Fri, 28 Aug 2020 13:17:23 GMT Date: Fri, 28 Aug 2020 13:17:21 +0000 From: Gregory Heytings To: 41423@debbugs.gnu.org Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) A last note: this bug exists because in Emacs 27 eshell uses `pcomplete-completions-at-point': TAB is bound to `completion-at-point' and `completion-at-point-functions' is `(pcomplete-completions-at-point t)'. In Emacs 26 eshell used the (now obsolete) `pcomplete' function: TAB was bound to `eshell-pcomplete', which was defined as follows: (defun eshell-pcomplete (&optional interactively) "Eshell wrapper for `pcomplete'." (interactive "p") (setq this-command 'pcomplete) (condition-case nil (if interactively (call-interactively 'pcomplete) (pcomplete)) (text-read-only (completion-at-point)))) IOW, pcomplete-completions-at-point was called only if `pcomplete' failed, and is now called by default. (`completion-at-point-functions' was set to `(pcomplete-completions-at-point t)', as in Emacs 27.) A simple fix is to eval (setq completion-at-point-functions '(pcomplete t)) after starting eshell (or to put this in one of the eshell hooks), which will restore the previous default behavior. I have no idea how `pcomplete-completions-at-point' should be adapted to avoid this bug. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 19:15:24 2020 Received: (at 41423) by debbugs.gnu.org; 28 Aug 2020 23:15:24 +0000 Received: from localhost ([127.0.0.1]:47659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBnae-0005nW-1P for submit@debbugs.gnu.org; Fri, 28 Aug 2020 19:15:24 -0400 Received: from mx.sdf.org ([205.166.94.24]:49407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBnaY-0005nF-W5 for 41423@debbugs.gnu.org; Fri, 28 Aug 2020 19:15:23 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07SNFFOl005325 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 28 Aug 2020 23:15:15 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07SNFEfg024451; Fri, 28 Aug 2020 23:15:14 GMT Date: Fri, 28 Aug 2020 23:15:12 +0000 From: Gregory Heytings To: 41423@debbugs.gnu.org Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Apparently my previous last note was not the last one ;-) I still don't know how this bug should be fixed (except by using (setq completion-at-point-functions '(pcomplete t))), but here is a more detailed explanation of what is happening, at least how I understand it: 1. TAB calls completion-at-point 2. completion-at-point calls pcomplete-completions-at-point, which calls pcomplete/cd; this completes the directory name 3. completion-at-point let-binds completion-in-region-mode-predicate to a lambda, which contains pcomplete-completion-at-point 4. completion-at-point calls completion-in-region, which adds completion-in-region--postch to post-command-hook 5. post-command-hook calls completion-in-region--postch 6. completion-in-region--postch funcalls completion-in-region-mode-predicate 7. this calls pcomplete-completions-at-point a second time, which again calls pcomplete/cd (and adds a '/' after the directory name (?)) 8. RET is pressed 9. post-command-hook still contains completion-in-region--postch: it is called again 10. completion-in-region--postch funcalls completion-in-region-mode-predicate again 11. this calls pcomplete-completions-at-point a third (!) time 12. at this point pcomplete-completions-at-point considers (for some reason, possibly because the last character of the input is '/' (?)) that it is a command that it must now complete 13. therefore instead of calling pcomplete/cd a third time, pcomplete-completions-at-point now calls eshell-complete-commands-list 14. this loops through all possible command names (on the local or remote host) 15. if all command names had had a common prefix, that prefix would have been inserted now, but this is not the case, so the effect of this loop (apart from a waste of time) is nil The fact that default-directory is remote is not important here, the exact same steps take place when it is local, except that step 15 is executed much faster. At step 15 it is possible to interrupt the loop with C-g. At step 8 it is possible to remove completion-in-region--postch from post-command-hook for example by switching buffers with C-x C-b. Why such a overly complicated mechanism is used, or what should be done to avoid this behavior, is beyond my understanding. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 08:39:05 2020 Received: (at 41423) by debbugs.gnu.org; 29 Aug 2020 12:39:05 +0000 Received: from localhost ([127.0.0.1]:48011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC08P-0004Ng-37 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 08:39:05 -0400 Received: from mout.gmx.net ([212.227.15.18]:41647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC08J-0004N6-Uu for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 08:39:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598704727; bh=35OnjKQ+4o66ozTQuhxDtrbMl0UyDnphmT9A78wFNHk=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=VazCDg1ja/arGtaIcba56hBhd628vhMGnKwbUfFpwYUIWWwqMUZXdLIHYpl603c4D VC6CK6hB4zgQqj5WU2rxv5pO8ks0EU2OgQBMdvzd8dq8tpfqjRIHHfaqpsmKyW8I+L b9iPTKKe2kSCtLaKZEq1Q9mnD4Fr/GzJ7MyyiXEk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.51.69]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfNl-1kSHhA0W9X-00vC5r; Sat, 29 Aug 2020 14:38:47 +0200 From: Michael Albinus To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] References: Date: Sat, 29 Aug 2020 14:38:45 +0200 In-Reply-To: (Gregory Heytings's message of "Fri, 28 Aug 2020 23:15:12 +0000") Message-ID: <87mu2d7hka.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:Sg19DI6xoAjNCpklD2knphGiTPUtuFPlT56/uMpIoVcKtsr4kyz ZI15HWn71DN4+0bidzqembtdO//JLeliP4/+57okbixvoOOymx/7ol6htjLQyd8uIqrFeid pk/LwiIFUd2zTjI6WIZu42LZ5nlD/F0ZlBuYpt0N5L15PA7vqa3v9I4qvQcHEJgtUMhevlv NZJqsqmezaD41aLSUH1Mw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:tWrZs+v2FHg=:TRFbbu2NJKxdvEaDdjOgDw f43/7IhoxZ8SMwjStrYVKHFCDiImBktPH84ynUnHEZ6hu35oMfVFisq9IMcYefsfGLJ8dJ+6o tcgCsAcGNEhpjgiaQEBX6f3I3y47k9npFuzcmZdKGJU2m65wtOizJODfMh4O4g+etltFLT0aU 0h8ueXT9XG5ghD4MWy3bkIKu+3oIndMjpUAJ0BtUCyL4sWwdD0u4/IBmfNfANAs2oxlEqMZKB ZDToHXSWUdamrawb9XqkWNd9N8+OTHh3JsK48VMUKpD9rQWC9Fa2VLvWrw4HL6eJl/NjRo9hF 82jC0zpq9esiSMw29UIWSX/NmN+DtV00sG23K6whQ9nVAKLZ0d0kp351i+xtUgLXpqR19g8aq aG4zuJg2V6HIrv1JEbwM/UW2s/Nk54MVJW4aOjBYF6x56NI9TDonGbEtH8mvcY2GQGsyUFq4C Na1zKioRUcKAh8dTKqIlIF+nYGkgiOF87eChDWyOa7gbPppLFysCPmOg+zGRDHWDTAe80NH0Y qgVYz5ZK7BRzMSLz35YHzdmiAW/HKnOAENP3kuAagUNIxYdphWWG9k22RkofiWl4eoTGp+y7A 2Vj2mdB4cVSGCfuq0PgefPpGFuWOX2VHurgHL8SqPa4FWOlOFmQPg26IyXFQ3sMV5/gGe/90m IL7ZPsqKBWBsFwbTuIiTp16S5c7s+mAY8C+9tq5od4l4ux1MjprWp8r7xH2P6ek7a2jj6cVvf 4BxouacezmMdY56TxHjNgdlswTeYkWN+sfFBXTuTAC6Fmn+aKptgk322vUcATOxsvwD/qLVra vtSod+PFbpgLOfLCNXYCvtH4oaoHmXjJlPOaXJHDen46hrW/Yy2wnRAdpcpuP9bB/meHpJIK1 O0a5Xx1pe/rtgrexYp434L5PLGay8y10bBY1GrotAYsfRv30w898XZ9RRh0iM8atl+xOVhwRa ZJ+H3AGUKUFdMPt27d3r5zXTvmuVJu3FvQsA8dx/7TXjb4umMBof81x3zVhzi/jBicH3eTcyU /dyy2WpyryrFQeCoL9GIx/DIK6JDFXl7nwlRuSyqaGDoUW9lAe7HHVq27OQHqK4fRNtJOREkU RC/dAYxICrSlHwQAfWGF/zv6v21qUpaBMYduovIdeaVpIjQyH+T+RAJS3FkyS7avzS40HOsYU 8Wg7kJz99uyMrsHCU/S0rqTUVgCiDTaAzbGoX4mpCvr9j7Z1A8n+8/1zFy0/o9HhZS4Vs8PPy oYunEizHJx5C+wvzaqPxj8KA8vPegSafoCvFGtg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Gregory Heytings writes: Hi, > Apparently my previous last note was not the last one ;-) > > I still don't know how this bug should be fixed (except by using (setq > completion-at-point-functions '(pcomplete t))), but here is a more > detailed explanation of what is happening, at least how I understand > it: > > 1. TAB calls completion-at-point > 2. completion-at-point calls pcomplete-completions-at-point, which > calls pcomplete/cd; this completes the directory name > 3. completion-at-point let-binds completion-in-region-mode-predicate > to a lambda, which contains pcomplete-completion-at-point > 4. completion-at-point calls completion-in-region, which adds > completion-in-region--postch to post-command-hook > 5. post-command-hook calls completion-in-region--postch > 6. completion-in-region--postch funcalls completion-in-region-mode-predicate > 7. this calls pcomplete-completions-at-point a second time, which > again calls pcomplete/cd (and adds a '/' after the directory name (?)) > 8. RET is pressed > 9. post-command-hook still contains completion-in-region--postch: it > is called again > 10. completion-in-region--postch funcalls > completion-in-region-mode-predicate again > 11. this calls pcomplete-completions-at-point a third (!) time > 12. at this point pcomplete-completions-at-point considers (for some > reason, possibly because the last character of the input is '/' (?)) > that it is a command that it must now complete > 13. therefore instead of calling pcomplete/cd a third time, > pcomplete-completions-at-point now calls eshell-complete-commands-list > 14. this loops through all possible command names (on the local or remote host) > 15. if all command names had had a common prefix, that prefix would > have been inserted now, but this is not the case, so the effect of > this loop (apart from a waste of time) is nil > > The fact that default-directory is remote is not important here, the > exact same steps take place when it is local, except that step 15 is > executed much faster. > > At step 15 it is possible to interrupt the loop with C-g. At step 8 > it is possible to remove completion-in-region--postch from > post-command-hook for example by switching buffers with C-x C-b. > > Why such a overly complicated mechanism is used, or what should be > done to avoid this behavior, is beyond my understanding. I don't know the completion machinery, so I'm adding Stefan who might know better. However, the remote case could be improved. Tramp uses caches. They expire after a while (10 seconds per default), but this might be improved. The appended patch disables Tramp cache expiry while being in eshell-complete-commands-list, so completion might be faster once the cache has been filled. Could you pls check? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable *** /tmp/ediff046iSD 2020-08-29 14:36:21.788278641 +0200 =2D-- /usr/local/src/emacs-27/lisp/eshell/em-cmpl.el 2020-08-29 14:22:38.7= 81483169 +0200 *************** *** 399,405 **** (defun eshell-complete-commands-list () "Generate list of applicable, visible commands." ! (let ((filename (pcomplete-arg)) glob-name) (if (file-name-directory filename) (if eshell-force-execution (pcomplete-dirs-or-entries nil #'file-readable-p) =2D-- 399,405 ---- (defun eshell-complete-commands-list () "Generate list of applicable, visible commands." ! (let ((filename (pcomplete-arg)) glob-name remote-file-name-inhibit-ca= che) (if (file-name-directory filename) (if eshell-force-execution (pcomplete-dirs-or-entries nil #'file-readable-p) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 09:09:00 2020 Received: (at 41423) by debbugs.gnu.org; 29 Aug 2020 13:09:00 +0000 Received: from localhost ([127.0.0.1]:48028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC0bM-000569-CH for submit@debbugs.gnu.org; Sat, 29 Aug 2020 09:09:00 -0400 Received: from mx.sdf.org ([205.166.94.24]:60806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC0bK-000561-PS for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 09:08:59 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07TD8vC5001332 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 29 Aug 2020 13:08:57 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07TD8v43015268; Sat, 29 Aug 2020 13:08:57 GMT Date: Sat, 29 Aug 2020 13:08:55 +0000 From: Gregory Heytings To: Michael Albinus Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Michael, > > However, the remote case could be improved. Tramp uses caches. They > expire after a while (10 seconds per default), but this might be > improved. The appended patch disables Tramp cache expiry while being in > eshell-complete-commands-list, so completion might be faster once the > cache has been filled. Could you pls check? > I just checked, and see no visible improvement. That being said, I don't think this bug should be fixed on the eshell level. It's a bug in the completion mechanisms, and `eshell-complete-commands-list' should simply not be called here. Gregory From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 11:44:22 2020 Received: (at 41423) by debbugs.gnu.org; 29 Aug 2020 15:44:22 +0000 Received: from localhost ([127.0.0.1]:48905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC31i-0002ui-1H for submit@debbugs.gnu.org; Sat, 29 Aug 2020 11:44:22 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC31g-0002uW-5v for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 11:44:20 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A9C9F809C0; Sat, 29 Aug 2020 11:44:14 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2FD8D80855; Sat, 29 Aug 2020 11:44:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598715853; bh=9hU1h7PZ6QTi9j883I83rZXFAJJgdI+lYbJack31u90=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ISePyYXlF8iQEa4o6VCVJrMoUXfD0cv6BDbJBY5B2xUNm4bhYYDKXik5kZEx7sLxM FA6afQ81B73l1yz4khNU0GwZSc+ZaYRbGDV2j1z2RTtKKU9gWtnQfMQDRGw/asVNQa fv9m5WHQyp+mM5aji6C9W38A0dPIXIX+BirsoKy/ruoBMeQQORaiAMqVlSHnbjMJGH zWdIvrnFHRXQI6P3XP43iZgtoNpDl4UvfLiNK8ZfEG0YYyqypisxn0Uq2aT8UIKq3C aDwSERIAhXtzSB+VnRtj3f86GZ3Gm3tcrDOLpPhLdFQ53TPS1KldBwU2ngLH+hpBQa YaAdpXFR3MVIQ== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CCE79120795; Sat, 29 Aug 2020 11:44:12 -0400 (EDT) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Sat, 29 Aug 2020 11:44:11 -0400 In-Reply-To: <87mu2d7hka.fsf@gmx.de> (Michael Albinus's message of "Sat, 29 Aug 2020 14:38:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Gregory Heytings , rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> 1. TAB calls completion-at-point >> 2. completion-at-point calls pcomplete-completions-at-point, which >> calls pcomplete/cd; this completes the directory name Sounds like a bug: the `completion-at-point-functions` should not perform the completion but should only return a description of the part of the text that is the subject of completion, along with a description (generally in the form of a function) of the set of elements from which the possible completions can be taken. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 12:12:22 2020 Received: (at 41423) by debbugs.gnu.org; 29 Aug 2020 16:12:22 +0000 Received: from localhost ([127.0.0.1]:48939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC3So-0003ZL-0L for submit@debbugs.gnu.org; Sat, 29 Aug 2020 12:12:22 -0400 Received: from mx.sdf.org ([205.166.94.24]:62638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC3Sl-0003ZE-Fx for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 12:12:20 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07TGCIDj018825 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 29 Aug 2020 16:12:18 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07TGCHj3017107; Sat, 29 Aug 2020 16:12:17 GMT Date: Sat, 29 Aug 2020 16:12:15 +0000 From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> 1. TAB calls completion-at-point >> 2. completion-at-point calls pcomplete-completions-at-point, which calls pcomplete/cd; this completes the directory name > > Sounds like a bug: the `completion-at-point-functions` should not > perform the completion but should only return a description of the part > of the text that is the subject of completion, along with a description > (generally in the form of a function) of the set of elements from which > the possible completions can be taken. > Please don't take my words too literally. "This completes the directory name" does not mean that `pcomplete/cd' performs the completion itself. Indeed it returns something with which the completion is performed. The bug is clearly not there (at step 2), but later (in the fact that `completion-at-point' calls `pcomplete-completions-at-point' three times). From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 12:55:10 2020 Received: (at 41423) by debbugs.gnu.org; 29 Aug 2020 16:55:10 +0000 Received: from localhost ([127.0.0.1]:49042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC48D-0000cH-RJ for submit@debbugs.gnu.org; Sat, 29 Aug 2020 12:55:10 -0400 Received: from mout.gmx.net ([212.227.15.15]:44849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC48C-0000bz-HQ for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 12:55:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598720095; bh=jUTlkxu20GkF7iRAaqKrgw3Jj1HQ2mHVFSmIgPdt3so=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Hjt+KiZJxS6CzirIoGusbQcOKR98Ueudr2ZIY40g/5CErt3/fyjKHi9NfjSw77JCD AQAM3NCIL0zD0UXP1Co7OFtGI/+61eZNt4yEh/53iIzHDykszYwiWFvTssgGO7abZS FJEiHfpuT4IMKDHp+CwzOwu1rrzJXvkH4GSTh3S0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.51.69]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MkYXs-1ksJAe39J8-00m0zz; Sat, 29 Aug 2020 18:54:54 +0200 From: Michael Albinus To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] References: Date: Sat, 29 Aug 2020 18:54:52 +0200 In-Reply-To: (Gregory Heytings's message of "Sat, 29 Aug 2020 13:08:55 +0000") Message-ID: <87imd175pf.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Qmhnz9I+o5tQkgpDDI/cLjbGU/rCmtuuJbhtKa6IU1D0siPSY0m Y8v9TaDliV7x8XZiIxEniNklMO0nc9xxcEPFZyxzWGU/O8S+kFG7EweGBF7S2rU44t3VBW8 6+z+hLksMi4kVaeNfGpFVadEMkaecL9gZEkMw+GhaLoDlHQioE3PtG6Vk/SpphH83pkbT0Y Anr0aaNrXaONspi0slzOw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XW2+hs4as6s=:AfotO/7iJ0uyneH/0KIM6D +n80/ZewOgI2yRxlW82dht40pOIaNZ5f1LPleGrRGXUbMO5xWgOWxO675SMowisytA0WhnPem ACEoetnKrGdMFaH2yaWs3Am6sNA5cIo3Gqw2hI+otg40YkdoRFW22/fitPlVyNw9mWj8gg+Xl dx3s+p5LysVUJSyvu7V880exG1Z8QLclGhJpBEVPmVlYHRAJ5gUnpHMXRVERBYX30/2tzjeUe ecIB/H1BzQMfcwO0GyfZ5fMijjg8XhqJhCQQYMjtdnyCAO6QJCCEWRaLTs6oh4MUbOagppeV/ 2LGoBp3PClFVp3LLs8POlf2qPQRP67XGGXXUQS8wonfcaHvuDLiIHen6V4QXtjGF0mxfOmkaT 2CcS9YLyX/byuT/iqpXpAs8Iw+I0+KL0HbpMHI1bnXswH2jYc2MbRVf8p8t8iAfXFq5gzNhBI 0Fo0e3kg0Ja5AGmP3ppofj/ZjG8JP/f5m8Feyvpf0y3mT5ggDUl/cdf6gqpwG3C40j0UxQyLe CkGu+qmlqF1B/gT9bhKCc7CxiGrnwDfs64ijwdFj1U8vxRL4XmFAcz0YZEixbR/g59qRf8X0J zy98XP0nwKHm+c0WQoxDNckZh3CUqmSyz2G9y+N+by5f8wBx1aSLES9y2ZGsThylwyKwYaJGA s73Hs2BHn9SGWtv44Vs3+8fSzik72wIRaicxWY62CWOH5UOw8PxAojQOYOsZaDp4bUvE2WmO8 WMRUUHGwWfeFyBUZgPfQjRL58smPc1J7FSnoEcEv64KHE2OvoYYiwW8+Ff1rSroBMsgOPwpkc zUIZkdRnptbAZ2l92/3H/6Axp3lXIwQFLz0dORq9ZbyllWv24OIvTDEjkE5WYnAI/8jpZnTsT GN0H6ly3msTgVUGfgteOPJbaZd2IZbYFhiMB9cNdtWZG8oeFOLRuzwbvUNWrVPliwNFKYLMnz arDPEW6T0EB32wYUjuwqck8qtWsjqBRFRWDN4mDquYoMGEQ+VVnJKebbXI4KLqjPl5Y5YlgUH Rc/lCoC1zGcKC3AZmksutvwSsRyoiVAoBP1Txwi+ea3/v6kG5L6FP1O8dxcDfVOw1+zfLuXrH 6qTvJ0V3QWgpljz4Kkdlwori7mKOwUZ6kF/paFGA4+82XjLFqvsTVeyk/McrsWpCddapdbfvH xjn9i4GA66GhLiimDYREOwt4RgqDuGUG5O9tU3AQ6xQynld5FqpyQOZS1ik0CzBWgD28sJqPa DAJbaEY/xLj82/kA9OQ3+/nYMZDhbEaa4GbPbdA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Gregory Heytings writes: > Hi Michael, Hi Gregory, >> However, the remote case could be improved. Tramp uses caches. They >> expire after a while (10 seconds per default), but this might be >> improved. The appended patch disables Tramp cache expiry while being >> in eshell-complete-commands-list, so completion might be faster once >> the cache has been filled. Could you pls check? >> > > I just checked, and see no visible improvement. The first time you try completion, there's no difference. The cache must be filled. But all next times you complete, it shall be faster for remote directoriues. > That being said, I don't think this bug should be fixed on the eshell > level. It's a bug in the completion mechanisms, and > `eshell-complete-commands-list' should simply not be called here. I do not claim my patch is the solution. But it shall be useful, if eshell-complete-commands-list is called somewhere. > Gregory Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 13:14:10 2020 Received: (at 41423) by debbugs.gnu.org; 29 Aug 2020 17:14:10 +0000 Received: from localhost ([127.0.0.1]:49061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC4Qc-00014c-0x for submit@debbugs.gnu.org; Sat, 29 Aug 2020 13:14:10 -0400 Received: from mx.sdf.org ([205.166.94.24]:57922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC4Qa-00014T-IL for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 13:14:09 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07THE7Dv003446 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 29 Aug 2020 17:14:07 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07THE6Bm000802; Sat, 29 Aug 2020 17:14:06 GMT Date: Sat, 29 Aug 2020 17:14:04 +0000 From: Gregory Heytings To: Michael Albinus Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: <87imd175pf.fsf@gmx.de> Message-ID: References: <87imd175pf.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > >> I just checked, and see no visible improvement. > > The first time you try completion, there's no difference. The cache must > be filled. But all next times you complete, it shall be faster for > remote directoriues. > Yes, this is what I did. The first time there was no difference. The second time I did not see any difference either, alas. I just tried it again. > > I do not claim my patch is the solution. But it shall be useful, if > eshell-complete-commands-list is called somewhere. > A much better patch at this point is to just restore the previous default behavior (in Emacs 26 and earlier) by setting completion-at-point-functions to '(pcomplete t) instead of '(pcomplete-completions-at-point t), for example with: (add-hook 'eshell-mode-hook (function (lambda () (setq completion-at-point-functions '(pcomplete t))))) pcomplete is obsolete, but it is still there, and it works. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 13:28:43 2020 Received: (at 41423) by debbugs.gnu.org; 29 Aug 2020 17:28:43 +0000 Received: from localhost ([127.0.0.1]:49069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC4eh-0001P3-Is for submit@debbugs.gnu.org; Sat, 29 Aug 2020 13:28:43 -0400 Received: from mout.gmx.net ([212.227.17.20]:57979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC4ec-0001Ol-0D for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 13:28:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598722103; bh=8EjOZSQU/mUQ2T0mDajJUD/WeB2eT3rWVi6AqT+H0Mw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=T/TOPlJZWCFQdFHdEjnnu6+EqStNgHJsdO7IzhbANKzn4J9tM2LbYOIsMpVtyVhbY 3aRZXfeKTlHzgBlg2w7cFhl20iIJ1yXdbwURZYDfSEnxquM0/6W6djRio/2DGoL4HG eg+YWLokOcsNFzODD9Z4tYSp4FyuO7IZwYQr0TbI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.51.69]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MdefJ-1klPXD4C5x-00ZfnK; Sat, 29 Aug 2020 19:28:23 +0200 From: Michael Albinus To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] References: <87imd175pf.fsf@gmx.de> Date: Sat, 29 Aug 2020 19:28:19 +0200 In-Reply-To: (Gregory Heytings's message of "Sat, 29 Aug 2020 17:14:04 +0000") Message-ID: <87a6yd745o.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ZFerM4wTOYtflTNEXNSjpRwd0bT6GI4omzO/6d7Qvyzle0isqTy H9S/4H5u1DFPcCCw0TO7xnSHcWge41tVD4fb0VJiaUKdyM0LxJX/dkdUHZuaZtj4sTA0K4S fPdjrml79f3Jx+xwm+7DYqy+pl0+7thdssuTGEePeQLw4ENlnEo9SFP1dGohEMe7ags9rJg n0mAX7ZRXLuVpSMsw3zrg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:hcNkEOGd/5E=:qesqrL/hN0KQQxXBcSCgxc 251gQnq8XCX1UJXJqgkbWYLUOkp4yJlMsgGYmTTWaVkYMCi0prB8P0ZFXSf3VqLz3KvZ6rFJX s/UQM4hl//yAh3Jqq0qEgTS4yYVEFMy2toTVH8gGZY0mtVJbfsobW3pWLSOUjyYzJf59txC+i eoAI4VY7fkt1kL6ufMHj/knaRbyXiwck+0/ynmoMmIlwgswdm3db0A63Bw1jpnWr/nIu5t19V ZVwpSW86wVx62Ztv1nx1LUFtyLF7h1RPiqjs6L2rjE5ob0kKxcNHQgb5Q4UO3cj2Oi7/enDVP mKGBeSuzbw1U1IZf0I0yXI25cBVNjurlSKBDjvrE3dMiSggauj1WAC4s8y1EjD43xhnaKK1pb WTqN0lKXqgANmLHow4Iw6y4kbakfh0Cu8NcRqPcQpX97qpm14hSITnxIFjJUlsREihV6BPtFs 447z3U/Bp2rhZqhHfewqzDOd2hY4DfshsG9g4KTePAKKqDuAgDQiOE04h2p0RUDxVRg0ADh3F OTt7suHRofg7lStv401Ky7oAjb2j0fDNX4GXf7huHr0x6UPmFUOC7wua48+TZzkZTIoKt1MJ5 x1PpuZJZemQkLYiH81yON6n4XiiH5vChaid2cm8LxWMN//B1AxbnN1NTSzKWbYOu+O949VudV MqFRWM2JjVNtZ/tWAB94aVMNpce2E2Hat1/VUDyQahmPATlOhug5qOPcnbLvP6p9SleiisxMu 7qZ1UhYnyXiR64OwE+O64PTjT95gHpuyl6qRi0rz9xQrgqzcJwI39Geylodp3wBlUYo5PUAWV C0ctSuPINjIvJfNk9wXE3Zm2r04Ju7CtMtWqeXmJdfnHDRU2aMXRSYXqLwm3Ch+GN43ELh11a dXEqiZxfkCIFknPhJa3M/NWlVSW0pKiZWaw7SNn0SkiHS4E7jrBr/XZDUJVPHYNabfeqWYqTR MmTVbCb+HlBQnJdaeAZ5oE4svsphBAJC24V9sPoyKWRLu8lrG1Ht04X9sWwNbU/jqkmeXQkOG OjQ326hjTSyQa6qcG6eJA6FFXn915m7sPU4+VItYSRVL4fHZeH0+HYUW1EJey/W97kkOcgfxX y5ffT97Ml26AL2Rj+BLYPwVlzqfu3szoTebJufLohPD2FoJpf2EPWUzwJ2A1mvnLd4Exs5exZ m+1w60FhUl/4CejyiX52NWo2J15cgR2Qwtf0ydRUsNUMsRfHT6WQ0tgkfyyeEtKNncjXd/g2W F35Afc5cV1K4PDGQhLEgFIQ0qalB8btjXTzeIIg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Gregory Heytings writes: > A much better patch at this point is to just restore the previous > default behavior (in Emacs 26 and earlier) by setting > completion-at-point-functions to '(pcomplete t) instead of > '(pcomplete-completions-at-point t), for example with: > > (add-hook 'eshell-mode-hook (function (lambda () (setq > completion-at-point-functions '(pcomplete t))))) > > pcomplete is obsolete, but it is still there, and it works. I guess Stefan had a reason when he applied 047c1b19353ff58d8cd45935c7b44c911b70e312 last year. Let's see his analysis. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 23:55:16 2020 Received: (at 41423) by debbugs.gnu.org; 30 Aug 2020 03:55:16 +0000 Received: from localhost ([127.0.0.1]:49353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCER1-0007ab-Ue for submit@debbugs.gnu.org; Sat, 29 Aug 2020 23:55:16 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCER0-0007aP-Sc for 41423@debbugs.gnu.org; Sat, 29 Aug 2020 23:55:15 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 51468809C0; Sat, 29 Aug 2020 23:55:09 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 87FA380855; Sat, 29 Aug 2020 23:55:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598759707; bh=OEUyx7UZASVoTjFTxToe+cVgX/XLB/rSIT0U4zK+3PU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=U1Zjjc6I/uWI2CUbiNSptGRBI3ZtZgwcn9qV4OZriFJDcUzCarEe3Kq52LNI0L5nn OFXfC8/efd+zCAVWwIN9hDNeWlbGMqF3S0732xGlDWD6DHYVcEI+Ymc+BN5AR5Dvic bM+OSjZ9NWcovRWNFjxJ5LBG3dsqKTjhvzUOoF+QerlLZWMBwuGJcvy2mZHmcdRj8P K+PUL8GpRabxJ/nhbTBTNUqj+u5pQsyLUUW10Shjx63fcf5UbyBJnWz3nwUm27QnYT 5e8mNgEDa5K5NMjQTZ9AtcgW/HSUkT+1aNIUPtrJLLKVy4EQdtyW16pbIcvGhdvoHW pYN0bRn7VgLMg== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3621A120397; Sat, 29 Aug 2020 23:55:07 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Sat, 29 Aug 2020 23:55:05 -0400 In-Reply-To: (Gregory Heytings's message of "Sat, 29 Aug 2020 16:12:15 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Please don't take my words too literally. "This completes the directory > name" does not mean that `pcomplete/cd' performs the completion > itself. Indeed it returns something with which the completion is performed. Hmm... any hope you could refine your description accordingly? > The bug is clearly not there (at step 2), but later (in the fact that > `completion-at-point' calls `pcomplete-completions-at-point' three times). Calling `pcomplete-completions-at-point` several times is not necessarily a problem. E.g. it's normal to call it a second time after completion to check whether we're still in the same completion area (in order to detect when completion is "finished"). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 18:28:08 2020 Received: (at 41423) by debbugs.gnu.org; 30 Aug 2020 22:28:08 +0000 Received: from localhost ([127.0.0.1]:50932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCVnz-0000qL-P4 for submit@debbugs.gnu.org; Sun, 30 Aug 2020 18:28:08 -0400 Received: from mx.sdf.org ([205.166.94.24]:57328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCVny-0000qE-M3 for 41423@debbugs.gnu.org; Sun, 30 Aug 2020 18:28:07 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07UMS5Dw014957 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 30 Aug 2020 22:28:05 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07UMSB48002619; Sun, 30 Aug 2020 22:28:11 GMT Date: Sun, 30 Aug 2020 22:28:01 +0000 From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Hmm... any hope you could refine your description accordingly? > I do not understand why I should explain to you how the code you wrote works. Anyway, here we go (and I fear you will now tell me that my description is now too refined): 1. start emacs -Q 2. in an eshell buffer, type " TAB" (command can be "cd", "ls", "rm", ...) 3. TAB calls completion-at-point 4. completion-at-point looks at completion-at-point-functions, whose value is (pcomplete-completions-at-point t), and calls pcomplete-completions-at-point 5. pcomplete-completions-at-point calls pcomplete-completions, which calls pcomplete/cd, which calls pcomplete--here, ... 6. pcomplete-completions returns a collection of completion candidates, and pcomplete-completions-at-point returns that collection together with a function pointer (to pcomplete-completions-at-point itself), a start position, an end position, and a property list 7. we are now back in completion-at-point, and enter the second case in its pcase 8. completion-at-point let-binds completion-in-region-mode-predicate to a lambda, which calls pcomplete-completion-at-point 9. completion-at-point then calls completion-in-region, which calls completion--in-region 10. completion--in-region enters completion-in-region-mode, which adds completion-in-region--postch to post-command-hook 11. completion--in-region calls completion--in-region-1, which calls completion--do-completion, which finally does the actual completion based on the collection of completion candidates returned at step 6 12. at this point the eshell buffer contains the completed directory name, with a trailing slash 13. completion-at-point is now finished, and post-command-hook is executed 14. post-command-hook calls completion-in-region--postch 15. completion-in-region--postch calls completion-in-region-mode-predicate (in fact, completion-in-region-mode--predicate which has been set to completion-in-region-mode-predicate when entering completion-in-region-mode at step 10) 16. this calls pcomplete-completions-at-point a second time, which calls pcomplete-completions, which calls pcomplete/cd, which calls pcomplete--here, ... 17. pcomplete/cd and pcomplete-completions return the exact same values as in step 6 18. pcomplete-completions-at-point returns almost the same value as in step 6 (the only difference is the value of the end position) 19. given that the value of the start position did not change, the lambda let-bound at step 8 returns t, and therefore completion-in-region--postch exits completion-in-region-mode entered at step 10 20. completion-in-region--postch is now finished, it did not change anything in the eshell buffer 21. RET is pressed 22. post-command-hook is executed, and still contains completion-in-region--postch, so it is called again 23. completion-in-region--postch calls completion-in-region-mode-predicate 24. this calls pcomplete-completions-at-point a third time, which calls pcomplete-completions 25. for some reason, pcomplete-completions considers that it must now complete a command name and not a directory name 26. therefore pcomplete-completions does not call pcomplete/cd but eshell-complete-commands-list 27. eshell-complete-commands-list loops through all possible command names 28. if these command names had a common prefix, it would have been inserted in the eshell buffer (?), but this is not the case, so the effect of this loop (apart from a waste of time) is nil 29. when eshell-complete-commands-list has finished its job, eshell prints its next prompt At step 27 it is possible to interrupt the loop with C-g. At step 21 it is possible to remove completion-in-region--postch from post-command-hook, for example by switching buffers with C-x C-b. > > Calling `pcomplete-completions-at-point` several times is not > necessarily a problem. E.g. it's normal to call it a second time after > completion to check whether we're still in the same completion area (in > order to detect when completion is "finished"). > For some general case , I don't know (I admit I can't think of a case in which this would be useful, but I know my experience is limited). To complete a directory name in a shell, I don't see why this should be the case. The (now obsolete) mechanism calls pcomplete (which also calls pcomplete/cd) a single time, and it worked. I don't see what steps 13-29 could possibly do that would be useful, at least in the context of a shell. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 31 04:30:09 2020 Received: (at 41423) by debbugs.gnu.org; 31 Aug 2020 08:30:09 +0000 Received: from localhost ([127.0.0.1]:51513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCfCb-0003BT-7D for submit@debbugs.gnu.org; Mon, 31 Aug 2020 04:30:09 -0400 Received: from mx.sdf.org ([205.166.94.24]:55035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCfCZ-0003Al-Gh for 41423@debbugs.gnu.org; Mon, 31 Aug 2020 04:30:08 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 07V8U62u025342 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 31 Aug 2020 08:30:06 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 07V8UCMI018223; Mon, 31 Aug 2020 08:30:12 GMT Date: Mon, 31 Aug 2020 08:30:03 +0000 From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Two corrections: Step 19 should be: 19. given that the value of the start position did not change, the lambda let-bound at step 8 returns t, and therefore completion-in-region--postch does not exit completion-in-region-mode And the last steps should be: 29. when eshell-complete-commands-list has finished its job, pcomplete-completions-at-point returns a value in which the start position has changed 30. therefore the lambda let-bound at step 8 returns nil, and therefore completion-in-region--postch exits completion-in-region-mode entered at step 10 31. this removes completion-in-region--postch from post-command-hook 32. eshell finally prints its next prompt From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 00:24:13 2020 Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 04:24:13 +0000 Received: from localhost ([127.0.0.1]:54490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCxq9-00083H-Bv for submit@debbugs.gnu.org; Tue, 01 Sep 2020 00:24:13 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCxq6-000832-Mx for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 00:24:11 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0FFAB80712; Tue, 1 Sep 2020 00:24:05 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 32D1680513; Tue, 1 Sep 2020 00:24:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598934243; bh=7FjurgGv+xAhtzaP7RQ9XaOUHzo2/4PfbsMbKJnomIs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QmZSYL2ZKuJ5m9ipqtZrlqRII4difdroaAXJUrwxbXj9hZX5WGK+icOshkiSna4yQ iPrB4/nalylur1zkCjkyjTDRoPkCQuE5+3S1AgBtZn+aUagQOJB9TJuB121VqsJxLq 5Gd9LCfyXSlmbM6GoepmeVEGSvCLF8cUBa0QwiJOkfqyte+9YTTfGpk8Jc1CLWQYD+ JceIqt37w3G0LIP2ZAU7i//uZJhB5UuTnKvS0SuROS6utrVVBZ35H8TmKppZHWG7mE kZNtOrpaUuWnKuGBP14lfR9XdTo+JuvbSV6/zTjOa7E8wK8VlT3G4RxTIEWGpuudo5 Z5wIBsfBiotHA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E89BB1202FB; Tue, 1 Sep 2020 00:24:02 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Tue, 01 Sep 2020 00:23:54 -0400 In-Reply-To: (Gregory Heytings's message of "Sun, 30 Aug 2020 22:28:01 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I do not understand why I should explain to you how the code you wrote > works. [ Because I remember ow it's supposed to work, but I don't know how it actually behaves in this specific case. ] > 19. given that the value of the start position did not change, the lambda > let-bound at step 8 returns t, and therefore completion-in-region--postch > does not exit completion-in-region-mode > 20. completion-in-region--postch is now finished, it did not change > anything in the eshell buffer > 21. RET is pressed > 22. post-command-hook is executed, and still contains > completion-in-region--postch, so it is called again > 23. completion-in-region--postch calls completion-in-region-mode-predicate > 24. this calls pcomplete-completions-at-point a third time, which calls > pcomplete-completions Looks OK so far. > 25. for some reason, pcomplete-completions considers that it must now > complete a command name and not a directory name I guess this is because after RET we're now at BOL so it looks like a brand new command is starting. > 26. therefore pcomplete-completions does not call pcomplete/cd but > eshell-complete-commands-list I guess this is the culprit and this is where the time is spent. `eshell-complete-commands-list` eagerly builds the list of possible candidates and it takes a while whereas we should here return something quickly and cheaply, e.g. by returning a function which will build and return this list more lazily when completion is actually performed. Of course, the slowdown will presumably still be seen when you do actually want to complete a command name, so we should probably try and figure out more precisely where the slowdown comes from and how to avoid/reduce it. I guess part of the slowdown comes from the fact that we don't just use `file-name-all-completions` in each directory in PATH but we additionally call `file-executable-p` (or `file-readable-p`) on every command found, which I expect will take quite a while when it goes through Tramp. Still, I'm not completely sure where the time is spent because I'm not sure which files/dirs will go through tramp. AFAICT, `eshell-get-path` will return the "local" $PATH rather than that of the remote host ... oh wait, no I see that `tramp-eshell-directory-change` will set that to the remote host's $PATH, so it should indeed work correctly (but slowly). Maybe `tramp-eshell-directory-change` should tell `eshell-complete-commands-list` to cache the list and also not to bother checking `file-executable-p`? > And the last steps should be: > > 29. when eshell-complete-commands-list has finished its job, > pcomplete-completions-at-point returns a value in which the start position > has changed > 30. therefore the lambda let-bound at step 8 returns nil, and therefore > completion-in-region--postch exits completion-in-region-mode entered at step > 10 > 31. this removes completion-in-region--postch from post-command-hook > 32. eshell finally prints its next prompt Yes, these steps look fine. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 04:31:24 2020 Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 08:31:24 +0000 Received: from localhost ([127.0.0.1]:54833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD1hM-0008CP-8C for submit@debbugs.gnu.org; Tue, 01 Sep 2020 04:31:24 -0400 Received: from mx.sdf.org ([205.166.94.24]:63039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD1hI-0008CE-JH for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 04:31:23 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 0818VJ0c000064 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 1 Sep 2020 08:31:19 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 0818VRh1003820; Tue, 1 Sep 2020 08:31:27 GMT Date: Tue, 1 Sep 2020 10:31:14 +0200 (CEST) From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > >> 26. therefore pcomplete-completions does not call pcomplete/cd but >> eshell-complete-commands-list > > I guess this is the culprit > No, see below. > > and this is where the time is spent. > Yes, this is what I said. > > `eshell-complete-commands-list` eagerly builds the list of possible > candidates and it takes a while whereas we should here return something > quickly and cheaply, e.g. by returning a function which will build and > return this list more lazily when completion is actually performed. > No, the bug is in the completion mechanism, not in eshell. I don't know exactly (because the mechanism is so complicated) where the completion functions should be fixed, but it is clear that there is no reason to call pcomplete-completions-at-point *three* times. There is no reason to call pcomplete-completions-at-point when RET is pressed. Typing "cd foo/ RET" does not call pcomplete-completions-at-point. Typing "cd foo TAB RET" should only call pcomplete-completions-at-point to add the trailing slash, and should not build a list of all possible commands. > > Of course, the slowdown will presumably still be seen when you do > actually want to complete a command name, so we should probably try and > figure out more precisely where the slowdown comes from and how to > avoid/reduce it. > That's another, separate issue, and it is not relevant here. BTW, when you want to complete a command name, at least you have some characters in the prefix (or if you don't, you expect that listing all candidates will be slow). Typing "cd TAB" works almost instantaneously (and prints "Sole completion"), even on a remote host. Typing "ls TAB" works almost instantaneously, too, even on a remote host. It prints "Complete, but not unique", and pressing TAB again lists the alternate completion candidates. Typing "l TAB" takes (on a remote host) five to ten seconds before printing all completion candidates, but again this is what a user expects. Nobody expects that typing RET, when the completion has already been done, would take three minutes. > > Maybe `tramp-eshell-directory-change` should tell > `eshell-complete-commands-list` to cache the list and also not to bother > checking `file-executable-p`? > That's yet another, separate issue, that is not relevant here. Indeed there are possible improvements in eshell and tramp, but this bug is in the completion mechanism, not in eshell or in tramp. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 06:14:41 2020 Received: (at submit) by debbugs.gnu.org; 1 Sep 2020 10:14:41 +0000 Received: from localhost ([127.0.0.1]:55138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD3JJ-0004dF-4z for submit@debbugs.gnu.org; Tue, 01 Sep 2020 06:14:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:35214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD3JG-0004d7-N3 for submit@debbugs.gnu.org; Tue, 01 Sep 2020 06:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD3JG-0007Id-Hj for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 06:14:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48266) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD3JF-0006Rg-Ri; Tue, 01 Sep 2020 06:14:37 -0400 Received: from [2a02:14f:1ff:9ae7::8cee:a9f] (port=51636) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1kD3JE-0000pk-KD; Tue, 01 Sep 2020 06:14:37 -0400 Date: Tue, 01 Sep 2020 13:14:33 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <87mu2d7hka.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] To: Gregory Heytings , "Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Stefan Monnier From: Eli Zaretskii Message-ID: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Michael Albinus , rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On September 1, 2020 11:31:14 AM GMT+03:00, "Gregory Heytings via Bug repor= ts for GNU Emacs, the Swiss army knife of text editors" wrote: > >> >>> 26=2E therefore pcomplete-completions does not call pcomplete/cd but= =20 >>> eshell-complete-commands-list >> >> I guess this is the culprit >> > >No, see below=2E > >> >> and this is where the time is spent=2E >> > >Yes, this is what I said=2E > >> >> `eshell-complete-commands-list` eagerly builds the list of possible=20 >> candidates and it takes a while whereas we should here return >something=20 >> quickly and cheaply, e=2Eg=2E by returning a function which will build >and=20 >> return this list more lazily when completion is actually performed=2E >> > >No, the bug is in the completion mechanism, not in eshell=2E I don't >know=20 >exactly (because the mechanism is so complicated) where the completion=20 >functions should be fixed, but it is clear that there is no reason to >call=20 >pcomplete-completions-at-point *three* times=2E Would it help to profile the completion process in this use case using the= built-in Lisp profiler? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 07:50:50 2020 Received: (at submit) by debbugs.gnu.org; 1 Sep 2020 11:50:50 +0000 Received: from localhost ([127.0.0.1]:55295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD4oL-0005Dx-Qr for submit@debbugs.gnu.org; Tue, 01 Sep 2020 07:50:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:34280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD4oI-0005Di-7p for submit@debbugs.gnu.org; Tue, 01 Sep 2020 07:50:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD4oH-0001JN-UO for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 07:50:45 -0400 Received: from mx.sdf.org ([205.166.94.24]:65411) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD4oF-0002V7-PY; Tue, 01 Sep 2020 07:50:45 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 081BoKnu005863 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 1 Sep 2020 11:50:21 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 081BoSpC026843; Tue, 1 Sep 2020 11:50:28 GMT Date: Tue, 1 Sep 2020 13:50:16 +0200 (CEST) From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 07:50:39 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Tim Vaughan , 41423@debbugs.gnu.org, "Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors" , rrandresf@gmail.com, Michael Albinus , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) > > Would it help to profile the completion process in this use case using > the built-in Lisp profiler? > No, because the bug is not about cpu or mem usage, but about doing something useless that just takes time (without eating much resources). A much better way to profile this is to use: (defvar pcomplete-completions-at-point-time 0) (defun around-pcomplete-completions-at-point (fun) (message "calling pcomplete-completions-at-point") (setq pcomplete-completions-at-point-time (float-time)) (let ((ret (funcall fun))) (message "returning from pcomplete-completions-at-point, call took %.2f seconds" (- (float-time) pcomplete-completions-at-point-time)) ret)) (advice-add 'pcomplete-completions-at-point :around #'around-pcomplete-completions-at-point) (let ((default-directory "/ssh:user@host:~/")) (eshell)) This will print: calling pcomplete-completions-at-point returning from pcomplete-completions-at-point, call took 0.00 seconds calling pcomplete-completions-at-point returning from pcomplete-completions-at-point, call took 0.00 seconds calling pcomplete-completions-at-point returning from pcomplete-completions-at-point, call took N seconds The value of N depends on the speed of your connection. On a fast connection it will be something around 50, on a slower one something around 100. With a local directory (that is, without let-binding default-directory before entering eshell) it depends on your machine. On a fast one it will be something around 0.10, on a slower one something around 0.50. Note again that this third call to pcomplete-completions-at-point does nothing useful. It just build a list of all possible commands, and throws it away. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 09:04:37 2020 Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 13:04:37 +0000 Received: from localhost ([127.0.0.1]:55353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD5xl-0006xF-Ik for submit@debbugs.gnu.org; Tue, 01 Sep 2020 09:04:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD5xj-0006x2-SX for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 09:04:36 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3465910022F; Tue, 1 Sep 2020 09:04:30 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 55C7C100019; Tue, 1 Sep 2020 09:04:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598965468; bh=QidgmSLKF0f6mS+hnLKWuHKoRzS+WJOFW29KiUcmC7E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=o5jg89gh2jjZv9n4Swl6E9+vPSywWTMgACVwXX5XEwqo0ly8OLMGNrPkrEATUAtYF dUyAUFCx80VlV+LqvzjL+4hE+Q1vtK1v1Yky0w62/J8rLXmpjYoiu7jvFSro1SoSpo 50Wzzy8DHL8Cjg6IFNEjb+Vrge0JWxWhQ5PJnTF2dqvaNiWRbM7O+70HpE4mGx1dis jeJ4qlaVZE1myaDn4zFYrn1cfx1WkLqJoI2X0hu4W66KiW4GR7v3W/HhKjtKlfe/8T yGzQUe4WRla0lHgJ28bG1cg/NCPnke/XgP7t8PqGWxewWL8dveak1+2OGvNWrus7iW Ayh7JmdNZe45w== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0DD74120314; Tue, 1 Sep 2020 09:04:28 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Tue, 01 Sep 2020 09:04:27 -0400 In-Reply-To: (Gregory Heytings's message of "Tue, 1 Sep 2020 10:31:14 +0200 (CEST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> `eshell-complete-commands-list` eagerly builds the list of possible >> candidates and it takes a while whereas we should here return something >> quickly and cheaply, e.g. by returning a function which will build and >> return this list more lazily when completion is actually performed. > No, the bug is in the completion mechanism, not in eshell. I don't know > exactly (because the mechanism is so complicated) where the completion > functions should be fixed, but it is clear that there is no reason to call > pcomplete-completions-at-point *three* times. The reason why it does so, is that it wants to know when a "completion session" terminates, e.g. to hide the *Completions* buffer or to run the exit-function. So it calls it: - once to do the actual completion. - once per command in post-command-hook to see if we're done. Since in your example you have 2 commands (TAB and RET), that gives you a total of 3. This design relies on the fact that completion tables can be lazy, so it should always be possible to make the completion-at-point-function very cheap and harmless, so it's OK to call it repeatedly (or even needlessly). > There is no reason to call pcomplete-completions-at-point when RET > is pressed. If running that function is costly, it's a bug. That's how completion-at-point-functions was designed. If you want to change that design, be my guest, but it likely implies changes to a fair bit of code, including outside Emacs. >> Of course, the slowdown will presumably still be seen when you do actually >> want to complete a command name, so we should probably try and figure out >> more precisely where the slowdown comes from and how to avoid/reduce it. > That's another, separate issue, and it is not relevant here. Agreed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 09:08:37 2020 Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 13:08:37 +0000 Received: from localhost ([127.0.0.1]:55358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD61d-00072t-5P for submit@debbugs.gnu.org; Tue, 01 Sep 2020 09:08:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD61b-00072g-VU for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 09:08:36 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 63FBF80533; Tue, 1 Sep 2020 09:08:30 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DAE838066B; Tue, 1 Sep 2020 09:08:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598965708; bh=vCsC+fsC6Oj6sCbFY7J68aziATNxlHsuD92XEGJ7Kk8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MOdY9wIn6pYv5iVb/L1hP/mZQBX0AnBnDLdLc/bHrvN0Q5ZEhMlfMRBxFDowNC1oh xs95F1UiZrlgmofbfBTkssr98Ap9rp6aZBFoRnb39MVgTO5KgJpfeMOnICU1+Ot/SX i1ExpiD63InPGe4+M021Qyw81t0weXi1/K6N8ObApMKW71PFGHLXv4oa7e9FjCxLaW rydAC/pfJNCFLhUthg/77HxooeSYcIcoeoSccGiODQxskNxOX7pjJbMm6o7/G1qzNw RbFDyIh7EysixH7I7osKxGQ2FjOF1Q3R4zmszFK9aNeqTtvTQLK+UYxvtnIYusBFLZ oG1+Byf4ua/qw== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8A0A81202FB; Tue, 1 Sep 2020 09:08:28 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Tue, 01 Sep 2020 09:08:28 -0400 In-Reply-To: (Gregory Heytings's message of "Tue, 1 Sep 2020 13:50:16 +0200 (CEST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Michael Albinus , Eli Zaretskii , rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > This will print: > > calling pcomplete-completions-at-point > returning from pcomplete-completions-at-point, call took 0.00 seconds > calling pcomplete-completions-at-point > returning from pcomplete-completions-at-point, call took 0.00 seconds > calling pcomplete-completions-at-point > returning from pcomplete-completions-at-point, call took N seconds [...] > Note again that this third call to pcomplete-completions-at-point does > nothing useful. It just build a list of all possible commands, and throws > it away. Exactly. And the fix is to make this third call return in 0.00 seconds like the others by making it return not the list of commands but a mere function (which will return that list of commands only when called, but in the present case it won't be called). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 09:30:19 2020 Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 13:30:19 +0000 Received: from localhost ([127.0.0.1]:55373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD6Md-0007ZJ-5R for submit@debbugs.gnu.org; Tue, 01 Sep 2020 09:30:19 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD6Ma-0007Z3-No for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 09:30:17 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 53A9A80922; Tue, 1 Sep 2020 09:30:11 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 88A888066B; Tue, 1 Sep 2020 09:30:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598967009; bh=K8GjzoEmo5w227a05xSqZiYIGE5acpsxJ8jBkrtzU+4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fRx4gUhPkFSsB0ul0Fsiw37jZxUG+l/TlIVZZyK2dgAigKU66T9dwvxnq3kpqAlRg C5RGYPXl8Q/kWrGl3dq7Qjw2A75QS/UDihzZ2RVKi6QjLG8lBlmOHWv8L0alBpGSsP m2K4ZIr48/MrcpCQWACcETP7xaOTmHzrDSCpXe7JspQcJ/vYabWmEhBe4er+qzGJsL jz5+9Rw1OfMe56F8RmMsdkUxCSXNWqYrNXOLFd+ni1qLpzHovudwsFgk4ZWzRV3t8T JnhEoq0dLIAsWT69D4RyKAULhY2s+YtOVOu8QuIm+WilW5gqDve/qBRiRvVQU4X48G NumVhrioYo0Tg== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4235C1202F4; Tue, 1 Sep 2020 09:30:09 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Tue, 01 Sep 2020 09:30:07 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 01 Sep 2020 09:08:28 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Michael Albinus , Eli Zaretskii , rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > And the fix is to make this third call return in 0.00 seconds like the > others by making it return not the list of commands but a mere function > (which will return that list of commands only when called, but in the > present case it won't be called). See for example patch below (which shouldn't be applied as-is since the body of the function ends up misindented). Stefan diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el index 48c99acac3..e41afea9ef 100644 --- a/lisp/eshell/em-cmpl.el +++ b/lisp/eshell/em-cmpl.el @@ -399,11 +399,15 @@ (defun eshell-complete-commands-list () "Generate list of applicable, visible commands." - (let ((filename (pcomplete-arg)) glob-name) + ;; Building the commands list can take quite a while over Tramp + ;; (bug#41423), so do it lazily. + (completion-table-dynamic + (lambda (filename) (if (file-name-directory filename) (if eshell-force-execution (pcomplete-dirs-or-entries nil #'file-readable-p) (pcomplete-executables)) + (let (glob-name) (if (and (> (length filename) 0) (eq (aref filename 0) eshell-explicit-command-char)) (setq filename (substring filename 1) @@ -455,7 +459,7 @@ (and eshell-show-lisp-alternatives (null completions))) (all-completions filename obarray #'functionp)) - completions))))))) + completions))))))))) (define-obsolete-function-alias 'eshell-pcomplete #'completion-at-point "27.1") From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:40:51 2020 Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 15:40:51 +0000 Received: from localhost ([127.0.0.1]:56842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8Ow-0000yA-S9 for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:40:51 -0400 Received: from mx.sdf.org ([205.166.94.24]:61112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8Ou-0000y0-Ax for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 11:40:50 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 081FekvE010073 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 1 Sep 2020 15:40:46 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 081Fes4T026778; Tue, 1 Sep 2020 15:40:54 GMT Date: Tue, 1 Sep 2020 17:40:41 +0200 (CEST) From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > >> No, the bug is in the completion mechanism, not in eshell. I don't >> know exactly (because the mechanism is so complicated) where the >> completion functions should be fixed, but it is clear that there is no >> reason to call pcomplete-completions-at-point *three* times. > > The reason why it does so, is that it wants to know when a "completion > session" terminates, e.g. to hide the *Completions* buffer or to run the > exit-function. > > So it calls it: > > - once to do the actual completion. > - once per command in post-command-hook to see if we're done. > > Since in your example you have 2 commands (TAB and RET), that gives you > a total of 3. > Hmmm... It seems to me that in this case, we're done after the first call to pcomplete-completions-at-point, so the second call to pcomplete-completions-at-point in post-command-hook should see this (or at least could see this), and remove completion-in-region--postch from post-command-hook. RET would then not call pcomplete-completions-at-point anymore. > > This design relies on the fact that completion tables can be lazy, so it > should always be possible to make the completion-at-point-function very > cheap and harmless, so it's OK to call it repeatedly (or even > needlessly). > This is not at all documented AFAICS. Given that it's a crucial aspect for your design to work, it should be. > >> There is no reason to call pcomplete-completions-at-point when RET is >> pressed. > > If running that function is costly, it's a bug. > It was not before you declared `pcomplete' obsolete and removed `eshell-pcomplete'. > > That's how completion-at-point-functions was designed. > > If you want to change that design, be my guest, but it likely implies > changes to a fair bit of code, including outside Emacs. > I don't want to change that design, but I ask myself why you documented `pcomplete-completions-at-point' as follows: "Provide standard completion using pcomplete's completion tables. Same as `pcomplete' but using the standard completion UI." It's NOT the same as `pcomplete', it relies on different conditions. All completion functions called by `pcomplete-completions-at-point' should be checked and possibly changed with this new design. Given this, why did you declared `pcomplete' obsolete (it would make sense to have both a simple mechanism for simple cases and a more complex one for more complex cases), and why did you remove `eshell-pcomplete'? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 11:42:03 2020 Received: (at 41423) by debbugs.gnu.org; 1 Sep 2020 15:42:03 +0000 Received: from localhost ([127.0.0.1]:56847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8Q7-00010V-9s for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:42:03 -0400 Received: from mx.sdf.org ([205.166.94.24]:61007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD8Q5-000106-Fl for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 11:42:01 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 081Ffn8i001410 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 1 Sep 2020 15:41:50 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 081FfxgJ028047; Tue, 1 Sep 2020 15:41:59 GMT Date: Tue, 1 Sep 2020 17:41:46 +0200 (CEST) From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Michael Albinus , Eli Zaretskii , rrandresf@gmail.com, Tim Vaughan , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > See for example patch below (which shouldn't be applied as-is since the > body of the function ends up misindented). > Indeed this patch works. But now my question is: whould it not be possible to do this (namely, returning a lazy completion table) in one of the pcomplete-* functions (in `pcomplete-completions-at-point' itself, or in `pcomplete-completions', or...), instead of doing this in the individual functions ultimately called by `pcomplete-completions-at-point'? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 01 20:32:03 2020 Received: (at 41423) by debbugs.gnu.org; 2 Sep 2020 00:32:03 +0000 Received: from localhost ([127.0.0.1]:57684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDGh0-0004KB-PU for submit@debbugs.gnu.org; Tue, 01 Sep 2020 20:32:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDGgy-0004Jh-ON for 41423@debbugs.gnu.org; Tue, 01 Sep 2020 20:32:01 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 106964409C4; Tue, 1 Sep 2020 20:31:55 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A84BB4409BE; Tue, 1 Sep 2020 20:31:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599006712; bh=mgYCSNbSGbefDNv51z1nWeB7X3t52UHJw8OnP4CkoG0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h0UkbG+rAM3sjQN/MrGbttE2Zl+XefppbAV8LsZZNz3HJkh9JjNH5vn8talz9ADkw ufXRRU5xU7azxdLZWzzir22Pue79pM1WW1NJB+2OJ8GlAkW5LGDpKaVR7dUa8D2Iv4 FubuMUnGK0OfyfedL5kCoE4sPsMqNTo3j2gAfYSzljAfZH7VEE5DBKFp8Ihn/3evp6 8QLBo1mV3hLXyD5ncOhrrwnp0OTAxR9IbwvXA2jvS/MxDO+nJK7t3qIfLhJvKOHJIF v5CcALUR5A19vYr/ypa5FpdMd1vxYFydSyqmmSpLflWUjUGcoACsaM+6EgZGalzCe7 ESeYgNBhzPEcQ== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B5B0912025D; Tue, 1 Sep 2020 20:31:51 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Tue, 01 Sep 2020 20:31:50 -0400 In-Reply-To: (Gregory Heytings's message of "Tue, 1 Sep 2020 17:40:41 +0200 (CEST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Since in your example you have 2 commands (TAB and RET), that gives you >> a total of 3. > Hmmm... It seems to me that in this case, we're done after the first call > to pcomplete-completions-at-point, Usually it depends on whether the completion inserts a separator (e.g. a space in the case of Eshell/Pcomplete). Otherwise, point is still placed "within" (tho probably right at the END position) the completion area and hence completion is not considered to be finished. You can refine/tune the completion tables so that completion will considered as finished in more cases, but that wouldn't solve the problem in the general case anyway. >> This design relies on the fact that completion tables can be lazy, so it >> should always be possible to make the completion-at-point-function very >> cheap and harmless, so it's OK to call it repeatedly (or even needlessly). > This is not at all documented AFAICS. Given that it's a crucial aspect for > your design to work, it should be. The lispref says the following: The functions on this hook should generally return quickly, since they may be called very often (e.g., from @code{post-command-hook}). Supplying a function for @var{collection} is strongly recommended if generating the list of completions is an expensive operation. Emacs may internally call functions in @code{completion-at-point-functions} many times, but care about the value of @var{collection} for only some of these calls. By supplying a function for @var{collection}, Emacs can defer generating completions until necessary. You can use @code{completion-table-dynamic} to create a wrapper function: >>> There is no reason to call pcomplete-completions-at-point when RET >>> is pressed. >> If running that function is costly, it's a bug. > It was not before you declared `pcomplete' obsolete and removed > `eshell-pcomplete'. Indeed, making the Pcomplete infrastructure compatible with the standard completion UI introduced some incompatibilities. This was true before `pcomplete` was declared obsolete, tho: it has been true since the introduction of `pcomplete-completions-at-point` (some time around Emacs-24, IIRC). > "Provide standard completion using pcomplete's completion tables. Same as > `pcomplete' but using the standard completion UI." > It's NOT the same as `pcomplete', it relies on different conditions. > All completion functions called by `pcomplete-completions-at-point' should > be checked and possibly changed with this new design. In practice it works fairly well for most cases, but yes some functions needed to be changed, and others remain, obviously. > Given this, why did you declared `pcomplete' obsolete (it would make sense > to have both a simple mechanism for simple cases and a more complex one for > more complex cases), and why did you remove `eshell-pcomplete'? There are several questions in there. I deprecated `pcomplete` and `eshell-pcomplete` because AFAIK they didn't have noticeably fewer bugs than `completion-at-point` any more and neither did they offer any feature available from `completion-at-point`. W.r.t simple mechanism for simple cases, I'm not sure what that would concretely look like in this particular case. Some motivations for `pcomplete-completions-at-point`: - make it possible to remove duplicate code that deals with the UI aspect of completion (i.e. the `pcomplete` command) rather than the core purpose of `pcomplete.el` which is to provide a way to specify which completion table applies where on a command line. - let the `pcomplete` machinery work with the standard UI, which means it can also (mostly) obey `completion-styles`. - let the `pcomplete` machinery work with other UIs such as `company-mode`. I believe this last point is more important now. > Indeed this patch works. Thanks. > But now my question is: whould it not be possible to do this (namely, > returning a lazy completion table) in one of the pcomplete-* functions (in > `pcomplete-completions-at-point' itself, or in `pcomplete-completions', > or...), instead of doing this in the individual functions ultimately called > by `pcomplete-completions-at-point'? IIRC it wasn't really easy/possible, no. E.g. in the patch I sent I think there's a bug in that a leading * should change the START..END returned by `pcomplete-completion-at-point-function` so the `glob-name` computation should be done outside of the `completion-table-dynamic`. It could have been made a bit simpler and cleaner I guess if I had decided to "start over from scratch" and force a rewrite of every pcomplete/ function (basically every such function would have to return the same kind of info as returned by `completion-at-point-functions`). It would not have had any code in common with `pcomplete` any more, other than the underlying design (which I find very clever&elegant). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 02 06:26:57 2020 Received: (at 41423) by debbugs.gnu.org; 2 Sep 2020 10:26:57 +0000 Received: from localhost ([127.0.0.1]:58427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDPyj-0008Ds-7S for submit@debbugs.gnu.org; Wed, 02 Sep 2020 06:26:57 -0400 Received: from mx.sdf.org ([205.166.94.24]:54848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDPyb-0008De-MQ for 41423@debbugs.gnu.org; Wed, 02 Sep 2020 06:26:52 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 082AQlVi020011 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 2 Sep 2020 10:26:47 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 082AQrgW028698; Wed, 2 Sep 2020 10:26:53 GMT Date: Wed, 02 Sep 2020 10:26:41 +0000 From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan, Thank you very much for your detailed answer! > >>> This design relies on the fact that completion tables can be lazy, so >>> it should always be possible to make the completion-at-point-function >>> very cheap and harmless, so it's OK to call it repeatedly (or even >>> needlessly). >> >> This is not at all documented AFAICS. Given that it's a crucial aspect >> for your design to work, it should be. > > The lispref says the following: > > The functions on this hook should generally return quickly, since > they may be called very often (e.g., from @code{post-command-hook}). > Supplying a function for @var{collection} is strongly recommended if > generating the list of completions is an expensive operation. Emacs > may internally call functions in @code{completion-at-point-functions} > many times, but care about the value of @var{collection} for only > some of these calls. By supplying a function for @var{collection}, > Emacs can defer generating completions until necessary. You can use > @code{completion-table-dynamic} to create a wrapper function: > I see, thanks for the pointer. I did not find this because I was searching for `pcomplete-completions-at-point' and `pcomplete-completions'. It would make sense to put this pointer in pcomplete.el. > > W.r.t simple mechanism for simple cases, I'm not sure what that would > concretely look like in this particular case. > In this particular case, in Emacs 24-26, `eshell-pcomplete' called `pcomplete', which did the completion without triggering the machinery of `pcomplete-completion-at-point', that is, without entering a transient `completion-in-region-mode', without modifying `post-command-hook', and so forth. In particular, `pcomplete/cd' was called a single time. It seems to me (even now that I understand the design of `pcomplete-completion-at-point', and that I understand how the more complex mechanism can be made as efficient as the simple one) that this simple mechanism is often sufficient, that it is easier to understand, and that it should remain available. OTOH I also understand the point that you want to avoid duplicating code. > > Some motivations for `pcomplete-completions-at-point`: > - make it possible to remove duplicate code that deals with the UI aspect of completion (i.e. the `pcomplete` command) rather than the core purpose of `pcomplete.el` which is to provide a way to specify which completion table applies where on a command line. > - let the `pcomplete` machinery work with the standard UI, which means it can also (mostly) obey `completion-styles`. > - let the `pcomplete` machinery work with other UIs such as `company-mode`. I believe this last point is more important now. > I see. This makes perfect sense, thanks for the clarification. What is still missing IMO is a general description/documentation of the various parts of the completion mechanisms (completion-at-point, completion-in-region, pcomplete, pcomplete-completion-at-point, comint-completion-at-point, icomplete, ...) in Emacs behave and interact. I was completely lost when I started working on this bug, things are a bit clearer now, but still not very clear. > >> Indeed this patch works. > > Thanks. > [...] > > In the patch I sent I think there's a bug in that a leading * should > change the START..END returned by > `pcomplete-completion-at-point-function` so the `glob-name` computation > should be done outside of the `completion-table-dynamic`. > *sigh* So this bug can still not be considered fixed? From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 02 06:33:46 2020 Received: (at 41423) by debbugs.gnu.org; 2 Sep 2020 10:33:47 +0000 Received: from localhost ([127.0.0.1]:58441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDQ5K-0008Or-L3 for submit@debbugs.gnu.org; Wed, 02 Sep 2020 06:33:46 -0400 Received: from mout.gmx.net ([212.227.15.15]:57859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDQ5G-0008Ob-Bn for 41423@debbugs.gnu.org; Wed, 02 Sep 2020 06:33:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599042809; bh=IrEA1NWMThqh4c0vNQIz23Zp2/tofJJODcdMB0qrMS4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=D3aTyKhp+LBCR7H6HdQ4XELtfmNWJl/GffpVttqt9qanE+LqoblM7FfAA99z2M8sc QZ1jmcYKNcWEbUWcbs8Hb/W3efy1NTdSe7R/IUB4aWE5CeMKBN4XYuphry8tYjQjx4 LlzkXl5pmvylIrHfce/PzHTgQ7fsZiRTyQ6boTwA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.145.17]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6llE-1kDxVX03Kw-008IRm; Wed, 02 Sep 2020 12:33:29 +0200 From: Michael Albinus To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] References: <87mu2d7hka.fsf@gmx.de> Date: Wed, 02 Sep 2020 12:33:26 +0200 In-Reply-To: (Gregory Heytings's message of "Wed, 02 Sep 2020 10:26:41 +0000") Message-ID: <87blio4geh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:hyqpiq32GuIUFElj1A/hnaBCelxaVsoqoHoLbo/tnRq4h3n58AN y31jBPWJGCGRa2iGC6mLl3dFapkKIi29coNdFoI79O4M6NW4XWcifXDBQCJ2epT4WZk9CQo oJCsTIkitmJrMuDvOvoFltVywIeNtKmSceYvvVB847hRsVvu6sLxpkEhsXaRQAX8eZ/h0dL NkG1SliodMzeTF6Bq3jYw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:HOiVeBxs0CU=:toDjGwcj5dT2uuZZYA3QPS ZZoctRDf7mX9Auy8uhlP6J+om6yZ5R2jDBGYWdEbohvIRdb/gqCpnOvqHrV16ea8ujFNzLPwM AqaaqghcYtLDyE5V/4m0iqc7T8/bBkPK5thhI63MEvQhVbdz9OgsmoAT14vOnGHEkQXxF30lK EcqdATu9gFcxBW19GJxxmOqFvpGoZg4QBmvEJ+iGQ20PfiwC9jFuA4wx6boeypi3FoGR3kiyp yWynZhJ5/0UKgP5tJHJW4EW2QZwaaQBN/iJbjiipcBusxOQYkRHl8v29fXcP7s2o7A2ZV0l8y RdH5Yh0QbNIQHNA6cjJOqtlzWPK02fQUNks9gxfqwb9m3zH+/IBSnIJ7qRgpIqZXr5SeX+CLt G47KyBXjKEkDwl7jh/uf2NhcZN/0S6RUJVor8Xst357PGjrJBVwmt6r4pfW/Cy/oROpCsTsW2 w8rN8VavfcfFELLpce8JVo8AyLYLJ+A1CgXc3I4dyYDcYUGkQq2Rpo3aVhLLxmCUUUWGXknnx UAbnLzDtK5RKl/cYeO4sqb/ncB+8BCp4ervlpaPoc29xRCOdTOhT/Bu5QFTN4D8QLRz/hlvz+ 9XoR9Wt27RuIsxC+3lnXzTEgUzq92/cZHPuozAvx694f06gUiiVqrUBTVP00CQ9V0Z3dEZZVc n/psnjt8mFZ7U5bFzQf2vJ34qDD3K28HxRG8WxCwPFnm0v3f9J01b2gnviNZ3mPvlhEYtbz2J xX7s1V5eHLI8zLEChBhax/IhQbsJSt/ikUUAK9X6BdLcgPJ6+Px1vTQbtxujQULzOhpNoR1Uv e/wYwzF9Chd+XKMX0Px073yzJsDWiM1Jt1RrNKmcVUxJVgsT0jQ1SE0yLnGZhSr75UExEsEBh Cyr2QHf4cJ7/NYX0woILKWuQ9SzkG4bbICzwPWOLJIvTTgacdEvjbCcNE3RJlRynLlTUuB3ss kA8gs8nvz4iXvznPgTU/BnnAQF/YSjf9G0hiLC5IfnpGRDeQnsH9JFDj3bXrKhsPQhJKXmaAQ YxfnvR4Igcd7D2INjuamdeDEwYUUfy1eMb/QvQp1IR71OVksSmpoTbR5/EvPK8fFs1+rhCFMs 51Xy/+0qkZ8IE7W+ySW/PpbNHrM2Lfx0DWljXjVpyCIQCunqSuqBZpGYz85uSfsGcYYsALEax wqFJo54bNUlV/XOjObolq0c63XE4Pj3VWnof5aSwhHtj7KwfVWyZG6P/RzbJdvMgYKSQlUndh RUy9qh2p9TlSlPgBJ0Xy027n4gz4BZ8YsUWHW8w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, Tim Vaughan , Stefan Monnier , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Gregory Heytings writes: > Hi Stefan, Hi, > What is still missing IMO is a general description/documentation of > the various parts of the completion mechanisms (completion-at-point, > completion-in-region, pcomplete, pcomplete-completion-at-point, > comint-completion-at-point, icomplete, ...) in Emacs behave and > interact. I was completely lost when I started working on this bug, > things are a bit clearer now, but still not very clear. +1 Exactly this is the reason I've tried and failed to work on completion problems. Several times. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 02 12:03:02 2020 Received: (at 41423) by debbugs.gnu.org; 2 Sep 2020 16:03:02 +0000 Received: from localhost ([127.0.0.1]:60490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDVDj-0002aC-Pi for submit@debbugs.gnu.org; Wed, 02 Sep 2020 12:03:02 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:54242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDVDg-0002Zx-ET for 41423@debbugs.gnu.org; Wed, 02 Sep 2020 12:02:46 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 082G0BmY033920; Wed, 2 Sep 2020 16:02:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=hrWJYCP5zjWaeKbKg6zC8+esU5WyOHgzj8/bjDXa7T4=; b=iosfAbjs5Eb3Jf5vZ7X5CmWdQZqq4gc+OEtV1ev2SWC5gA2djgQevmld/Q5myQAw7wV+ mvkFqQMimH9IL/3luQEXuL4qd4owgtx92Kd8UCH2QAN/92tpigt2yFFQh7CyRntbj0N7 3WvN9GPjaos6JKzuWsGAXWRpOKUM/ENeX/qioqsZDsPDV1hSUWGk85Kt3K91DtIyqoua LJnUaEk0ejKiKrArYl/hQUwNv+/mKCHHhRKCCVUMfu2c/ZafdNbMEzubnSxvkG3wdSEU tbWD8W39aKJKXzBJ3KQesfFwGbORuDtVVRuVptzUf+gflL9QnxB7lYY4MY0I+Y2eimEJ qQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 337eymbg81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 02 Sep 2020 16:02:37 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 082Ft5vf059799; Wed, 2 Sep 2020 16:00:37 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 3380su6v04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Sep 2020 16:00:37 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 082G0F27007929; Wed, 2 Sep 2020 16:00:33 GMT MIME-Version: 1.0 Message-ID: <83cdfdd0-c0dc-479d-a593-90e4d05625f6@default> Date: Wed, 2 Sep 2020 09:00:14 -0700 (PDT) From: Drew Adams To: Michael Albinus , Gregory Heytings Subject: RE: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] References: <87mu2d7hka.fsf@gmx.de> <87blio4geh.fsf@gmx.de> In-Reply-To: <87blio4geh.fsf@gmx.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9732 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009020152 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9732 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009020152 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, Tim Vaughan , Stefan Monnier , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> What is still missing IMO is a general description/documentation of >> the various parts of the completion mechanisms (completion-at-point, >> completion-in-region, pcomplete, pcomplete-completion-at-point, >> comint-completion-at-point, icomplete, ...) in Emacs behave and >> interact. I was completely lost when I started working on this bug, >> things are a bit clearer now, but still not very clear. >=20 > +1 >=20 > Exactly this is the reason I've tried and failed to work on completion > problems. Several times. +1 And it's not just a lack of doc, I think. The completion mechanism (e.g. minibuffer.el) is a labyrinth. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 02 12:36:50 2020 Received: (at 41423) by debbugs.gnu.org; 2 Sep 2020 16:36:50 +0000 Received: from localhost ([127.0.0.1]:60531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDVkf-0003On-Up for submit@debbugs.gnu.org; Wed, 02 Sep 2020 12:36:50 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDVkc-0003OZ-R6 for 41423@debbugs.gnu.org; Wed, 02 Sep 2020 12:36:48 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3208C440A00; Wed, 2 Sep 2020 12:36:41 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 723514409E5; Wed, 2 Sep 2020 12:36:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599064599; bh=UtWRV6Ee9KHTUdxTRN62AiWvSOfCOq9HO8CTpHBnJjs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OwUDqF74U6A39u+Vjuu5ObEki22coAhccZ6VuSiAaU6s4GcWKgFfsZIRXhoVXIO7E 6ad8njRzF7F/g53HDmutpr486lFxcyrKCDdm4SrhRnUBwXw/VLT8VNZAo4wtnN2HDk l2joeGKxM8r+DA+rPd7MderasslXFgWM1CAwHwdH6rC7xjQRe3Bw57jAEuqa6SpgHD H/ZYf3c7XnTDc2h3vtgeIGJGLMSKdgtSUi/jwnJW3ojmIHMckT9WCmvDBtYy8iIyhz D1z9LpQEtxXwyYyg9Pj2UlpcISx/9LZQRWGe8ER3sGp97BfX2F/pg3Go4N17kcw7jK 3luKdBFvceMKQ== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3B8561207B2; Wed, 2 Sep 2020 12:36:39 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Wed, 02 Sep 2020 12:36:38 -0400 In-Reply-To: (Gregory Heytings's message of "Wed, 02 Sep 2020 10:26:41 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The lispref says the following: >> >> The functions on this hook should generally return quickly, since >> they may be called very often (e.g., from @code{post-command-hook}). >> Supplying a function for @var{collection} is strongly recommended if >> generating the list of completions is an expensive operation. Emacs >> may internally call functions in @code{completion-at-point-functions} >> many times, but care about the value of @var{collection} for only >> some of these calls. By supplying a function for @var{collection}, >> Emacs can defer generating completions until necessary. You can use >> @code{completion-table-dynamic} to create a wrapper function: >> > > I see, thanks for the pointer. I did not find this because I was searching > for `pcomplete-completions-at-point' and `pcomplete-completions'. It would > make sense to put this pointer in pcomplete.el. Indeed, it might make sense to add a reminder that `pcomplete-here` is the function where we "choose which completion table to use" and that this choice should always be quick (so if the set of candidates can take a while to compute, make sure the completion table computes it lazily). > It seems to me (even now that I understand the design of > `pcomplete-completion-at-point', and that I understand how the more > complex mechanism can be made as efficient as the simple one) that > this simple mechanism is often sufficient, that it is easier to > understand, and that it should remain available. You can definitely write such a "simple completion UI" on top of `completion-at-point-functions`, and make sure it calls things like `pcomplete-completion-at-point` only once. Basically, take `completion-at-point`, throw out the "minor mode" part and you're done. > What is still missing IMO is a general description/documentation of the > various parts of the completion mechanisms (completion-at-point, > completion-in-region, pcomplete, pcomplete-completion-at-point, > comint-completion-at-point, icomplete, ...) in Emacs behave and > interact. I was completely lost when I started working on this bug, things > are a bit clearer now, but still not very clear. I find it hard to write such things because I'm too familiar with it to know what's non-obvious. Maybe you could try writing something that you'd have found useful, and then we can collaboratively improve it? >> In the patch I sent I think there's a bug in that a leading * should >> change the START..END returned by `pcomplete-completion-at-point-function` >> so the `glob-name` computation should be done outside of the >> `completion-table-dynamic`. > *sigh* So this bug can still not be considered fixed? Yup :-( I'll try to come up with something better if noone else beats me to it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 02 15:52:45 2020 Received: (at 41423) by debbugs.gnu.org; 2 Sep 2020 19:52:45 +0000 Received: from localhost ([127.0.0.1]:60739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDYoH-0007z8-2l for submit@debbugs.gnu.org; Wed, 02 Sep 2020 15:52:45 -0400 Received: from mx.sdf.org ([205.166.94.24]:64122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDYoC-0007yt-4p for 41423@debbugs.gnu.org; Wed, 02 Sep 2020 15:52:43 -0400 Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 082JqcS2017817 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 2 Sep 2020 19:52:38 GMT Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 082Jql5Q009651; Wed, 2 Sep 2020 19:52:47 GMT Date: Wed, 02 Sep 2020 19:52:34 +0000 From: Gregory Heytings To: Stefan Monnier Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: Message-ID: References: <87mu2d7hka.fsf@gmx.de> User-Agent: Alpine 2.22 (NEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > >> What is still missing IMO is a general description/documentation of the >> various parts of the completion mechanisms (completion-at-point, >> completion-in-region, pcomplete, pcomplete-completion-at-point, >> comint-completion-at-point, icomplete, ...) in Emacs behave and >> interact. I was completely lost when I started working on this bug, >> things are a bit clearer now, but still not very clear. > > I find it hard to write such things because I'm too familiar with it to > know what's non-obvious. Maybe you could try writing something that > you'd have found useful, and then we can collaboratively improve it? > Based on the time I already spent on this bug, I guess writing something like this will require a substantial amount of work, but if you are willing to help me, I'm willing to do that. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 02 16:08:58 2020 Received: (at 41423) by debbugs.gnu.org; 2 Sep 2020 20:08:58 +0000 Received: from localhost ([127.0.0.1]:60752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDZ3y-0008Nh-7G for submit@debbugs.gnu.org; Wed, 02 Sep 2020 16:08:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDZ3v-0008NU-Jy for 41423@debbugs.gnu.org; Wed, 02 Sep 2020 16:08:56 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 099D1440A14; Wed, 2 Sep 2020 16:08:50 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 66049440A03; Wed, 2 Sep 2020 16:08:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599077328; bh=c7Xf7Inu3qnMHyY2FNdDpEffsdy4iltww/A+3LGXeiI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gg8y5MqFKWBvPdOf4aOhDiQEWdgswXJbBP/loIG6oFvZMnFymdzfKZMX8IOTkdI/4 NorrIFekZXfbaMLa8w7scmFe0km2nZyYLTpCdvdbyur8TLxCVI0K4lhiQ1rEV0jM7x TcLpcJoHovsCvU5ddRGy0ryDPZLrPFPJk9SBZfgX8zlZKeFlG0XGGh5B+gSFIu1MXe n7/4XnjfwXq8nhIGH3++BFJVX6a2q0yRGwbLAcXGgsEzKk9/3GjvvELddmeRuPmpfs VLyBBUvQcRgn1HhnB6ZHMbH2V2+zi7IAVBTiLvNrOKGX/lEqJpn1El8ybdKxZ3aiJs KgEUVYzIvnehA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 272C112078A; Wed, 2 Sep 2020 16:08:48 -0400 (EDT) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <87mu2d7hka.fsf@gmx.de> Date: Wed, 02 Sep 2020 16:08:47 -0400 In-Reply-To: (Gregory Heytings's message of "Wed, 02 Sep 2020 19:52:34 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , rrandresf@gmail.com, Michael Albinus , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> What is still missing IMO is a general description/documentation of the >>> various parts of the completion mechanisms (completion-at-point, >>> completion-in-region, pcomplete, pcomplete-completion-at-point, >>> comint-completion-at-point, icomplete, ...) in Emacs behave and >>> interact. I was completely lost when I started working on this bug, >>> things are a bit clearer now, but still not very clear. >> I find it hard to write such things because I'm too familiar with it to >> know what's non-obvious. Maybe you could try writing something that you'd >> have found useful, and then we can collaboratively improve it? > Based on the time I already spent on this bug, I guess writing something > like this will require a substantial amount of work, but if you are willing > to help me, I'm willing to do that. That'd be great. There's a chance others will chime in as well. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 12:08:06 2021 Received: (at 41423) by debbugs.gnu.org; 31 Jan 2021 17:08:06 +0000 Received: from localhost ([127.0.0.1]:57872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6GCj-0000UG-Re for submit@debbugs.gnu.org; Sun, 31 Jan 2021 12:08:06 -0500 Received: from mx.sdf.org ([205.166.94.24]:49810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6GCg-0000Tg-AJ for 41423@debbugs.gnu.org; Sun, 31 Jan 2021 12:08:05 -0500 Received: from melchior.lan (ma.sdf.org [205.166.94.33]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 10VH7lTF024640 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits) verified NO); Sun, 31 Jan 2021 17:07:48 GMT From: xristos To: Drew Adams Subject: Re: bug#41423: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] In-Reply-To: <83cdfdd0-c0dc-479d-a593-90e4d05625f6@default> (Drew Adams's message of "Wed, 2 Sep 2020 09:00:14 -0700 (PDT)") References: <87mu2d7hka.fsf@gmx.de> <87blio4geh.fsf@gmx.de> <83cdfdd0-c0dc-479d-a593-90e4d05625f6@default> Date: Sun, 31 Jan 2021 12:07:46 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: Tim Vaughan , 41423@debbugs.gnu.org, rrandresf@gmail.com, Michael Albinus , Stefan Monnier , Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 2 Sep 2020 09:00:14 -0700 (PDT), Drew Adams wrote: > +1 > > And it's not just a lack of doc, I think. > The completion mechanism (e.g. minibuffer.el) is a labyrinth. +1 I was bitten by this bug today (which is still unfixed afaict), and since TRAMP/eshell is an important part of my daily routine I went back to using pcomplete. Having ran into similar completion heisenbugs in the past, I have to say that I find the mechanism to be severely under-documented and the code very hard to make sense of in reasonable time. A design document that lays out the architecture and component interactions is sorely needed. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 21:45:53 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 02:45:53 +0000 Received: from localhost ([127.0.0.1]:58412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6PDs-0007uK-JK for submit@debbugs.gnu.org; Sun, 31 Jan 2021 21:45:53 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6PDo-0007u1-9E for 41423@debbugs.gnu.org; Sun, 31 Jan 2021 21:45:51 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 38238808A9; Sun, 31 Jan 2021 21:45:42 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E6F798070D; Sun, 31 Jan 2021 21:45:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612147540; bh=DO/WycYYIZsXxA7GoITOfTrBStOke8/3vNknp6azF44=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JPZP4CxhldJNGON1sVpww4412BfaHz7CZbY55QgPIlEZis0CNAqOK4oGOCm/1jbbI 7sI3pKql2SExFkoNonr2Br5uFPJ1jKLTRZkgXK/9a3VVJMAYG0lTRBrwKIuZQI0S5/ 36yqgaaiv/VN0bPq0tgOQtZg9bDLFeyO79kO7dIJyxeV4+bsxDLZ0aK00fTs8O2YBJ mjoNDRnO6x51G5PvTxcBZKix9nusBAJtc49OzipZcn4EVHILIHQ4HBdKPU5i4LTrqN /Si0ul5ZZFxnqvm64gAdDW/YNxyE1vbFbS2VtdmAlyQvdM0Y+u9W8wpbhplcvSyKhv XaanDyoI+wRgg== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9584E120270; Sun, 31 Jan 2021 21:45:40 -0500 (EST) From: Stefan Monnier To: Michael Albinus Subject: Re: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest] Message-ID: References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> Date: Sun, 31 Jan 2021 21:45:39 -0500 In-Reply-To: <87r1v4z3f1.fsf_-_@gmx.de> (Michael Albinus's message of "Thu, 28 May 2020 13:48:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: =?windows-1252?Q?andr=E9s_ram=EDrez?= , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) FWIW, I installed a variant of my earlier patch into `master`. I suspect it has a few rough edges, so watch out for regressions, please and complain to me (with as precise a recipe as you can) when you bump into them, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 31 23:36:21 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 04:36:21 +0000 Received: from localhost ([127.0.0.1]:58462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6Qwm-0002Bi-GP for submit@debbugs.gnu.org; Sun, 31 Jan 2021 23:36:21 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6Qwj-0002BT-5Y for 41423@debbugs.gnu.org; Sun, 31 Jan 2021 23:36:19 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D2D33808A9; Sun, 31 Jan 2021 23:36:11 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6385D8079B; Sun, 31 Jan 2021 23:36:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612154170; bh=tvb7M4/LWGTfEIMt/c8pB6Cgp+rWeHzrz2Dwovwifcg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lEGxpdL5pGS/Zrv6EfUp8vg2KjWhXqeGsqnkXdqdPQDqNlAB4VUJBdB/YQ/edqJlV JxLvWcJHYWpEuKi0/QnbWDiRISUaNEC8uvyqRO9TBK+SamdZg3K0ph9tPR4yxflANT lcmR/h0tDyAYvqj/G9Pegm6EbyesDWESUXH608fG8xnEHrlZu6SSgtVrSiJMNXqNVW z5iGdVvwrChOh7ArRGHMlwDlJ05/lxqndk9XHzsP1pxzA7BIbMZCcCkcXCq7tR00tl 6cppIdpQRC/OrK8OC5ORzJHbY40R8cJsEJOlw2LGrcbFO6gki9ZmkcCzy+ih3t8tC2 dHWbSGQ4fEbzg== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2B954120147; Sun, 31 Jan 2021 23:36:10 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Installing the fix for bug#41423 on emacs-27 (was: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest]) Message-ID: References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> Date: Sun, 31 Jan 2021 23:36:09 -0500 In-Reply-To: (Stefan Monnier's message of "Sun, 31 Jan 2021 21:45:39 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: =?windows-1252?Q?andr=E9s_ram=EDrez?= , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier [2021-01-31 21:45:39] wrote: > FWIW, I installed a variant of my earlier patch into `master`. > I suspect it has a few rough edges, so watch out for regressions, please > and complain to me (with as precise a recipe as you can) when you bump > into them, I installed a further change which should fix the main issue I could foresee. I'm now reasonably happy with the patch (I think it's "right" rather than a quick ad-hoc fix. It deserves further improvements to add some form of caching, but that's largely orthogonal to this bug report). IIUC Michael had marked this bug as "blocking" for Emacs-27, so this argues for installing it on the `emacs-27` branch. The patch is not without risks seeing how it changes a function from returning a list to returning a function and how it fundamentally changes *when* the code is executed. So I'm not sure whether it should go on the `emacs-27` branch: A- For non-Eshell users it is "obviously safe". B- For Eshell-over-Tramp users it should be a clear improvement even if it turns out to introduce some unforeseen regressions in some cases. C- Finally, Eshell-not-over-Tramp users should hopefully see no difference at all, which mostly means no improvement to make up for any risk of regression. So, is the improvement in B worth the risk in C? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 04:59:22 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 09:59:22 +0000 Received: from localhost ([127.0.0.1]:58905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6VzO-0002CW-De for submit@debbugs.gnu.org; Mon, 01 Feb 2021 04:59:22 -0500 Received: from mout.gmx.net ([212.227.17.21]:55143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6VzM-0002CB-2P for 41423@debbugs.gnu.org; Mon, 01 Feb 2021 04:59:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1612173549; bh=dxQ/g7XMQZi5f008GaJE19gFsIYOGgWNiGDmnhI+j3Q=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=iRxPLhqRecp839iBbK0wFa4w6M2T5gS1cAaZDsjOwNK2I62hcFs+WNY7U1o9zNpeV uyrrLI34g1R779utMj8EX66BpeyCmuYAPi8uSMW5TdfoDbtV+JSLCC3NjAGwcvmuGF Vtt1Ugec7OAn5TYY+WgckTWrZgnCDdstr94oeSJs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.124.49]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M8hVB-1l1p9w1aQz-004joh; Mon, 01 Feb 2021 10:59:09 +0100 From: Michael Albinus To: Stefan Monnier Subject: Re: bug#41423: Installing the fix for bug#41423 on emacs-27 References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> Date: Mon, 01 Feb 2021 10:59:07 +0100 In-Reply-To: (Stefan Monnier's message of "Sun, 31 Jan 2021 23:36:09 -0500") Message-ID: <878s883y8k.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:i4KPqLIZNNKsrg/iZkKIhbck2tQnIj37g/K9dSM6ZlNbL+RbTC3 rx3A3hwugkP9JbuAiZGIK4kmz4IPSRkcLO44AHEW+Tvj+mMLnRcdJ0Sq/S5wM0MJWiJFdEU j6Hh/PFtzYvCoOnuV3S6MoOy6JFVIyp3bx4BviWpRl4HPgmkEResrQUCyRD/isuzSMdu20t UxxmVbRNHso6ytPvicvfQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:mKWRuTUIJM4=:Cr1FXpSoLTiD8Ii87hDT2a VuIKx5QIJ5wo/9LH+KrGia7NeWA7PZSbTcaGNDXn/Cfp0cJ4QP95irDLuFOnwUuavTXmINpmy nFFr78aPqfg/yFox2v6vaISeuutPOvK0V/KA/oKMGQ65EF+CMiUJEwMlRoHEGqaUZkyNDe1J4 gEW+Oz40BDLzRhmpgJRTzuETIDj6x9MtXgkeUhnP2+bjUKHioDNLmPpBrYnIDuw0uvBoyQZ+Y ceqAOuF2A0uxImcevgh20+ttaK3Nm1QziQkqE8f1KIudwrjYiPz5eNiZ7kIMA2pAD4L3RNloq 5FNoC6bSKc0ArkkkHmgCKedlKibyq8GVnjNgkExHu2ozUbSxclD18GR9DeshlivuLewXFf2DK rsRAB4Q1bvEZsp9Tg+WXZYSq/QeUA047tVEiq2aQ5JfDPJ6Qd1U4C2TlqsBzViH8jfOPSfmHP bvT//otHiBPl7zsERUBaPexenzWDZXNveOeIQ+qQRNTt+XyEypcAn4Rbs7yvlLmX2Uu0ZvYfj +ggAbcnNFGqhLBvR2afabsg5GsgbCo+tznF/9o5Yt3zNwm0yqyE1jYngZpKQ5C0VaqYxBmEIj t+BB32yXYaxFo7U5goH3ZlLgFRH3VOOvSWtUlEqwyXK+apjTapVX34cevP3FXfe0dKE060JxQ k1+ZkaFg8wopQntTRi0LR74lXg5T7Th1ToGLk15ljaUwwdcT1D9oz0NSg0Ee0yEPLQgh7wQpa Jn+LG72d4JUEMSuqlGBdwl+FWSTZJmRiTmFFyI84Mfw/vlukcl9YP4zOpLIWInVutSCKemWBQ Hu0NWp0olkCXJBj/5OtGmaa9czxRiMGQj/m8NcT/xJ9sfJ4cEwhKflWUT37cvwgqhF3R7sVoD 54nAUAjCWlO7vQyGv8sw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41423 Cc: Eli Zaretskii , =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: Hi, > IIUC Michael had marked this bug as "blocking" for Emacs-27, so this > argues for installing it on the `emacs-27` branch. > > The patch is not without risks seeing how it changes a function from > returning a list to returning a function and how it fundamentally > changes *when* the code is executed. So I'm not sure whether it should > go on the `emacs-27` branch: > > A- For non-Eshell users it is "obviously safe". > B- For Eshell-over-Tramp users it should be a clear improvement even if > it turns out to introduce some unforeseen regressions in some cases. > C- Finally, Eshell-not-over-Tramp users should hopefully see no > difference at all, which mostly means no improvement to make up for > any risk of regression. > > So, is the improvement in B worth the risk in C? For me, the patch is not trivial enough that I can read it fluently. So I propose to keep the bug open as blocking for Emacs 27, and backport the patch to the emacs-27 branch only after the 27.2 release. Whether there will be an Emacs 27.3 doesn't matter then. > Stefan Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 09:46:48 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 14:46:48 +0000 Received: from localhost ([127.0.0.1]:59438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6aTX-0005kc-9z for submit@debbugs.gnu.org; Mon, 01 Feb 2021 09:46:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6aTU-0005kN-4p for 41423@debbugs.gnu.org; Mon, 01 Feb 2021 09:46:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53333) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6aTO-0004Zk-1w; Mon, 01 Feb 2021 09:46:38 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4672 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l6aTN-0006tr-JX; Mon, 01 Feb 2021 09:46:37 -0500 Date: Mon, 01 Feb 2021 16:47:05 +0200 Message-Id: <83bld37sly.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 31 Jan 2021 23:36:09 -0500) Subject: Re: Installing the fix for bug#41423 on emacs-27 (was: 27.0.91; eshell file completion in tramp dir is slow (3 minutes) [regression on pretest]) References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Stefan Monnier > Cc: andrés ramírez , > 41423@debbugs.gnu.org > Date: Sun, 31 Jan 2021 23:36:09 -0500 > > IIUC Michael had marked this bug as "blocking" for Emacs-27, so this > argues for installing it on the `emacs-27` branch. > > The patch is not without risks seeing how it changes a function from > returning a list to returning a function and how it fundamentally > changes *when* the code is executed. So I'm not sure whether it should > go on the `emacs-27` branch: > > A- For non-Eshell users it is "obviously safe". > B- For Eshell-over-Tramp users it should be a clear improvement even if > it turns out to introduce some unforeseen regressions in some cases. > C- Finally, Eshell-not-over-Tramp users should hopefully see no > difference at all, which mostly means no improvement to make up for > any risk of regression. > > So, is the improvement in B worth the risk in C? No, I don't think so. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 10:33:54 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 15:33:54 +0000 Received: from localhost ([127.0.0.1]:32918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6bD8-0007W2-5D for submit@debbugs.gnu.org; Mon, 01 Feb 2021 10:33:54 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6bD5-0007Vo-AZ for 41423@debbugs.gnu.org; Mon, 01 Feb 2021 10:33:53 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D628E100222; Mon, 1 Feb 2021 10:33:45 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 93F3510005D; Mon, 1 Feb 2021 10:33:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612193624; bh=c0Vottyd6SozxT+fmsOzBqvaxdIfdjBOj2QjZLtmCjM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lNAcqgRveMMJjXlL+5VU2Q98tjqGvloSDls4jJSTslNXhh8bPawnJ/RXe8yB6RwUj LLFf1EHXut1hcVcXUb5bNuou5lHQop98ok/cblBsvE1ki4IMuWskwN76kqqxq/A4gB YJEGmJr3u6uuBJyfGGPmq46H9hgAy5BTX3uC73innEk5EYqUmaZuzxaEWzMUlojNhC Fe0dOnwbJYnVXRDjDPzMkn3N8rvhOueixOShILI8Zm9FcGrI+qDoblMmnTtgkQzHnd Hrg0L8EkR/jiUM0rBnNP0ksvKNFTxEy87KnRtKuLbiQG6aGlEpi2+hEsK1rzdyLvCL NkGnqMaylLvKQ== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 64AF8120270; Mon, 1 Feb 2021 10:33:44 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: Installing the fix for bug#41423 on emacs-27 Message-ID: References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> Date: Mon, 01 Feb 2021 10:33:43 -0500 In-Reply-To: <83bld37sly.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Feb 2021 16:47:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.337 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: rrandresf@gmail.com, 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> So, is the improvement in B worth the risk in C? > No, I don't think so. OK, thanks. That saves me the trouble of trying to write a minimalist version of the patch ;-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 10:53:50 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 15:53:50 +0000 Received: from localhost ([127.0.0.1]:32927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6bWP-0007yZ-V6 for submit@debbugs.gnu.org; Mon, 01 Feb 2021 10:53:50 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:35397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6bWM-0007yL-KC for 41423@debbugs.gnu.org; Mon, 01 Feb 2021 10:53:49 -0500 Received: by mail-qt1-f176.google.com with SMTP id t17so12574948qtq.2 for <41423@debbugs.gnu.org>; Mon, 01 Feb 2021 07:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:organization:references:date :message-id:mime-version; bh=dlOx+Dvn87NzLJIcJqNqcTg6kblbSjB8dPf/zny0iHQ=; b=qrQLpjeuHwQUk67EjbeSSHSuryJSWUafD9ox7vWdqd8Vx5Pp3KPb1K9LnXpPy31wjm iwsWpvDaEjGbT2Js4pIXsT6VdBWozA1eBLyzM+bC+wqxJ9Wm83J+t9JQz9um+vQs3/a3 Oq7YqEigRaMftafZMc7qxM/pjr95fJwvzkyPDVvvwgHM/8A9atQOjFNWX1hC5fpPDb+r zRcgMbyhyF/RfWV0fJbPa9zO2ZG+exn8Gkn8fytKhMDzWD5Xz7ztXDKECyis7SJU1UGB F55SS5IcHZhMmZNwQuC8U+7xLUBUyOMHNJnGl+jtlSdawMBwCEaep0/SM7DakDAe6n7+ duZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:organization :references:date:message-id:mime-version; bh=dlOx+Dvn87NzLJIcJqNqcTg6kblbSjB8dPf/zny0iHQ=; b=N0OIC+J7xHcYMZ4Mtr2dBVRpB4jUBVACV6Ec0CdLL9zvhejsdRnpaRQl7fWJA3pzML bFyasXcHN8OPtUo7yqQL3dr/ps6p8NdxOiMqBrlhoLI0iIr0x6Rwv9zf08OMOO6MnB6M 2j0TMbNa9oYGHsruy2+VIRddsx8P5nroEnIbJ+AC/y/skZtSJAICE5NXx334qcZllGKf XMcViG5bXH3WGVDw5pNuvT3Je/GvPgItaEUp8fybOq588NKe/r7QKPvSnloNQev7aQK8 cdcYU5SUhsm6U/qmcYWVvZQGAsd/L3ka8Oh+/NhgrX7XXdupkPwJ3dilqB216L6kTdkG NlxA== X-Gm-Message-State: AOAM533y/e/5/LMXJp8MGtC8UtFX3IRq1Ryosn4t1I64FhYo/s13FPqa CYsqA6e8JgjqF2upMDmYT0c= X-Google-Smtp-Source: ABdhPJyTooCnjBawZKyjY8xp0D9o961Q3KBy6S6pi9nDPFN010zfH8ABC3mK9VIzQVgraubfd9Gy6w== X-Received: by 2002:ac8:370d:: with SMTP id o13mr15408672qtb.165.1612194820994; Mon, 01 Feb 2021 07:53:40 -0800 (PST) Received: from sacsa.n800.arm.processor.yandex.fm ([190.42.230.123]) by smtp.gmail.com with ESMTPSA id v8sm11124329qkb.101.2021.02.01.07.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 07:53:40 -0800 (PST) From: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= To: Stefan Monnier Subject: Re: Installing the fix for bug#41423 on emacs-27 In-Reply-To: Organization: bien.comun.org References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> X-Attribution: INKA Date: Mon, 01 Feb 2021 15:53:35 +0000 Message-ID: <86czxjg4xs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi. Stefan, Lars, Eli, Michael, Guys. >>>>> "Stefan" == Stefan Monnier writes: Stefan> OK, thanks. That saves me the trouble of trying to write a minimalist version of the Stefan> patch ;-) Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rrandresf[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.160.176 listed in list.dnswl.org] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [190.42.230.123 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.160.176 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 41423 Cc: Lars Magne Ingebrigtsen , Eli Zaretskii , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Hi. Stefan, Lars, Eli, Michael, Guys. >>>>> "Stefan" == Stefan Monnier writes: Stefan> OK, thanks. That saves me the trouble of trying to write a minimalist version of the Stefan> patch ;-) I am testing now: ,---- [ ] | GNU Emacs 27.1.91 (build 1, armv7l-unknown-linux-gnueabihf, X toolkit, cairo version 1.17.4, Xaw3d scroll bars) | of 2021-01-31 `---- If You code the 'minimalist version of the patch'. I could try it on this version. compiling master takes 1h on my lower end machine. But the releases like: --8<---------------cut here---------------start------------->8--- https://alpha.gnu.org/gnu/emacs/pretest/emacs-27.1.91.tar.xz --8<---------------cut here---------------end--------------->8--- have been prepared with: --8<---------------cut here---------------start------------->8--- autoreconf -i -I m4 --force make bootstrap ./make-dist --snapshot --no-compress --no-changelog --8<---------------cut here---------------end--------------->8--- After all this preparation compiling emacs just take me 20 minutes. I think Lars was talking about having "Multi-OS Emacs buildbot". If that happens. It would be excellent having daily snapshot pre-packaged (like the one in pretest You know with make bootstrap and the other two cli commands ). That would simplify compiling emacs master on lower end machines like my SBC {Single Board Computer}. Best Regards From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 11:13:24 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 16:13:24 +0000 Received: from localhost ([127.0.0.1]:32956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6bpM-0008Ui-C9 for submit@debbugs.gnu.org; Mon, 01 Feb 2021 11:13:24 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6bpK-0008UW-57 for 41423@debbugs.gnu.org; Mon, 01 Feb 2021 11:13:22 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D854C80C19; Mon, 1 Feb 2021 11:13:16 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5CD358079A; Mon, 1 Feb 2021 11:13:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612195995; bh=I8YlIODjSLjL3b1TJRHy0ur8MFvFwA/J1mVt5/KAnK8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=L+IEqBru5Zh5+gx0k86I25NiYtD8N4lpeuyf3nZje0ilhf/TE4qCNeaG2c7luP/EL 5rGnt6/5dyntL0sXqgnLES+doBhMFRHi6ojf/RaDNZXNNhrQy+Tzx0cZ3cO8vPGCwH yXkuwSOG6CXUQbGueZpOuIa3ETF9oKEfrkmMPjYXpxInAa7JtmtOpxc0I0YpTAhkUk ER3EdCcnxkaMCo3rxm0/4BbtcAkCE04qur5VTkRXiUgqMOH/Z9bx606g+0qIqAgYip YA7+KlGWVOjwHtwsh3VLNRJWplcO0j3Cai4jFZJCOO1ZG9ALKRrixXe9iPzGV1Mj3L ANg2MrltNRExA== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 23EC11203FF; Mon, 1 Feb 2021 11:13:15 -0500 (EST) From: Stefan Monnier To: =?windows-1252?Q?andr=E9s_ram=EDrez?= Subject: Re: Installing the fix for bug#41423 on emacs-27 Message-ID: References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> <86czxjg4xs.fsf@gmail.com> Date: Mon, 01 Feb 2021 11:13:14 -0500 In-Reply-To: <86czxjg4xs.fsf@gmail.com> (=?windows-1252?Q?=22andr=E9s_ram?= =?windows-1252?Q?=EDrez=22's?= message of "Mon, 01 Feb 2021 15:53:35 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.318 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Lars Magne Ingebrigtsen , Eli Zaretskii , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > If You code the 'minimalist version of the patch'. I could try it on this > version. See patch below. You don't need to rebuild Emacs either: just recompile that one file and you're done. > commands ). That would simplify compiling emacs master on lower end > machines like my SBC {Single Board Computer}. I know what you mean (recompiling Emacs on my takes quite a while on some of my machines (BananaPi, Mele-A1000, and Thinkpad X30), especially because my build scripts enable all debug options, which makes it even slower). Stefan diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el index faf749d836..744be525ec 100644 --- a/lisp/eshell/em-cmpl.el +++ b/lisp/eshell/em-cmpl.el @@ -399,16 +399,21 @@ (defun eshell-complete-commands-list () "Generate list of applicable, visible commands." - (let ((filename (pcomplete-arg)) glob-name) + ;; Building the commands list can take quite a while, especially over Tramp + ;; (bug#41423), so do it lazily. + (let ((glob-name + ;; When a command is specified using `eshell-explicit-command-char', + ;; that char is not part of the command and hence not part of what + ;; we complete. Adjust `pcomplete-stub' accordingly! + (if (and (> (length pcomplete-stub) 0) + (eq (aref pcomplete-stub 0) eshell-explicit-command-char)) + (setq pcomplete-stub (substring pcomplete-stub 1))))) + (completion-table-dynamic + (lambda (filename) (if (file-name-directory filename) (if eshell-force-execution (pcomplete-dirs-or-entries nil #'file-readable-p) (pcomplete-executables)) - (if (and (> (length filename) 0) - (eq (aref filename 0) eshell-explicit-command-char)) - (setq filename (substring filename 1) - pcomplete-stub filename - glob-name t)) (let* ((paths (eshell-get-path)) (cwd (file-name-as-directory (expand-file-name default-directory))) @@ -455,7 +460,7 @@ (and eshell-show-lisp-alternatives (null completions))) (all-completions filename obarray #'functionp)) - completions))))))) + completions))))))))) (define-obsolete-function-alias 'eshell-pcomplete #'completion-at-point "27.1") From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 01 12:35:16 2021 Received: (at 41423) by debbugs.gnu.org; 1 Feb 2021 17:35:17 +0000 Received: from localhost ([127.0.0.1]:33067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6d6a-0006H0-2T for submit@debbugs.gnu.org; Mon, 01 Feb 2021 12:35:16 -0500 Received: from mail-qv1-f50.google.com ([209.85.219.50]:41829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6d6W-0006Ge-Cz for 41423@debbugs.gnu.org; Mon, 01 Feb 2021 12:35:14 -0500 Received: by mail-qv1-f50.google.com with SMTP id h21so8517894qvb.8 for <41423@debbugs.gnu.org>; Mon, 01 Feb 2021 09:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:organization:references:date :message-id:mime-version; bh=LHKSD5wtljfl33et+d+jyoIRiu9MY5Mw/TcWJt7NuY8=; b=ZBe4RkNZ2St0tevwn/mapIU38D/fSym3qg1vzy7L//HZvBCnttNU+QHrZ7OOjKCQNr GI8Yb5TXnXOep9c+A5RH1eEZxqM+CJq9b7iSE0KrB33N/toeuLauCYJXYjxViFF9ayah HYl5Ak/o99oAfvHy2MBOnpzojoveJmu6QYzuULaOEbibuEmQE76y4Jdg6Uu3VaG3+qxa CqjlY9LGIXiOY0c/A3sGvPUHtnRPAPYqZTPkG4L/yfrQJCUOjlZqRKmersGaZpr25I6V kuBJpsTOit3opAhE2TkIHuY8vD0bwIxjMvUGVGB8Ok4/Jh8GWdGpi91aBrVayNb8uUo9 bfKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:organization :references:date:message-id:mime-version; bh=LHKSD5wtljfl33et+d+jyoIRiu9MY5Mw/TcWJt7NuY8=; b=Fuwdb8EqeqmLYqbXgtd6rvB9zxXHhV4E1qj+j2qO71dLAi+EEen4fna1gZb2RKUZ5L 6eF6CvDjQB+bUnka6HRvHF6twpQNM8uYyTdgWw0f+gYKcTc7iDRRD1e4KXjvatXQM0aJ Lt8l8UV20gQ86LzAtOvVKFBD0kUvnbGunBQQRWhwEOGUvitYX1TGtADsw9fIkTIYAjwo 6ciwTNIixvZTz8t336LactybHUecFlWGTwSYlNCKyC2ElQMbTZ0nrilVsoNqThMfz73N tlR62f9kC9uagKVziW+aUO7+LlB26EsmA64LMotS8zT4KCwGOU9ORL4mYPKmBzq/GMc4 41yA== X-Gm-Message-State: AOAM530Z04Aaimz44rjPKloxeWE508DBST9Exq6/9IZNGYzqfBLYi3Vj 1kME2ikKKS+BMfHcH3GwEew= X-Google-Smtp-Source: ABdhPJx3ruTKcZY8D9ZRsxeKG7Dsj25F+bkwvl162KzK3uGlhZrxV5EKcly6xSFKjOLaSojJ4Aml2w== X-Received: by 2002:a0c:b645:: with SMTP id q5mr9859898qvf.9.1612200906821; Mon, 01 Feb 2021 09:35:06 -0800 (PST) Received: from sacsa.n800.arm.processor.yandex.fm ([190.42.230.123]) by smtp.gmail.com with ESMTPSA id t22sm13922960qtp.7.2021.02.01.09.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 09:35:05 -0800 (PST) From: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= To: Stefan Monnier Subject: Re: Installing the fix for bug#41423 on emacs-27 In-Reply-To: Organization: bien.comun.org References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> <86czxjg4xs.fsf@gmail.com> X-Attribution: INKA Date: Mon, 01 Feb 2021 17:35:00 +0000 Message-ID: <86bld3g08r.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi. Stefan. >>>>> "Stefan" == Stefan Monnier writes: >> If You code the 'minimalist version of the patch'. I could try it on this version. Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rrandresf[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.50 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.50 listed in wl.mailspike.net] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [190.42.230.123 listed in dnsbl.sorbs.net] X-Debbugs-Envelope-To: 41423 Cc: Lars Magne Ingebrigtsen , Eli Zaretskii , 41423@debbugs.gnu.org, xristos@sdf.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Hi. Stefan. >>>>> "Stefan" == Stefan Monnier writes: >> If You code the 'minimalist version of the patch'. I could try it on this version. Stefan> See patch below. You don't need to rebuild Emacs either: just recompile that one file Stefan> and you're done. I have re-tested the original conditions of this bug report. Without the 'minimalist version of the patch'. And the problem does NOT happen anymore. Perhaps Xristos could provide his test conditions and also try the 'minimalist version of the patch'. [...] Best Regards From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 21 12:06:24 2021 Received: (at 41423) by debbugs.gnu.org; 21 Apr 2021 16:06:24 +0000 Received: from localhost ([127.0.0.1]:59584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZFMu-0007lk-Ac for submit@debbugs.gnu.org; Wed, 21 Apr 2021 12:06:24 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:45908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZFMr-0007lU-CR for 41423@debbugs.gnu.org; Wed, 21 Apr 2021 12:06:22 -0400 Received: by mail-qk1-f169.google.com with SMTP id d19so7582265qkk.12 for <41423@debbugs.gnu.org>; Wed, 21 Apr 2021 09:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:in-reply-to:message-id:mime-version; bh=MSlA2shgabN+uzQUBPfy/np4nRUWZUCzWLcbvrQrVWo=; b=RAQWyPmkyhPuJ4QwhrIl2kSpqLWuRoqSolEj6ww7C/IKfAJQInyhdOH/prVgCyB0xk w7lexb81cfycg/OiPW0JQsvZx0fH9QxdWHIpEGzGO+NZDra+1WR8fO7k84AhOvyPqx7u sah0gZHvOuCJoWA6eK2nF191uUGjZdd9ervtzJZahIMmRsl41mETwd+pDVHyATlGTt2c aBjmZpK7tfqLBhjzO0Gejqve0d9Ar5vIk/zwbeOA4x3BINL9mHSJ8872DM85XVMb3G+u 9Q1yH9c47wAfV4wdeu/TmZmi73nv4h8VyoPGcbgpqanAXgZqsY8Ol1nYq/JkqDYu96LK pGRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:in-reply-to:message-id :mime-version; bh=MSlA2shgabN+uzQUBPfy/np4nRUWZUCzWLcbvrQrVWo=; b=WYyrAtJ6hIeZkAmNx78awygJYQgUFHMQEJTE4VyE1lzkbupQpGAvjWin8hPgKiD/O+ lpOHJCIUAQVhCiFTzbaR2QpctjxcL40xsDS7W3OiXCL+invsXrEH6I9BxyUiyd+vj/iQ G0TycDLkmUT0n2sINl0bscsC/RgTA58j1vyd6MQ8b1rqJm+6AGAXVKkxefoMqlPUNQJZ eKc+w0TbCvjA2m9lwReU38VkPMO3Mkrbuk0/Agz0TYhCnZFlL0qX+58rkTXhXsRmw3yb 9YNd2xprJVBtXMpJ6z+WkbrgKy1cEWKyDuXr+mIa5SqXbok9YYJnw3vX3z/xrUyhkpwM 2wbQ== X-Gm-Message-State: AOAM531/P0MiD3vHTzdtOjTetACxcTJZGfeloaXafHucVBeL1BzL4uGI QRJdBIpyUygngrVpXk6+6AAuCCSd39K1OQ== X-Google-Smtp-Source: ABdhPJyD3uCUW9uNV+2mlJSj8qCdCnmZ8KPNx99nNo/zJGPrkXrw9Ts/cuqzIRKyMGdFuXpgB0b16w== X-Received: by 2002:a37:9087:: with SMTP id s129mr24092397qkd.297.1619021175721; Wed, 21 Apr 2021 09:06:15 -0700 (PDT) Received: from sacsa.n800.arm.processor.yandex.fm ([190.237.25.165]) by smtp.gmail.com with ESMTPSA id a21sm2447455qkk.45.2021.04.21.09.06.14 for <41423@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 09:06:15 -0700 (PDT) From: =?utf-8?Q?Andr=C3=A9s_Ram=C3=ADrez?= To: 41423@debbugs.gnu.org Subject: Re: Installing the fix for bug#41423 on emacs-27 Date: Wed, 21 Apr 2021 16:06:12 +0000 In-Reply-To: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?='s message of "Mon, 01 Feb 2021 17:35:00 +0000" Message-ID: <86tunzaah7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41423 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi. Stefan. I have been testing the 'minimalist version of the patch'. And I have found this issue: --8<---------------cut here---------------start------------->8--- http://debbugs.gnu.org/47389 --8<---------------cut here---------------end--------------->8--- For fixing that issue. I have added a tiny modification. to the 'minimalist version of the patch' which is: --8<---------------cut here---------------start------------->8--- - (if glob-name + (if (and (boundp 'glob-name) glob-name) --8<---------------cut here---------------end--------------->8--- That change let me workaround bug#47389. The change is OK? Best Regards From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 23 18:14:29 2021 Received: (at 41423) by debbugs.gnu.org; 23 Apr 2021 22:14:29 +0000 Received: from localhost ([127.0.0.1]:39122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la44D-0001hk-CJ for submit@debbugs.gnu.org; Fri, 23 Apr 2021 18:14:29 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la44C-0001hX-5u for 41423@debbugs.gnu.org; Fri, 23 Apr 2021 18:14:28 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9B27080A9C; Fri, 23 Apr 2021 18:14:22 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 28BF980533; Fri, 23 Apr 2021 18:14:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619216061; bh=oCQKbrMHkxDy1kkerldc72PbvkOgLGx9CeTFyzUjiPk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=N10B9UVuz161oNHG4P7SK5pZ1MuS0Heqz9Qb6wP1pU/cSCs0kgBPq8bmtOJ0Wsxdn 6l4uI/ga/u9i1EGK+HGByRdvJR6/b2SHnDx/Vz2zXqXd83fPKY/DW/wKKe/+JCFbI3 gzKzGt5Rg+N/xiDodvnAB2GZ9guwauisRCURqB4q8McaT36eRAI8cv2iJSHdpXNAb1 4NcuG4w0j8zkT0195pAYpgKKTagzhovmyfjuYiJlnm8cFU6QcwHaEm3yYeduoh1ZNd VafMdC/4bOdrXp2rQPDtEOJmt0kKLZ96b+SM3du/mp1GoK+UH7tmlkeKEQ9NpgfFXH DFTJD4Z9QDnoA== Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C910E1200C3; Fri, 23 Apr 2021 18:14:20 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?Q?Andr=E9s_Ram=EDrez?= Subject: Re: bug#41423: Installing the fix for bug#41423 on emacs-27 Message-ID: References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tunzaah7.fsf@gmail.com> Date: Fri, 23 Apr 2021 18:14:19 -0400 In-Reply-To: <86tunzaah7.fsf@gmail.com> (=?windows-1252?Q?=22Andr=E9s_Ram?= =?windows-1252?Q?=EDrez=22's?= message of "Wed, 21 Apr 2021 16:06:12 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.309 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I have been testing the 'minimalist version of the patch'. > > And I have found this issue: > --8<---------------cut here---------------start------------->8--- > http://debbugs.gnu.org/47389 > --8<---------------cut here---------------end--------------->8--- > > For fixing that issue. I have added a tiny modification. to the > 'minimalist version of the patch' > which is: > --8<---------------cut here---------------start------------->8--- > - (if glob-name > + (if (and (boundp 'glob-name) glob-name) > --8<---------------cut here---------------end--------------->8--- > > That change let me workaround bug#47389. > The change is OK? No, the missing part is the `-*- lexical-binding:t -*-` on the first line of the file in which you place that code. The above workaround you found might mostly work OK, tho; I suspect it will just mis-complete when you use a command name like `*foo`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 23 23:37:59 2021 Received: (at 41423) by debbugs.gnu.org; 24 Apr 2021 03:37:59 +0000 Received: from localhost ([127.0.0.1]:39235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la97H-0000qF-H0 for submit@debbugs.gnu.org; Fri, 23 Apr 2021 23:37:59 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:43630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la97F-0000q2-I3 for 41423@debbugs.gnu.org; Fri, 23 Apr 2021 23:37:57 -0400 Received: by mail-qk1-f172.google.com with SMTP id u20so19476223qku.10 for <41423@debbugs.gnu.org>; Fri, 23 Apr 2021 20:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:organization:references:date :message-id:mime-version; bh=4fSa6xPa3LnPKe05YmgYNYUtIRM6q8aK/dSMK3ie+TE=; b=FQXd/pnqVzKOvRqbfr2gWF9Ckq8SllJdUk2qQjrtAA+LIE7svlfPw3ppH356tdIj35 /fH77HrMGjScmp3x7rrYDGujbEhDFtEsBEK15h2JEcQWdnf3Z7eem9Ido8fi49+SY8e9 BTD0GaDiVF3n7s5IWT/K+WUFMebhFo/ETsImsugFyRtS1mFhDZAbxHYPVmnE9y1ZljDA oD+s7s4G13KL6MY2aqrMMReLkypIJWJp0fnk+rWjZfxl8XouYVfJzEb2PFuaJb47Eyt8 cNRbphO8MmcbSYOVKTjKPqjn2p0EW6S9mFv/8j/R1G8W1xIZP7wQV2ePf4W9w/H5iivd aGdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:organization :references:date:message-id:mime-version; bh=4fSa6xPa3LnPKe05YmgYNYUtIRM6q8aK/dSMK3ie+TE=; b=OVAlHZ3UU1cHSf2x7Dy4SeEPrPjMCccvFdwM+xT6b9T6yl5Vu+U/+1/5oNtvCrVhiP Om0O7gF4/kclk9JlDB2TjnvxaQIXPAKCEkRN3BPJH6qXi8Q0Kc5AZdalNp6jW6cwF8zP Pbi3vVhb1cAD8q+oXf71A/GAp5JpWsCS6ldV6pm3RehN67j/kh+KXiCU62kJmTj6jAx3 iLmH13z5izTGSIXSCrmzdi2PGWzjiLBcCKOgg/RVFYmFy2SYtbt1YP3W1/2DfsuQjPha cZZ/vu3qq/OB85UR7I8i/7G6IwRr6sY2gOXa7vVjaQh4ek+DnFJWy693rVfguVZXOhup rC6g== X-Gm-Message-State: AOAM5319voc6DWM3q5ihA/mWaxPRXNraJ+GLGAWodd6xzxqsXu0Uht0g 8L9JLKXA/ogzE/Lmm1m3xDo4RvmizcE= X-Google-Smtp-Source: ABdhPJzO5eVT6x6lSCU0FUBEhamUHj6afU2Jvcj1+wCjUsLGoQnSojvjXSeo0cZVNh2+UK0zXRT7RQ== X-Received: by 2002:a05:620a:89d:: with SMTP id b29mr7509491qka.231.1619235471738; Fri, 23 Apr 2021 20:37:51 -0700 (PDT) Received: from sacsa.n800.arm.processor.yandex.fm ([190.237.25.165]) by smtp.gmail.com with ESMTPSA id n15sm5728448qti.51.2021.04.23.20.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 20:37:51 -0700 (PDT) From: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= To: Stefan Monnier Subject: Re: bug#41423: Installing the fix for bug#41423 on emacs-27 In-Reply-To: Organization: bien.comun.org References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tunzaah7.fsf@gmail.com> X-Attribution: INKA Date: Sat, 24 Apr 2021 03:37:47 +0000 Message-ID: <86eef0z71w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41423 Cc: 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan. >>>>> "Stefan" == Stefan Monnier writes: Stefan> No, the missing part is the `-*- lexical-binding:t -*-` on the first line of the file in Stefan> which you place that code. Then I am going to do this change. And keep testing the 'minimalist version of the patch'. Stefan> The above workaround you found might mostly work OK, tho; I suspect it will just Stefan> mis-complete when you use a command name like `*foo`. Thanks for the information. Best Regards From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 25 15:03:28 2021 Received: (at control) by debbugs.gnu.org; 25 Apr 2021 19:03:28 +0000 Received: from localhost ([127.0.0.1]:43835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lak2R-0006s3-Ub for submit@debbugs.gnu.org; Sun, 25 Apr 2021 15:03:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lak2R-0006rq-6G for control@debbugs.gnu.org; Sun, 25 Apr 2021 15:03:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tleoFKRQNCpE6FRuydNl7ag7c1fLBxCvCOg890dxtS8=; b=SNubIFXhillQw6hTRhQRoonoXp PcIpuHWmxf09eD8gR+mctKQIMa6sMP3oN7CtEVsX36oK5OUeTKlE2HlIbyKVtQxmLUCqYjcOWKvoe Vm3j55g+OWS2qkVUxad7FGQ7S8qYlOdUZxzHkEwbKfpmUR4WmG0jhSvgtrslf5wMkKng=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lak2J-0001Di-Cg for control@debbugs.gnu.org; Sun, 25 Apr 2021 21:03:21 +0200 Date: Sun, 25 Apr 2021 21:03:18 +0200 Message-Id: <87k0oqjifd.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47389 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: forcemerge 47389 41423 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 47389 41423 quit From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 10:34:26 2021 Received: (at control) by debbugs.gnu.org; 16 May 2021 14:34:26 +0000 Received: from localhost ([127.0.0.1]:51321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHqc-0005IZ-Fc for submit@debbugs.gnu.org; Sun, 16 May 2021 10:34:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHqb-0005IM-2a for control@debbugs.gnu.org; Sun, 16 May 2021 10:34:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wdS076hDJMtULU0LGNTIHiRTX7scBA75DmgX7OxDons=; b=jg1/92hBWMFIEe5uf///fUNC3P CcS++cVb+S9atq+us7DDAUrCBKNHWxTYaDTqM81T+Z2ula7i591Ubu1tObwUJe95eH89OhmhaFixc /pP1yPriGuKNHpCEj89GCLOWDWJHLlMY/Q48IHTcUWmUoIuvt3Ej29BVWiAuerO93JYE=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liHqT-0007qE-HP for control@debbugs.gnu.org; Sun, 16 May 2021 16:34:19 +0200 Date: Sun, 16 May 2021 16:34:17 +0200 Message-Id: <87h7j2n3x2.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41423 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 41423 - moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 41423 - moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 04:29:49 2022 Received: (at 41423) by debbugs.gnu.org; 27 Jun 2022 08:29:49 +0000 Received: from localhost ([127.0.0.1]:49784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5k7x-0001w5-4x for submit@debbugs.gnu.org; Mon, 27 Jun 2022 04:29:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5k7v-0001vk-2l; Mon, 27 Jun 2022 04:29:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9LnkZVdQjpmA1KaGcvwkXQW1RTI6wa6E7/MVp3JG0UM=; b=kZZcMD2pKxHb6wcFif3gor8cDk tYHEsONMEIzc3nWKH3oo2sKSeADuyXSv2FQ8lQFNha182EQXXqndKmrXj93LWONQMbNX/RvAqjNCP k5E8IG8OVC9FjLut11ytWA6/BX3sR+5ieql6VDg9/1ZCli80StUAof0XSevBfa8TDIH4=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5k7k-0003bE-UU; Mon, 27 Jun 2022 10:29:39 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#47389: 27.1.91; completion issue on eshell References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> <86czxjg4xs.fsf@gmail.com> Date: Mon, 27 Jun 2022 10:29:34 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 01 Feb 2021 11:13:14 -0500") Message-ID: <87fsjq7bm9.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> If You code the 'minimalist version of the patch'. I could try it on this >> version. > > See patch below. You don't need to rebuild Emacs either: just recompile > that one file and you're done. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Eli Zaretskii , =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= , 47389@debbugs.gnu.org, 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> If You code the 'minimalist version of the patch'. I could try it on this >> version. > > See patch below. You don't need to rebuild Emacs either: just recompile > that one file and you're done. [...] > diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el > index faf749d836..744be525ec 100644 > --- a/lisp/eshell/em-cmpl.el > +++ b/lisp/eshell/em-cmpl.el > @@ -399,16 +399,21 @@ > > (defun eshell-complete-commands-list () > "Generate list of applicable, visible commands." > - (let ((filename (pcomplete-arg)) glob-name) > + ;; Building the commands list can take quite a while, especially over = Tramp > + ;; (bug#41423), so do it lazily. Re-skimming this bug report quickly, it seems like this patch was applied at the time, but Andr=C3=A9s had some additional issues, and a proposed addition patch? Andr=C3=A9s, did this patch fix the issue, and if not, do you have an additional patch here? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 04:29:55 2022 Received: (at control) by debbugs.gnu.org; 27 Jun 2022 08:29:55 +0000 Received: from localhost ([127.0.0.1]:49789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5k82-0001wU-SQ for submit@debbugs.gnu.org; Mon, 27 Jun 2022 04:29:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5k7x-0001vp-29 for control@debbugs.gnu.org; Mon, 27 Jun 2022 04:29:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qcPLZKeb6R7TxKn+Wv/fbL85QjAJyGPAIo6VujWFD2s=; b=q4z//fbTGFQAIcVCH16UKrM9iQ 3mKHQSIlyZbi7BaP/nLUMpBPpbEDkfMR9crnhqOnKAsAXx2HS5vyR9BijGrVwWcrD12cP/32OkS8T xEKGHbm9V1p2ou86R+mXusfOhNNcj082RINegggKYO6oAT2kmBX2xmyhVGOqPw1xp2ms=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5k7p-0003bJ-C9 for control@debbugs.gnu.org; Mon, 27 Jun 2022 10:29:43 +0200 Date: Mon, 27 Jun 2022 10:29:40 +0200 Message-Id: <87edza7bm3.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47389 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47389 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 47389 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 07:44:34 2022 Received: (at 41423) by debbugs.gnu.org; 27 Jun 2022 11:44:34 +0000 Received: from localhost ([127.0.0.1]:50078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5nAP-0001ys-V0 for submit@debbugs.gnu.org; Mon, 27 Jun 2022 07:44:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5nAN-0001yU-F4; Mon, 27 Jun 2022 07:44:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OoUAYezqtbRWftCkNoEzyd+3obtgSERDGCzXHo+QzLg=; b=nAZvYr33gUJvU9iyHBHRkz9SjJ WlFObCeuV86cEfsCCO3EIGrOWxQJVbyp7N0MOjr2sVp0CF3KClV4yt4sdYoG0u33V8sL/WXBZGflF FJ6PXK8ZOG3ZdBwYyaBMt+KG4ScgcBIyVLodJTvvnSg5+LNNU85BmljcywWyivyLEoaI=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5nAD-0005Zk-51; Mon, 27 Jun 2022 13:44:23 +0200 From: Lars Ingebrigtsen To: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= Subject: Re: bug#47389: 27.1.91; completion issue on eshell References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> <86czxjg4xs.fsf@gmail.com> <87fsjq7bm9.fsf_-_@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUcGiJcGBGlTBzU lEU9SUUNDAu6sZ/////py3SQAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YGGwsqEpQWJYAAAAGpSURB VDjLdZTPboMwDMbNlOxMkHqnrfYC68Q5Ym7ProTv0/7k/R9hnwOMhG2WWgX/6s+ObUpE1IST2fn5 Mlt+ogy6Y4dz4T928McxwDbwjGMwwOMxWMD5stoJDnIcH+aAwo4hAPCIyFCaPc3JIYUf4bNEGHDE Bnqv2chB4lRE9KQqEVSY3QxcBgdzRYthjpZziQgARFkMZRbJAYTnNNMeTHFOP0UqkodW5foDuhqY kkMNjispmQB44DjRBloDojqOA78w1xHqp9c0pPSJC27gHnrVR/Ond45cgif1j+kyDGkv1Yuf0hkR /Q606vX2ARDZ7VsCrY9wI963BHdGwOfvJsJuKb3ZQLrQNhWQlL6s74j4AS0pWcjV+l5V1eZBOa8i LpTAo14hJutuqNueO85eiDagALgIfGwbtOXw4WCbACm2720espRLeYNKqWYFNvicdM1hwAvKFQPt No8Mlp2TPTAtsl1ZAS1AsNYVQLn3DMRdWaDW1FWJnRmZm7VcOmjTVe/gCrzeT3+CuaTC7u0/QGWV +hvIb6C1lGAkskwuA7Vbzb0LzfLv8A21O7AgBjMOmgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0w Ni0yN1QxMTo0MjoxOCswMDowMJ0lGWYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDYtMjdUMTE6 NDI6MTgrMDA6MDDseKHaAAAAAElFTkSuQmCC X-Now-Playing: Joni Mitchell's _Turbulent Indigo_: "Sex Kills" Date: Mon, 27 Jun 2022 13:44:19 +0200 In-Reply-To: (=?utf-8?Q?=22andr=C3=A9s_ram=C3=ADrez=22's?= message of "Mon, 27 Jun 2022 11:37:09 +0000") Message-ID: <87a69ywcto.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: andrés ramírez writes: > I have removed the patch from my dot emacs today. And everything seems > to be working fine. So no additional patch is needed. Thanks; I'm closing this bug report, then. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41423 Cc: Eli Zaretskii , =?utf-8?Q?andr=C3=A9s_ram?= =?utf-8?Q?=C3=ADrez?= , 47389@debbugs.gnu.org, Stefan Monnier , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) andr=C3=A9s ram=C3=ADrez writes: > I have removed the patch from my dot emacs today. And everything seems > to be working fine. So no additional patch is needed. Thanks; I'm closing this bug report, then. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 07:44:40 2022 Received: (at control) by debbugs.gnu.org; 27 Jun 2022 11:44:40 +0000 Received: from localhost ([127.0.0.1]:50083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5nAW-0001zK-Ey for submit@debbugs.gnu.org; Mon, 27 Jun 2022 07:44:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5nAU-0001yr-Qj for control@debbugs.gnu.org; Mon, 27 Jun 2022 07:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oHoPfERoakq+W+6NF1ClED+vHTL2K5sDdIFSXzXS/38=; b=PIG2FGPSovF6fOjym9Rb4xyutm PdGb32XjCrJfN/WvgyITuLFZ4zpTrCoWxAmuiEs4Xb2amX4knrvPJ5DLnCgiSk+0vZ2g2CfpO5IoV s75v+fMF2kOJ0w6XRO8wLbskc4LgX7TMJHzFmukBJBF2tD3I4FMowMcQTMXz8yicERTU=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5nAM-0005Zt-Rv for control@debbugs.gnu.org; Mon, 27 Jun 2022 13:44:33 +0200 Date: Mon, 27 Jun 2022 13:44:29 +0200 Message-Id: <878rpiwcte.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47389 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 47389 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 47389 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 08:31:33 2022 Received: (at 41423) by debbugs.gnu.org; 27 Jun 2022 12:31:33 +0000 Received: from localhost ([127.0.0.1]:50227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5nts-00073S-9N for submit@debbugs.gnu.org; Mon, 27 Jun 2022 08:31:33 -0400 Received: from mail-mw2nam04olkn2027.outbound.protection.outlook.com ([40.92.46.27]:46688 helo=NAM04-MW2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5n3T-0001kJ-De; Mon, 27 Jun 2022 07:37:24 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xfbhck4kNHHAIYRB8iMhW8sQ5jVZFwhC/Ahdw5bbpxZ6+2mpwi3TVSwILP/GbJgbGssk/16qPZAYcjgWKYyyVrus/sUtCBDn1v3w4nrcfiicZn4muz723fDCnTVNbMr78eec1gDEFpECxGtvVPtiuAcf0iyWGdEEIShh7wYnGXoMl6CRAi84xgS7Bh4IHpFOjDzhHFl6g9BTG+EUsyjyH/y0JHskxVxWohR1YwzAUBzzY7I8/XL2TSTnEzBEkLN3kNrJBE9zNNJX7/kaJueebV4Nwh7YZWDI+HjjhIPK28InFLvbBcfACvvUa2/OqK1cP4KYR6f75CCePy70NN360A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pS7MMxMnRs+KHLk0Zk9MpC44Jik40hS+6k08UBAh7QY=; b=XcxP5fXzCEWmg4UGAprye28Wp6gRdUpBFsaXumjbHLDzY9XJ23+489E3mdn8TiDwmYbPTd84pS50tI3NfXTtH+qvEv7GHET2D5S0NyxoVkmZGBWjIXJXkR3tItwM6ZFR4RGqKNM3Gbmyf0O2pwHC50jLNXzHsozuJO5Cx1zOE0fYMGTD4QQAGCJK7XMGuG91laASQoGIn4Oq8vpcgwBxaQMHmuviA9uNWsKYCHdwPxgTj08vsmDK1kNIqgkzGdfFgKqRdY8j6xp3XQ2pnWesCw8HAqNqNFgcpqiVw9z77r/tbELcvHLnCtx16Qqngx9TqpCflcAttzP+7VGJlZQodQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pS7MMxMnRs+KHLk0Zk9MpC44Jik40hS+6k08UBAh7QY=; b=LjoE9tgL2uYd0mjzFuOP2jKfrBFQ4cJQcv4BJUBJbJ4VWHofc3Xp7Tzx8kxOb7aRIeXQFjeoNaBQd24YpW7EFYkGmExqkezmK9VaYU1RQtoILO6vBGd5PjyG6rC/CO74/qmvehw7JEVG6g5obEJ/7NyfiiZ7pWGEnR9n3o5LPC3P+Eo2NWMh9tXwO1VcsoxdpNIIlUxnx1yvK54FynxRX7jd4YI7I0ttKuoN26sEriTg3RTu29slf2CeVjFsb7dHUxUfpekV2qWxTL023krXQf5r1X0uwgkB/ss5YDGLGwU4YGtOnKKwhzTQnkyKFd/NjkdgMYewHeLLxScSld/q2A== Received: from DM6PR03MB3803.namprd03.prod.outlook.com (2603:10b6:5:42::23) by SJ0PR03MB6520.namprd03.prod.outlook.com (2603:10b6:a03:394::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 27 Jun 2022 11:37:16 +0000 Received: from DM6PR03MB3803.namprd03.prod.outlook.com ([fe80::b124:b679:c1e6:39c4]) by DM6PR03MB3803.namprd03.prod.outlook.com ([fe80::b124:b679:c1e6:39c4%6]) with mapi id 15.20.5373.018; Mon, 27 Jun 2022 11:37:16 +0000 From: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= To: Lars Ingebrigtsen Subject: Re: bug#47389: 27.1.91; completion issue on eshell In-Reply-To: <87fsjq7bm9.fsf_-_@gnus.org> Organization: bien.comun.org References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> <86czxjg4xs.fsf@gmail.com> <87fsjq7bm9.fsf_-_@gnus.org> X-Attribution: INKA Date: Mon, 27 Jun 2022 11:37:09 +0000 Message-ID: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TMN: [Qbu5PJl6phzVCoXlyx94tqHmnZkjvUfA] X-ClientProxiedBy: SC1PR80CA0089.lamprd80.prod.outlook.com (2603:10d6:2::16) To DM6PR03MB3803.namprd03.prod.outlook.com (2603:10b6:5:42::23) X-Microsoft-Original-Message-ID: <86edzaxrq2.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3fbcb3c-0170-4ab5-c23e-08da583162e1 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6520:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TESu7+oypsLm+P6w8Ffq+kx69/SIK6o6cheniYz4z4IBv7d+rZ8LEcowk93eSKVyJaxQG+HVO3gbe42EsSDGCqulUyaWt9IJTxiPW8TvUKSfo7f2uB6uUuoJpXHmWpvhMhG0wy9PIOstXtJYpEfE4pag0g4VrltMOMS4gnakcS0bo5hMb7yIi9ZQ/BXiDTtQe6Kesx6E7wEu2Y/ygO0tlO12AjLQMUCG4AZuxBaCQwA53BXPBoQwhM9CRXAwmS3vo5EpzU6n1zWOJbI3KIzB5i4suO67T/+ifyMuNrLPmb8giOwrsuZggmi6Q9g6Lon/xn0j8NjT+FqHrd+RRdqJ13wL9Y5lQeDh7yhd6VdTZQphLyGpapJuGgzlBWpkLTVtwB/ub7YWyr5qaQBg8E+8sGPvdB64fvPfyhw0LIocfcz3vrkMMY9Hg4c5Q0kyYXu0clHwoH1p6s/4JK12/jAGkhahQquLzh2vqpTgqZFdy1pNT0ESV9CG7XvdRykdf3TemN6hNTRxYtJVYpNssL+DtMPZ2QBYibFGy21GEsu2vv4VFCS+lN5ddKcrN08GkswE47liboPBWUKzmJeYdyd4zACEAhRdKs7n+VKOvwxPyexmQvkSkm4s6ewBmPSQEFvj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDdBSDIvTUFqTW0vVGJXYTR5QXlnbWQ2MFoxSUdhOG1YQU9MSytxeWtjeDVH?= =?utf-8?B?OGxBMTFYV01Qb2lHMVZ4ZjlVanNBQjhKbEFpbzltZmxYcE03UTQ2VDNYV0Rp?= =?utf-8?B?RjdFeXIyRGc3QWhiM2FGbnpEVmpBeldhcnJWZ1kraDRnaEZkT0dRWTU5c01X?= =?utf-8?B?VWxHVWVnSWdKQk5wVGorZGxtTktnY0RrMXl5bEY2OFloUXJML3BkZGFZekEv?= =?utf-8?B?cmN0dzN0MCt2LzBKQTBsNGFvVFd0cnNubW9IcEVHclQ1d05JL2loUm56UEYw?= =?utf-8?B?VCtvVTdrRmI3TFNqTU43dVFiVDY3QWg5SHNwTENDTDJ0N2NrL1MxbktWaHJt?= =?utf-8?B?SmxwazFvN3JYTDBJMDJpanJSaHNMSmtsc2VTVDhYWGpZcWw1T01BaDlrQjRu?= =?utf-8?B?QUk5QVYvWjFnTXd4akxpT3dxVzlBUDNGbW5xbVpuMi90czRSWVdEY2lnQU9l?= =?utf-8?B?Y0FMQjJobnlpdnlwWnozd3pMMFRhZDRsbHhOb0piNE90aURpak9oeC9HczFX?= =?utf-8?B?dWc4V1hQdFM1UUFJNDV1cXNndEZqT2tKOXE1VGhNLzNVa3B5SHYvQWt1VVds?= =?utf-8?B?UnB2LysybmhoaHp4cHBLMnJDT1UwS0g1UkhpVXZXQkx5WUYzYWdtbkZJbElT?= =?utf-8?B?THFoc0ozL21aQ2RCa2V5aE9RQnNlWnhKeG5hMEUwMER5S0JvMkRreGxjdjJk?= =?utf-8?B?cmNqS2hWVVJCYlRlaXAzcFUxZkNpRVF3SmRnMHNVMFJEQjE4Z3dzVGtVU2Rq?= =?utf-8?B?UVFHMEhmSU5ZU1RadHFEUlZXakc4d3I3UysweFFZZFRzYUVKYWV1UWZiWEtG?= =?utf-8?B?VVVQVG5yQmE1eFM1cU12RmVEWktKaDBYY2hicjJQR0ZZZkdjVG9hRXcvbTlF?= =?utf-8?B?WTNaM1dmYkV3NmE4VWFqV0lHWmN3UWxkWmtBNzc3eWl5SGlyU2Y3UGJ1cDMr?= =?utf-8?B?c1RlWWhNeFozTXQzc3NRK2l5WENjdDNiTkdWNDd0Y1g1MkZtQlVwNzRzNFFC?= =?utf-8?B?Nk1vbjJUWC8xaGRFdUZkWU9IbWxYWGkyajhWRlZIOTU4TDFGSHRyNDZLb1py?= =?utf-8?B?R05Sb0lDSDJ3a0I4MHcrWVQzdm5tQU9Yckw1Z1FJS3ltYVZYeGRyUkFFK2VC?= =?utf-8?B?NThMdTNmVG5rcXVwajRrbW9hVjdUdEFDUzFyb2MrWi9Lc2E0U0p0ZlBHcjF2?= =?utf-8?B?UXN2YmE2M3d1RlQ5SmlPU1ZFUklJOEJlQmFSOVAzSGdweUF5RVhpMXlMWStl?= =?utf-8?B?NWtzQ1BtMjN1cmFobHdsaytJSklGZmRzT05VZEFFNXdSQSs1UE1ac1FsdVda?= =?utf-8?B?Z3VvU1dEQ0Z2S1pvZzFSS04wQ0R6RTk4TzA4U3BQVXNacXIxVU9kZUFqckF3?= =?utf-8?B?WkxUakdzcDZtM0c4TDFNM2J3YU9JK0lzWUtESnRja0VvaTZvc1I2d1hIcEpO?= =?utf-8?B?b1pSS1hJOWZJR1NVaUpBZFJ1ZldYV2JrRTBTNmVoblE0MWc2QjhFWDI2NGx2?= =?utf-8?B?TytHZWs1bGE2MzN3Y09rdnMwS202WnhLWmRPb3dlcWxlUk1oWG8xamx1SVRs?= =?utf-8?B?MUpFazcyY3A5anFpQkNYYyt0RmlXVnBReUcyczIwVkdadzQxaVViNjRFWFRN?= =?utf-8?B?VS84emxFYXd6Mk1yc2JRRFgxaGhOSTVubFRleHdmcjR6MEQ2RzNMTXVMblhV?= =?utf-8?B?Zjh1VGpXZXd0NVgyV2lJejVsYWVNZDZsSHpDSDl5a3N6MjloNy9XYWxBPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-685f7.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: a3fbcb3c-0170-4ab5-c23e-08da583162e1 X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB3803.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 11:37:16.5388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6520 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41423 X-Mailman-Approved-At: Mon, 27 Jun 2022 08:31:26 -0400 Cc: Eli Zaretskii , =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= , 47389@debbugs.gnu.org, Stefan Monnier , 41423@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi. Lars. >>>>> "Lars" =3D=3D Lars Ingebrigtsen writes: Lars> Re-skimming this bug report quickly, it seems like this patch was= applied at the time, but Lars> Andr=C3=A9s had some additional issues, and a proposed addition p= atch? I have removed the patch from my dot emacs today. And everything seems to be working fine. So no additional patch is needed. Lars> Andr=C3=A9s, did this patch fix the issue, and if not, do you hav= e an additional patch here? Yes. It did. Thanks Guys Best Regards From unknown Tue Aug 19 05:09:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Jul 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator