GNU bug report logs - #41410
Patch: Add function ffap-other-tab

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41410 in the body.
You can then email your comments to 41410 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ej32u <at> protonmail.com
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Patch: Add function ffap-other-tab
Date: Tue, 19 May 2020 21:43:13 +0000

[Message part 1 (text/plain, inline)]

Hello,

Attached is a patch to add a function to open files at point in another tab. It is basically the same as the function ffap-other-window.

Please use it.

Thank you.

[Message part 2 (text/html, inline)]

[0001-Add-ffap-other-tab.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: ej32u--- via "Bug reports for GNU Emacs, the Swiss army knife of text
 editors" <bug-gnu-emacs <at> gnu.org>
Cc: ej32u <at> protonmail.com, 41410 <at> debbugs.gnu.org
Subject: Re: bug#41410: Patch: Add function ffap-other-tab
Date: Wed, 20 May 2020 01:31:04 +0300

> Attached is a patch to add a function to open files at point in another
> tab. It is basically the same as the function ffap-other-window.

Thanks, this is a useful addition.  Please push it to master.

> +(defun ffap-other-tab (filename)
> +  "Like `ffap', but put buffer in another tab.
> +Only intended for interactive use."
> +  (interactive (list (ffap-prompter nil " other tab")))
> +  (pcase (save-window-excursion (find-file-at-point filename))
> +    ((or (and (pred bufferp) b) `(,(and (pred bufferp) b) . ,_))
> +     (switch-to-buffer-other-tab b))))
> +
>  (defun ffap--toggle-read-only (buffer-or-list)
>    (dolist (buffer (if (listp buffer-or-list)
>  		      buffer-or-list
> @@ -2013,6 +2023,7 @@ ffap-bindings
>
>       (global-set-key [remap find-file-other-window] 'ffap-other-window)
>       (global-set-key [remap find-file-other-frame] 'ffap-other-frame)
> +     (global-set-key [remap find-file-other-tab] 'ffap-other-tab)
>       (global-set-key [remap find-file-read-only-other-window] 'ffap-read-only-other-window)
>       (global-set-key [remap find-file-read-only-other-frame] 'ffap-read-only-other-frame)

Message #18 received at 41410 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 41410 <at> debbugs.gnu.org
Cc: ej32u <at> protonmail.com
Subject: Re: bug#41410: Patch: Add function ffap-other-tab
Date: Mon, 25 May 2020 01:05:22 +0300

>> Attached is a patch to add a function to open files at point in another
>> tab. It is basically the same as the function ffap-other-window.
>>
>> +(defun ffap-other-tab (filename)
>> +  "Like `ffap', but put buffer in another tab.
>> +Only intended for interactive use."
>> +  (interactive (list (ffap-prompter nil " other tab")))
>> +  (pcase (save-window-excursion (find-file-at-point filename))
>> +    ((or (and (pred bufferp) b) `(,(and (pred bufferp) b) . ,_))
>> +     (switch-to-buffer-other-tab b))))
>> +
>>  (defun ffap--toggle-read-only (buffer-or-list)
>>    (dolist (buffer (if (listp buffer-or-list)
>>  		      buffer-or-list
>> @@ -2013,6 +2023,7 @@ ffap-bindings
>>
>>       (global-set-key [remap find-file-other-window] 'ffap-other-window)
>>       (global-set-key [remap find-file-other-frame] 'ffap-other-frame)
>> +     (global-set-key [remap find-file-other-tab] 'ffap-other-tab)
>>       (global-set-key [remap find-file-read-only-other-window] 'ffap-read-only-other-window)
>>       (global-set-key [remap find-file-read-only-other-frame] 'ffap-read-only-other-frame)
>
> Thanks, this is a useful addition.  Please push it to master.

Maybe someone could check if this requires papers and
could push it to master when I'm away from computer.

Message #21 received at 41410 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>, 41410 <at> debbugs.gnu.org
Cc: ej32u <at> protonmail.com
Subject: Re: bug#41410: Patch: Add function ffap-other-tab
Date: Sun, 24 May 2020 15:26:31 -0700

Juri Linkov <juri <at> linkov.net> writes:

>>> Attached is a patch to add a function to open files at point in another
>>> tab. It is basically the same as the function ffap-other-window.
>>>
>>> +(defun ffap-other-tab (filename)
>>> +  "Like `ffap', but put buffer in another tab.
>>> +Only intended for interactive use."
>>> +  (interactive (list (ffap-prompter nil " other tab")))
>>> +  (pcase (save-window-excursion (find-file-at-point filename))
>>> +    ((or (and (pred bufferp) b) `(,(and (pred bufferp) b) . ,_))
>>> +     (switch-to-buffer-other-tab b))))
>>> +
>>>  (defun ffap--toggle-read-only (buffer-or-list)
>>>    (dolist (buffer (if (listp buffer-or-list)
>>>  		      buffer-or-list
>>> @@ -2013,6 +2023,7 @@ ffap-bindings
>>>
>>>       (global-set-key [remap find-file-other-window] 'ffap-other-window)
>>>       (global-set-key [remap find-file-other-frame] 'ffap-other-frame)
>>> +     (global-set-key [remap find-file-other-tab] 'ffap-other-tab)
>>>       (global-set-key [remap find-file-read-only-other-window] 'ffap-read-only-other-window)
>>>       (global-set-key [remap find-file-read-only-other-frame] 'ffap-read-only-other-frame)
>>
>> Thanks, this is a useful addition.  Please push it to master.
>
> Maybe someone could check if this requires papers and
> could push it to master when I'm away from computer.

OK.

I could find no previous commit by ej32u <at> protonmail.com, and this patch
is only 11 lines.  I therefore believe we could safely install it as
Copyright-paperwork-exempt.  Unless anyone disagrees with that analysis,
I'll push this to master in the next couple of days.

Best regards,
Stefan Kangas

Message #24 received at 41410 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 41410 <at> debbugs.gnu.org, ej32u <at> protonmail.com, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#41410: Patch: Add function ffap-other-tab
Date: Sun, 24 May 2020 20:46:10 -0400

tags 41410 fixed
close 41410 28.1
quit

Stefan Kangas <stefankangas <at> gmail.com> writes:

> I could find no previous commit by ej32u <at> protonmail.com, and this patch
> is only 11 lines.  I therefore believe we could safely install it as
> Copyright-paperwork-exempt.  Unless anyone disagrees with that analysis,
> I'll push this to master in the next couple of days.

There's an assignment on file for that address; I've pushed to master.

[1: 0cdedf612b]: 2020-05-24 20:45:05 -0400
  Add command ffap-other-tab (Bug#41410)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0cdedf612b9da14fccc39c4a4e81cbf400e4552f

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.