GNU bug report logs - #41395
[PATCH 0/2] gnu: Add python-questionary

Previous Next

Full log

View this message in rfc822 format

From: Marius Bakke <mbakke <at> fastmail.com>
To: Edouard Klein <edk <at> beaver-labs.com>, 41395 <at> debbugs.gnu.org
Subject: [bug#41395] [PATCH 2/2] gnu: Add python-questionary
Date: Sat, 23 May 2020 20:39:17 +0200

[Message part 1 (text/plain, inline)]

Edouard Klein <edk <at> beaver-labs.com> writes:

> * /gnu/packages/python-xyz.scm (python-questionary): New variable
> * /gnu/packages/python-check.scm (python-pytest-pycodestyle): New variable

Can you submit these packages as two separate patches?

[...]

> +(define-public python-pytest-pycodestyle
> +  (package
> +    (name "python-pytest-pycodestyle")
> +    (version "2.0.0")  ;; Any version higher than that requires python-pytest~=5.4
> +    ;; (python-pytest is at version 5.3.5 as I write this comment
> +    ;; and 5478 packages depend on it.)

You can create a 'python-pytest-5.4' variable instead of sticking to
this old version, we'll probably need it sooner or later.  No strong
opinion though.

[...]

> +(define-public python-questionary
> +  (package
> +   (name "python-questionary")
> +   (version "1.5.2")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (pypi-uri "questionary" version))
> +     (sha256
> +      (base32
> +       "09n737qmvzbibl8hmbd5zfg1502fd9n0r8qjzz1y0vy8nqv1xr7n"))))
> +   (build-system python-build-system)
> +   (propagated-inputs
> +    `(("python-prompt-toolkit" ,python-prompt-toolkit)))
> +   (native-inputs
> +    `(("python-coveralls" ,python-coveralls)
> +      ("python-pytest-cov" ,python-pytest-cov)
> +      ("python-pytest-pycodestyle"
> +       ,python-pytest-pycodestyle)
> +      ))

These parens feel lonely.  :-)

> +   (arguments
> +    `(#:phases
> +      (modify-phases %standard-phases
> +        (replace 'check
> +          (lambda _
> +            (invoke "py.test"))))))
> +   (home-page "https://github.com/tmbo/questionary")
> +   (synopsis
> +    "Pretty command line user prompts")

The line break here is not necessary.

LGTM with these changes, can you send updated patches?

Thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.