Subject: Re: [bug#41395] [PATCH 2/4] gnu: Update python-prompt-toolkit to version 3.0.5

From: Edouard Klein <[email-masked]>
Date: Tue, 26 May 2020 13:39:09 +0200

Marius Bakke writes:

> Edouard Klein <[email-masked]> writes:
>
>> * gnu/packages/machine-learning.scm (python-iml): Move python-nose from
>> propagated to native input.
>
> Can you submit this change as a separate patch, as it is unrelated to
> the python-prompt-toolkit update?
>
> [...]
Done

>
>> @@ -12105,14 +12108,14 @@ collections of data.")
>>  (define-public python-prompt-toolkit
>>    (package
>>      (name "python-prompt-toolkit")
>> -    (version "2.0.7")
>> +    (version "3.0.5")
>>      (source
>>       (origin
>>         (method url-fetch)
>> -       (uri (pypi-uri "prompt_toolkit" version ".tar.gz"))
>> +       (uri (pypi-uri "prompt_toolkit" version))
>>         (sha256
>>          (base32
>> -         "0fgacqk73w7s932vy46pan2yp8rvjmlkag20xvaydh9mhf6h85zx"))))
>> +         "1j3x5s4gp4ih73sbcni0a0vffbzvrxbrbnkvb3fzjgxn810ilgan"))))
>>      (build-system python-build-system)
>>      (arguments
>>       `(#:phases
>> @@ -12126,12 +12129,11 @@ collections of data.")
>>               (add-installed-pythonpath inputs outputs)
>>               (invoke "py.test"))))))
>>      (propagated-inputs
>> -     `(("python-wcwidth" ,python-wcwidth)
>> -       ("python-six" ,python-six)
>> -       ("python-pygments" ,python-pygments)))
>> +     `(("python-wcwidth" ,python-wcwidth)))
>
> I think you need to re-add these inputs in 'python-prompt-toolkit-2'.
> 'python2-prompt-toolkit' should probably inherit from
> 'python-prompt-toolkit-2' too, given that the dependency on Six is
> removed in version 3.
>
That makes sense, done.

> Finally 'python-prompt-toolkit-1' (!!!) also needs to inherit from
> 'python-prompt-toolkit-2' so that the inputs don't change, unless
> version 1 can be removed entirely.

I grepped and did not find any user anywhere so I went ahead and removed it.

> Quite the cabal!