GNU bug report logs - #41392
[PATCH] Upgrade python-argcomplete to 1.11.1

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41392 in the body.
You can then email your comments to 41392 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Upgrade python-argcomplete to 1.11.1
Date: Tue, 19 May 2020 09:32:09 +0200

[Message part 1 (text/plain, inline)]

Hi,

the attached patch upgrades python-argcomplete to version 1.11.1 and includes a
fix from git for the testsuite and fish>=3.1.

Cheers,
Lars

[0001-gnu-python-argcomplete-Update-to-1.11.1.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41392 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>, 41392 <at> debbugs.gnu.org
Subject: Re: [bug#41392] [PATCH] Upgrade python-argcomplete to 1.11.1
Date: Wed, 20 May 2020 22:47:36 +0200

[Message part 1 (text/plain, inline)]

Lars-Dominik Braun <ldb <at> leibniz-psychology.org> writes:

> Hi,
>
> the attached patch upgrades python-argcomplete to version 1.11.1 and includes a
> fix from git for the testsuite and fish>=3.1.

Thanks!  A few small nit-picks:

> From f72dc474ff2e0ded162661b5c845371cb48c936d Mon Sep 17 00:00:00 2001
> From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
> Date: Tue, 19 May 2020 09:24:03 +0200
> Subject: [PATCH] gnu: python-argcomplete: Update to 1.11.1

Please use punctuations in commit messages.

> * gnu/packages/python-xyz.scm (python-argcomplete)[version]: Upgrade
> [arguments]: Remove, obsolete

Also mention the removed [inputs].

> * gnu/packages/patches/python-argcomplete-1.11.1-fish31.patch: Add fix for fish 3.1
> * gnu/local.mk (dist_patch_DATA): Add new file

Here it should say something along the lines of "...fish31.patch": New file.
...(dist_patch_DATA): Add it.

See the commit log for examples.

> diff --git a/gnu/packages/patches/python-argcomplete-1.11.1-fish31.patch b/gnu/packages/patches/python-argcomplete-1.11.1-fish31.patch
> new file mode 100644
> index 0000000000..575c8abbb7
> --- /dev/null
> +++ b/gnu/packages/patches/python-argcomplete-1.11.1-fish31.patch
> @@ -0,0 +1,35 @@
> +From 08bfc8a788e8081515d733e67be026d051c726f7 Mon Sep 17 00:00:00 2001
> +From: Evan <evanunderscore <at> gmail.com>
> +Date: Thu, 19 Mar 2020 14:55:07 +1100
> +Subject: [PATCH] Remove expected test failure for new versions of fish (#292)
> +
> +---
> + test/test.py | 7 ++++++-
> + 1 file changed, 6 insertions(+), 1 deletion(-)
> +

Finally, can you remove this git patch header, and instead add a short
free-style comment about what the patch does, and where it comes from
(URL)?  See other patches for examples.

Very minor issues, but getting these right will get your patches merged
faster in the future.  ;-)

Can you send an updated patch?  TIA!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41392 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 41392 <at> debbugs.gnu.org
Subject: Re: [bug#41392] [PATCH] Upgrade python-argcomplete to 1.11.1
Date: Fri, 22 May 2020 08:31:35 +0200

[Message part 1 (text/plain, inline)]

Hi,

> Please use punctuations in commit messages.
> Also mention the removed [inputs].
> Here it should say something along the lines of "...fish31.patch": New file.
> ...(dist_patch_DATA): Add it.
> Finally, can you remove this git patch header, and instead add a short
> free-style comment about what the patch does, and where it comes from
> (URL)?  See other patches for examples.
all done. See attached updated patch.

Cheers,
Lars

[0001-gnu-python-argcomplete-Update-to-1.11.1.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 41392-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 41392-done <at> debbugs.gnu.org
Subject: Re: [bug#41392] [PATCH] Upgrade python-argcomplete to 1.11.1
Date: Sat, 23 May 2020 20:07:30 +0200

[Message part 1 (text/plain, inline)]

Lars-Dominik Braun <ldb <at> leibniz-psychology.org> writes:

> Hi,
>
>> Please use punctuations in commit messages.
>> Also mention the removed [inputs].
>> Here it should say something along the lines of "...fish31.patch": New file.
>> ...(dist_patch_DATA): Add it.
>> Finally, can you remove this git patch header, and instead add a short
>> free-style comment about what the patch does, and where it comes from
>> (URL)?  See other patches for examples.
> all done. See attached updated patch.

Perfect, applied!

I noticed it broke the Python 2 variant, but it only has a single
dependency and is probably not worth fixing.  Let's see if anyone
complains and instead remove it later.  :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.