GNU bug report logs - #41385
[PATCH] Show eww bookmarks buffer only if it's not empty

Previous Next

Full log

Message #11 received at 41385 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 41385 <at> debbugs.gnu.org
Subject: Re: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not
 empty
Date: Tue, 19 May 2020 20:44:30 -0700

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I don't think this is an ideal way to fix this command -- using error
> handling to do control flow is usually the wrong thing to do, and it
> makes debugging difficult.  What if there's a real bug in
> eww-bookmark-prepare?
>
> Instead eww-list-bookmarks should just do the
>
>   (eww-read-bookmarks)
>   (unless eww-bookmarks
>     (user-error "No bookmarks are defined"))
>
> bit, I think.  It might mean rearranging some stuff in eww-next-bookmark
> etc, though.

Thanks, good point.  Does the attached patch look better?

Best regards,
Stefan Kangas

[0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.