From unknown Mon Jun 16 23:39:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41385 <41385@debbugs.gnu.org> To: bug#41385 <41385@debbugs.gnu.org> Subject: Status: [PATCH] Show eww bookmarks buffer only if it's not empty Reply-To: bug#41385 <41385@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:39:25 +0000 retitle 41385 [PATCH] Show eww bookmarks buffer only if it's not empty reassign 41385 emacs submitter 41385 Stefan Kangas severity 41385 minor tag 41385 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 18 20:51:12 2020 Received: (at submit) by debbugs.gnu.org; 19 May 2020 00:51:12 +0000 Received: from localhost ([127.0.0.1]:48630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaqTQ-0006J9-3b for submit@debbugs.gnu.org; Mon, 18 May 2020 20:51:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:45622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaqTN-0006J0-EH for submit@debbugs.gnu.org; Mon, 18 May 2020 20:51:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaqTN-0001lQ-6B for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 20:51:09 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:40594) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaqTM-0006i1-4Z for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 20:51:08 -0400 Received: by mail-qk1-f176.google.com with SMTP id g185so12677402qke.7 for ; Mon, 18 May 2020 17:51:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=Xjat/P8OVCAV9uCizrEkSxjDYiPs1ynXkB2sOzuaP3Q=; b=QCwcAgt2WuHxzCKVioDWMtYKc4WdElY1EQbrXbop6MTQ9LCANT16KjHPuLZ8n1hFsE KdWFWd6GyuRET+09WHEy8zpw8wxV866qXmwLXr8JtpZAUtmLjf99hV/MnVhtztUojg7/ r1n1Xmh4b6EkMbKbI4Ah3/cFg/pR2ErCQSzGiUZ7lt1CTmeyphC0Xt5St/b0u7krqVLY 2fdr1meVJeN0hQoPJjsK3qqwbOZvXLbbr7WHKrI+Fprk1W7VSanx7JcPqnaxpuMypoOW xbJZgY0kcNsmaZzEP2YqSM8HDxr/a57Wzf4vHhgGXKuosCAs/gkif7P82ko8XIlePrjq K/mQ== X-Gm-Message-State: AOAM532G+OF85msR2D3xviVolig/KdXpp1k7QirGCbpZqwY18cacIXtd FmOCWcEOLNYnHrThRyS5s8zUaDdf4RfVo+TU/ShcKg== X-Google-Smtp-Source: ABdhPJx3r2XjA3gl645XG02hQGYcdqH3xb/cvu5phpznqJZc55lpofaxBLZFhSD8cANueBQj0Xp1mtQ8wkR54mqyA+4= X-Received: by 2002:a25:5f52:: with SMTP id h18mr15659913ybm.231.1589849466908; Mon, 18 May 2020 17:51:06 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 18 May 2020 17:51:06 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 18 May 2020 17:51:06 -0700 Message-ID: Subject: [PATCH] Show eww bookmarks buffer only if it's not empty To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000b8ddef05a5f5accd" Received-SPF: pass client-ip=209.85.222.176; envelope-from=stefankangas@gmail.com; helo=mail-qk1-f176.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/18 20:51:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Severity: minor X-Debbugs-CC: larsi@gnus.org Please see the attached patch which fixes a minor annoyance with eww-list-bookmarks. Best regards, Stefan Kangas Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --000000000000b8ddef05a5f5accd Content-Type: text/plain; charset="UTF-8" Severity: minor X-Debbugs-CC: larsi@gnus.org Please see the attached patch which fixes a minor annoyance with eww-list-bookmarks. Best regards, Stefan Kangas --000000000000b8ddef05a5f5accd Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch" Content-Disposition: attachment; filename="0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 8861e3a14e77bfac_0.1 RnJvbSBmZjVjODEyMDk1NWE4YzBhMjNjYWZlNWUwY2I2ODIxZGMxNTRmNzJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDE5IE1heSAyMDIwIDAyOjQzOjE2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U2hvdyBld3cgYm9va21hcmtzIGJ1ZmZlciBvbmx5IGlmIGl0J3Mgbm90IGVtcHR5CgoqIGxpc3Av bmV0L2V3dy5lbCAoZXd3LWxpc3QtYm9va21hcmtzKTogRG9uJ3Qgc2hvdyBidWZmZXIgaWYgdGhl cmUKYXJlIG5vIGJvb2ttYXJrcy4KLS0tCiBsaXNwL25ldC9ld3cuZWwgfCA5ICsrKysrKystLQog MSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL25ldC9ld3cuZWwgYi9saXNwL25ldC9ld3cuZWwKaW5kZXggYTZjMWFiZGJiMS4u ZjI0YWRhNjI4NyAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZXd3LmVsCisrKyBiL2xpc3AvbmV0L2V3 dy5lbApAQCAtMTc1NCw4ICsxNzU0LDEzIEBAIGV3dy1yZWFkLWJvb2ttYXJrcwogKGRlZnVuIGV3 dy1saXN0LWJvb2ttYXJrcyAoKQogICAiRGlzcGxheSB0aGUgYm9va21hcmtzLiIKICAgKGludGVy YWN0aXZlKQotICAocG9wLXRvLWJ1ZmZlciAiKmV3dyBib29rbWFya3MqIikKLSAgKGV3dy1ib29r bWFyay1wcmVwYXJlKSkKKyAgKGxldCAoKGJ1ZiAoZ2V0LWJ1ZmZlci1jcmVhdGUgIipld3cgYm9v a21hcmtzKiIpKSBuby1lcnJvcikKKyAgICAodW53aW5kLXByb3RlY3QKKyAgICAgICAgKHByb2du CisgICAgICAgICAgKHBvcC10by1idWZmZXIgYnVmKQorICAgICAgICAgIChld3ctYm9va21hcmst cHJlcGFyZSkKKyAgICAgICAgICAoc2V0cSBuby1lcnJvciB0KSkKKyAgICAgICh3aGVuIChub3Qg bm8tZXJyb3IpIChraWxsLWJ1ZmZlciBidWYpKSkpKQogCiAoZGVmdW4gZXd3LWJvb2ttYXJrLXBy ZXBhcmUgKCkKICAgKGV3dy1yZWFkLWJvb2ttYXJrcykKLS0gCjIuMjYuMgoK --000000000000b8ddef05a5f5accd-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 08:34:59 2020 Received: (at 41385) by debbugs.gnu.org; 19 May 2020 12:34:59 +0000 Received: from localhost ([127.0.0.1]:49522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb1SV-0007ev-4R for submit@debbugs.gnu.org; Tue, 19 May 2020 08:34:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb1ST-0007eb-NC for 41385@debbugs.gnu.org; Tue, 19 May 2020 08:34:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J27z3dECfFNh6egcWo98vwkE9jNNeqE92xaiOhO7lIs=; b=c0DoiHWen6+siQrG4Vjf1iv0Uy elsaU+uaOeqlDDWL33s5QBKc1Y64hoEAINDGVtWXS3knFz5NUtvKcfU5Q6Pgq8w1T4hX20SZf+/pH Cn0wq/s0K0FHh5HoFsWcz9j2pNXHYHjn+Ig5E6Rn+FZQTzzJ5IpJNLct261aZL9BHry4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jb1SI-0000XJ-Fe; Tue, 19 May 2020 14:34:50 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty References: Date: Tue, 19 May 2020 14:34:45 +0200 In-Reply-To: (Stefan Kangas's message of "Mon, 18 May 2020 17:51:06 -0700") Message-ID: <87ftbwrtlm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > Please see the attached patch which fixes a minor annoyance with > eww-list-bookmarks. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41385 Cc: 41385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Please see the attached patch which fixes a minor annoyance with > eww-list-bookmarks. [...] > - (pop-to-buffer "*eww bookmarks*") > - (eww-bookmark-prepare)) > + (let ((buf (get-buffer-create "*eww bookmarks*")) no-error) > + (unwind-protect > + (progn > + (pop-to-buffer buf) > + (eww-bookmark-prepare) > + (setq no-error t)) > + (when (not no-error) (kill-buffer buf))))) I don't think this is an ideal way to fix this command -- using error handling to do control flow is usually the wrong thing to do, and it makes debugging difficult. What if there's a real bug in eww-bookmark-prepare? Instead eww-list-bookmarks should just do the (eww-read-bookmarks) (unless eww-bookmarks (user-error "No bookmarks are defined")) bit, I think. It might mean rearranging some stuff in eww-next-bookmark etc, though. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 23:44:38 2020 Received: (at 41385) by debbugs.gnu.org; 20 May 2020 03:44:38 +0000 Received: from localhost ([127.0.0.1]:51798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbFeo-0007RO-HP for submit@debbugs.gnu.org; Tue, 19 May 2020 23:44:38 -0400 Received: from mail-yb1-f194.google.com ([209.85.219.194]:40873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbFen-0007RB-6w for 41385@debbugs.gnu.org; Tue, 19 May 2020 23:44:37 -0400 Received: by mail-yb1-f194.google.com with SMTP id c2so268369ybi.7 for <41385@debbugs.gnu.org>; Tue, 19 May 2020 20:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=pE1dQmorQuS22PCiOkbLFFB9rZuGIBcXsMSGhsihcx8=; b=Z1KyKQMJACTt3a7g5HWdOi4kCS8VGOzsutf/7yxT2ynEdBHGfNFAYBVuXfMFhfTJHt mJnZb5/pHLZOquOKdwqG0DyvmomN/E2poDEbUuO4Jutk4/UxbmrJPZtvkbssk6ksQS9v +rJFf9R773XyHcalz+99G8QuiPwXX1smpVVOPp1fPJ8l4HO/J+l0NM1ORO5wUtKRB+RX tsifyDbebU5zxg/q+8hto+Bb5zqleAp0Tpsa5ZsKyGw2ECKbd7RSE98A6oqhNDHf8fEC 4U8NF1CfecFY0MiLWyWOMHHBi1mDWpn1X29JzPcG123uCX3k+N0h1xH39shSmO72KJ6d HTlA== X-Gm-Message-State: AOAM533xXgnVdQPk3CuC2KW7FrVY+i4gdoiT492bI938e/UC2W/VEPOP NGMhJGm6244rxovS9SHEo4WvksxeAmcHMqPw43g= X-Google-Smtp-Source: ABdhPJwtIGJsMKLu26ralUVw6B1ikEfqutnTLEwbSq94sknZkAqTJN4LERWSIEBdKLzwEZskvOyIUiXQSCfcKSZuBEg= X-Received: by 2002:a25:ad4c:: with SMTP id l12mr4181249ybe.389.1589946271519; Tue, 19 May 2020 20:44:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 May 2020 20:44:30 -0700 From: Stefan Kangas In-Reply-To: <87ftbwrtlm.fsf@gnus.org> References: <87ftbwrtlm.fsf@gnus.org> MIME-Version: 1.0 Date: Tue, 19 May 2020 20:44:30 -0700 Message-ID: Subject: Re: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="000000000000ba1b0a05a60c3656" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41385 Cc: 41385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --000000000000ba1b0a05a60c3656 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > I don't think this is an ideal way to fix this command -- using error > handling to do control flow is usually the wrong thing to do, and it > makes debugging difficult. What if there's a real bug in > eww-bookmark-prepare? > > Instead eww-list-bookmarks should just do the > > (eww-read-bookmarks) > (unless eww-bookmarks > (user-error "No bookmarks are defined")) > > bit, I think. It might mean rearranging some stuff in eww-next-bookmark > etc, though. Thanks, good point. Does the attached patch look better? Best regards, Stefan Kangas --000000000000ba1b0a05a60c3656 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch" Content-Disposition: attachment; filename="0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: d52d17460c82e716_0.1 RnJvbSAxOGE2YWVjMGM4YzI0MjUwZmNkMTA1ZDUzOGJkZGNkZjkwN2MwZTVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDE5IE1heSAyMDIwIDAyOjQzOjE2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U2hvdyBld3cgYm9va21hcmtzIGJ1ZmZlciBvbmx5IGlmIGl0J3Mgbm90IGVtcHR5CgoqIGxpc3Av bmV0L2V3dy5lbCAoZXd3LWxpc3QtYm9va21hcmtzKTogRG9uJ3Qgc2hvdyBidWZmZXIgaWYgdGhl cmUKYXJlIG5vIGJvb2ttYXJrcy4gIChCdWcjNDEzODUpCihld3ctYm9va21hcmstcHJlcGFyZSk6 IE1vdmUgc2lnbmFsbGluZyBhbiBlcnJvciBpZiB0aGVyZSBhcmUgbm8KYm9va21hcmtzIGZyb20g aGVyZS4uLgooZXd3LXJlYWQtYm9va21hcmtzKTogLi4udG8gaGVyZS4gIEFkZCBuZXcgYXJndW1l bnQgYGVycm9yLW91dCcgdG8KY29udHJvbCB0aGlzLgooZXd3LW5leHQtYm9va21hcmssIGV3dy1w cmV2aW91cy1ib29rbWFyayk6IENhbGwgYGV3dy1yZWFkLWJvb2ttYXJrcycuCi0tLQogbGlzcC9u ZXQvZXd3LmVsIHwgMTQgKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvZXd3LmVsIGIvbGlz cC9uZXQvZXd3LmVsCmluZGV4IGE2YzFhYmRiYjEuLjg0MTU0YzUwMmQgMTAwNjQ0Ci0tLSBhL2xp c3AvbmV0L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTE3NDIsMjUgKzE3NDIsMjcg QEAgZXd3LXdyaXRlLWJvb2ttYXJrcwogICAgIChpbnNlcnQgIjs7IEF1dG8tZ2VuZXJhdGVkIGZp bGU7IGRvbid0IGVkaXQgLSotIG1vZGU6IGxpc3AtZGF0YSAtKi1cbiIpCiAgICAgKHBwIGV3dy1i b29rbWFya3MgKGN1cnJlbnQtYnVmZmVyKSkpKQogCi0oZGVmdW4gZXd3LXJlYWQtYm9va21hcmtz ICgpCisoZGVmdW4gZXd3LXJlYWQtYm9va21hcmtzICgmb3B0aW9uYWwgZXJyb3Itb3V0KQorICAi UmVhZCBib29rbWFya3MgZnJvbSBgZXd3LWJvb2ttYXJrcycuCitJZiBFUlJPUi1PVVQsIHNpZ25h bCB1c2VyLWVycm9yIGlmIHRoZXJlIGFyZSBubyBib29rbWFya3MuIgogICAobGV0ICgoZmlsZSAo ZXhwYW5kLWZpbGUtbmFtZSAiZXd3LWJvb2ttYXJrcyIgZXd3LWJvb2ttYXJrcy1kaXJlY3Rvcnkp KSkKICAgICAoc2V0cSBld3ctYm9va21hcmtzCiAJICAodW5sZXNzICh6ZXJvcCAob3IgKGZpbGUt YXR0cmlidXRlLXNpemUgKGZpbGUtYXR0cmlidXRlcyBmaWxlKSkgMCkpCiAJICAgICh3aXRoLXRl bXAtYnVmZmVyCiAJICAgICAgKGluc2VydC1maWxlLWNvbnRlbnRzIGZpbGUpCi0JICAgICAgKHJl YWQgKGN1cnJlbnQtYnVmZmVyKSkpKSkpKQorCSAgICAgIChyZWFkIChjdXJyZW50LWJ1ZmZlcikp KSkpCisgICAgKHdoZW4gKGFuZCBlcnJvci1vdXQgKG5vdCBld3ctYm9va21hcmtzKSkKKyAgICAg ICh1c2VyLWVycm9yICJObyBib29rbWFya3MgYXJlIGRlZmluZWQiKSkpKQogCiA7OzsjIyNhdXRv bG9hZAogKGRlZnVuIGV3dy1saXN0LWJvb2ttYXJrcyAoKQogICAiRGlzcGxheSB0aGUgYm9va21h cmtzLiIKICAgKGludGVyYWN0aXZlKQorICAoZXd3LXJlYWQtYm9va21hcmtzIHQpCiAgIChwb3At dG8tYnVmZmVyICIqZXd3IGJvb2ttYXJrcyoiKQogICAoZXd3LWJvb2ttYXJrLXByZXBhcmUpKQog CiAoZGVmdW4gZXd3LWJvb2ttYXJrLXByZXBhcmUgKCkKLSAgKGV3dy1yZWFkLWJvb2ttYXJrcykK LSAgKHVubGVzcyBld3ctYm9va21hcmtzCi0gICAgKHVzZXItZXJyb3IgIk5vIGJvb2ttYXJrcyBh cmUgZGVmaW5lZCIpKQogICAoc2V0LWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgIipld3cgYm9v a21hcmtzKiIpKQogICAoZXd3LWJvb2ttYXJrLW1vZGUpCiAgIChsZXQqICgod2lkdGggKC8gKHdp bmRvdy13aWR0aCkgMikpCkBAIC0xODI4LDYgKzE4MzAsNyBAQCBld3ctbmV4dC1ib29rbWFyawog CWJvb2ttYXJrKQogICAgICh1bmxlc3MgKGdldC1idWZmZXIgIipld3cgYm9va21hcmtzKiIpCiAg ICAgICAoc2V0cSBmaXJzdCB0KQorICAgICAgKGV3dy1yZWFkLWJvb2ttYXJrcyB0KQogICAgICAg KGV3dy1ib29rbWFyay1wcmVwYXJlKSkKICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAoZ2V0LWJ1 ZmZlciAiKmV3dyBib29rbWFya3MqIikKICAgICAgICh3aGVuIChhbmQgKG5vdCBmaXJzdCkKQEAg LTE4NDYsNiArMTg0OSw3IEBAIGV3dy1wcmV2aW91cy1ib29rbWFyawogCWJvb2ttYXJrKQogICAg ICh1bmxlc3MgKGdldC1idWZmZXIgIipld3cgYm9va21hcmtzKiIpCiAgICAgICAoc2V0cSBmaXJz dCB0KQorICAgICAgKGV3dy1yZWFkLWJvb2ttYXJrcyB0KQogICAgICAgKGV3dy1ib29rbWFyay1w cmVwYXJlKSkKICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAoZ2V0LWJ1ZmZlciAiKmV3dyBib29r bWFya3MqIikKICAgICAgIChpZiBmaXJzdAotLSAKMi4yNi4yCgo= --000000000000ba1b0a05a60c3656-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 11:25:24 2020 Received: (at 41385) by debbugs.gnu.org; 10 Jun 2020 15:25:24 +0000 Received: from localhost ([127.0.0.1]:35122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2bU-0001H1-8a for submit@debbugs.gnu.org; Wed, 10 Jun 2020 11:25:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2bP-0001Gi-Ou for 41385@debbugs.gnu.org; Wed, 10 Jun 2020 11:25:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8BJi5oAbq0+RrqXj27tsP/BvYf1bHCcwIFE5JMGdJnE=; b=d1rdSkk/f+k5w9CTo4vHLxu9u+ SOulo3+gQ20JoYVbXacx7I0f0izAhUGJfvaXvloIj3UGZoJISGVZxOkSwxzAlofD8EAudfvTQxxQe aCbSYTXtbAi3Esa2/4/Kk0QbgFA9nruRkiJtS239ntuND62JXn5p5zaoQL/XIWnURiss=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj2bF-0005d8-Rl; Wed, 10 Jun 2020 17:25:12 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty References: <87ftbwrtlm.fsf@gnus.org> Date: Wed, 10 Jun 2020 17:25:09 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 19 May 2020 20:44:30 -0700") Message-ID: <87d0679c4q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > Thanks, good point. Does the attached patch look better? Yup; looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41385 Cc: 41385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Thanks, good point. Does the attached patch look better? Yup; looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 21:24:14 2020 Received: (at 41385) by debbugs.gnu.org; 17 Jul 2020 01:24:14 +0000 Received: from localhost ([127.0.0.1]:56296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwF6k-00081u-GX for submit@debbugs.gnu.org; Thu, 16 Jul 2020 21:24:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwF6j-00081i-22 for 41385@debbugs.gnu.org; Thu, 16 Jul 2020 21:24:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qm84teKqWbxAGlsoHENrkVAdUNTbTYSg/ZS5blKZLvA=; b=GCmI6XkHa98GKLrxsQupoaeU7W 5g++wZCUDJlPvbj3xnKAIG5xNvUxEPQbPhhV5OMj89ZrNMWZqaVIGeLrl/x7bV9dVi127g3vd0x6V LbNQXA9im5aRPn3LayzvvbqZ4izNHQSH0OzRsR6Yov269lt4qB5ysjoeQ8HQ/hyUfCVU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwF6Y-00058M-Ic; Fri, 17 Jul 2020 03:24:06 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty References: <87ftbwrtlm.fsf@gnus.org> <87d0679c4q.fsf@gnus.org> Date: Fri, 17 Jul 2020 03:24:01 +0200 In-Reply-To: <87d0679c4q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 10 Jun 2020 17:25:09 +0200") Message-ID: <87eepborwu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> Thanks, good point. Does the attached patch look better? > > Yup; looks good to me. That was five weeks ago, and I'm triaging shr/eww bugs tonight, so I went ahead and applied the patch. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41385 Cc: 41385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> Thanks, good point. Does the attached patch look better? > > Yup; looks good to me. That was five weeks ago, and I'm triaging shr/eww bugs tonight, so I went ahead and applied the patch. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 21:24:22 2020 Received: (at control) by debbugs.gnu.org; 17 Jul 2020 01:24:22 +0000 Received: from localhost ([127.0.0.1]:56299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwF6r-00082K-Oq for submit@debbugs.gnu.org; Thu, 16 Jul 2020 21:24:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwF6q-000822-77 for control@debbugs.gnu.org; Thu, 16 Jul 2020 21:24:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wefD/KOXPxBdhRxWPLz95+DHZin4QVuwWksYDXRU78E=; b=p9XbvK8nbZupEgSGgLxqeUaioq XNgqPUF2bwBOrJ3jUMMOu+AMyiiVzFuSkBE0JNyvAGp7Ja1WEsZjWCTddN8Q6koOIBh3JSZytS4Nu xP9xwfOR2l3XCZ5bq/3QJklATfotWhSRIwPPSTC2kyUnlTP0B1VvDpclp4J2l937aQdQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwF6i-00058b-Dp for control@debbugs.gnu.org; Fri, 17 Jul 2020 03:24:14 +0200 Date: Fri, 17 Jul 2020 03:24:11 +0200 Message-Id: <87d04vorwk.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41385 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 41385 fixed close 41385 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 41385 fixed close 41385 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 29 06:29:38 2020 Received: (at 41385) by debbugs.gnu.org; 29 Jul 2020 10:29:38 +0000 Received: from localhost ([127.0.0.1]:60182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0jL8-0002V9-3a for submit@debbugs.gnu.org; Wed, 29 Jul 2020 06:29:38 -0400 Received: from mail-yb1-f196.google.com ([209.85.219.196]:43139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0jL2-0002Us-Hu for 41385@debbugs.gnu.org; Wed, 29 Jul 2020 06:29:36 -0400 Received: by mail-yb1-f196.google.com with SMTP id m200so8114333ybf.10 for <41385@debbugs.gnu.org>; Wed, 29 Jul 2020 03:29:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vZOnO46SbZXhjoh68McoSX3goT676DkFzBd6MnVBE/g=; b=myEFfK9fP+9wf9WiN2PPAHfyhGu/hNBMv89VXpbd1NmMZOuscJ+PR0Xntz1GvKmn9D CY7MSuM/CsjH1S2Y6NG8dwv3FjQdQXmnR7lIOiklTRzHRuu+Dk33/4c5oWwt3X45C++y rE8jIdHPjUcTEFXwxPWxuk+mD0zeD2RrkNu8Lt9DEbGzxAGrfw08CfORnC5lOI5stykd aZV60jzIidC8eB6XqjWD/oX3yP6aHfKwL9rtSjnwSf7osjOjEUQP8pzCiIKng+utN3d+ U+Zd8aQiw+CNGs4Jn5Z2UbsPjbXccDP4x1BOEN8QUenVNlgCUeOfnNeEQBSEGibS1jHs r6sA== X-Gm-Message-State: AOAM531LQWhbgaoJIHqPDdOREycMi+wDzkAunN3aROK69Cr/n3fHhvyy JqfOZqlopBEdKQmTmoRHKTItwNQ6e1Ne+QKz5d4= X-Google-Smtp-Source: ABdhPJzH98NcDhPvBKigdj2qnwSKykGWhfGCp/QyZziW5uDGVPUVuLqDVuITF0DP6m4bxVxnjG00qFQAkiZhEeSWvUA= X-Received: by 2002:a25:3309:: with SMTP id z9mr28987067ybz.43.1596018567097; Wed, 29 Jul 2020 03:29:27 -0700 (PDT) MIME-Version: 1.0 References: <87ftbwrtlm.fsf@gnus.org> <87d0679c4q.fsf@gnus.org> <87eepborwu.fsf@gnus.org> In-Reply-To: <87eepborwu.fsf@gnus.org> From: Stefan Kangas Date: Wed, 29 Jul 2020 12:29:16 +0200 Message-ID: Subject: Re: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41385 Cc: 41385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > That was five weeks ago, and I'm triaging shr/eww bugs tonight, so I > went ahead and applied the patch. :-) Thanks! From unknown Mon Jun 16 23:39:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Aug 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator