GNU bug report logs - #41382
[PATCH 0/6] Allow for a cryptographic hash function migration

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Mon, 18 May 2020 21:32:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41382: closed ([PATCH 0/6] Allow for a cryptographic hash
 function migration)
Date: Thu, 21 May 2020 23:44:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 22 May 2020 01:43:32 +0200
with message-id <87wo54c0rf.fsf <at> gnu.org>
and subject line Re: [bug#41382] [PATCH 0/6] Allow for a cryptographic hash function migration
has caused the debbugs.gnu.org bug report #41382,
regarding [PATCH 0/6] Allow for a cryptographic hash function migration
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41382: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41382
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/6] Allow for a cryptographic hash function migration
Date: Mon, 18 May 2020 23:31:16 +0200
Hello Guix!

This is a first stab at preparing for a possible migration to
hash algorithms other than SHA256 (there’s no rush AFAIK, but it’s
good to be prepared).  The first bits just improve tests and
adjust the tools, which doesn’t hurt.

The last bit adds a ‘sha512’ field to <origin>, which we could
eventually provide instead of or in addition to ‘sha256’, possibly
as a base64-encoded string so that it’s not too large.

Another option would be to create a <hash> data type that specifies
its algorithm and its value.  We’d replace the ‘sha256’ field with
a ‘hash’ field of that type (in a backward-compatible way).  Thinking
about it, this is perhaps the better option.

Other bits that would need to be adjusted include importer, updaters,
and ‘guix publish’.

Thoughts?

Ludo’.

Ludovic Courtès (6):
  tests: Test 'add-to-store' with several hash algorithms.
  tests: Test fixed-output derivations with several hash algorithms.
  guix hash, guix download: Add '--hash'.
  guix hash, guix download: Support base64 format.
  packages: Add 'sha512' optional field to <origin>.
  packages: Add 'base64' macro.

 doc/guix.texi             | 25 +++++++++++++++--
 guix/packages.scm         | 56 +++++++++++++++++++++++----------------
 guix/scripts/download.scm | 26 +++++++++++++-----
 guix/scripts/hash.scm     | 35 +++++++++++++++++-------
 tests/derivations.scm     | 39 ++++++++++++++++-----------
 tests/guix-hash.sh        |  7 ++++-
 tests/packages.scm        | 26 ++++++++++++++++++
 tests/store.scm           | 12 +++++++++
 8 files changed, 170 insertions(+), 56 deletions(-)

-- 
2.26.2



[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: guix-devel <at> gnu.org, 41382-done <at> debbugs.gnu.org
Subject: Re: [bug#41382] [PATCH 0/6] Allow for a cryptographic hash function
 migration
Date: Fri, 22 May 2020 01:43:32 +0200
Pushed the whole series:

  ce0be5675b packages: Introduce <content-hash> and use it in <origin>.
  56f7ca6e7c packages: Add 'base64' macro.
  0e4e9c8e76 guix hash, guix download: Support base64 format.
  18ae1ec3ec guix hash, guix download: Add '--hash'.
  9418aaa00d tests: Test fixed-output derivations with several hash algorithms.
  73b27eaa64 tests: Test 'add-to-store' with several hash algorithms.

You’ll have to recompile due to the ABI change:

  make clean-go && make

I realized several tests needed to be adjusted for proper syntax-case
matching, which I did in ce0be5675b.

Ludo’.


This bug report was last modified 5 years and 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.