From debbugs-submit-bounces@debbugs.gnu.org Sun May 17 18:36:15 2020 Received: (at submit) by debbugs.gnu.org; 17 May 2020 22:36:16 +0000 Received: from localhost ([127.0.0.1]:45063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaRtH-0006fP-GC for submit@debbugs.gnu.org; Sun, 17 May 2020 18:36:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:37974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaRtF-0006fI-UF for submit@debbugs.gnu.org; Sun, 17 May 2020 18:36:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaRtC-0006Js-3d for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 18:36:12 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:39836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaRtA-0006wd-RW for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 18:36:09 -0400 Received: by mail-wm1-x343.google.com with SMTP id w64so8236942wmg.4 for ; Sun, 17 May 2020 15:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=6dSTrrbedbSKdtezkIJTQ3q86lDJtz8BbBUFD/jVchU=; b=EzqKg0L6OEM8hpC5DcWwhmnt++4K88JRmMiLiunQiiFsQA4yVJOq4OhwSCHKPBJrVw 8GEL+veM26YkAoJ6MD1jo+8eGm21reGGDaGR81TDiN84vPMfPBsH2V49NcXc4aAClMfn ecc0OKIT060x7RzS8wRZ9Pb1p4/PCAb3aQizu/eA9Nx170Km0up9Q8Bghn0RNz5gsFhJ f37WP1wSVaR2ZqX2q7gMvcbsiGmkKQkHbpZHmuZDfrIbblrk63ohdsLNOpIoHNAC5RwA nVIZ6b56tLTyiOQDH4fjOok/oEuBQkEpabLr6LfWhisLirrf5+iPyP+zcY452NbLmJjA K8YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=6dSTrrbedbSKdtezkIJTQ3q86lDJtz8BbBUFD/jVchU=; b=HNGkvDkAGlOJZ0B3O0hcEEcGFBPCYKx3QxQtKO2Gkp3ihGB5yn7FIGwXM5ILjRt2BO 3NSzbKUBz4uMK7bfmJFy/8WPSb9rPLF5eF0iGmUxygplPHfrzJRF3bImojAV7r4Ws4zQ pF+L+tkUguzOV5KLPeKmHG3WkSUKZlG88O7noVuICh9eqmAo9woW/nqIpxcf7oqVDvJQ Ft5YoK1V7RxR4ItXJsfkgALgk+FTieqGeDQy4wKZGqHZWdjyEf50C/mVlOSxVnYtWjV6 cDy19DIofxGMOahfyAsFdTisJZnevl8nEWs04YZrGNnBskE1q2E2NQfGFbpTiwEoMCMW WnCA== X-Gm-Message-State: AOAM532q4mE1xSUWv88BtBAwS+ZP3s8MSk4ouhT0g6LhKlKtZgYaxhjm g7RD6X4wK1eYPw0TtgS4WQkLYT8qxUtYTA== X-Google-Smtp-Source: ABdhPJxXn9+yjcmHRoOWPgHuG1xuV0/2XRRr6V9CZ7QP+9sWb48qYXlJsnjjTkneVCiDPuVKSgKDlg== X-Received: by 2002:a05:600c:2f97:: with SMTP id t23mr16200560wmn.150.1589754963870; Sun, 17 May 2020 15:36:03 -0700 (PDT) Received: from carbon.localdomain (48.199.23.93.rev.sfr.net. [93.23.199.48]) by smtp.gmail.com with ESMTPSA id m6sm13164153wrq.5.2020.05.17.15.36.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2020 15:36:02 -0700 (PDT) From: Matthias Meulien To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis Date: Mon, 18 May 2020 00:35:55 +0200 Message-ID: <87imguchpw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=orontee@gmail.com; helo=mail-wm1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable When I evaluate (char-displayable-p ?=E2=80=A6) from current frame (under X= ) it evaluates to a valid font but, after I customized `tab-bar-tab-name-function` to equal `tab-bar-tab-name-truncated`, tab names are truncated using three dots characters. --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-Fix-tab-bar-tab-name-ellipsis-initialization.patch Content-Transfer-Encoding: quoted-printable >From 6482236257c99dcd411d635360ce4c1d8144b3f0 Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Mon, 18 May 2020 00:32:47 +0200 Subject: [PATCH] Fix tab-bar-tab-name-ellipsis initialization * lisp/tab-bar.el (tab-bar-tab-name-truncated): Evaluate displayable character when generating tab name. --- lisp/tab-bar.el | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index ce6d8c33dd..c327ac0967 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -376,19 +376,16 @@ tab-bar-tab-name-truncated-max :group 'tab-bar :version "27.1") =20 -(defvar tab-bar-tab-name-ellipsis - (if (char-displayable-p ?=E2=80=A6) "=E2=80=A6" "...")) - (defun tab-bar-tab-name-truncated () "Generate tab name from the buffer of the selected window. -Truncate it to the length specified by `tab-bar-tab-name-truncated-max'. -Append ellipsis `tab-bar-tab-name-ellipsis' in this case." - (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)= )))) +Truncate it to the length specified by `tab-bar-tab-name-truncated-max'." + (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)= ))) + (ellipsis (if (char-displayable-p ?=E2=80=A6) "=E2=80=A6" "..."))) (if (< (length tab-name) tab-bar-tab-name-truncated-max) tab-name (propertize (truncate-string-to-width tab-name tab-bar-tab-name-truncated-max nil nil - tab-bar-tab-name-ellipsis) + ellipsis) 'help-echo tab-name)))) =20 --=20 2.20.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable In GNU Emacs 28.0.50 (build 9, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, ca= iro version 1.16.0) of 2020-05-16 built on carbon Repository revision: 1ba4e5b5eb7360338c5ed750c8e4a2b09835f78b Repository branch: dev/mm Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Recent messages: Creating customization setup...done You can run the command =E2=80=98customize-group=E2=80=99 with M-x cu-g RET Creating customization setup...done Mark saved where search started Show the value of this option. Show or hide rest of the documentation. Show the value of this option. Choice: 2 To install your edits, invoke [State] and choose the Set operation Set all values according to this buffer? (y or n) y Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: fr_FR.UTF-8 value of $LC_TIME: fr_FR.UTF-8 value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Custom Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils seq byte-opt gv bytecomp byte-compile cconv mule-util misearch multi-isearch cus-edit easymenu cus-start cus-load wid-edit cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 67053 5417) (symbols 48 7511 1) (strings 32 19027 1185) (string-bytes 1 596724) (vectors 16 11021) (vector-slots 8 133160 11144) (floats 8 32 63) (intervals 56 484 14) (buffers 992 14)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 18:46:54 2020 Received: (at 41372) by debbugs.gnu.org; 19 May 2020 22:46:54 +0000 Received: from localhost ([127.0.0.1]:51421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbB0g-0004PP-69 for submit@debbugs.gnu.org; Tue, 19 May 2020 18:46:54 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:42555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbB0U-0004Od-Ol for 41372@debbugs.gnu.org; Tue, 19 May 2020 18:46:43 -0400 X-Originating-IP: 91.129.97.200 Received: from mail.gandi.net (m91-129-97-200.cust.tele2.ee [91.129.97.200]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CEFEF20007; Tue, 19 May 2020 22:46:35 +0000 (UTC) From: Juri Linkov To: Matthias Meulien Subject: Re: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis Organization: LINKOV.NET References: <87imguchpw.fsf@gmail.com> Date: Wed, 20 May 2020 01:35:56 +0300 In-Reply-To: <87imguchpw.fsf@gmail.com> (Matthias Meulien's message of "Mon, 18 May 2020 00:35:55 +0200") Message-ID: <87tv0b7dtf.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41372 Cc: 41372@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > When I evaluate (char-displayable-p ?…) from current frame (under X) it > evaluates to a valid font but, after I customized > `tab-bar-tab-name-function` to equal `tab-bar-tab-name-truncated`, tab > names are truncated using three dots characters. Thanks for the patch. One problem is that the patch hard-codes the ellipsis, so that the user loses the ability to configure it. A better way would be to leave defvar tab-bar-tab-name-ellipsis, but by default set its value to nil. So when it's non-nil, then use its value, otherwise use "…"/"..." by default. > -(defvar tab-bar-tab-name-ellipsis > - (if (char-displayable-p ?…) "…" "...")) > - > (defun tab-bar-tab-name-truncated () > "Generate tab name from the buffer of the selected window. > -Truncate it to the length specified by `tab-bar-tab-name-truncated-max'. > -Append ellipsis `tab-bar-tab-name-ellipsis' in this case." > - (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window))))) > +Truncate it to the length specified by `tab-bar-tab-name-truncated-max'." > + (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)))) > + (ellipsis (if (char-displayable-p ?…) "…" "..."))) > (if (< (length tab-name) tab-bar-tab-name-truncated-max) > tab-name > (propertize (truncate-string-to-width > tab-name tab-bar-tab-name-truncated-max nil nil > - tab-bar-tab-name-ellipsis) > + ellipsis) From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 15:54:26 2020 Received: (at 41372) by debbugs.gnu.org; 23 May 2020 19:54:26 +0000 Received: from localhost ([127.0.0.1]:35762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcaDx-0001cw-TY for submit@debbugs.gnu.org; Sat, 23 May 2020 15:54:26 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:35263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcaDv-0001ci-N6 for 41372@debbugs.gnu.org; Sat, 23 May 2020 15:54:24 -0400 Received: by mail-wm1-f44.google.com with SMTP id n5so13274040wmd.0 for <41372@debbugs.gnu.org>; Sat, 23 May 2020 12:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7PQNpft+QIYDSnYI+Nc7/6CSEGXwQdCkPsjU9ab3xso=; b=bGWfq9X1ZsTYIaLcxRSn5BNJM1cHnXrBtWct23GM8+RoNUS69hwTLDE60x1G5yivhW JPcUHDP974MpBgy7D6mXCmRBxLiHQ6iZ6SZhLABz3JQESbuIUHhhBg82jPZHiT9Ga7BI eqj0a1qqv2mxSpVPEf7XoMe55TsxyCtZGNlIcElc/UR9ONm93WLYScT0hvnlM3aXS9nU ciuJoSTGOZsdFUq6ePVqKbkxXOJMFRdPfgpSOu3hc1jOELAHL/nQ7jt0sD9LqefBZmtX uuqC03Dx6/wUKgpCrWByvowJwsvHXqDxJu6CUvg2NaTKLrshD957V5xDuYjOBaWJ+8X7 8G8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7PQNpft+QIYDSnYI+Nc7/6CSEGXwQdCkPsjU9ab3xso=; b=EXNrS5ycwHvbXE0H5d3GRa5qORERN0W+f+hGHWVobGUvBnmWRERZRUTY7SpK1QGX+A ANHOQ4eUdBBRSr0RynM2MT1rhXZuqBqB8UResfnif1FT7lSgWk+xKVa3nxwrhAShWkz0 CeJ0j7JupNTuhr3WsCStWt7J9elQq6pxTgYBqgH30wr2lMXa3P7OaYdOETScdNR0ebt/ AjRTy5Qe+y2V9IqglB3kN/5kjjxP+7uojknfW3d2LtHOX4pu/aN7/Huj/D2QC1GyKunV ezu0s16e/0hHxbG9hv9aozYB44DrUNJSmyxUv8tekBI0hijYqQ0OZi1NFE16rvblYNSX tbUA== X-Gm-Message-State: AOAM532x2udjN2N4q5nSknU1W1o71oq2TR7k8Rbn5zDnISuYHY/2MGRV ShtXIKSU3hOCakRDubNe6Lecx3ZNigM= X-Google-Smtp-Source: ABdhPJx3jL0LMCqI3J+GTuCP59UuUGklvdCGP1Ipxx2yBRBWjfo/fWg60+P4NcZFzWb3MHECSwMCwA== X-Received: by 2002:a05:600c:214:: with SMTP id 20mr17857126wmi.41.1590263657490; Sat, 23 May 2020 12:54:17 -0700 (PDT) Received: from carbon.localdomain ([2a01:e0a:252:7910:679d:a1d5:8917:cc97]) by smtp.gmail.com with ESMTPSA id w10sm1875042wrp.16.2020.05.23.12.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 12:54:16 -0700 (PDT) From: Matthias Meulien To: Juri Linkov Subject: Re: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis References: <87imguchpw.fsf@gmail.com> <87tv0b7dtf.fsf@mail.linkov.net> Date: Sat, 23 May 2020 21:54:14 +0200 In-Reply-To: <87tv0b7dtf.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 20 May 2020 01:35:56 +0300") Message-ID: <87d06umnq1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41372 Cc: 41372@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Juri Linkov writes: > Thanks for the patch. One problem is that the patch hard-codes=20 > the ellipsis, so that the user loses the ability to configure=20 > it.=20 >=20 > A better way would be to leave defvar tab-bar-tab-name-ellipsis,=20 > but by default set its value to nil. So when it's non-nil, then=20 > use its value, otherwise use "=E2=80=A6"/"..." by default. You're right. Here's un updated patch: --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-Fix-tab-bar-tab-name-ellipsis-initialization.patch Content-Transfer-Encoding: quoted-printable >From d607000155a21340aebd101ee5dc4a12037088d7 Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Mon, 18 May 2020 00:32:47 +0200 Subject: [PATCH] Fix tab-bar-tab-name-ellipsis initialization * lisp/tab-bar.el (tab-bar-tab-name-truncated): Evaluate displayable character when generating tab name. --- lisp/tab-bar.el | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index ce6d8c33dd..d24d59cb7e 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -376,19 +376,22 @@ tab-bar-tab-name-truncated-max :group 'tab-bar :version "27.1") =20 -(defvar tab-bar-tab-name-ellipsis - (if (char-displayable-p ?=E2=80=A6) "=E2=80=A6" "...")) +(defvar tab-bar-tab-name-ellipsis nil) =20 (defun tab-bar-tab-name-truncated () "Generate tab name from the buffer of the selected window. Truncate it to the length specified by `tab-bar-tab-name-truncated-max'. Append ellipsis `tab-bar-tab-name-ellipsis' in this case." - (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)= )))) + (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)= ))) + (ellipsis (cond + (tab-bar-tab-name-ellipsis) + ((char-displayable-p ?=E2=80=A6) "=E2=80=A6") + ("...")))) (if (< (length tab-name) tab-bar-tab-name-truncated-max) tab-name (propertize (truncate-string-to-width tab-name tab-bar-tab-name-truncated-max nil nil - tab-bar-tab-name-ellipsis) + ellipsis) 'help-echo tab-name)))) =20 --=20 2.20.1 --=-=-= Content-Type: text/plain; format=flowed -- Matthias --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 18:56:41 2020 Received: (at 41372) by debbugs.gnu.org; 23 May 2020 22:56:41 +0000 Received: from localhost ([127.0.0.1]:36004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcd4L-00088m-G4 for submit@debbugs.gnu.org; Sat, 23 May 2020 18:56:41 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:58541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcd4D-00087y-En for 41372@debbugs.gnu.org; Sat, 23 May 2020 18:56:33 -0400 Received: from mail.gandi.net (m91-129-97-200.cust.tele2.ee [91.129.97.200]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 77106100002; Sat, 23 May 2020 22:56:26 +0000 (UTC) From: Juri Linkov To: Matthias Meulien Subject: Re: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis Organization: LINKOV.NET References: <87imguchpw.fsf@gmail.com> <87tv0b7dtf.fsf@mail.linkov.net> <87d06umnq1.fsf@gmail.com> Date: Sun, 24 May 2020 01:28:12 +0300 In-Reply-To: <87d06umnq1.fsf@gmail.com> (Matthias Meulien's message of "Sat, 23 May 2020 21:54:14 +0200") Message-ID: <87pnauuw03.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41372 Cc: 41372@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Thanks for the patch. One problem is that the patch hard-codes the >> ellipsis, so that the user loses the ability to configure it. >> A better way would be to leave defvar tab-bar-tab-name-ellipsis, >> but by default set its value to nil. So when it's non-nil, then use its >> value, otherwise use "…"/"..." by default. > > You're right. Here's un updated patch: Eli, this patch should go to emacs-27? From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 22:33:58 2020 Received: (at 41372) by debbugs.gnu.org; 24 May 2020 02:33:58 +0000 Received: from localhost ([127.0.0.1]:36111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcgSc-0004l6-ED for submit@debbugs.gnu.org; Sat, 23 May 2020 22:33:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcgSa-0004ku-KH for 41372@debbugs.gnu.org; Sat, 23 May 2020 22:33:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53841) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcgSV-0005Ad-1t; Sat, 23 May 2020 22:33:51 -0400 Received: from [176.228.60.248] (port=4311 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcgST-00027o-VL; Sat, 23 May 2020 22:33:50 -0400 Date: Sun, 24 May 2020 05:33:59 +0300 Message-Id: <83k112xdrc.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87pnauuw03.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 24 May 2020 01:28:12 +0300) Subject: Re: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis References: <87imguchpw.fsf@gmail.com> <87tv0b7dtf.fsf@mail.linkov.net> <87d06umnq1.fsf@gmail.com> <87pnauuw03.fsf@mail.linkov.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41372 Cc: 41372@debbugs.gnu.org, orontee@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Sun, 24 May 2020 01:28:12 +0300 > Cc: 41372@debbugs.gnu.org > > >> Thanks for the patch. One problem is that the patch hard-codes the > >> ellipsis, so that the user loses the ability to configure it. > >> A better way would be to leave defvar tab-bar-tab-name-ellipsis, > >> but by default set its value to nil. So when it's non-nil, then use its > >> value, otherwise use "…"/"..." by default. > > > > You're right. Here's un updated patch: > > Eli, this patch should go to emacs-27? I'm okay with doing that on emacs-27, yes. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun May 24 18:10:27 2020 Received: (at 41372) by debbugs.gnu.org; 24 May 2020 22:10:27 +0000 Received: from localhost ([127.0.0.1]:38993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcyp8-0000AS-Mv for submit@debbugs.gnu.org; Sun, 24 May 2020 18:10:26 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:23981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcyp7-00009w-0v; Sun, 24 May 2020 18:10:25 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 62D3E240002; Sun, 24 May 2020 22:10:16 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis Organization: LINKOV.NET References: <87imguchpw.fsf@gmail.com> <87tv0b7dtf.fsf@mail.linkov.net> <87d06umnq1.fsf@gmail.com> <87pnauuw03.fsf@mail.linkov.net> <83k112xdrc.fsf@gnu.org> Date: Mon, 25 May 2020 01:02:05 +0300 In-Reply-To: <83k112xdrc.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 May 2020 05:33:59 +0300") Message-ID: <87imgluh42.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41372 Cc: 41372@debbugs.gnu.org, orontee@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 41372 fixed close 41372 27.1 thanks >> >> Thanks for the patch. One problem is that the patch hard-codes the >> >> ellipsis, so that the user loses the ability to configure it. >> >> A better way would be to leave defvar tab-bar-tab-name-ellipsis, >> >> but by default set its value to nil. So when it's non-nil, then use its >> >> value, otherwise use "…"/"..." by default. >> > >> > You're right. Here's un updated patch: >> >> Eli, this patch should go to emacs-27? > > I'm okay with doing that on emacs-27, yes. Now pushed to emacs-27. From unknown Tue Jun 17 01:36:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jun 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator