GNU bug report logs - #41360
[PATCH 00/12] Package java-openjfx

Previous Next

Full log

Message #50 received at 41360 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: 41360 <at> debbugs.gnu.org
Subject: Re: [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable.
Date: Sat, 23 May 2020 16:09:47 +0200

Alexey Abramov <levenson <at> mmer.org> skribis:

> ---
>  gnu/packages/java.scm | 165 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 165 insertions(+)

Please add a commit log.

[...]

> +         (add-after 'build 'generate-headers
> +           (lambda* (#:key inputs #:allow-other-keys)

Could you add a comment explaining what this phase does and why we’re
doing all this?  (Same for the other phases.)

> +             (let* ((module (string-append (getcwd) "/modules/web"))
> +                    (classes (string-append module "/build/classes/java/main"))
> +                    (web-generated-headers (string-append module "/build/generated-src/headers"))
> +                    (web-generated-classes '("com.sun.webkit.ContextMenu"
> +                                             "com.sun.webkit.ContextMenuItem"
> +                                             "com.sun.webkit.CursorManager"

Perhaps add a comment explaining how you obtained this list of classes
so that our future selves know how to update it.

Since this is a Web thing, could you check whether it contains pre-built
(“minified”) JavaScript?  If it does, that’s a problem because we
generally provide only software built from source.

Could you send an updated patch series?

Thank you for the hard work!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.