Subject: bug#41358: closed (Re: [bug#41358] lm-sensors: pwmconfig is broken)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 17 May 2020 15:13:02 +0000

Your bug report

#41358: lm-sensors: pwmconfig is broken

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41358: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41358
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#41358] lm-sensors: pwmconfig is broken
From: Tobias Geerinckx-Rice <[email-masked]>
To: Nicolò Balzarotti <[email-masked]>
Cc: [email-masked]
Date: Sun, 17 May 2020 17:12:07 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Nicolò,

Nicolò Balzarotti 写道：
> The current version of lm-sensors adjust grep path in the 
> pwmconfig
> script, replacing grep->/gnu/store/.../grep.  However, the 
> script is
> using egrep, leading to the non-existant e/gnu/store/.../grep 
> path.
> The attached patch fixes is actually replacing 
> egrep->/gnu/store/../egrep

Thanks!

As it was, this change would in turn break fancontrol which does 
use plain ‘grep’:

   INTERVAL=$(grep -E '^INTERVAL=.*$' $1 | …

I've modified it to match either and pushed as 
074cd595bbcd343f86aad09794d8781846ff1927.

Kind regards,

T G-R

Subject: lm-sensors: pwmconfig is broken
From: [email-masked] (Nicolò Balzarotti)
To: [email-masked]
Date: Sun, 17 May 2020 14:46:25 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello guix!

The current version of lm-sensors adjust grep path in the pwmconfig
script, replacing grep->/gnu/store/.../grep.  However, the script is
using egrep, leading to the non-existant e/gnu/store/.../grep path.
The attached patch fixes is actually replacing egrep->/gnu/store/../egrep

Thanks!

>From 1a0395630547868385312198659d5fda39845cbe Mon Sep 17 00:00:00 2001
From: nixo <[email-masked]>
Date: Sun, 17 May 2020 14:39:17 +0200
Subject: [PATCH] gnu: lm-sensors: Use correct egrep path.

---
 gnu/packages/linux.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 290090456f..6dd4fdf747 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3541,9 +3541,9 @@ country-specific regulations for the wireless spectrum.")
                (("cat ")
                 (string-append (assoc-ref inputs "coreutils")
                                "/bin/cat "))
-               (("grep ")
+               (("egrep ")
                 (string-append (assoc-ref inputs "grep")
-                               "/bin/grep "))
+                               "/bin/egrep "))
                (("sed -e")
                 (string-append (assoc-ref inputs "sed")
                                "/bin/sed -e"))
-- 
2.26.2