GNU bug report logs - #41358
lm-sensors: pwmconfig is broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41358 in the body.
You can then email your comments to 41358 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: anothersms <at> gmail.com (Nicolò Balzarotti)
To: guix-patches <at> gnu.org
Subject: lm-sensors: pwmconfig is broken
Date: Sun, 17 May 2020 14:46:25 +0200

[Message part 1 (text/plain, inline)]

Hello guix!

The current version of lm-sensors adjust grep path in the pwmconfig
script, replacing grep->/gnu/store/.../grep.  However, the script is
using egrep, leading to the non-existant e/gnu/store/.../grep path.
The attached patch fixes is actually replacing egrep->/gnu/store/../egrep

Thanks!

[0001-gnu-lm-sensors-Use-correct-egrep-path.patch (text/x-patch, attachment)]

Message #10 received at 41358-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: 41358-done <at> debbugs.gnu.org
Subject: Re: [bug#41358] lm-sensors: pwmconfig is broken
Date: Sun, 17 May 2020 17:12:07 +0200

[Message part 1 (text/plain, inline)]

Nicolò,

Nicolò Balzarotti 写道：
> The current version of lm-sensors adjust grep path in the 
> pwmconfig
> script, replacing grep->/gnu/store/.../grep.  However, the 
> script is
> using egrep, leading to the non-existant e/gnu/store/.../grep 
> path.
> The attached patch fixes is actually replacing 
> egrep->/gnu/store/../egrep

Thanks!

As it was, this change would in turn break fancontrol which does 
use plain ‘grep’:

  INTERVAL=$(grep -E '^INTERVAL=.*$' $1 | …

I've modified it to match either and pushed as 
074cd595bbcd343f86aad09794d8781846ff1927.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Tobias Geerinckx-Rice via Guix-patches <guix-patches <at> gnu.org>
Cc: 41358-done <at> debbugs.gnu.org
Subject: Re: bug#41358: lm-sensors: pwmconfig is broken
Date: Sun, 17 May 2020 17:19:44 +0200

Hi Tobias!

Tobias Geerinckx-Rice via Guix-patches via <guix-patches <at> gnu.org>
writes:

> Nicolò,
>
> Nicolò Balzarotti 写道：
>> The current version of lm-sensors adjust grep path in the 
>> pwmconfig
>> script, replacing grep->/gnu/store/.../grep.  However, the 
>> script is
>> using egrep, leading to the non-existant e/gnu/store/.../grep 
>> path.
>> The attached patch fixes is actually replacing 
>> egrep->/gnu/store/../egrep
>
> Thanks!
>
> As it was, this change would in turn break fancontrol which does 
> use plain ‘grep’:
>
>    INTERVAL=$(grep -E '^INTERVAL=.*$' $1 | …
>
Sorry for missing that

> I've modified it to match either and pushed as 
> 074cd595bbcd343f86aad09794d8781846ff1927.
>
Thanks!
Nicolò

> Kind regards,
>
> T G-R

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.