GNU bug report logs - #41351
28.0.50; Cannot customize mouse-drag-and-drop-region-show-tooltip

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41351 in the body.
You can then email your comments to 41351 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Ponce <da_vid <at> orange.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Cannot customize mouse-drag-and-drop-region-show-tooltip
Date: Sun, 17 May 2020 12:23:39 +0200

Hello,

The option `mouse-drag-and-drop-region-show-tooltip' cannot be
customized as mentioned in the doc string. Only an integer value can be
entered via customization. The proposed patch below fixed the defcustom
for me.

Thanks!

diff --git a/installs/emacs/lisp/mouse.el b/home/dponce/emacs.d/mouse.el
index 795b4da..47a7f20 100644
--- a/installs/emacs/lisp/mouse.el
+++ b/home/dponce/emacs.d/mouse.el
@@ -2577,7 +2577,10 @@ tooltips.  If this is t, it shows the entire text dragged in a
 tooltip.  If this is an integer (as with the default value of
 256), it will show that many characters of the dragged text in
 a tooltip."
-  :type 'integer
+  :type '(choice
+          (const :tag "Do not show tooltips" nil)
+          (const :tag "Show the entire text dragged" t)
+          (integer :tag "Show that many characters of the dragged text" 256))
   :version "26.1")
 
 (defcustom mouse-drag-and-drop-region-show-cursor t


In GNU Emacs 28.0.50 (build 11, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, cairo version 1.16.0)
 of 2020-05-17 built on kilauea
Repository revision: 313955110b242cd18fc19bd168032d3ddf39fe94
Repository branch: master
Windowing system distributor 'Fedora Project', version 11.0.12006000
System Description: Fedora 31 (KDE Plasma)

Message #8 received at 41351 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: David Ponce <da_vid <at> orange.fr>, 41351 <at> debbugs.gnu.org
Subject: Re: bug#41351: 28.0.50;
 Cannot customize mouse-drag-and-drop-region-show-tooltip
Date: Sun, 17 May 2020 06:09:09 -0700

[Message part 1 (text/plain, inline)]

Hi David,

David Ponce <da_vid <at> orange.fr> writes:

> diff --git a/installs/emacs/lisp/mouse.el b/home/dponce/emacs.d/mouse.el
> index 795b4da..47a7f20 100644
> --- a/installs/emacs/lisp/mouse.el
> +++ b/home/dponce/emacs.d/mouse.el
> @@ -2577,7 +2577,10 @@ tooltips.  If this is t, it shows the entire text dragged in a
>   tooltip.  If this is an integer (as with the default value of
>   256), it will show that many characters of the dragged text in
>   a tooltip."
> -  :type 'integer
> +  :type '(choice
> +          (const :tag "Do not show tooltips" nil)
> +          (const :tag "Show the entire text dragged" t)
> +          (integer :tag "Show that many characters of the dragged text" 256))

Thanks for the bug report.

I think these should be made shorter to better fit in the customize
buffer.

I also found a bug where if you set this option to 0, the text is
incorrectly shown in full.

How about the below patch?

Best regards,
Stefan Kangas

[0001-Fix-minor-issues-with-mouse-drag-and-drop-region-sho.patch (text/x-diff, attachment)]

Message #11 received at 41351 <at> debbugs.gnu.org (full text, mbox):

From: David Ponce <da_vid <at> orange.fr>
To: Stefan Kangas <stefankangas <at> gmail.com>, 41351 <at> debbugs.gnu.org
Subject: Re: bug#41351: 28.0.50; Cannot customize
 mouse-drag-and-drop-region-show-tooltip
Date: Sun, 17 May 2020 15:43:53 +0200

On 17/05/2020 15:09, Stefan Kangas wrote:
> Hi David,
[...]
> Thanks for the bug report.
> 
> I think these should be made shorter to better fit in the customize
> buffer.
> 
> I also found a bug where if you set this option to 0, the text is
> incorrectly shown in full.
> 
> How about the below patch?
> 
> Best regards,
> Stefan Kangas
> 

Hi Stefan,

I agree, your patch is better, tags are clear and will fit better in
the customize buffer.

Also, good catch about when the option sets to 0 :-)

Please feel free to apply.

Thanks for your quick answer!
Regards,
David Ponce

Message #14 received at 41351 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: David Ponce <da_vid <at> orange.fr>, 41351 <at> debbugs.gnu.org
Cc: control <at> debbugs.gnu.org
Subject: Re: bug#41351: 28.0.50;
 Cannot customize mouse-drag-and-drop-region-show-tooltip
Date: Sun, 17 May 2020 06:55:45 -0700

close 41351 28.1
thanks

David Ponce <da_vid <at> orange.fr> writes:

> I agree, your patch is better, tags are clear and will fit better in
> the customize buffer.
>
> Also, good catch about when the option sets to 0 :-)
>
> Please feel free to apply.

Thanks!

Now pushed to master as commit a8f24a89d7.  Closing this bug.

Best regards,
Stefan Kangas

Message #19 received at 41351 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: da_vid <at> orange.fr, 41351 <at> debbugs.gnu.org
Subject: Re: bug#41351: 28.0.50;
 Cannot customize mouse-drag-and-drop-region-show-tooltip
Date: Sun, 17 May 2020 18:40:03 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 17 May 2020 06:09:09 -0700
> 
> +          (integer :tag "Show characters (max)" 256))

IMO, the original text was much more clear.  maybe it can be
shortened, but your variant goes too far.

Message #22 received at 41351 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: da_vid <at> orange.fr, 41351 <at> debbugs.gnu.org
Subject: Re: bug#41351: 28.0.50;
 Cannot customize mouse-drag-and-drop-region-show-tooltip
Date: Sun, 17 May 2020 14:00:45 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Sun, 17 May 2020 06:09:09 -0700
>>
>> +          (integer :tag "Show characters (max)" 256))
>
> IMO, the original text was much more clear.  maybe it can be
> shortened, but your variant goes too far.

Thanks, I appreciate the attention to detail.

Having thought a bit about this, the best alternatives I could come up
with are:

  (1) Max number of characters

  (2) Show only N characters

Any preference, or better ideas?

Best regards,
Stefan Kangas

Message #25 received at 41351 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: da_vid <at> orange.fr, 41351 <at> debbugs.gnu.org
Subject: Re: bug#41351: 28.0.50;
 Cannot customize mouse-drag-and-drop-region-show-tooltip
Date: Mon, 18 May 2020 05:25:46 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 17 May 2020 14:00:45 -0700
> Cc: da_vid <at> orange.fr, 41351 <at> debbugs.gnu.org
> 
>   (1) Max number of characters
> 
>   (2) Show only N characters
> 
> Any preference, or better ideas?

"Max number of characters to show", I guess.

Message #28 received at 41351 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: da_vid <at> orange.fr, 41351 <at> debbugs.gnu.org
Subject: Re: bug#41351: 28.0.50;
 Cannot customize mouse-drag-and-drop-region-show-tooltip
Date: Mon, 18 May 2020 17:25:09 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> "Max number of characters to show", I guess.

Fixed on master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.