GNU bug report logs - #41348
emacs compilation with clang10 fails in the file lib-src/etags.c

Previous Next

Package: emacs;

Reported by: Narayanan Nellayi <n.a.narayanan <at> gmail.com>

Date: Sun, 17 May 2020 08:30:02 UTC

Severity: normal

Tags: fixed, patch

Done: Tom Tromey <tom <at> tromey.com>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 41348 <at> debbugs.gnu.org (full text, mbox):

From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Narayanan Nellayi <n.a.narayanan <at> gmail.com>, 41348 <at> debbugs.gnu.org
Subject: Re: bug#41348: emacs compilation with clang10 fails in the file
 lib-src/etags.c
Date: Sun, 17 May 2020 17:36:57 +0200
[Message part 1 (text/plain, inline)]
Eli Zaretskii writes:
> Does this mean Clang doesn't support __attribute__ ((__fallthrough__))?

It looks to like it does support it.  But it complains, that there is a
non-switch label "resetfvdef:" (for goto) between the annotation and the
next "case".  The correct fix is probably to move "resetfvdef:" after
the "case" labels.

[patch (text/x-patch, inline)]
diff --git a/lib-src/etags.c b/lib-src/etags.c
index 174c33a7a5..5eb7504e67 100644
--- a/lib-src/etags.c
+++ b/lib-src/etags.c
@@ -4196,9 +4196,9 @@ C_entries (int c_ext, FILE *inf)
 	      break;
 	    }
 	  FALLTHROUGH;
-	resetfvdef:
 	case '#': case '~': case '&': case '%': case '/':
 	case '|': case '^': case '!': case '.': case '?':
+	resetfvdef:
 	  if (definedef != dnone)
 	    break;
 	  /* These surely cannot follow a function tag in C. */
[Message part 3 (text/plain, inline)]
benny

This bug report was last modified 4 years and 361 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.