GNU bug report logs - #41343
tab-bar-mode: Close tab on mouse-2 click

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefankangas <at> gmail.com>

Date: Sun, 17 May 2020 04:06:02 UTC

Severity: wishlist

Tags: fixed, patch

Merged with 41342

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #66 received at 41343 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 41343 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#41343: tab-bar-mode: Close tab on mouse-2 click
Date: Wed, 11 Aug 2021 14:56:26 +0300
> From: Juri Linkov <juri <at> linkov.net>
> Cc: stefankangas <at> gmail.com,  41343 <at> debbugs.gnu.org
> Date: Wed, 11 Aug 2021 10:01:53 +0300
> 
> >> So now I've completely redesigned the event processing on the tab bar.
> >
> > Thanks, this looks much, much better to me.
> 
> Could you please help to check if everything is correct
> on the Windows part (unfortunately, I don't have Windows).
> The changes in w32inevt.c and w32term.c just mirror the changes
> in xdisp.c and xterm.c, but I'm sure I might have made a typo.

I will, if you tell me what to try after applying the patch.

> There is the need to apply an additional patch below,
> because the tab symbol is carried by the event in its
> OBJECT slot, but some functions expect that the OBJECT
> slot should contain only (STRING . STRING-POS)

That expectation is according to the documented behavior, so it is
correct.  I don't quite understand why you need to break the contract
here.  Can you elaborate where do the deviant values come and why they
must have a different value form?




This bug report was last modified 3 years and 305 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.