From unknown Fri Aug 15 15:37:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41341: 27.0.91; project.el 0.1.2 project-try-vc() fails in Git subdirectories; patch attached Resent-From: John SJ Anderson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 May 2020 01:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 41341@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158968070718062 (code B ref -1); Sun, 17 May 2020 01:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 May 2020 01:58:27 +0000 Received: from localhost ([127.0.0.1]:42004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja8ZO-0004hG-PT for submit@debbugs.gnu.org; Sat, 16 May 2020 21:58:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:54844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja8ST-0004XL-IF for submit@debbugs.gnu.org; Sat, 16 May 2020 21:51:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja8ST-0004hA-50 for bug-gnu-emacs@gnu.org; Sat, 16 May 2020 21:51:17 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:56223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja8SQ-0002po-ST for bug-gnu-emacs@gnu.org; Sat, 16 May 2020 21:51:16 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 329FADFB60 for ; Sat, 16 May 2020 21:51:10 -0400 (EDT) (envelope-from john@genehack.org) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from :content-type:mime-version:subject:message-id:date:to; s=sasl; bh=kTKWq1x7g2dvI0NRVl/vbPm3nps=; b=Hxi7aPEbDt6m4QeVrl0sM/QKqvRE NZ5b7LXtgvk4E37QsVN0sfVAjj8sImPAbtdbyU2cjcSnyIlW7PS8cfKoeoSxltHN Qt3bmDY6KPVkz3I9o2zg7WBHOPQw+87k8tKcZbCo4hauVQOexPnGhSpJIACy+CmK Itf9sVgBsi7PeT8= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 2C036DFB5F for ; Sat, 16 May 2020 21:51:10 -0400 (EDT) (envelope-from john@genehack.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=genehack.org; h=from:content-type:mime-version:subject:message-id:date:to; s=mesmtp; bh=ZqdOFKFeiwes5Mbc5Mkq15bT1FOhWlyNJlcp4B1pPWc=; b=kjOfNbE9Jt+FN1XNZoPUaYZx7sSZCe93qomgQ862akvYgQZyK4RBooVBA1w5MUfwcPnMJe91k8DIdpVN3uAu2jnLsQYXVlsV6Sr3Efq7zmp5dSbyTzVr9B8mS608eA9v0+GcEGd5Yh1R2EzW09wlah4u/4W7+XodeC799gZXLAs= Received: from phineas.home.genehack.org (unknown [67.189.65.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 9F742DFB5E for ; Sat, 16 May 2020 21:51:06 -0400 (EDT) (envelope-from john@genehack.org) From: John SJ Anderson Content-Type: multipart/alternative; boundary="Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Message-Id: Date: Sat, 16 May 2020 18:51:05 -0700 X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Pobox-Relay-ID: DF87E238-97E0-11EA-A7F1-8D86F504CC47-02214974!pb-smtp21.pobox.com Received-SPF: none client-ip=173.228.157.53; envelope-from=john@genehack.org; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/16 21:51:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Mailman-Approved-At: Sat, 16 May 2020 21:58:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I upgraded packages on 16 May 2020, which resulted in project.el = upgrading to v0.1.2.=20 I restarted Emacs and got the following stack trace: Debugger entered--Lisp error: (file-missing "Opening input file" "No = such file or directory" "/Users/genehack/proj/apollo/models/.git") insert-file-contents("/Users/genehack/proj/apollo/models/.git") project-try-vc("/Users/genehack/proj/apollo/models/") run-hook-with-args-until-success(project-try-vc = "/Users/genehack/proj/apollo/models/") project--find-in-directory("/Users/genehack/proj/apollo/models/") project-current() eglot--maybe-activate-editing-mode() run-hooks(change-major-mode-after-body-hook = after-change-major-mode-hook) normal-mode(t) after-find-file(nil nil) find-file-noselect-1(# "~/proj/apollo/models/index.js" = :nowarn nil "~/proj/apollo/models/index.js" (8667578097 16777222)) find-file-noselect("/Users/genehack/proj/apollo/models/index.js" = :nowarn) = desktop-restore-file-buffer("/Users/genehack/proj/apollo/models/index.js" = "index.js" nil) desktop-create-buffer(208 = "/Users/genehack/proj/apollo/models/index.js" "index.js" js2-mode = (eldoc-mode override-global-mode gcmh-mode global-auto-revert-mode = company-mode flymake-mode projectile-mode aggressive-indent-mode = flycheck-mode smartparens-mode prettier-js-mode) 1 (nil nil) nil nil = ((buffer-display-time 24256 19314 922097 0) (buffer-file-coding-system . = undecided-unix)) ((mark-ring nil))) eval-buffer(# nil = "/Users/genehack/.emacs.d/.emacs.desktop" nil t) ; Reading at buffer = position 9385 load-with-code-conversion("/Users/genehack/.emacs.d/.emacs.desktop" = "/Users/genehack/.emacs.d/.emacs.desktop" t t) load("/Users/genehack/.emacs.d/.emacs.desktop" t t t) desktop-read() #f(compiled-function () #)() run-hooks(after-init-hook delayed-warnings-hook) command-line() normal-top-level() I verified that falling back to project-0.1.el fixed the issue. Looking = at the diff between 0.1 and 0.1.2, I was able to concoct the following = patch, which seems to resolve the issue: --- ./upstream-project-0.1.2.el 2020-05-16 13:51:19.000000000 -0700 +++ elpa/project-0.1.2/project.el 2020-05-16 13:50:15.000000000 = -0700 @@ -275,7 +275,7 @@ ;; Don't stop at submodule boundary. (or (vc-file-getprop dir 'project-git-root) (let* ((default-directory dir) - (root (vc-root-dir)) + (root (vc-find-root dir ".git/")) (gitfile (expand-file-name ".git" root))) (vc-file-setprop dir 'project-git-root Information generated by `report-emacs-bug` is below:=20 In GNU Emacs 27.0.91 (build 1, x86_64-apple-darwin19.3.0, NS = appkit-1894.30 Version 10.15.3 (Build 19D76)) of 2020-04-25 built on phineas.home.genehack.org Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.4 Configured using: 'configure --with-gnutls=3Dyes --without-makeinfo --with-ns = CPPFLAGS=3D-I/usr/local/opt/libxml2/include/libxml2 = PKG_CONFIG_PATH=3D/usr/local/lib/pkgconfig' --Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
I upgraded packages on 16 May 2020, which resulted in = project.el upgrading to v0.1.2. 

I restarted Emacs and got the following = stack trace:

Debugger = entered--Lisp error: (file-missing "Opening input file" "No such file or = directory" = "/Users/genehack/proj/apollo/models/.git")
insert-file-contents("/Users/genehack/proj/apollo/models/.git")=
project-try-vc("/Users/genehack/proj/apollo/models/")
run-hook-with-args-until-success(project-try-vc = "/Users/genehack/proj/apollo/models/")
project--find-in-directory("/Users/genehack/proj/apollo/models/= ")
project-current()
eglot--maybe-activate-editing-mode()
run-hooks(change-major-mode-after-body-hook = after-change-major-mode-hook)
normal-mode(t)
after-find-file(nil nil)
find-file-noselect-1(#<buffer = index.js> "~/proj/apollo/models/index.js" :nowarn nil = "~/proj/apollo/models/index.js" (8667578097 = 16777222))
  = find-file-noselect("/Users/genehack/proj/apollo/models/index.js" = :nowarn)
  = desktop-restore-file-buffer("/Users/genehack/proj/apollo/models/index.js" = "index.js" nil)
  desktop-create-buffer(208 = "/Users/genehack/proj/apollo/models/index.js" "index.js" js2-mode = (eldoc-mode override-global-mode gcmh-mode global-auto-revert-mode = company-mode flymake-mode projectile-mode aggressive-indent-mode = flycheck-mode smartparens-mode prettier-js-mode) 1 (nil nil) nil nil = ((buffer-display-time 24256 19314 922097 0) (buffer-file-coding-system . = undecided-unix)) ((mark-ring nil)))
  eval-buffer(#<buffer =  *load*> nil "/Users/genehack/.emacs.d/.emacs.desktop" nil t) =  ; Reading at buffer position 9385
  = load-with-code-conversion("/Users/genehack/.emacs.d/.emacs.desktop" = "/Users/genehack/.emacs.d/.emacs.desktop" t t)
  = load("/Users/genehack/.emacs.d/.emacs.desktop" t t = t)
  = desktop-read()
  #f(compiled-function () #<bytecode = 0x1fe27544cc95>)()
  run-hooks(after-init-hook = delayed-warnings-hook)
  command-line()
  normal-top-level()

I verified that falling = back to project-0.1.el fixed the issue. Looking at the diff between 0.1 = and 0.1.2, I was able to concoct the following patch, which seems to = resolve the issue:

--- = ./upstream-project-0.1.2.el 2020-05-16 13:51:19.000000000 = -0700
+++ = elpa/project-0.1.2/project.el       2020-05-16 = 13:50:15.000000000 -0700
@@ -275,7 +275,7 @@
              ;; Don't = stop at submodule boundary.
              (or = (vc-file-getprop dir 'project-git-root)
        =           (let* ((default-directory = dir)
-   =                     =  (root (vc-root-dir))
+                 =        (root (vc-find-root dir = ".git/"))
                =          (gitfile (expand-file-name ".git" = root)))
    =                 = (vc-file-setprop
                =      dir 'project-git-root

Information generated by = `report-emacs-bug` is below: 


In = GNU Emacs 27.0.91 (build 1, x86_64-apple-darwin19.3.0, NS appkit-1894.30 = Version 10.15.3 (Build 19D76))
 of 2020-04-25 = built on phineas.home.genehack.org
Windowing = system distributor 'Apple', version 10.3.1894
System = Description:  Mac OS X 10.15.4

Configured using:
 'configure --with-gnutls=3Dyes --without-makeinfo = --with-ns CPPFLAGS=3D-I/usr/local/opt/libxml2/include/libxml2 = PKG_CONFIG_PATH=3D/usr/local/lib/pkgconfig'

= --Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD-- From unknown Fri Aug 15 15:37:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41341: 27.0.91; project.el 0.1.2 project-try-vc() fails in Git subdirectories; patch attached Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 May 2020 12:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: John SJ Anderson , 41341@debbugs.gnu.org Received: via spool by 41341-submit@debbugs.gnu.org id=B41341.158971791622636 (code B ref 41341); Sun, 17 May 2020 12:19:02 +0000 Received: (at 41341) by debbugs.gnu.org; 17 May 2020 12:18:36 +0000 Received: from localhost ([127.0.0.1]:42490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaIFX-0005t2-Lm for submit@debbugs.gnu.org; Sun, 17 May 2020 08:18:35 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:44934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaIFW-0005sn-0c for 41341@debbugs.gnu.org; Sun, 17 May 2020 08:18:34 -0400 Received: by mail-wr1-f44.google.com with SMTP id 50so8505807wrc.11 for <41341@debbugs.gnu.org>; Sun, 17 May 2020 05:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ppufpilKZfDUPAXAR4kJUdX7QpEvOvBRV+G/mDQjY5I=; b=Rcwn0EeHATiFzEllw6fooN4BmMjZaI1E0Mtw1nRtkYPwn/Ml+4Wmzn+cpBMRMYfumc Pb8ZAc/EJuAXbPi0KY6k3gqspgrd0U9UU1Hm9WpWUGtdG86BZxFL/wBg6TqJwtzQ+gnd cDW21iqRxp0YNLNHi/cccR9P/ZlR6siysTs1iXEVvhJxxS9619nozLC1BNnJiLNoF6Vg fsj5cOqv7At0ny+XOzY0BvmgzU0PIQoGTVDg9MPCydz90c/lXHQa6mW6y61aIT33oyZR b47G5f5McJ7UT7856ohheVQ5I4DcgCT8qPf7rU/i4j0YREXwD8iY7jVZFjW+dWiMZlI8 QAWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ppufpilKZfDUPAXAR4kJUdX7QpEvOvBRV+G/mDQjY5I=; b=HJWNK2XTJMblz8X2bSPsCNu4b2P53Ve5tDfejTZwEbb15CMkjqExC4QVIh/+HoirUt Kn4tnnVYOzi5LH4kjhKxV5X+YhFihpVSnk9qCLJKjD7KRp1VYVzr7EPgWDa02Aik52Rw Hrzu17tbi7JZg5YP7+F2pD+0RWU5U93sP45ATfCrfPD/2Kd2/A1KIFZdlpyqY3LS1knf bzX0OIk7ccchoORC1Qe8YK7iiV1GY3uFDJGsg6M7oL05kYXP4fvfu6mPvDI8swHjB3jE q1KoArCLjEk8x1yNeNm9V+/NdyjMF4+tq/coqHiOY6DrOWEkrNFQSR8yttePJur6iFSr 7Jsw== X-Gm-Message-State: AOAM5336o+Fi7niUOFdh+cC4e5plHX6gG4UAcj6L8us35RZnq4L+JRre etn6CK6xISgPpeg/GKch6A5oiA5A X-Google-Smtp-Source: ABdhPJxzubjqbZO14mgJpb9zpQ91C8FHstfwcYwx8+6oaxs6ggt6xd+RjcxP57lvzi4ejnjuiS0x8g== X-Received: by 2002:adf:e802:: with SMTP id o2mr14018560wrm.110.1589717907829; Sun, 17 May 2020 05:18:27 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id j2sm11623511wrp.47.2020.05.17.05.18.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2020 05:18:27 -0700 (PDT) References: From: Dmitry Gutov Message-ID: <2e44b1b6-7e33-b5ef-d912-512b2d0fc6eb@yandex.ru> Date: Sun, 17 May 2020 15:18:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi! Thank you for the report. On 17.05.2020 04:51, John SJ Anderson wrote: > I upgraded packages on 16 May 2020, which resulted in project.el > upgrading to v0.1.2. > > I restarted Emacs and got the following stack trace: Version 0.1.3 is now out with a proper fix. Sorry, it's been fixed on master already, I just wasn't aware we got real users yet. :-) (project.el has only been a stand-alone package for a few days). But I suppose that's how package.el works with built-in packages. From unknown Fri Aug 15 15:37:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: John SJ Anderson Subject: bug#41341: closed (Re: bug#41341: 27.0.91; project.el 0.1.2 project-try-vc() fails in Git subdirectories; patch attached) Message-ID: References: X-Gnu-PR-Message: they-closed 41341 X-Gnu-PR-Package: emacs Reply-To: 41341@debbugs.gnu.org Date: Sun, 17 May 2020 12:20:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1589718002-22793-1" This is a multi-part message in MIME format... ------------=_1589718002-22793-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #41341: 27.0.91; project.el 0.1.2 project-try-vc() fails in Git subdirector= ies; patch attached which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 41341@debbugs.gnu.org. --=20 41341: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41341 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1589718002-22793-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 41341-done) by debbugs.gnu.org; 17 May 2020 12:19:27 +0000 Received: from localhost ([127.0.0.1]:42497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaIGN-0005up-8d for submit@debbugs.gnu.org; Sun, 17 May 2020 08:19:27 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:36603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaIGL-0005ud-Ez for 41341-done@debbugs.gnu.org; Sun, 17 May 2020 08:19:25 -0400 Received: by mail-wr1-f52.google.com with SMTP id k13so6460843wrx.3 for <41341-done@debbugs.gnu.org>; Sun, 17 May 2020 05:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pLyIeN04ZhOyRvPKy/5q+wvu1GOE5Vl1+Q/PIVPayjk=; b=Ezsi5osfjAGKKyyUIkbQavMzYUBzPCdV455alK/A45l0HOE66JHEDsSufHd6KPmmLp RRGKTKeOouCZpJgBqUJW23qqtI50ATuaeXV4t4YP9fM2VVFOVfhe2O8vJVcaLcr/E/aU 2ap/IFwbYWC3ihh0eg7uP4NDv3M/p5qzDw8eqvT/xhtJ8Oan+O5JahLqk05jXYvXU39D Vkk6ctUMYn8bMKObZHiH5nkRCklKnZEQQUoNblRNT6inCnE2aF8R/jElW1/V1hleMFzb GqA9xb0iBcjE6EzKzYRyHfJcn/GFgtahARCUtGU7v99ENXs7xM4IGRN+vE4yEDajhoA9 vA7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pLyIeN04ZhOyRvPKy/5q+wvu1GOE5Vl1+Q/PIVPayjk=; b=IUBLL04qLrg7iu33lSjLqJ9LI5fE8KVw2Rsqeb8iUA6kOdVzAqbDoXH1vft3QP2jNG wO7TywIwaSAv7Lkiq+TSKmw3/QGWm0WaqjZVuq/C5pAdCFkiZ8NxDylFjPMKvGB1KVNq aQfTW7ukY/p7savIxyKgCu7g68tuIsZ1AeO9qwL9MsaOs9FIYjzqd1nKn/yy3eqDchcb 7V1ADp3AiZdygWat6xh66cI85boPiaegRGb1zMiB3/PJIg3hCOlJL/Nye1kf6K0fC1VP ipnRCFeRT3KOmshGcItuHbtARirVvQ7iggoyBFwYP6aZH+T7cntagtf2Q/Og1qRqrlJY nChQ== X-Gm-Message-State: AOAM530rpG57Mia7rkgiXvR7lMewqFNIMS4Ph7TuOn4f8ehaJTO9plz7 Z1aGQfLchwLEzx+VBBAeB5aJG9og X-Google-Smtp-Source: ABdhPJz/qLJNX55Ze5k5iPyTmFuN8wRAtJX//7lKd41GGvuHamh1nZK8cr/vH43fTORLV8EyWSHuOw== X-Received: by 2002:adf:b301:: with SMTP id j1mr13997760wrd.221.1589717959693; Sun, 17 May 2020 05:19:19 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l18sm11502111wmj.22.2020.05.17.05.19.18 for <41341-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2020 05:19:19 -0700 (PDT) Subject: Re: bug#41341: 27.0.91; project.el 0.1.2 project-try-vc() fails in Git subdirectories; patch attached From: Dmitry Gutov To: 41341-done@debbugs.gnu.org References: <2e44b1b6-7e33-b5ef-d912-512b2d0fc6eb@yandex.ru> Message-ID: Date: Sun, 17 May 2020 15:19:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2e44b1b6-7e33-b5ef-d912-512b2d0fc6eb@yandex.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41341-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) So: closing. ------------=_1589718002-22793-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 May 2020 01:58:27 +0000 Received: from localhost ([127.0.0.1]:42004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja8ZO-0004hG-PT for submit@debbugs.gnu.org; Sat, 16 May 2020 21:58:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:54844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja8ST-0004XL-IF for submit@debbugs.gnu.org; Sat, 16 May 2020 21:51:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja8ST-0004hA-50 for bug-gnu-emacs@gnu.org; Sat, 16 May 2020 21:51:17 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:56223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja8SQ-0002po-ST for bug-gnu-emacs@gnu.org; Sat, 16 May 2020 21:51:16 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 329FADFB60 for ; Sat, 16 May 2020 21:51:10 -0400 (EDT) (envelope-from john@genehack.org) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from :content-type:mime-version:subject:message-id:date:to; s=sasl; bh=kTKWq1x7g2dvI0NRVl/vbPm3nps=; b=Hxi7aPEbDt6m4QeVrl0sM/QKqvRE NZ5b7LXtgvk4E37QsVN0sfVAjj8sImPAbtdbyU2cjcSnyIlW7PS8cfKoeoSxltHN Qt3bmDY6KPVkz3I9o2zg7WBHOPQw+87k8tKcZbCo4hauVQOexPnGhSpJIACy+CmK Itf9sVgBsi7PeT8= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 2C036DFB5F for ; Sat, 16 May 2020 21:51:10 -0400 (EDT) (envelope-from john@genehack.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=genehack.org; h=from:content-type:mime-version:subject:message-id:date:to; s=mesmtp; bh=ZqdOFKFeiwes5Mbc5Mkq15bT1FOhWlyNJlcp4B1pPWc=; b=kjOfNbE9Jt+FN1XNZoPUaYZx7sSZCe93qomgQ862akvYgQZyK4RBooVBA1w5MUfwcPnMJe91k8DIdpVN3uAu2jnLsQYXVlsV6Sr3Efq7zmp5dSbyTzVr9B8mS608eA9v0+GcEGd5Yh1R2EzW09wlah4u/4W7+XodeC799gZXLAs= Received: from phineas.home.genehack.org (unknown [67.189.65.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 9F742DFB5E for ; Sat, 16 May 2020 21:51:06 -0400 (EDT) (envelope-from john@genehack.org) From: John SJ Anderson Content-Type: multipart/alternative; boundary="Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: 27.0.91; project.el 0.1.2 project-try-vc() fails in Git subdirectories; patch attached Message-Id: Date: Sat, 16 May 2020 18:51:05 -0700 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Pobox-Relay-ID: DF87E238-97E0-11EA-A7F1-8D86F504CC47-02214974!pb-smtp21.pobox.com Received-SPF: none client-ip=173.228.157.53; envelope-from=john@genehack.org; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/16 21:51:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 16 May 2020 21:58:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I upgraded packages on 16 May 2020, which resulted in project.el = upgrading to v0.1.2.=20 I restarted Emacs and got the following stack trace: Debugger entered--Lisp error: (file-missing "Opening input file" "No = such file or directory" "/Users/genehack/proj/apollo/models/.git") insert-file-contents("/Users/genehack/proj/apollo/models/.git") project-try-vc("/Users/genehack/proj/apollo/models/") run-hook-with-args-until-success(project-try-vc = "/Users/genehack/proj/apollo/models/") project--find-in-directory("/Users/genehack/proj/apollo/models/") project-current() eglot--maybe-activate-editing-mode() run-hooks(change-major-mode-after-body-hook = after-change-major-mode-hook) normal-mode(t) after-find-file(nil nil) find-file-noselect-1(# "~/proj/apollo/models/index.js" = :nowarn nil "~/proj/apollo/models/index.js" (8667578097 16777222)) find-file-noselect("/Users/genehack/proj/apollo/models/index.js" = :nowarn) = desktop-restore-file-buffer("/Users/genehack/proj/apollo/models/index.js" = "index.js" nil) desktop-create-buffer(208 = "/Users/genehack/proj/apollo/models/index.js" "index.js" js2-mode = (eldoc-mode override-global-mode gcmh-mode global-auto-revert-mode = company-mode flymake-mode projectile-mode aggressive-indent-mode = flycheck-mode smartparens-mode prettier-js-mode) 1 (nil nil) nil nil = ((buffer-display-time 24256 19314 922097 0) (buffer-file-coding-system . = undecided-unix)) ((mark-ring nil))) eval-buffer(# nil = "/Users/genehack/.emacs.d/.emacs.desktop" nil t) ; Reading at buffer = position 9385 load-with-code-conversion("/Users/genehack/.emacs.d/.emacs.desktop" = "/Users/genehack/.emacs.d/.emacs.desktop" t t) load("/Users/genehack/.emacs.d/.emacs.desktop" t t t) desktop-read() #f(compiled-function () #)() run-hooks(after-init-hook delayed-warnings-hook) command-line() normal-top-level() I verified that falling back to project-0.1.el fixed the issue. Looking = at the diff between 0.1 and 0.1.2, I was able to concoct the following = patch, which seems to resolve the issue: --- ./upstream-project-0.1.2.el 2020-05-16 13:51:19.000000000 -0700 +++ elpa/project-0.1.2/project.el 2020-05-16 13:50:15.000000000 = -0700 @@ -275,7 +275,7 @@ ;; Don't stop at submodule boundary. (or (vc-file-getprop dir 'project-git-root) (let* ((default-directory dir) - (root (vc-root-dir)) + (root (vc-find-root dir ".git/")) (gitfile (expand-file-name ".git" root))) (vc-file-setprop dir 'project-git-root Information generated by `report-emacs-bug` is below:=20 In GNU Emacs 27.0.91 (build 1, x86_64-apple-darwin19.3.0, NS = appkit-1894.30 Version 10.15.3 (Build 19D76)) of 2020-04-25 built on phineas.home.genehack.org Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.4 Configured using: 'configure --with-gnutls=3Dyes --without-makeinfo --with-ns = CPPFLAGS=3D-I/usr/local/opt/libxml2/include/libxml2 = PKG_CONFIG_PATH=3D/usr/local/lib/pkgconfig' --Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
I upgraded packages on 16 May 2020, which resulted in = project.el upgrading to v0.1.2. 

I restarted Emacs and got the following = stack trace:

Debugger = entered--Lisp error: (file-missing "Opening input file" "No such file or = directory" = "/Users/genehack/proj/apollo/models/.git")
insert-file-contents("/Users/genehack/proj/apollo/models/.git")=
project-try-vc("/Users/genehack/proj/apollo/models/")
run-hook-with-args-until-success(project-try-vc = "/Users/genehack/proj/apollo/models/")
project--find-in-directory("/Users/genehack/proj/apollo/models/= ")
project-current()
eglot--maybe-activate-editing-mode()
run-hooks(change-major-mode-after-body-hook = after-change-major-mode-hook)
normal-mode(t)
after-find-file(nil nil)
find-file-noselect-1(#<buffer = index.js> "~/proj/apollo/models/index.js" :nowarn nil = "~/proj/apollo/models/index.js" (8667578097 = 16777222))
  = find-file-noselect("/Users/genehack/proj/apollo/models/index.js" = :nowarn)
  = desktop-restore-file-buffer("/Users/genehack/proj/apollo/models/index.js" = "index.js" nil)
  desktop-create-buffer(208 = "/Users/genehack/proj/apollo/models/index.js" "index.js" js2-mode = (eldoc-mode override-global-mode gcmh-mode global-auto-revert-mode = company-mode flymake-mode projectile-mode aggressive-indent-mode = flycheck-mode smartparens-mode prettier-js-mode) 1 (nil nil) nil nil = ((buffer-display-time 24256 19314 922097 0) (buffer-file-coding-system . = undecided-unix)) ((mark-ring nil)))
  eval-buffer(#<buffer =  *load*> nil "/Users/genehack/.emacs.d/.emacs.desktop" nil t) =  ; Reading at buffer position 9385
  = load-with-code-conversion("/Users/genehack/.emacs.d/.emacs.desktop" = "/Users/genehack/.emacs.d/.emacs.desktop" t t)
  = load("/Users/genehack/.emacs.d/.emacs.desktop" t t = t)
  = desktop-read()
  #f(compiled-function () #<bytecode = 0x1fe27544cc95>)()
  run-hooks(after-init-hook = delayed-warnings-hook)
  command-line()
  normal-top-level()

I verified that falling = back to project-0.1.el fixed the issue. Looking at the diff between 0.1 = and 0.1.2, I was able to concoct the following patch, which seems to = resolve the issue:

--- = ./upstream-project-0.1.2.el 2020-05-16 13:51:19.000000000 = -0700
+++ = elpa/project-0.1.2/project.el       2020-05-16 = 13:50:15.000000000 -0700
@@ -275,7 +275,7 @@
              ;; Don't = stop at submodule boundary.
              (or = (vc-file-getprop dir 'project-git-root)
        =           (let* ((default-directory = dir)
-   =                     =  (root (vc-root-dir))
+                 =        (root (vc-find-root dir = ".git/"))
                =          (gitfile (expand-file-name ".git" = root)))
    =                 = (vc-file-setprop
                =      dir 'project-git-root

Information generated by = `report-emacs-bug` is below: 


In = GNU Emacs 27.0.91 (build 1, x86_64-apple-darwin19.3.0, NS appkit-1894.30 = Version 10.15.3 (Build 19D76))
 of 2020-04-25 = built on phineas.home.genehack.org
Windowing = system distributor 'Apple', version 10.3.1894
System = Description:  Mac OS X 10.15.4

Configured using:
 'configure --with-gnutls=3Dyes --without-makeinfo = --with-ns CPPFLAGS=3D-I/usr/local/opt/libxml2/include/libxml2 = PKG_CONFIG_PATH=3D/usr/local/lib/pkgconfig'

= --Apple-Mail=_BDB7C2AF-1D42-4CBA-8A3F-4C9C37CE27DD-- ------------=_1589718002-22793-1--