From unknown Sat Aug 09 04:54:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#4130 <4130@debbugs.gnu.org> To: bug#4130 <4130@debbugs.gnu.org> Subject: Status: issues with js2-mode faces Reply-To: bug#4130 <4130@debbugs.gnu.org> Date: Sat, 09 Aug 2025 11:54:05 +0000 retitle 4130 issues with js2-mode faces reassign 4130 emacs submitter 4130 Steve Yegge severity 4130 normal thanks From steve.yegge@gmail.com Tue Aug 11 22:51:09 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 12 Aug 2009 05:51:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=MULTALT autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7C5p8kZ027085 for ; Tue, 11 Aug 2009 22:51:09 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mb6js-0001wZ-2Q for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mb6jn-0001te-MQ for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:07 -0400 Received: from [199.232.76.173] (port=55485 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mb6jn-0001tO-C4 for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:03 -0400 Received: from mx20.gnu.org ([199.232.41.8]:53522) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mb6jm-00088e-LJ for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:02 -0400 Received: from mail-vw0-f182.google.com ([209.85.212.182]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mb6jl-0007Ix-BW for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 01:51:01 -0400 Received: by vws12 with SMTP id 12so4107341vws.24 for ; Tue, 11 Aug 2009 22:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=A98D+0iokscCeMvuy+svhxDKTzJSkfMPMOBQ6nAZhiU=; b=EEGQwfwBfLvgxK825jEd0hvikjQC5/zIUOuZdjWYdaGg0pzVDg4lwLLJSKZrKq4JhC ikQUK6d9GKIl1HmIq/e+R70NPbS62UgXpUgEUj7MuTphr6oG7fxZ7xANZZHJNg8sAyWH XOfXnt1EoTl2KoSe8XsnfXdk9TWOErs1BjFJ8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=lKMjdALGoAQ8PeyruRHWUA/1KHyG8038HrRgBgAXcpldRQgzyurR3iSZoAL9RulI39 7VSsYMccOqFq/vTw6aOE4evkK4CNL9Fbg3PeIZwNrDndB0SbbAj4lPs+ELJvvC7ocw8S rLdJ3poeNKsjfXn4dOwKOxgeQnfrmHWxmpu7k= MIME-Version: 1.0 Received: by 10.220.90.194 with SMTP id j2mr191070vcm.70.1250056259975; Tue, 11 Aug 2009 22:50:59 -0700 (PDT) In-Reply-To: <200908091800.n79I0KLn016605@godzilla.ics.uci.edu> References: <200908091800.n79I0KLn016605@godzilla.ics.uci.edu> Date: Tue, 11 Aug 2009 22:50:59 -0700 Message-ID: Subject: Re: issues with js2-mode faces From: Steve Yegge To: Dan Nicolaescu Cc: bug-gnu-emacs Content-Type: multipart/alternative; boundary=0016e64755c25339910470eb678a X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --0016e64755c25339910470eb678a Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Sun, Aug 9, 2009 at 11:00 AM, Dan Nicolaescu wrote: > > js2-mode uses -face suffix for faces. > > We are not using this suffix anymore and the tree has been cleaned up of > such with backward compatibility code added. This is new code, so > there's little point in having the suffix... > Agree; I'll fix it. The docs (info pages) are incorrect on a relevant point, incidentally; they claim that defining variables whose value is set to the face of the same name is popular but obsolete; the reality is that font-lock-add-keywords requires the variable definitions. > > Also, instead of defining a new js2-error-face why not just use > font-lock-warning-face? > Why not just define a font-lock-error-face instead? Other modes (such as compilation) define their own error faces. Fix it in Emacs and the modes will follow. -steve --0016e64755c25339910470eb678a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, Aug 9, 2009 at 11:00 AM, Dan Nicolaescu <dann@ics.uci.edu> wrote:

js2-mode uses -face suffix for faces.

We are not using this suffix anymore and the tree has been cleaned up of such with backward compatibility code added. =A0This is new code, so
there's little point in having the suffix...

Agree; I'll fix it. =A0The docs (info = pages) are incorrect on a relevant point,
incidentally; they clai= m that defining variables whose value is set to the
face of the s= ame name is popular but obsolete; the reality is that
font-lock-add-keywords requires the variable definitions.
= =A0

Also, instead of defining a new js2-error-face why not just use
font-lock-warning-face?

Why not just define a font-lock-error-face inst= ead?=A0=A0Other=A0modes
(such=A0as=A0compilation)=A0define=A0thei= r=A0own=A0error=A0faces.=A0=A0Fix=A0it=A0in=A0Emacs
and=A0the=A0m= odes=A0will=A0follow.

-steve
--0016e64755c25339910470eb678a-- From cyd@stupidchicken.com Fri Aug 14 18:18:03 2009 Received: (at control) by emacsbugs.donarmstrong.com; 15 Aug 2009 01:18:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po44.its.yale.edu (pantheon-po44.its.yale.edu [130.132.50.78]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7F1I2Xv001514 for ; Fri, 14 Aug 2009 18:18:03 -0700 Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n7F1HuXY008811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 14 Aug 2009 21:17:56 -0400 Received: by furry (Postfix, from userid 1000) id 2CBA3C070; Fri, 14 Aug 2009 21:17:57 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 4097 Date: Fri, 14 Aug 2009 21:17:57 -0400 Message-ID: <87fxbtnad6.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) close 4097 close 4130 thanks (js2-mode is no longer in CVS.) From unknown Sat Aug 09 04:54:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 12 Sep 2009 14:24:43 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 20:52:15 2010 Received: (at control) by debbugs.gnu.org; 27 Jan 2010 01:52:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZx4p-0001L8-3A for submit@debbugs.gnu.org; Tue, 26 Jan 2010 20:52:15 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZx4n-0001Kz-Cy for control@debbugs.gnu.org; Tue, 26 Jan 2010 20:52:13 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZx4j-0008Do-Q1; Tue, 26 Jan 2010 20:52:09 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19295.40009.742711.907136@fencepost.gnu.org> Date: Tue, 26 Jan 2010 20:52:09 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: .,Id9;5qiQf&2n,<1Q)pSe~'s"9B`l,&Ounxr+7\iedM93C_oK>"#$=D?*3Jqnu(&EvTR4 X-Debbugs-No-Ack: yes X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) tags 4053 moreinfo reassign 4066 emacs,org-mode reassign 4068 emacs,org-mode severity 4068 minor unarchive 4087 reassign 4087 notemacs tags 4094 moreinfo merge 4094 4096 merge 1611 3978 4108 unarchive 4097 unarchive 4130 merge 4097 4130 tags 4140 moreinfo close 4146 reassign 4151 emacs,ns tags 4192 patch From unknown Sat Aug 09 04:54:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 24 Feb 2010 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator