GNU bug report logs - #41297
[PATCH] gnu: openctm: Correct inputs vs native-inputs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41297 in the body.
You can then email your comments to 41297 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs
Date: Fri, 15 May 2020 22:57:53 +0000

From 417f64adc854e5d717351fec68872ed19a9ac3df Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Date: Sat, 16 May 2020 00:49:53 +0200
Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

    * gnu/packages/engineering.scm (openctm): Change inputs
---
 gnu/packages/engineering.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index aec692174a..aab414bf0e 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2557,11 +2557,12 @@ official SDK.")
           (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
       (build-system gnu-build-system)
       (native-inputs
+       `(("pkg-config" ,pkg-config)))
+      (inputs
        `(("mesa" ,mesa)
          ("glu" ,glu)
          ("glut" ,freeglut)
-         ("gtk" ,gtk+-2)
-         ("pkg-config" ,pkg-config)))
+         ("gtk" ,gtk+-2)))
       (arguments
        `(#:tests? #f                              ;no tests
          #:phases
--
2.26.1

Message #8 received at 41297 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 41297 <at> debbugs.gnu.org
Subject: Re: [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
Date: Sat, 16 May 2020 01:35:09 +0200

On 16.05.20 00:57, Ekaitz Zarraga wrote:
> From 417f64adc854e5d717351fec68872ed19a9ac3df Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
> Date: Sat, 16 May 2020 00:49:53 +0200
> Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

Please add a dot add the end of sentences.

>     * gnu/packages/engineering.scm (openctm): Change inputs

Maybe rephrase it to: Move pkg-config to native-inputs.

> ---
>  gnu/packages/engineering.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index aec692174a..aab414bf0e 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2557,11 +2557,12 @@ official SDK.")
>            (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
>        (build-system gnu-build-system)
>        (native-inputs
> +       `(("pkg-config" ,pkg-config)))
> +      (inputs
>         `(("mesa" ,mesa)
>           ("glu" ,glu)
>           ("glut" ,freeglut)
> -         ("gtk" ,gtk+-2)
> -         ("pkg-config" ,pkg-config)))
> +         ("gtk" ,gtk+-2)))
>        (arguments
>         `(#:tests? #f                              ;no tests
>           #:phases
> --

Otherwise it looks good.

Message #11 received at 41297 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: "41297 <at> debbugs.gnu.org" <41297 <at> debbugs.gnu.org>
Subject: Re: [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
Date: Sat, 16 May 2020 09:57:39 +0000

Hi,

>
> Maybe rephrase it to: Move pkg-config to native-inputs.
>

In fact, the pkg-config is the only one that it's not moved. The change is moving all of the others to inputs.

I really bad at describing what I did. I don't know how to say it short and accurately :D

Thanks!

Message #14 received at 41297 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "41297 <at> debbugs.gnu.org" <41297 <at> debbugs.gnu.org>
Subject: Re: [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
Date: Sat, 16 May 2020 12:06:54 +0200

On 16.05.20 11:57, Ekaitz Zarraga wrote:
> Hi,
>
>>
>> Maybe rephrase it to: Move pkg-config to native-inputs.
>>
>
> In fact, the pkg-config is the only one that it's not moved. The change is moving all of the others to inputs.
>
> I really bad at describing what I did. I don't know how to say it short and accurately :D

Ah, so it's the other way round. So move mesa, glu, glut and gtk+-2 to
inputs.

Message #17 received at 41297 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: "41297 <at> debbugs.gnu.org" <41297 <at> debbugs.gnu.org>
Subject: Re: [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
Date: Sat, 16 May 2020 10:24:47 +0000

Hi,

> Ah, so it's the other way round. So move mesa, glu, glut and gtk+-2 to
> inputs.

Short and accurate. Thanks

Here it goes:



From 9e6f5503fd8837bcbb03eed3a05d6105b1752fc3 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Date: Sat, 16 May 2020 12:22:09 +0200
Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

    * gnu/packages/engineering.scm (openctm): Move mesa, glu, glut and
    gtk+-2 to inputs
---
 gnu/packages/engineering.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index aec692174a..aab414bf0e 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2557,11 +2557,12 @@ official SDK.")
           (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
       (build-system gnu-build-system)
       (native-inputs
+       `(("pkg-config" ,pkg-config)))
+      (inputs
        `(("mesa" ,mesa)
          ("glu" ,glu)
          ("glut" ,freeglut)
-         ("gtk" ,gtk+-2)
-         ("pkg-config" ,pkg-config)))
+         ("gtk" ,gtk+-2)))
       (arguments
        `(#:tests? #f                              ;no tests
          #:phases
--
2.26.1

Message #20 received at 41297 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "41297 <at> debbugs.gnu.org" <41297 <at> debbugs.gnu.org>,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: [bug#41297] [PATCH] gnu: openctm: Correct inputs vs native-inputs
Date: Sat, 16 May 2020 19:24:31 +0200

Hi,

Ekaitz Zarraga <ekaitz <at> elenq.tech> skribis:

>>From 9e6f5503fd8837bcbb03eed3a05d6105b1752fc3 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
> Date: Sat, 16 May 2020 12:22:09 +0200
> Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs
>
>     * gnu/packages/engineering.scm (openctm): Move mesa, glu, glut and
>     gtk+-2 to inputs

Applied, thanks, and sorry for not catching it earlier!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.