GNU bug report logs - #41256
[PATCH] gnu: icedove: Add a desktop file.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41256 in the body.
You can then email your comments to 41256 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: guix-patches <at> gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH] gnu: icedove: Add a desktop file.
Date: Thu, 14 May 2020 13:49:53 +0200

Thunderbird upstream doesn't provide any desktop file. So we have
to create it downstream. I filed an upstream bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1637575

* gnu/packages/gnuzilla.scm (icedove)[phases]: Add install-desktop-file phase.
---
 gnu/packages/gnuzilla.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 8a926681e0..7bf9850e97 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1344,6 +1344,32 @@ standards of the IceCat project.")
            (lambda _ (invoke "./mach" "build")))
          (replace 'install
            (lambda _ (invoke "./mach" "install")))
+         ;; Thunderbird doesn't provide any .desktop file.
+         ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
+         (add-after 'install 'install-desktop-file
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (apps (string-append out "/share/applications")))
+               (mkdir-p apps)
+               (with-output-to-file (string-append apps "/icedove.desktop")
+                 (lambda _
+                   (format #t
+                           "[Desktop Entry]~@
+                            Name=Icedove~@
+                            Exec=~a/bin/icedove~@
+                            Icon=icedove~@
+                            GenericName=Mail/News Client~@
+                            Categories=Network;Email;~@
+                            Terminal=false~@
+                            StartupNotify=true~@
+                            MimeType=x-scheme-handler/mailto;~@
+                            Type=Application~@
+                            Actions=ComposeMessage;~@
+                            [Desktop Action ComposeMessage]~@
+                            Name=Write new message~@
+                            Exec=~@*~a/bin/icedove -compose~%"
+                           out))))
+             #t))
          (add-after 'install 'wrap-program
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
--
2.26.2

Message #8 received at 41256 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus via web <issues.guix.gnu.org <at> elephly.net>
To: 41256 <at> debbugs.gnu.org
Subject: [PATCH] gnu: icedove: Add a desktop file.
Date: Thu, 14 May 2020 14:50:50 +0200

This looks good to me!

Message #11 received at 41256 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Ricardo Wurmus via web <issues.guix.gnu.org <at> elephly.net>,
 41256 <at> debbugs.gnu.org
Subject: Re: [bug#41256] [PATCH] gnu: icedove: Add a desktop file.
Date: Fri, 15 May 2020 10:56:41 +0200

so is this good for push? I cannot do that myself.

On 14.05.20 14:50, Ricardo Wurmus via web wrote:
> This looks good to me!
>
>
>
>

Message #16 received at 41256-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>,
 41256-done <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: [bug#41256] [PATCH] gnu: icedove: Add a desktop file.
Date: Sat, 23 May 2020 21:16:51 +0200

[Message part 1 (text/plain, inline)]

Jonathan Brielmaier <jonathan.brielmaier <at> web.de> writes:

> Thunderbird upstream doesn't provide any desktop file. So we have
> to create it downstream. I filed an upstream bug:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
>
> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add install-desktop-file phase.

Applied, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 41256 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 41256 <at> debbugs.gnu.org
Cc: mbakke <at> fastmail.com, jonathan.brielmaier <at> web.de
Subject: Re: bug#41256: [PATCH] gnu: icedove: Add a desktop file.
Date: Sat, 23 May 2020 21:56:23 +0200

Hello,

Marius Bakke <mbakke <at> fastmail.com> writes:

> Jonathan Brielmaier <jonathan.brielmaier <at> web.de> writes:
>
>> Thunderbird upstream doesn't provide any desktop file. So we have
>> to create it downstream. I filed an upstream bug:
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
>>
>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add
>> install-desktop-file phase.

I'm a bit late at the party, but would it make sense to use
make-desktop-entry-file instead?

Regards,

-- 
Nicolas Goaziou

Message #22 received at 41256 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, 41256 <at> debbugs.gnu.org
Cc: jonathan.brielmaier <at> web.de
Subject: Re: bug#41256: [PATCH] gnu: icedove: Add a desktop file.
Date: Sat, 23 May 2020 22:18:53 +0200

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Jonathan Brielmaier <jonathan.brielmaier <at> web.de> writes:
>>
>>> Thunderbird upstream doesn't provide any desktop file. So we have
>>> to create it downstream. I filed an upstream bug:
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
>>>
>>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add
>>> install-desktop-file phase.
>
> I'm a bit late at the party, but would it make sense to use
> make-desktop-entry-file instead?

Probably, yes.  :-)

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 41256 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, 41256 <at> debbugs.gnu.org
Cc: mbakke <at> fastmail.com
Subject: Re: bug#41256: [PATCH] gnu: icedove: Add a desktop file.
Date: Sat, 23 May 2020 23:47:10 +0200

On 23.05.20 21:56, Nicolas Goaziou wrote:
>>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add
>>> install-desktop-file phase.
>
> I'm a bit late at the party, but would it make sense to use
> make-desktop-entry-file instead?
Oh Nicolas that is a good catch. I didn't know this nice function :P

But I wonder how to archive the compose action:
```
[Desktop Action ComposeMessage]~@
Name=Write new message~@
Exec=~@*~a/bin/icedove -compose~%"
```

With the field `actions` but how?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.