GNU bug report logs - #41242
Port feature/native-comp to Windows

Previous Next

Full log

Message #368 received at 41242 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: nicolasbertolo <at> gmail.com, 41242 <at> debbugs.gnu.org
Subject: Re: bug#41242: Port feature/native-comp to Windows - Determine the
 emacs root dir...
Date: Fri, 29 May 2020 14:26:37 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Andrea Corallo <akrl <at> sdf.org>
>> Cc: 41242 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
>> Date: Fri, 29 May 2020 12:12:49 +0000
>> 
>> question: what if instead of using Ffile_exists we just use fopen to
>> check if the file exists in dump_do_dump_relocation?
>> 
>> I think the origin of "the trouble" is just there while checking if a
>> file exists, the path in discussion should be already absolute by
>> construction so I suspect we do not need Fexpand_file to come into play.
>
> Will that work if the files were moved?

I think so yes, the absolute path under discussion is generated on
purpose using Vinvocation_directory as follow:

pdumper.c:5304
=====
	if (installation_state == UNKNOWN)
	  /* Check just once if is a local build or Emacs got installed. */
	  installation_state =
	    NILP (Ffile_exists_p (concat2 (Vinvocation_directory,
					   XCAR (comp_u->file))))
	    ? LOCAL_BUILD : INSTALLED;
====

  Andrea

-- 
akrl <at> sdf.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.