GNU bug report logs - #41242
Port feature/native-comp to Windows

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Bértolo <nicolasbertolo <at> gmail.com>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 41242 <at> debbugs.gnu.org
Subject: bug#41242: Port feature/native-comp to Windows
Date: Wed, 20 May 2020 15:48:52 -0300

[Message part 1 (text/plain, inline)]

> This won't compile on Posix because setjmp_ctx_func is under #ifdef
> _WIN32.

Fixed.

> Given setjmp_ctx_func is used only in emit_setjmp I suggest to invoke
> directly gcc_jit_context_get_builtin_function there while emitting the
> corresponding call.

Done.

> The following patches do not currently apply, please update them from
> your rebase branch:

> 0004-Handle-LISP_WORDS_ARE_POINTERS-and-CHECK_LISP_OBJECT.patch
> 0005-Remove-a-layer-of-indirection-for-access-to-pure-sto.patch

Done.

> While you are refreshing patches please have a look into the GNU style
> of the diff (spaces in function calls and in pointer declaration) ;)

Fixed :).

> Sorry, still looking at
> 0003-Handle-setjmp-taking-two-arguments-in-Windows.patch forgot to ask
> if you could comment on this change:
> >                                     comp.char_type,
> > -                                   sizeof (jmp_buf)),
> > +                                   sizeof (sys_jmp_buf)),

It is just a little bit more portable.

I uploaded new patches to https://github.com/nicber/emacs branch
feature/native-comp. Please tell me I if you'd rather I posted patches here.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.