From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 12:33:05 2020 Received: (at submit) by debbugs.gnu.org; 13 May 2020 16:33:05 +0000 Received: from localhost ([127.0.0.1]:59210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYuJd-0007Z3-CZ for submit@debbugs.gnu.org; Wed, 13 May 2020 12:33:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:52972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYuJb-0007Yv-Vl for submit@debbugs.gnu.org; Wed, 13 May 2020 12:33:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYuJa-0003j4-Pl for bug-guix@gnu.org; Wed, 13 May 2020 12:33:03 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYuJX-00020a-Oh for bug-guix@gnu.org; Wed, 13 May 2020 12:33:02 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay4-d.mail.gandi.net (Postfix) with ESMTPA id C5B12E000D for ; Wed, 13 May 2020 16:32:55 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 13 May 2020 16:32:55 +0000 From: Brice Waegeneire To: bug-guix@gnu.org Subject: guix deploy close ssh session after each store items sent Message-ID: <0156447bb0d526cdfe42d51a154a2bd3@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 Received-SPF: pass client-ip=217.70.183.196; envelope-from=brice@waegenei.re; helo=relay4-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 12:32:56 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hey Guix, “guix deploy” bugs; they keep coming! “guix deploy” doesn't make use of SSH channels[0], instead it close the SSH session each time after sending store items. This may be unnoticeable by users using a password-less SSH key (bad!) or an SSH agent (better!) but for the other it mean entering the password ~5 times per host per deployment which get old very quick. In my case I use a keycard that require me to physically interact with it for each authentication request, it means multiple touch per deployment, reducing it just one would be a great relief. [0]: https://github.com/artyom-poptsov/guile-ssh/blob/b11182d5582844df0c8d1fcb7177ff85f8ac3bcd/doc/api-sessions.texi#L17 - Brice From debbugs-submit-bounces@debbugs.gnu.org Fri May 15 02:59:54 2020 Received: (at 41238) by debbugs.gnu.org; 15 May 2020 06:59:54 +0000 Received: from localhost ([127.0.0.1]:35732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZUK2-00078q-0t for submit@debbugs.gnu.org; Fri, 15 May 2020 02:59:54 -0400 Received: from mail-lj1-f180.google.com ([209.85.208.180]:43562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZUJz-00078Q-6H for 41238@debbugs.gnu.org; Fri, 15 May 2020 02:59:52 -0400 Received: by mail-lj1-f180.google.com with SMTP id l19so1026933lje.10 for <41238@debbugs.gnu.org>; Thu, 14 May 2020 23:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zurqP/1rYVNbzc0imbPltRueYLIkDOX8WyEXVQx4D+M=; b=qCsWVNyP8oAW9BNlR25YjhH9zJhUJU4ZnMfONyOgk47CxcaGqAkHS7DoRvAsls6zfD xbVkOJW0t0PbIQk4KnQnZZYb03jfMoz2SkhckAwGkkwZ0lzZ2cMkWq0UzpK+GUIQTaVO beUyrNAICCFrZoLroGa4xVsZEMiF83HRMGFjKyKD/ob5KFcGc5qDcfro+qFFU5qOD5nm uNWdTXfYtJ8H9/azYhpasrCpiF1yQchudTQL/+OH48mRXGnV9UFoylX8xQUCJ1OmtIsK hcXCqVhU/yClaKusmvMysj7Vu6p6Vaw+ZJtrYnEkaSxOvw+GA+DxmvBPpP8+Admz8iAY EJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zurqP/1rYVNbzc0imbPltRueYLIkDOX8WyEXVQx4D+M=; b=IYrtL6jGi6FmfPIke9HLOFPc4gLgKU/J2Mq9//fbRSI3tWXCxpJ89LeJY5GKX+NT/o HcS3wXlZJLosiSuyA29e+EKoD2NIXu83f6FItWZbIJ9IX791jgenc0hSiPJTzeYr/8tU Ujo1PYFBdYVugP5IjT5ozkx34vzduui0mMjM2PxYI8wK5zXQxgTRHxC7xJ8vfpKZ4xY/ LnX6s4DjxV00jH3IwJVkM9KWiubr91xxwOnDCSqKl726E0I/AGDGUqXacWcw6Un9/uDt pp6avaLXsnKhOp55N/hh3Qq/PyVJMH8oCTEAdX2xgbWp82gk3lJMv6xh8Y3X5FNxkswR OmdQ== X-Gm-Message-State: AOAM5321TcbAp6mJSbv4eAI3rjUxdL9OyOOQmTrmY5iN9M9DAkf37NX9 9YKyryke9cbdfLL3H9B0JQ/57Yu2 X-Google-Smtp-Source: ABdhPJwuAYzgEZhnfFocLMr7IZhHsiUTkcLKWTju+Etkj8yTLxtTyk6SXIK9YltlCzT4DdMlMvmO1g== X-Received: by 2002:a2e:5808:: with SMTP id m8mr1342959ljb.244.1589525984543; Thu, 14 May 2020 23:59:44 -0700 (PDT) Received: from guixsd (92-100-245-224.dynamic.avangarddsl.ru. [92.100.245.224]) by smtp.gmail.com with ESMTPSA id l20sm760131lfj.10.2020.05.14.23.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 23:59:43 -0700 (PDT) From: Oleg Pykhalov To: Brice Waegeneire Subject: Re: bug#41238: guix deploy close ssh session after each store items sent References: <0156447bb0d526cdfe42d51a154a2bd3@waegenei.re> Date: Fri, 15 May 2020 09:59:38 +0300 In-Reply-To: <0156447bb0d526cdfe42d51a154a2bd3@waegenei.re> (Brice Waegeneire's message of "Wed, 13 May 2020 16:32:55 +0000") Message-ID: <87wo5du1id.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41238 Cc: 41238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Brice Waegeneire writes: > =E2=80=9Cguix deploy=E2=80=9D bugs; they keep coming! =E2=80=9Cguix deplo= y=E2=80=9D doesn't make use of SSH > channels[0], instead it close the SSH session each time after sending sto= re > items. Did you try a built in SSH's =E2=80=9CControl*=E2=80=9D feature? ssh_config (0) ControlMaster auto ControlPath ~/.ssh/master-%r@%h:%p ControlPersist yes --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl6+PdoACgkQFn+OpQAa +pyjMg/9F8rhtsyM7qsl2OwUoVCA593OoBGIgwbPCRlXVM3sioGm/Mi8f00rwquP x3slw7z7mf+dhKC2txbYvwkUQUCqVeFK58PrESFNdxZLWLxOqGXmEG4gBFDwwCd6 386XqrdO9AnLcvwxBGXKtB3nfk5ojCtg8hLKbcuU7wmCCnqjBsn456daRFzclN8T kaVa2Ge7XJhQ4ToqUiCK2xzAV3AqUv3cQFpJFghQG0RLmqFCXGVCa2ddZeLm5sDw WGX7ZNz+opkB0EiuO3J5ols4kuT/0trcxNMZpGRTNmlIgD1I24JKl+DwI9pIarsN W6kBwTnazplKCB0pRrIb6HE+544v3x6Ffb9rX9Pgd6Uf27uxw8QCH9npbHKQxpOv OKpnoJfgKmskbNmVvu8gkf1NZHRQWZzgQfvYWkkNHcF1RKjx9d6svTmCknTT5UGs 4mvu5PGeli4JNinKBSKAPYXZVxuZsk2MF9nZC7EheEsRYrLt7yT0+eM+o1D7g4U6 4d6oDFJsRVWCia26nmR0RxiJ5pOtz55vZzRo2CcwWVamkS9RVmplxYP4lhIaZpPu MVf9lV2bRD1YDpqafuVaNuQhKJSr8adV3LdeQ2gVQY2oWt7CreXeoLu1LvYpsyW4 X6A2vBxe7f2fHof2EZrwqEpZJvWKqVBzw3JmUwabEyZ0SIccsSs= =dNiI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 15 03:46:36 2020 Received: (at 41238) by debbugs.gnu.org; 15 May 2020 07:46:36 +0000 Received: from localhost ([127.0.0.1]:35773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZV3D-0008Ip-PZ for submit@debbugs.gnu.org; Fri, 15 May 2020 03:46:35 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:45299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZV3B-0008Ia-9S for 41238@debbugs.gnu.org; Fri, 15 May 2020 03:46:34 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay11.mail.gandi.net (Postfix) with ESMTPA id 373B4100004; Fri, 15 May 2020 07:46:26 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 15 May 2020 07:46:25 +0000 From: Brice Waegeneire To: Oleg Pykhalov Subject: Re: bug#41238: guix deploy close ssh session after each store items sent In-Reply-To: <87wo5du1id.fsf@gmail.com> References: <0156447bb0d526cdfe42d51a154a2bd3@waegenei.re> <87wo5du1id.fsf@gmail.com> Message-ID: X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41238 Cc: 41238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-05-15 06:59, Oleg Pykhalov wrote: > Brice Waegeneire writes: > >> “guix deploy” bugs; they keep coming! “guix deploy” doesn't make use >> of SSH >> channels[0], instead it close the SSH session each time after sending >> store >> items. > > Did you try a built in SSH's “Control*” feature? > > ssh_config (0) > > ControlMaster auto > ControlPath ~/.ssh/master-%r@%h:%p > ControlPersist yes Of course, it's my default setting for SSH (and the host I tried to deploy to). But “guix deploy” don't support it; it's the core of the issue here. I didn't mention those options in the initial bug report because IFAIK the ssh functionality for “guix deploy” is provided by guile-ssh, a wrapper around libssh which isn't related to OpenSSH in any way. So the “Control*” options doesn't apply here, instead they talk about channels and session[0] which seems to be the terms used in the SSH specification. [0]: https://api.libssh.org/stable/libssh_tutor_guided_tour.html From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 18 02:09:11 2022 Received: (at 41238-close) by debbugs.gnu.org; 18 Jan 2022 07:09:11 +0000 Received: from localhost ([127.0.0.1]:48672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ic9-0003HN-Bw for submit@debbugs.gnu.org; Tue, 18 Jan 2022 02:09:11 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:37515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ic3-0003Gl-4s for 41238-close@debbugs.gnu.org; Tue, 18 Jan 2022 02:09:07 -0500 Received: (Authenticated sender: brice@waegenei.re) by mail.gandi.net (Postfix) with ESMTPSA id 45F5F240006 for <41238-close@debbugs.gnu.org>; Tue, 18 Jan 2022 07:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waegenei.re; s=gm1; t=1642489736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VanBYohqUuTtlz0jDqLyqoGrieNVogluYhohXl8ra4w=; b=EhY2Bd+0R0uxpb9dju4Ic02sxCbp9GrydLpFUIJfC0oSe4HpP91hwAosGLOQqWKMf5/dsk alSOhB3PdmNu/sHaQF4p7ru0+VJABpHpcyk++tFUqFpPnyVjhPmH+Jw4aWmPz/m57u0JDl TJftKOCm0GzWd64ckOy2fu3l+B0+rw1ttwzxrPCAlC6h8hLovtPiKgpaNB1FZ+BC3qSsAO kJulswHWb6BUveOPUdh5Rx9Z4rd61+FEO6Ckrj5In62/mjcqoVdkXSVN+HDr5VJ9ljtPm1 4iNVpjlknjcO6TYu1i53RZm11cR0O4AOtqrYriGCLERxQMtdDNBaGJwFke8WIQ== From: Brice Waegeneire To: 41238-close@debbugs.gnu.org Subject: Re: bug#41238: guix deploy close ssh session after each store items sent References: <0156447bb0d526cdfe42d51a154a2bd3@waegenei.re> Date: Tue, 18 Jan 2022 08:08:51 +0100 In-Reply-To: <0156447bb0d526cdfe42d51a154a2bd3@waegenei.re> (Brice Waegeneire's message of "Wed, 13 May 2020 16:32:55 +0000") Message-ID: <871r15tta4.fsf@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41238-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Guix, Brice Waegeneire writes: > =E2=80=9Cguix deploy=E2=80=9D bugs; they keep coming! =E2=80=9Cguix deplo= y=E2=80=9D doesn't make use of SSH > channels[0], instead it close the SSH session each time after sending sto= re > items. [...] Ludo=E2=80=98 fixed the issue with the commit 7f20e59a13a6acc3331e04185b8f1= ed2538dcd0a. For posterity, here is the workaround I was using a few month ago and is now unecessary. The session filed needed to be manually set with a call to "openssh-ssh-session" from (guix ssh): --8<---------------cut here---------------start------------->8--- (machine-ssh-configuration (host-name "foo") (system "x86_64-linux") (session (open-ssh-session "foo" #:user "root")) (host-key "...")) --8<---------------cut here---------------end--------------->8--- Currently the following suffice: --8<---------------cut here---------------start------------->8--- (machine-ssh-configuration (host-name "foo") (system "x86_64-linux") (user "root")=20 (host-key "...")) --8<---------------cut here---------------end--------------->8--- Cheers, - Brice From unknown Sat Sep 06 10:20:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Feb 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator