GNU bug report logs - #41230
[PATCH] gnu: Add libqglviewer.

Previous Next

Package: guix-patches;

Reported by: Kei Kebreau <kkebreau <at> posteo.net>

Date: Wed, 13 May 2020 12:45:01 UTC

Severity: normal

Tags: patch

Done: Kei <kkebreau <at> posteo.net>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 41230-done <at> debbugs.gnu.org (full text, mbox):

From: Kei <kkebreau <at> posteo.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 41230-done <at> debbugs.gnu.org
Subject: Re: [bug#41230] [PATCH] gnu: Add libqglviewer.
Date: Wed, 13 May 2020 17:05:30 -0400

On Wed, 2020-05-13 at 21:52 +0200, Ricardo Wurmus wrote:
> Kei Kebreau <kkebreau <at> posteo.net> writes:
> 
> > * gnu/packages/qt.scm (libqglviewer): New variable.
> 
> Looks good to me!
> 
> > +    (arguments
> > +     '(#:tests? #f                      ; no check target
> > +       #:make-flags (list (string-append "PREFIX="
> > +                                         (assoc-ref %outputs
> > "out")))
> 
> Except for the formatting here.  I’d break the line before “(list”.
> 

Done and pushed to master as commit e792dd3244.  Thanks for the review!
This bug report was last modified 5 years and 13 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.