Subject: bug#41230: closed (Re: [bug#41230] [PATCH] gnu: Add libqglviewer.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 13 May 2020 21:06:02 +0000

Your bug report

#41230: [PATCH] gnu: Add libqglviewer.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41230: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41230
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#41230] [PATCH] gnu: Add libqglviewer.
From: Kei <[email-masked]>
To: Ricardo Wurmus <[email-masked]>
Cc: [email-masked]
Date: Wed, 13 May 2020 17:05:30 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On Wed, 2020-05-13 at 21:52 +0200, Ricardo Wurmus wrote:
> Kei Kebreau <[email-masked]> writes:
> 
> > * gnu/packages/qt.scm (libqglviewer): New variable.
> 
> Looks good to me!
> 
> > +    (arguments
> > +     '(#:tests? #f                      ; no check target
> > +       #:make-flags (list (string-append "PREFIX="
> > +                                         (assoc-ref %outputs
> > "out")))
> 
> Except for the formatting here.  I’d break the line before “(list”.
> 

Done and pushed to master as commit e792dd3244.  Thanks for the review!

Subject: [PATCH] gnu: Add libqglviewer.
From: Kei Kebreau <[email-masked]>
To: [email-masked]
Cc: Kei Kebreau <[email-masked]>
Date: Wed, 13 May 2020 08:44:07 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/qt.scm (libqglviewer): New variable.
---
 gnu/packages/qt.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 9d54fde887..caa758d59f 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2018 John Soo <[email-masked]>
 ;;; Copyright © 2020 Mike Rosset <[email-masked]>
 ;;; Copyright © 2020 Jakub Kądziołka <[email-masked]>
+;;; Copyright © 2020 Kei Kebreau <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2698,3 +2699,46 @@ generate Python bindings for your C or C++ code.")
     (description
      "Contains lupdate, rcc and uic tools for PySide2")
     (license license:gpl2)))
+
+(define-public libqglviewer
+  (package
+    (name "libqglviewer")
+    (version "2.7.2")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append "http://libqglviewer.com/src/libQGLViewer-"
+                              version ".tar.gz"))
+              (sha256
+               (base32
+                "023w7da1fyn2z69nbkp2rndiv886zahmc5cmira79zswxjfpklp2"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f                      ; no check target
+       #:make-flags (list (string-append "PREFIX="
+                                         (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key make-flags #:allow-other-keys)
+             (apply invoke (cons "qmake" make-flags)))))))
+    (native-inputs
+     `(("qtbase" ,qtbase)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("glu" ,glu)))
+    (home-page "http://libqglviewer.com")
+    (synopsis "Qt-based C++ library for the creation of OpenGL 3D viewers")
+    (description
+     "@code{libQGLViewer} is a C++ library based on Qt that eases the creation
+of OpenGL 3D viewers.
+
+It provides some of the typical 3D viewer functionalities, such as the
+possibility to move the camera using the mouse, which lacks in most of the
+other APIs.  Other features include mouse manipulated frames, interpolated
+keyFrames, object selection, stereo display, screenshot saving and much more.
+It can be used by OpenGL beginners as well as to create complex applications,
+being fully customizable and easy to extend.")
+    ;; According to LICENSE, either version 2 or version 3 of the GNU GPL may
+    ;; be used.
+    (license (list license:gpl2 license:gpl3))))
-- 
2.26.2