GNU bug report logs - #41225
[PATCH] Show bookmark list in new tab

Previous Next

Package: emacs;

Reported by: Matthias Meulien <orontee <at> gmail.com>

Date: Wed, 13 May 2020 00:06:02 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #20 received at 41225 <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 41225 <at> debbugs.gnu.org
Subject: Re: bug#41225: [PATCH] Show bookmark list in new tab
Date: Sun, 09 Aug 2020 16:35:43 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> And I'm not sure this is safe.  For one, if you load the file 
> twice, you'll get this added twice.  And it's destructively 
> modifying a list that's dumped with Emacs, which I think is 
> undefined behaviour?

Nice catch. I must admit I don't know the dump mecanism at all...

> So I've added a new utility function custom-add-choice to 
> custom.el that checks for double entry, and doesn't modify 
> anything destructively, and pushed this to Emacs 28.1. 

I tested master today and it works like a charm. Thanks for your 
careful reading and improvements!
-- 
Matthias
This bug report was last modified 4 years and 289 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.