From unknown Mon Jun 23 00:35:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41225: [PATCH] Show bookmark list in new tab Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 May 2020 00:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 41225@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158932833124501 (code B ref -1); Wed, 13 May 2020 00:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 May 2020 00:05:31 +0000 Received: from localhost ([127.0.0.1]:56898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYetv-0006N7-GL for submit@debbugs.gnu.org; Tue, 12 May 2020 20:05:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:47018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYett-0006Mz-Fg for submit@debbugs.gnu.org; Tue, 12 May 2020 20:05:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYett-0006uj-Bj for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 20:05:29 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:33112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYetr-00029p-VV for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 20:05:29 -0400 Received: by mail-wm1-x332.google.com with SMTP id d207so7584975wmd.0 for ; Tue, 12 May 2020 17:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=xRtEiMW408QBLUAVbFJKVe28gLq1coJMvfc6Tc1DexQ=; b=X+KIOlTCiRs38wzeMWXG+9FB3EJsFY6ypCm7xEv2egEKTMB6F//NLbNoZsgOh43gM0 cAXGEi7Lxw9FMBEG/LriP8Scb5Z3ouXuJCHPQbpirxdg7Y/WEfyFc3g322YLmWJvmmfh fKAj5NuMHJocpAK+7mpg83iCG+Ztdm0vPmVFGsG91P98al/9Ad54/1nR0asNv8XGnFGP YKESznymeCmqSR30UF7LDZLdR3hDFigx7ZPYGTIRPp0m9c9+3I4KwMiSUh3+Vmxnw80k 5k2xj7YR10zjcI5QO+DTAA+UKJQTALsLuGr6qaznYFpEh7KbVGIf3GzfnE+KFn1uiQ93 l++A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=xRtEiMW408QBLUAVbFJKVe28gLq1coJMvfc6Tc1DexQ=; b=U8wG/nx/ISEdiPRZv5mEWqOrPpDuvvtUNPPCGNs4DAOQluJIXlql2ZDVu9zHqsSTBp bHUeGCNoQlRCuR/rmlmJt5hqTJ2eF9whH518ny7JFAPkUMe7pk1J6IWZp+3Lvd+vpeEc 0HShPrvC3cYw+WEiVQ4tqebrtgkz2Z5KDRJWDwwJhS802cWwd4QyeynCVIJipAhWoys6 X1zDjb7uIcbG0PZQVL/EjzYS1DLqJDR4B2+7tyGU7+3k3pi1bpH38x7Kt8iF4BKLbF1K +uKRM/pNqO14pn3uRpSj/1Ufjhj58310kAsaZ+rBV99u/XROyZIYL2jr8F01+Q9AVOkx bqBA== X-Gm-Message-State: AGi0PubXlvMdKlHJxHgix2vvfC6C/ikWHfCxCMteGfrXRC+gcwCmNZrT 6/al39NhDPyMgM70tth19JAd1SaCt2w= X-Google-Smtp-Source: APiQypJerq+SgrPaNSRzVHrQzVPsQ9KqstdhRlMdRbYAxbe7V/9Fd5I/qv283UovBN3vhoNpkHNqEA== X-Received: by 2002:a7b:c927:: with SMTP id h7mr39320156wml.122.1589328325622; Tue, 12 May 2020 17:05:25 -0700 (PDT) Received: from carbon.localdomain ([2a01:e0a:252:7910:f1be:8104:293:6ee2]) by smtp.gmail.com with ESMTPSA id a67sm35997567wmc.30.2020.05.12.17.05.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 17:05:24 -0700 (PDT) From: Matthias Meulien Date: Wed, 13 May 2020 02:05:23 +0200 Message-ID: <87eerok8cc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=orontee@gmail.com; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed A small patch that adds a customize choice to `tab-bar-new-tab-choice` in order to show bookmark list in new tab. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-bookmark.el-Customize-choice-to-show-bookmark-l.patch >From 67bc218224a548699e974d3276f54ae698987d93 Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Tue, 12 May 2020 21:51:40 +0200 Subject: [PATCH] lisp/bookmark.el: Customize choice to show bookmark list in a new tab --- etc/NEWS | 5 +++++ lisp/bookmark.el | 14 ++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index 01c584833b..f3725e954b 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -348,6 +348,11 @@ symbol property to the browsing functions. With a new command 'browse-url-with-browser-kind', an URL can explicitly be browsed with either an internal or external browser. +** bookmark + +When the 'bookmark.el' library is loaded, a customize choice is added +to 'tab-bar-new-tab-choice' for new tab to show the bookmark list. + ** vc-dir.el *** Support for bookmark.el. diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 0fa77ed322..3a8b07f241 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1666,6 +1666,20 @@ bookmark-bmenu-surreptitiously-rebuild-list (bookmark-bmenu-list))))) +;;;###autoload +(defun bookmark-bmenu-get-buffer () + "Return the Bookmark List, building it if it doesn't exists. +Don't affect the buffer ring order." + (cond + ((get-buffer bookmark-bmenu-buffer)) + (t (save-excursion + (save-window-excursion + (bookmark-bmenu-list) + (get-buffer bookmark-bmenu-buffer)))))) + +(nconc (get 'tab-bar-new-tab-choice 'custom-type) + '((const :tag "Bookmark List" bookmark-bmenu-get-buffer))) + ;;;###autoload (defun bookmark-bmenu-list () "Display a list of existing bookmarks. -- 2.20.1 --=-=-= Content-Type: text/plain; format=flowed -- Matthias Meulien --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 20 11:48:22 2020 Received: (at control) by debbugs.gnu.org; 20 May 2020 15:48:22 +0000 Received: from localhost ([127.0.0.1]:54065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbQxB-0004sI-Of for submit@debbugs.gnu.org; Wed, 20 May 2020 11:48:21 -0400 Received: from mail-il1-f182.google.com ([209.85.166.182]:35622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbQx9-0004s5-Ve for control@debbugs.gnu.org; Wed, 20 May 2020 11:48:20 -0400 Received: by mail-il1-f182.google.com with SMTP id a14so3606961ilk.2 for ; Wed, 20 May 2020 08:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=Pn4hhQvTgNVRTppFgKDLOsssGUabYCLGI7+z92BfvH4=; b=fBUiByNSuLZAjPbmGywNS1r8HB3iVu825RrfX7xu2BJ73SZkLpC3Eg2iOG7MNRKpY/ HRVAyN20nPii2DuFpiE7v8oosHGs57vxWt2G2Zety/xAmtVyqp8smxwdA3nV68DVpQIY 38ARH3T30zrhkFZA3RRjVFcJpR6NajFhT6yDhWXWH7M0YIOi0sluPVVBmRR4vo06KDJa KvnKOU9UK4JQqKqtyUKIdkb8MAE+LGppCnqXuoHyBUJKjstKUKpW07ydtCGsOKwqGXoX 75HbjkFEDgSUGmAf9pB4cT1sp4tzLw4EDOkrkQsW+BuaoBnAMcN4I3lAswDcWgC7LJG4 a1mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Pn4hhQvTgNVRTppFgKDLOsssGUabYCLGI7+z92BfvH4=; b=rrQr+a1fqX7bt3eBLiocWQBEeMJLhMNjXC8Kw/8pxswEi77xLeHxElyNb02xfH+UOs dgk5kjj3e6iuldy6KJYc0nV3BIcnqIIuzlUpvTTtoHn+tzvsoA9V4sbkl6iEaRR843jY KjKKN00eJiIk8Z51ObfuKsLmxjZTIkPBpbsobKrnLfuxHvWX483cqH916rQHbrMMn6qd l51wTaIlwF7NssWxPPHrGHj4z/6ggBRL+q0lnoS132uDizZy4zGfTP9ssPc/iE7njIQT ffglV7WcsWTwwyeRkp2aJdaemgCupU9AKC1hecRMidJFsuc5VY9UXPMr+V3WHI7zvJlu M1/Q== X-Gm-Message-State: AOAM5300hwkvXAHU3mfs0XZBfvpWAvdWa5OYnGg7Y3hNkC/U6ZGkI9gF OLkYD2e03YpXF+UCO+yZ9cQzzQda X-Google-Smtp-Source: ABdhPJyopNSFaXLD4NfnE5synarBVah9BoLQNzVOGzhweR4xA8gYdB4GPrzDBpHkxOZs2x6xp0KOQg== X-Received: by 2002:a92:9e51:: with SMTP id q78mr4586712ili.268.1589989694166; Wed, 20 May 2020 08:48:14 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id m17sm1520193ilh.51.2020.05.20.08.48.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 May 2020 08:48:13 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #41410 Date: Wed, 20 May 2020 11:48:12 -0400 Message-ID: <85mu62ober.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 41410 wishlist tags 41410 + patch tags 41239 + confirmed severity 41094 minor severity 41065 minor severity 41029 wishlist tags 41029 + patch severity 40972 minor severity 41328 wishlist severity 41225 wishlist quit From unknown Mon Jun 23 00:35:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41225: [PATCH] Show bookmark list in new tab Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Aug 2020 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Matthias Meulien Cc: 41225@debbugs.gnu.org Received: via spool by 41225-submit@debbugs.gnu.org id=B41225.159688727610308 (code B ref 41225); Sat, 08 Aug 2020 11:48:02 +0000 Received: (at 41225) by debbugs.gnu.org; 8 Aug 2020 11:47:56 +0000 Received: from localhost ([127.0.0.1]:58318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NKO-0002gB-8B for submit@debbugs.gnu.org; Sat, 08 Aug 2020 07:47:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NKK-0002fl-1K for 41225@debbugs.gnu.org; Sat, 08 Aug 2020 07:47:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KGl2JARhH5XYWJW7W5LgPMqQ3VrrTN5ue1GTtKbPCLg=; b=aLYJtlfakz5slhoVCtwjDsGtX4 ArGW7OPZPB0mOleIW4FYsdJMMMiN481YMq3/wgnQ6yCw7S4chCK2e15nnFoVQrnMRr9MN6VBVMjuy iBr0Q37GSXHMJAOVv3J8ZRI06DVy6G2tEfh5XMhLt7LXTC4vWHyj7Qthml8o4XXkj6i4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4NK8-0003qk-9J; Sat, 08 Aug 2020 13:47:45 +0200 From: Lars Ingebrigtsen References: <87eerok8cc.fsf@gmail.com> Date: Sat, 08 Aug 2020 13:47:38 +0200 In-Reply-To: <87eerok8cc.fsf@gmail.com> (Matthias Meulien's message of "Wed, 13 May 2020 02:05:23 +0200") Message-ID: <87ft8x4aw5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matthias Meulien writes: > A small patch that adds a customize choice to `tab-bar-new-tab-choice` > in order to show bookmark list in new tab. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matthias Meulien writes: > A small patch that adds a customize choice to `tab-bar-new-tab-choice` > in order to show bookmark list in new tab. [...] > +When the 'bookmark.el' library is loaded, a customize choice is added > +to 'tab-bar-new-tab-choice' for new tab to show the bookmark list. Makes sense to me. > +;;;###autoload > +(defun bookmark-bmenu-get-buffer () > + "Return the Bookmark List, building it if it doesn't exists. > +Don't affect the buffer ring order." > + (cond > + ((get-buffer bookmark-bmenu-buffer)) > + (t (save-excursion > + (save-window-excursion > + (bookmark-bmenu-list) > + (get-buffer bookmark-bmenu-buffer)))))) I changed this bit into an `or' before committing. > +(nconc (get 'tab-bar-new-tab-choice 'custom-type) > + '((const :tag "Bookmark List" bookmark-bmenu-get-buffer))) And I'm not sure this is safe. For one, if you load the file twice, you'll get this added twice. And it's destructively modifying a list that's dumped with Emacs, which I think is undefined behaviour? So I've added a new utility function custom-add-choice to custom.el that checks for double entry, and doesn't modify anything destructively, and pushed this to Emacs 28.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 08 07:48:00 2020 Received: (at control) by debbugs.gnu.org; 8 Aug 2020 11:48:00 +0000 Received: from localhost ([127.0.0.1]:58321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NKS-0002gV-H5 for submit@debbugs.gnu.org; Sat, 08 Aug 2020 07:48:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NKQ-0002g0-Fb for control@debbugs.gnu.org; Sat, 08 Aug 2020 07:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LeHGCQ6fK2wm17y8leiDvOaKrYN98x6hL+R+KOB6Hvo=; b=jhaE37AQLcEeJwsbPgorNo9gur 79mLPDfwKvr+oEGAfqoCL7/T3b3YZbpvrLB0ukWDCWwonrebQRmn2AjJUJ9XWUiZbc8BkILwXZfBl pF3eYlO5G7WxZKvOq4233/l/Qec12NDiQ5CKmoRrc/7JtDW/zmm2Qvx4k7LgHllVHubw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4NKI-0003qs-L6 for control@debbugs.gnu.org; Sat, 08 Aug 2020 13:47:52 +0200 Date: Sat, 08 Aug 2020 13:47:49 +0200 Message-Id: <87eeoh4avu.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41225 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 41225 fixed close 41225 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 41225 fixed close 41225 28.1 quit From unknown Mon Jun 23 00:35:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41225: [PATCH] Show bookmark list in new tab Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Aug 2020 11:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Matthias Meulien Cc: 41225@debbugs.gnu.org Received: via spool by 41225-submit@debbugs.gnu.org id=B41225.159688737110576 (code B ref 41225); Sat, 08 Aug 2020 11:50:01 +0000 Received: (at 41225) by debbugs.gnu.org; 8 Aug 2020 11:49:31 +0000 Received: from localhost ([127.0.0.1]:58328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NLu-0002kU-TZ for submit@debbugs.gnu.org; Sat, 08 Aug 2020 07:49:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4NLs-0002k7-Pz for 41225@debbugs.gnu.org; Sat, 08 Aug 2020 07:49:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=M6WavGWzUSxGZo24iU9Z3C7qgab28i5e+Xx5Yv1oO/M=; b=AoZLkCLPRrxIu8tKfU7HKHcLGT 9xpJQNqAPJ8RC9NwQFlRICke3BAzxzec+WitmqoinXjKTcNpq/EECrRujr9QcH/4pq6ub3B5y39gX wlXkr9iHnOjfu9z6L1yeGAT8NTvMhKYp3Ck0bK7woBIbzrvbo729VwJ1leeVmbES7BHE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4NLk-0003ra-Al; Sat, 08 Aug 2020 13:49:22 +0200 From: Lars Ingebrigtsen References: <87eerok8cc.fsf@gmail.com> <87ft8x4aw5.fsf@gnus.org> Date: Sat, 08 Aug 2020 13:49:19 +0200 In-Reply-To: <87ft8x4aw5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 08 Aug 2020 13:47:38 +0200") Message-ID: <87a6z54atc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > So I've added a new utility function custom-add-choice to custom.el that > checks for double entry, and doesn't modify anything destructively, and > pushed this to Emacs 28.1. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > So I've added a new utility function custom-add-choice to custom.el that > checks for double entry, and doesn't modify anything destructively, and > pushed this to Emacs 28.1. (The function seems like a somewhat generally useful function for modes to use to add more choices, which is why I didn't keep it as a bookmark-specific change.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 23 00:35:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41225: [PATCH] Show bookmark list in new tab Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Lars Ingebrigtsen Cc: 41225@debbugs.gnu.org Received: via spool by 41225-submit@debbugs.gnu.org id=B41225.159698375425445 (code B ref 41225); Sun, 09 Aug 2020 14:36:01 +0000 Received: (at 41225) by debbugs.gnu.org; 9 Aug 2020 14:35:54 +0000 Received: from localhost ([127.0.0.1]:33262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4mQT-0006cI-Py for submit@debbugs.gnu.org; Sun, 09 Aug 2020 10:35:53 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:38646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4mQR-0006c5-RT for 41225@debbugs.gnu.org; Sun, 09 Aug 2020 10:35:52 -0400 Received: by mail-wm1-f52.google.com with SMTP id t14so6008828wmi.3 for <41225@debbugs.gnu.org>; Sun, 09 Aug 2020 07:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=v6D4+AZfOoqiYl59LziZAaVFso6nNJveR0CuRe0kQeM=; b=W1R3kVEC/nmqePgH/KeYgnMGoZS90XP05GLbBH/x9kOimKsh43xPBIwqn7jvHJyJ1n S2uMsRnpIW8UCOYYxwAlvrMmBspYramOq39z84bxuPLJ5w4AyAi8ork3CEMouIZzElV6 GxqNNfGP8m0ufoskdPZPTukw6kDxiYIPAYd7LSGxPm+KdZCY9oM7Lz5vf2kfdrrmBBwE 1JFoDld558wFrLN7UwQJGAOrzmHaC1nddevaOck8IFuww/Ba6V8+1zFNocQqCXpIg4U+ vgkcFPjA/rT9kzSwfISv+Sta64MnkpEwmJERp1JGmDCY/acD3FTtwumsOBfCm0YInEB/ y7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=v6D4+AZfOoqiYl59LziZAaVFso6nNJveR0CuRe0kQeM=; b=EdrN9yxat39IntJy28cfdDr9nHksGYMRnMZsn5UosbKkIPneZiMnp6j2D3I/ouh7+/ 1wnQ3WsGT66+i8NTrpfyDyqX62+NFQeVCfr0bcIeEdlyr5+MV1qSsYzmaLE6G595rgAm jSZQoqv+Bg252YeyIJQDl+7JBCW4QJBf1RQj6u3QfzwLiJT5kZKlJFD6F/fSPS9A4BNd QbdlKyqfgI5Cfyc7sLHOxRqiSWuANFWiH7sxej/tWdnqynIyzzgaw8kiyBwozKQEH/a/ EZERni0TvuU/Z60FX6hzJTMgvaj99dS0DI3HMBT3bphiK+wduuytcW4wiyx/LJWz1vXQ J9+Q== X-Gm-Message-State: AOAM532uCLGMf5wLGtzlN7DRgitNFYvqX/c4m1WmHl6py9TBSNwgkH6n oJGrB/W2ZS9JTfuFToypxPCr8ocwXgE= X-Google-Smtp-Source: ABdhPJx0dbrFjBvlAJ6PcCOwpO/VQTOmwYUCxV5bT3wPeFXoOJk7GMqH+qwPnDWYegk8xFfVmmaRKQ== X-Received: by 2002:a1c:4c17:: with SMTP id z23mr22506513wmf.49.1596983745622; Sun, 09 Aug 2020 07:35:45 -0700 (PDT) Received: from carbon.localdomain ([2a01:e0a:252:7910:679d:a1d5:8917:cc97]) by smtp.gmail.com with ESMTPSA id z11sm16673581wrw.93.2020.08.09.07.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2020 07:35:44 -0700 (PDT) From: Matthias Meulien References: <87eerok8cc.fsf@gmail.com> <87ft8x4aw5.fsf@gnus.org> Date: Sun, 09 Aug 2020 16:35:43 +0200 In-Reply-To: <87ft8x4aw5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 08 Aug 2020 13:47:38 +0200") Message-ID: <87y2mnubsw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > And I'm not sure this is safe. For one, if you load the file > twice, you'll get this added twice. And it's destructively > modifying a list that's dumped with Emacs, which I think is > undefined behaviour? Nice catch. I must admit I don't know the dump mecanism at all... > So I've added a new utility function custom-add-choice to > custom.el that checks for double entry, and doesn't modify > anything destructively, and pushed this to Emacs 28.1. I tested master today and it works like a charm. Thanks for your careful reading and improvements! -- Matthias From unknown Mon Jun 23 00:35:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41225: [PATCH] Show bookmark list in new tab Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 19:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Matthias Meulien Cc: 41225@debbugs.gnu.org Received: via spool by 41225-submit@debbugs.gnu.org id=B41225.1597002686852 (code B ref 41225); Sun, 09 Aug 2020 19:52:01 +0000 Received: (at 41225) by debbugs.gnu.org; 9 Aug 2020 19:51:26 +0000 Received: from localhost ([127.0.0.1]:33551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4rLp-0000Df-V5 for submit@debbugs.gnu.org; Sun, 09 Aug 2020 15:51:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4rLo-0000DR-9T for 41225@debbugs.gnu.org; Sun, 09 Aug 2020 15:51:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DwlOL/nGQvKgJbeSRm3QnWi5ZCv4z/kkrL9NRxybMSs=; b=VpiTHQ6+Y+NI69aB0Zx6paOogn wyfF+lGEU6irjNY1gzqzMQDWa8MO4d5sV39B4tewXvPteKNRT7PVHZbuY9xIlFBHr+O4Y5PD5apJ4 M2khu1xJlkKrIOt1CbUFnJ5X3+usZKHjTvX7WkDc0rRZdcdB2TwlHTUT1FKKRiDhUygY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4rLf-00032J-RO; Sun, 09 Aug 2020 21:51:18 +0200 From: Lars Ingebrigtsen References: <87eerok8cc.fsf@gmail.com> <87ft8x4aw5.fsf@gnus.org> <87y2mnubsw.fsf@gmail.com> Date: Sun, 09 Aug 2020 21:51:14 +0200 In-Reply-To: <87y2mnubsw.fsf@gmail.com> (Matthias Meulien's message of "Sun, 09 Aug 2020 16:35:43 +0200") Message-ID: <87lfina98t.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matthias Meulien writes: > I tested master today and it works like a charm. Thanks for your > careful reading and improvements! Thanks for checking. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matthias Meulien writes: > I tested master today and it works like a charm. Thanks for your > careful reading and improvements! Thanks for checking. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no