From debbugs-submit-bounces@debbugs.gnu.org Tue May 12 18:56:14 2020 Received: (at submit) by debbugs.gnu.org; 12 May 2020 22:56:14 +0000 Received: from localhost ([127.0.0.1]:56809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYdos-0004Rn-AC for submit@debbugs.gnu.org; Tue, 12 May 2020 18:56:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:48848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYdSU-0003pv-BS for submit@debbugs.gnu.org; Tue, 12 May 2020 18:33:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYdSU-0001L1-3e for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 18:33:06 -0400 Received: from mail-vi1eur05olkn2075.outbound.protection.outlook.com ([40.92.90.75]:31072 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYdSR-0000kY-QM for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 18:33:05 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKc9+zZFmpMlIRRT9y/z0tQcy/XsthrCcTfUUphIaG8chJ4tAaI2L+UJbWA85DEdZWwwZeZhbi57Rui6idggHDKk18gWwkyd+BzQFXh6PSvp3zrm5LKK34+B3WLrGHVtTchVqxOOcK6kOLSz3GdH638tJHgcmuu0UBci5pMsCFtP7zKVIwO/NNMpMUs0ncGTY8wlofBymjuNWDPMfCxpnFtZywDg+UkMTWUCridPEhCF55Ot+/IlTrM/PSVWP+u3Y0d0IuCCFyHVe3lMtRuQg3RHpVkPIfqHiDn3eaxcmBQ0UsofPkffll+Ybi0K6Wmp0VGtNdq0pBTsjRzjJBkfKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DdIZ7NvnoESKkqyqsQZz46lnM4UftVq1UvL/ab6bqFQ=; b=hyQYm8pVtrV1J+dzSHGO4xx8LQN20bQFqvXWkWXgqZXtX+8qtjtM/cJ1vgHdLOxXrXMiBD91ImEV3I3LVU62S3+dDuYgdD/ZHRiJ+4OQnWWqBESkHZQK95jcNmz3vjMUKKoJmbiz8N8nOoPJB2zWro6ffx/u3ovs33g/KgVH/JYJHj14HIKHBKs7XXTf4FGoqD6yZV7Aw6IPhjLGrLtvS0HE6inNq07SAyr78K7a3hn4Ckl5XPHEh31+YxX4lUSUhsEixFSQ5B92a4bunnf1KPWj7WW7Tq7+oRPPOlMPxw7nJ5BlP5lBK4HjEfCITs2QGXYcYoAUpZKSEIw1B29/zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DdIZ7NvnoESKkqyqsQZz46lnM4UftVq1UvL/ab6bqFQ=; b=JEQ26zD7hk8WjVHEOP6hx+pfcIwUk9eZNahnSQRTtGeqOeBiopeCw3gaX9a34CN8etR2aEuUXJhlaMtluyLYfgJalAdSFDyojxjtO9Z8ICp+7wYoeK60IHEt7duhtJaNo+Qx4QxhVrJupcruj0Ywh0Uxzf2fWQRYDETLmBwFxiLQ4HdF+GnELpL8oU75Ua+4mvRmePAVYLOFA0B1YvBFjHuWhBkBUtgXhHZHMBU7jzwt42qnFUqGb0Kf99Bxjy3s0AoU0GPlTW80aSKeySFRPE7o21mllyt3uqLpSiF0jIo6Wl3J64ecuZvOhjW3xb++5oYrrB4QIv/vd4Er6gN/1Q== Received: from DB8EUR05FT031.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::4c) by DB8EUR05HT191.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::309) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Tue, 12 May 2020 22:18:00 +0000 Received: from VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:fc0f::4a) by DB8EUR05FT031.mail.protection.outlook.com (2a01:111:e400:fc0f::449) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Tue, 12 May 2020 22:18:00 +0000 Received: from VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM ([fe80::cdcf:4451:1409:86a9]) by VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM ([fe80::cdcf:4451:1409:86a9%2]) with mapi id 15.20.2979.033; Tue, 12 May 2020 22:18:00 +0000 From: Simon Lang To: "bug-gnu-emacs@gnu.org" Subject: Add some ediff faces to misterioso theme to improve readability Thread-Topic: Add some ediff faces to misterioso theme to improve readability Thread-Index: AQHWKKrWrbztuwWmM0ecwcexgeYYPw== Date: Tue, 12 May 2020 22:18:00 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:11931B39447E928989F26E330069269826F131EE1DB7FCE6DBF8EFFE07BE9890; UpperCasedChecksum:50C1C55F458BFD83AAC9E54F591750D0B6ED088592E0145C11D3E2A8AE9C93C0; SizeAsReceived:6784; Count:43 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [vvoKRDZv5zuFfq4VvF/F24rx/3rBw+u1] x-ms-publictraffictype: Email x-incomingheadercount: 43 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: a27fd416-9ba5-4c5e-d754-08d7f6c254c2 x-ms-traffictypediagnostic: DB8EUR05HT191: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bNcrM28vO/4XKP4XrhicCEx9jqwK2Y9eoorwTqrEgTrPQTdYXZAC1Lhq6mH8A4BmLwbDYi6fD6ew8YFDBP24LCxzfxyFL7a1CYHrOZQQTF00/AqJgLN3dhoI2RLkjExoBLzAjlxPyPY9Cgs4VcUUyNW+yrZTFnIc9Md4i+9v0OC9WPIfLzVgjaGBw5MgXk6huHi+cy3JTsoFdXQYAiATWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; x-ms-exchange-antispam-messagedata: RLZqb6Yf0oZ825D5wn2xG8PmP7lNB9DPjMBkY8KKi/achZ9kI5CL4v3VTLXyUixJZddv2IHbNpTFuIEOJ9DsZI3uAVaW2B3xrFgUZrVbc8PLgDHGjYTAykiwt3m9imx5cGV9rxO/ZT07/+g0pYhuyA== x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_002_VI1PR10MB2800864744C16220EE48E2DF80BE0VI1PR10MB2800EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a27fd416-9ba5-4c5e-d754-08d7f6c254c2 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 22:18:00.1938 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR05HT191 Received-SPF: pass client-ip=40.92.90.75; envelope-from=simon.lang@outlook.com; helo=EUR05-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 18:33:02 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 12 May 2020 18:56:12 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --_002_VI1PR10MB2800864744C16220EE48E2DF80BE0VI1PR10MB2800EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable This fix adds ediff faces for =0A= =0A= ediff-even-diff-A=0A= ediff-even-diff-B=0A= ediff-odd-diff-A=0A= ediff-odd-diff-B=0A= --_002_VI1PR10MB2800864744C16220EE48E2DF80BE0VI1PR10MB2800EURP_ Content-Type: application/octet-stream; name="0001-Improve-ediff-readability-in-misterioso-theme.patch" Content-Description: 0001-Improve-ediff-readability-in-misterioso-theme.patch Content-Disposition: attachment; filename="0001-Improve-ediff-readability-in-misterioso-theme.patch"; size=1153; creation-date="Tue, 12 May 2020 22:17:38 GMT"; modification-date="Tue, 12 May 2020 22:17:38 GMT" Content-Transfer-Encoding: base64 RnJvbSAzNGIzYmJhOGI5MTlmYzRlNTEzYzYyMDI0NDRkMTI4Nzc2NWRlNjRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaW1vbiBMYW5nIDxzaW1vbi5sYW5nQG91dGxvb2suY29tPgpE YXRlOiBUdWUsIDEyIE1heSAyMDIwIDIyOjU0OjUyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gSW1w cm92ZSBlZGlmZiByZWFkYWJpbGl0eSBpbiBtaXN0ZXJpb3NvIHRoZW1lCgoqIGV0Yy90aGVtZXMv bWlzdGVyaW9zby10aGVtZS5lbDogQWRkIGVkaWZmIGZhY2VzCi0tLQogZXRjL3RoZW1lcy9taXN0 ZXJpb3NvLXRoZW1lLmVsIHwgNSArKysrKwogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL2V0Yy90aGVtZXMvbWlzdGVyaW9zby10aGVtZS5lbCBiL2V0Yy90aGVt ZXMvbWlzdGVyaW9zby10aGVtZS5lbAppbmRleCA4MTYxZGJkOWU5Li4wMzBjYjNkZDc1IDEwMDY0 NAotLS0gYS9ldGMvdGhlbWVzL21pc3Rlcmlvc28tdGhlbWUuZWwKKysrIGIvZXRjL3RoZW1lcy9t aXN0ZXJpb3NvLXRoZW1lLmVsCkBAIC02Myw2ICs2MywxMSBAQAogICAgYChidXR0b24gKCgsY2xh c3MgKDp1bmRlcmxpbmUgdCkpKSkKICAgIGAobGluayAoKCxjbGFzcyAoOmZvcmVncm91bmQgIiM1 OWU5ZmYiIDp1bmRlcmxpbmUgdCkpKSkKICAgIGAobGluay12aXNpdGVkICgoLGNsYXNzICg6Zm9y ZWdyb3VuZCAiI2VkNzRjZCIgOnVuZGVybGluZSB0KSkpKQorICAgOzsgRWRpZmYKKyAgIGAoZWRp ZmYtZXZlbi1kaWZmLUEgKCgsY2xhc3MgKDpiYWNrZ3JvdW5kICIjMWQyNDMwIikpKSkKKyAgIGAo ZWRpZmYtZXZlbi1kaWZmLUIgKCgsY2xhc3MgKDpiYWNrZ3JvdW5kICIjMWQyNDMwIikpKSkKKyAg IGAoZWRpZmYtb2RkLWRpZmYtQSAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiM0MTUxNjAiKSkpKQor ICAgYChlZGlmZi1vZGQtZGlmZi1CICgoLGNsYXNzICg6YmFja2dyb3VuZCAiIzQxNTE2MCIpKSkp CiAgICA7OyBHbnVzIGZhY2VzCiAgICBgKGdudXMtZ3JvdXAtbmV3cy0xICgoLGNsYXNzICg6Zm9y ZWdyb3VuZCAiI2ZmNDI0MiIgOndlaWdodCBib2xkKSkpKQogICAgYChnbnVzLWdyb3VwLW5ld3Mt MS1sb3cgKCgsY2xhc3MgKDpmb3JlZ3JvdW5kICIjZmY0MjQyIikpKSkKLS0gCjIuMjEuMCAoQXBw bGUgR2l0LTEyMikKCg== --_002_VI1PR10MB2800864744C16220EE48E2DF80BE0VI1PR10MB2800EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 12 21:17:02 2020 Received: (at 41221) by debbugs.gnu.org; 13 May 2020 01:17:02 +0000 Received: from localhost ([127.0.0.1]:56964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYg18-0008IO-M2 for submit@debbugs.gnu.org; Tue, 12 May 2020 21:17:02 -0400 Received: from mail-yb1-f172.google.com ([209.85.219.172]:44800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYg17-0008Hp-Eq for 41221@debbugs.gnu.org; Tue, 12 May 2020 21:17:01 -0400 Received: by mail-yb1-f172.google.com with SMTP id o8so7961934ybc.11 for <41221@debbugs.gnu.org>; Tue, 12 May 2020 18:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=MNbm0ICK/gDR2379bGLStxdpFMkhTI6XJURWaRsb6Z0=; b=XO2OS7rSew0oPa6Ofu8I99ys3N4endo2f1tJX8XWgv00pweZzXFEkRcathuL1OxcI6 80dXJ8yyd7yKk/JPBUJTYBwuPuVXXEt8rn1TRiEqTjtvlTVmckVlSqQNNi+S2ULySw45 Z3/otynv2vjsHsC0Va7dahveaxo4crmlWGHRrrINtdVbpffgF60drqJOofuBmspmwiV9 Ou8Q+lm0R91/ofqMeQT7aIbXD6WfmIFu9Lr+POzMaVmfJXHbF2Mbjmdwf6m+C1w64d4s Nvs/otUK3c6OJeAp43AEHxpKKlpsS+Xd+TcF+DZqF4WfcULY7yTI8jgGr5SWxHtEiI6w C77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=MNbm0ICK/gDR2379bGLStxdpFMkhTI6XJURWaRsb6Z0=; b=pwnIx71Jj/lAFOvLVm9cBquOBYMfWzWEt/h6JS8lq5y3i60HeGnHg6Lbst2oWbSnKv wQthrXo/PdoaXZvOFImmYzP9Ot28aHt/KaS4dqVA/iJA4AkoYOJfKIXjYm34fFLc9hyj xV8F2y91JyLoSBAU9wKUNH2eSPg+lbHgpWajkCRprxv/gwsujhsbrzvTA399OiwRB3ol aX8tOkN3muwgkeffwEQ8w3A+xb7DREbxLvc1QaNXyFMGOH/1KfJCmpqojuJFno3bHxea R/N6gg3M8YolD4FHY+5gFIVsMlcu0T/AHhhg5F1qSgd05c4yETPP2y/EY1QDwaRrmkp+ Lexg== X-Gm-Message-State: AGi0PuZrguf2sfrv/qgNg/Cqo+UTr0g3va97Pou/7UoRvNNfXiTvpjaA /xlBhWmGoIqmU41KQVINgrw6myp6PU3IPfFL6Ik= X-Google-Smtp-Source: APiQypIlHtDzne/BnWfI/1PePPaAspbb65woShBSCb0idpr5hW3skIDJ/jmAqyz8MY488nf/bqRXFqKuAkiPRpVYEKU= X-Received: by 2002:a25:c402:: with SMTP id u2mr37569194ybf.231.1589332615816; Tue, 12 May 2020 18:16:55 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 May 2020 18:16:55 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Tue, 12 May 2020 18:16:55 -0700 Message-ID: Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability To: Simon Lang , 41221@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41221 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Simon Lang writes: > This fix adds ediff faces for > > ediff-even-diff-A > ediff-even-diff-B > ediff-odd-diff-A > ediff-odd-diff-B Thank you for your contribution. This is obviously broken in the theme as is, since you can't read the changed text in ediff. I tested it, and your change looks good to me. Eli, is the below acceptable for emacs-27? > diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el > index 8161dbd9e9..030cb3dd75 100644 > --- a/etc/themes/misterioso-theme.el > +++ b/etc/themes/misterioso-theme.el > @@ -63,6 +63,11 @@ > `(button ((,class (:underline t)))) > `(link ((,class (:foreground "#59e9ff" :underline t)))) > `(link-visited ((,class (:foreground "#ed74cd" :underline t)))) > + ;; Ediff > + `(ediff-even-diff-A ((,class (:background "#1d2430")))) > + `(ediff-even-diff-B ((,class (:background "#1d2430")))) > + `(ediff-odd-diff-A ((,class (:background "#415160")))) > + `(ediff-odd-diff-B ((,class (:background "#415160")))) Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 02:35:57 2020 Received: (at 41221) by debbugs.gnu.org; 13 May 2020 06:35:57 +0000 Received: from localhost ([127.0.0.1]:57199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYkzl-0000Ek-8T for submit@debbugs.gnu.org; Wed, 13 May 2020 02:35:57 -0400 Received: from mail-oln040092073032.outbound.protection.outlook.com ([40.92.73.32]:25071 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYkoc-0008Iw-Mg for 41221@debbugs.gnu.org; Wed, 13 May 2020 02:24:27 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZG0mxJOoVC/rRX4hPIKyxrPRz+bfHmqGNs//nonmFgR0XCmCVUJgG8j6LhOB835CGl+nsYTWw4qcyrXpEKI/QaF2G9TMEQawImOV2Iv16CDpkTnnHhOZyNT4jR2b2PBosNmFQLkIOF0+LzCVHPK99ssAhy2YcwIyTuBb8rDGH//Uh2vffTXzok7TSE/5EUCvPkUZO/1b7Sci/NSjxgcot4bc/+hh4qBpcN04LltzpYXrRRz3sQ/EghVjEbPldiRHzH5SgiHJTb/Y10sPb/dyQbrN1i4Yd5ekddN2ZgJVwo/I5WiVjOw3qch6+yswaxyl47dqGmTfDOh1Dr3LW9z9PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8qrjI1zuC2qw0tUCugRrA6i+NTDqG10ZCpq0T8KWCA=; b=SkH7Wd1Gc8wCpycaAZaxyf2d3O3t/cfC7jSJTICmiLvZQh1qklML46EX1nuJjlmtbalQ+JdorJYMtraLD+MgiQ0SZcgqR5vQ+9rTbmf5ZI0mmxhbYc+QaR0FDnX3jknFTMOqQjC2rv8MGWEdcVOAT3w/bWx++5es2+VIZK6mAhb9l/ZWtrAu3wZ/c+sWqIKU4gygsFJEu+uGEqEsdk7IzLS69kE7+7EUHwQ7EEQ0m9pogyORyNQiBiBL7V0raAnOYfhDwv6QV5DpYW8LBv9fL3/4EnpliJTJ4MUUdopeo3RJZL2S+Y32uTVEhWAkrZYeBXMB/VCAc3BMIDcIy5jVLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8qrjI1zuC2qw0tUCugRrA6i+NTDqG10ZCpq0T8KWCA=; b=YCgX8LZvqy+UvFbXcylFqrDiLVvNaLjT8iMWFZUENemIZGnlUDtr3o9dW+PqmRdAprnqGYxODLhKdNOUyl2eVUYfTl9K02i5g+NU680zfEpP3yK4BLweOAbf9syMK6zwymH6XuOKN+J/mz+V+bVhGHQEtMXA2Pvn2JCqsD9iyIEJnsV+iwSgFvBoFRA9Oc56M4w9UkJpnR7p6BhTvtP8BDzluIPnhEoBSFjz5v6BDtUbDWR/9oqGqf0WQ8kr6PHii126vnh15LtlI+VzRI3lnZksAACT3kV5zv9hntn4Kv5nW2TVn6bn7ahNibnUhf7vZymJComfjzdnrzSj4bL6iQ== Received: from VI1EUR04FT018.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::50) by VI1EUR04HT136.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::385) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Wed, 13 May 2020 06:24:19 +0000 Received: from DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e0e::4d) by VI1EUR04FT018.mail.protection.outlook.com (2a01:111:e400:7e0e::359) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Wed, 13 May 2020 06:24:19 +0000 Received: from DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM ([fe80::e194:f64b:e547:e9ab]) by DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM ([fe80::e194:f64b:e547:e9ab%6]) with mapi id 15.20.2979.033; Wed, 13 May 2020 06:24:19 +0000 From: Simon Lang To: Stefan Kangas , "41221@debbugs.gnu.org" <41221@debbugs.gnu.org> Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability Thread-Topic: bug#41221: Add some ediff faces to misterioso theme to improve readability Thread-Index: AQHWKKrWrbztuwWmM0ecwcexgeYYP6ilNwuAgABVE80= Date: Wed, 13 May 2020 06:24:19 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:87BFB2EB8ECF01C1EF218A1D7854D2BF410BADCF3833B11C6F9C42B1EF5741F6; UpperCasedChecksum:B6BEBA457EBA0B244706D09E848B306360898FE01BF289799F69AC8747CCFC4E; SizeAsReceived:7183; Count:46 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [L3QSyA2SaWa8GVpN6+rgC5hgHMEJqCn9] x-ms-publictraffictype: Email x-incomingheadercount: 46 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 978a62a1-47a9-454f-f10b-08d7f706451c x-ms-traffictypediagnostic: VI1EUR04HT136: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wLfbPrWZxi5NDEEDA8eb56Xgo0yXKwXj/yf2YAUbJApdk4G6381LO5WicYyJbMheV2Tfb6Taxk1Okq0d6IXT9VJhlj/0YeT9yHAHdhCTUxIZ20KEBweOtSwRWeGIZea6pRjIru1m6Wxd/bJHF9oloUGTfSMjtWn/4VsRl/9F+dUyaoR/YuKtCOSPHT7sz/FHuE+yrtoYxPJYnmYaOG0eWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; x-ms-exchange-antispam-messagedata: ZsgsoUvS1Zbp6I7ak+noEBKpVZENoR442QcjNWwUA27hVQtuPLGhl8Vopc+z97iYjdboE8qFGJHE4Il4r4FLLJN/+7PZMTqpxjIsRN8/O3tS1jZTQxfRbXyXB+zTXgvL5rCbZJ1SLsFU4EGDn45HGA== x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 978a62a1-47a9-454f-f10b-08d7f706451c X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 06:24:19.7203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT136 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41221 X-Mailman-Approved-At: Wed, 13 May 2020 02:35:55 -0400 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi,=0A= =0A= sorry, I relaized that I forgot about =0A= =0A= ediff-even-diff-C=0A= ediff-odd-diff-C=0A= =0A= I added these now (trivial change, same faces as the others).=0A= =0A= Thank you!!=0A= =0A= ________________________________________=0A= From: Stefan Kangas =0A= Sent: 13 May 2020 02:16=0A= To: Simon Lang; 41221@debbugs.gnu.org=0A= Cc: Eli Zaretskii=0A= Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve= readability=0A= =0A= Simon Lang writes:=0A= =0A= > This fix adds ediff faces for=0A= >=0A= > ediff-even-diff-A=0A= > ediff-even-diff-B=0A= > ediff-odd-diff-A=0A= > ediff-odd-diff-B=0A= =0A= Thank you for your contribution.=0A= =0A= This is obviously broken in the theme as is, since you can't read the=0A= changed text in ediff. I tested it, and your change looks good to me.=0A= =0A= Eli, is the below acceptable for emacs-27?=0A= =0A= > diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme= .el=0A= > index 8161dbd9e9..030cb3dd75 100644=0A= > --- a/etc/themes/misterioso-theme.el=0A= > +++ b/etc/themes/misterioso-theme.el=0A= > @@ -63,6 +63,11 @@=0A= > `(button ((,class (:underline t))))=0A= > `(link ((,class (:foreground "#59e9ff" :underline t))))=0A= > `(link-visited ((,class (:foreground "#ed74cd" :underline t))))=0A= > + ;; Ediff=0A= > + `(ediff-even-diff-A ((,class (:background "#1d2430"))))=0A= > + `(ediff-even-diff-B ((,class (:background "#1d2430"))))=0A= > + `(ediff-odd-diff-A ((,class (:background "#415160"))))=0A= > + `(ediff-odd-diff-B ((,class (:background "#415160"))))=0A= =0A= Best regards,=0A= Stefan Kangas=0A= --_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_ Content-Type: application/octet-stream; name="0001-Improve-ediff-readability-in-misterioso-theme.patch" Content-Description: 0001-Improve-ediff-readability-in-misterioso-theme.patch Content-Disposition: attachment; filename="0001-Improve-ediff-readability-in-misterioso-theme.patch"; size=1274; creation-date="Wed, 13 May 2020 06:23:44 GMT"; modification-date="Wed, 13 May 2020 06:23:44 GMT" Content-Transfer-Encoding: base64 RnJvbSBiZGQ1ODI0ODdhMDIyNzVkODJiZmRhMDFlYmI2ZDA2MDVjMDM0OWQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaW1vbiBMYW5nIDxzaW1vbi5sYW5nQG91dGxvb2suY29tPgpE YXRlOiBUdWUsIDEyIE1heSAyMDIwIDIyOjU0OjUyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gSW1w cm92ZSBlZGlmZiByZWFkYWJpbGl0eSBpbiBtaXN0ZXJpb3NvIHRoZW1lCgoqIGV0Yy90aGVtZXMv bWlzdGVyaW9zby10aGVtZS5lbDogQWRkIGVkaWZmIGZhY2VzCi0tLQogZXRjL3RoZW1lcy9taXN0 ZXJpb3NvLXRoZW1lLmVsIHwgNyArKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25z KCspCgpkaWZmIC0tZ2l0IGEvZXRjL3RoZW1lcy9taXN0ZXJpb3NvLXRoZW1lLmVsIGIvZXRjL3Ro ZW1lcy9taXN0ZXJpb3NvLXRoZW1lLmVsCmluZGV4IDgxNjFkYmQ5ZTkuLmZmOWFmMGM3NDQgMTAw NjQ0Ci0tLSBhL2V0Yy90aGVtZXMvbWlzdGVyaW9zby10aGVtZS5lbAorKysgYi9ldGMvdGhlbWVz L21pc3Rlcmlvc28tdGhlbWUuZWwKQEAgLTYzLDYgKzYzLDEzIEBACiAgICBgKGJ1dHRvbiAoKCxj bGFzcyAoOnVuZGVybGluZSB0KSkpKQogICAgYChsaW5rICgoLGNsYXNzICg6Zm9yZWdyb3VuZCAi IzU5ZTlmZiIgOnVuZGVybGluZSB0KSkpKQogICAgYChsaW5rLXZpc2l0ZWQgKCgsY2xhc3MgKDpm b3JlZ3JvdW5kICIjZWQ3NGNkIiA6dW5kZXJsaW5lIHQpKSkpCisgICA7OyBFZGlmZgorICAgYChl ZGlmZi1ldmVuLWRpZmYtQSAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiMxZDI0MzAiKSkpKQorICAg YChlZGlmZi1ldmVuLWRpZmYtQiAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiMxZDI0MzAiKSkpKQor ICAgYChlZGlmZi1ldmVuLWRpZmYtQyAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiMxZDI0MzAiKSkp KQorICAgYChlZGlmZi1vZGQtZGlmZi1BICgoLGNsYXNzICg6YmFja2dyb3VuZCAiIzQxNTE2MCIp KSkpCisgICBgKGVkaWZmLW9kZC1kaWZmLUIgKCgsY2xhc3MgKDpiYWNrZ3JvdW5kICIjNDE1MTYw IikpKSkKKyAgIGAoZWRpZmYtb2RkLWRpZmYtQyAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiM0MTUx NjAiKSkpKQogICAgOzsgR251cyBmYWNlcwogICAgYChnbnVzLWdyb3VwLW5ld3MtMSAoKCxjbGFz cyAoOmZvcmVncm91bmQgIiNmZjQyNDIiIDp3ZWlnaHQgYm9sZCkpKSkKICAgIGAoZ251cy1ncm91 cC1uZXdzLTEtbG93ICgoLGNsYXNzICg6Zm9yZWdyb3VuZCAiI2ZmNDI0MiIpKSkpCi0tIAoyLjIx LjAgKEFwcGxlIEdpdC0xMjIpCgo= --_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 10:46:16 2020 Received: (at 41221) by debbugs.gnu.org; 13 May 2020 14:46:16 +0000 Received: from localhost ([127.0.0.1]:59051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYseG-0004nJ-5m for submit@debbugs.gnu.org; Wed, 13 May 2020 10:46:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYseF-0004n6-Ei for 41221@debbugs.gnu.org; Wed, 13 May 2020 10:46:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38591) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYse9-00062h-Ke; Wed, 13 May 2020 10:46:09 -0400 Received: from [176.228.60.248] (port=3511 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jYse8-0006mF-0K; Wed, 13 May 2020 10:46:08 -0400 Date: Wed, 13 May 2020 17:45:51 +0300 Message-Id: <83imgz7v1c.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 12 May 2020 18:16:55 -0700) Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41221 Cc: 41221@debbugs.gnu.org, simon.lang@outlook.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 12 May 2020 18:16:55 -0700 > Cc: Eli Zaretskii > > Eli, is the below acceptable for emacs-27? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 13:52:02 2020 Received: (at 41221) by debbugs.gnu.org; 13 May 2020 17:52:03 +0000 Received: from localhost ([127.0.0.1]:59440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYvY2-0001AF-P6 for submit@debbugs.gnu.org; Wed, 13 May 2020 13:52:02 -0400 Received: from mail-yb1-f169.google.com ([209.85.219.169]:42575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYvY0-00019f-Qh for 41221@debbugs.gnu.org; Wed, 13 May 2020 13:52:01 -0400 Received: by mail-yb1-f169.google.com with SMTP id i16so190854ybq.9 for <41221@debbugs.gnu.org>; Wed, 13 May 2020 10:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=pyMpNRDPjkhSiR1Bw9TZAyZvzgJh/F+K7Gg2PsM6Z5U=; b=gtEnOdT7ihXPNQCJLX5vgcL5Eod3V1SazKHuZpaF44OT+O0rLlj/p85hO+6vqdwxM3 YT9/5JRF00t9GIrt3VUG8lzGOTLF3VKB4XN6by0SjtWHGsI8o9PYMtsRB/P5DxlZEVic LUcmTXBOcroFPEXtNX95k3AaoZa81WbNGX6i2ynhgTMSLzZCbVF2hm3MkjQdcdnpjd16 bvhRxtKIPVIhwFv3E97edKZHXXxkGbCWW0WR38598Y4UREhuW/tkK2iKu0FG6bwCBTOv mIgWJ8RuQib7rj4/JOvqfNnuULjHAioI2P43r4NwENCK7MzmyKkZ9AFlJO8vxeqxTPoK dbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=pyMpNRDPjkhSiR1Bw9TZAyZvzgJh/F+K7Gg2PsM6Z5U=; b=rm3Nei4eExwwo4fAH8rbdUFV1xx/f8cuP4CBoL0t76HDr1RSLWaZnfZ1HiIkocfN50 MKxquTlcSlpHNVC4En57ItxxYEWXTa4kJ7/BbYArtayarIdGCgfSe41qEnPOfawTBGh7 yA5MK2hKG59hbzQjeZRsFFIfLdEDKnL9dMu7L5Ef8vSDZtc9RcBVJNaOrTMHCb4u+c4M jKrMhpYOomPVPTimFgm786zNzlu5Nkt46r4irVNIOEx3o1WURGOLUEU2tdnkC0aeyXB1 xOaBWdAhpGkB6SQc0jxpOdAqRt50aZ9q1i09oFxYOin5YSJW8oRFnRSS4Hs+G6GrA4D9 fslQ== X-Gm-Message-State: AOAM5310CkeRB27jmDX+uQhtupdBjGr96tXK0eyoO6GLlbzv9Q4t8t9n TiVYEUUUra/Azb3CMLhX/OtXz496RCedEDZ5eVc= X-Google-Smtp-Source: ABdhPJyGdIM2Sy0Ujz0UcNHG2l07uAZxXUxwhbdC01KcjMo0Nv1CZds6gkecSrJAsF1u0MktfbGVAbNwA8D5Lv2uUH4= X-Received: by 2002:a25:4c04:: with SMTP id z4mr327414yba.466.1589392315065; Wed, 13 May 2020 10:51:55 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 May 2020 10:51:54 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Wed, 13 May 2020 10:51:54 -0700 Message-ID: Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability To: Simon Lang , "41221@debbugs.gnu.org" <41221@debbugs.gnu.org> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41221 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 41221 27.1 thanks Hi Simon, Simon Lang writes: > I added these now (trivial change, same faces as the others). Great, looks good to me. Thanks again for your contribution, which I have now pushed to emacs-27 as commit 747e0a2523. It will be part of the upcoming Emacs 27.1. Best regards, Stefan Kangas From unknown Sun Jun 22 17:18:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jun 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator