GNU bug report logs - #41221
Add some ediff faces to misterioso theme to improve readability

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41221 in the body.
You can then email your comments to 41221 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Lang <simon.lang <at> outlook.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Add some ediff faces to misterioso theme to improve readability
Date: Tue, 12 May 2020 22:18:00 +0000

[Message part 1 (text/plain, inline)]

This fix adds ediff faces for 

ediff-even-diff-A
ediff-even-diff-B
ediff-odd-diff-A
ediff-odd-diff-B

[0001-Improve-ediff-readability-in-misterioso-theme.patch (application/octet-stream, attachment)]

Message #8 received at 41221 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Simon Lang <simon.lang <at> outlook.com>, 41221 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve
 readability
Date: Tue, 12 May 2020 18:16:55 -0700

Simon Lang <simon.lang <at> outlook.com> writes:

> This fix adds ediff faces for
>
> ediff-even-diff-A
> ediff-even-diff-B
> ediff-odd-diff-A
> ediff-odd-diff-B

Thank you for your contribution.

This is obviously broken in the theme as is, since you can't read the
changed text in ediff.  I tested it, and your change looks good to me.

Eli, is the below acceptable for emacs-27?

> diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
> index 8161dbd9e9..030cb3dd75 100644
> --- a/etc/themes/misterioso-theme.el
> +++ b/etc/themes/misterioso-theme.el
> @@ -63,6 +63,11 @@
>     `(button ((,class (:underline t))))
>     `(link ((,class (:foreground "#59e9ff" :underline t))))
>     `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
> +   ;; Ediff
> +   `(ediff-even-diff-A ((,class (:background "#1d2430"))))
> +   `(ediff-even-diff-B ((,class (:background "#1d2430"))))
> +   `(ediff-odd-diff-A ((,class (:background "#415160"))))
> +   `(ediff-odd-diff-B ((,class (:background "#415160"))))

Best regards,
Stefan Kangas

Message #11 received at 41221 <at> debbugs.gnu.org (full text, mbox):

From: Simon Lang <Simon.lang <at> outlook.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, "41221 <at> debbugs.gnu.org"
 <41221 <at> debbugs.gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve
 readability
Date: Wed, 13 May 2020 06:24:19 +0000

[Message part 1 (text/plain, inline)]

Hi,

sorry, I relaized that I forgot about 

ediff-even-diff-C
ediff-odd-diff-C

I added these now (trivial change, same faces as the others).

Thank you!!

________________________________________
From: Stefan Kangas <stefankangas <at> gmail.com>
Sent: 13 May 2020 02:16
To: Simon Lang; 41221 <at> debbugs.gnu.org
Cc: Eli Zaretskii
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability

Simon Lang <simon.lang <at> outlook.com> writes:

> This fix adds ediff faces for
>
> ediff-even-diff-A
> ediff-even-diff-B
> ediff-odd-diff-A
> ediff-odd-diff-B

Thank you for your contribution.

This is obviously broken in the theme as is, since you can't read the
changed text in ediff.  I tested it, and your change looks good to me.

Eli, is the below acceptable for emacs-27?

> diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
> index 8161dbd9e9..030cb3dd75 100644
> --- a/etc/themes/misterioso-theme.el
> +++ b/etc/themes/misterioso-theme.el
> @@ -63,6 +63,11 @@
>     `(button ((,class (:underline t))))
>     `(link ((,class (:foreground "#59e9ff" :underline t))))
>     `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
> +   ;; Ediff
> +   `(ediff-even-diff-A ((,class (:background "#1d2430"))))
> +   `(ediff-even-diff-B ((,class (:background "#1d2430"))))
> +   `(ediff-odd-diff-A ((,class (:background "#415160"))))
> +   `(ediff-odd-diff-B ((,class (:background "#415160"))))

Best regards,
Stefan Kangas

[0001-Improve-ediff-readability-in-misterioso-theme.patch (application/octet-stream, attachment)]

Message #14 received at 41221 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 41221 <at> debbugs.gnu.org, simon.lang <at> outlook.com
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve
 readability
Date: Wed, 13 May 2020 17:45:51 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Tue, 12 May 2020 18:16:55 -0700
> Cc: Eli Zaretskii <eliz <at> gnu.org>
> 
> Eli, is the below acceptable for emacs-27?

Yes, thanks.

Message #17 received at 41221 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Simon Lang <Simon.lang <at> outlook.com>,
 "41221 <at> debbugs.gnu.org" <41221 <at> debbugs.gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve
 readability
Date: Wed, 13 May 2020 10:51:54 -0700

close 41221 27.1
thanks

Hi Simon,

Simon Lang <Simon.lang <at> outlook.com> writes:

> I added these now (trivial change, same faces as the others).

Great, looks good to me.

Thanks again for your contribution, which I have now pushed to emacs-27
as commit 747e0a2523.  It will be part of the upcoming Emacs 27.1.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.