GNU bug report logs - #41219
Enforce "files" directive in node build system

Previous Next

Full log

Message #35 received at 41219 <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: Jelle Licht <jlicht <at> fsfe.org>, 41219 <at> debbugs.gnu.org
Subject: Re: [bug#41219] [PATCH 2/2] guix: Enforce package.json "files"
 directive.
Date: Mon, 19 Oct 2020 01:32:50 +0200

[Message part 1 (text/plain, inline)]

Dear Jelle,

On 9/22/20 8:09 PM, Jelle Licht wrote:
> Hey Giacomo,
>
> paul <goodoldpaul <at> autistici.org> writes:
>>>> +         install-dir)
>>>> +        (begin
>>>> +          (copy-recursively "." install-dir)
>>>> +          ;; Remove references to dependencies
>>>> +          (delete-file-recursively
>>>> +           (string-append install-dir "/node_modules"))))
>>>> +    (if (and main
>>>> +             (not (file-exists?
>>>> +                   (string-append
>>>> +                    install-dir "/" (dirname main)))))
>                                            ^
>
> {New,Forgotten} nitpick; this only checks for the `dirname': why not
> just `(string-append install-dir "/" main)'? Because if
> e.g. "lib/utils.js" is in "files", and main is "lib/main.js", it seems
> that main would not be installed with this snippet. Does that make
> sense?

Yes it definitely does. I believe I fixed this in the attached patch.

Thank you for your review,

Giacomo

[0002-guix-Enforce-package.json-files-directive.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.