Subject: bug#41216: closed (Re: [bug#41216] [PATCH] doc: Mention guix-daemon's 'https_proxy' environment variable.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 13 May 2020 08:59:02 +0000

Your bug report

#41216: [PATCH] doc: Mention guix-daemon's 'https_proxy' environment variable.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41216: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41216
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#41216] [PATCH] doc: Mention guix-daemon's 'https_proxy' environment variable.
From: Brice Waegeneire <[email-masked]>
To: Mathieu Othacehe <[email-masked]>
Cc: [email-masked]
Date: Wed, 13 May 2020 08:58:18 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Mathieu,

Thank you for the review.

On 2020-05-13 06:49, Mathieu Othacehe wrote:
> Hello Brice,
> 
>> +Substitutes are downloaded over HTTP or HTTPS.  The @env{http_proxy} 
>> and
>> +@env{https_proxy} environment variables can be set in the environment 
>> of
>> +@command{guix-daemon} and is honored for downloads of substitutes.  
>> Note
> 
> are honored?

Fixed.

> This looks fine, thanks!
> Mathieu

Pushed as 15014dc61858e14e3356c7489cd366555085048b.

- Brice

Subject: [PATCH] doc: Mention guix-daemon's 'https_proxy' environment variable.
From: Brice Waegeneire <[email-masked]>
To: [email-masked]
Date: Tue, 12 May 2020 22:04:39 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* doc/guix.texi (Proxy Settings, Derivations): Mention 'https_proxy'.
---
 doc/guix.texi | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 420c2c9eae..09d5a1dc52 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -1012,9 +1012,11 @@ environments, which avoids discrepancies in cases where build processes
 capture the name of their build tree.
 
 @vindex http_proxy
-The daemon also honors the @env{http_proxy} environment variable for
-HTTP downloads it performs, be it for fixed-output derivations
-(@pxref{Derivations}) or for substitutes (@pxref{Substitutes}).
+@vindex https_proxy
+The daemon also honors the @env{http_proxy} and @env{https_proxy}
+environment variables for HTTP and HTTPS downloads it performs, be it
+for fixed-output derivations (@pxref{Derivations}) or for substitutes
+(@pxref{Substitutes}).
 
 If you are installing Guix as an unprivileged user, it is still possible
 to run @command{guix-daemon} provided you pass @option{--disable-chroot}.
@@ -3376,13 +3378,13 @@ authenticating bindings between domain names and public keys.)
 @subsection Proxy Settings
 
 @vindex http_proxy
-Substitutes are downloaded over HTTP or HTTPS.
-The @env{http_proxy} environment
-variable can be set in the environment of @command{guix-daemon} and is
-honored for downloads of substitutes.  Note that the value of
-@env{http_proxy} in the environment where @command{guix build},
-@command{guix package}, and other client commands are run has
-@emph{absolutely no effect}.
+@vindex https_proxy
+Substitutes are downloaded over HTTP or HTTPS.  The @env{http_proxy} and
+@env{https_proxy} environment variables can be set in the environment of
+@command{guix-daemon} and is honored for downloads of substitutes.  Note
+that the value of those environment variables in the environment where
+@command{guix build}, @command{guix package}, and other client commands
+are run has @emph{absolutely no effect}.
 
 @node Substitution Failure
 @subsection Substitution Failure
-- 
2.26.2