GNU bug report logs - #41204
port-revealed count is initially > 30000

Previous Next

Package: guile;

Reported by: Caleb Ristvedt <caleb.ristvedt <at> cune.org>

Date: Tue, 12 May 2020 10:33:02 UTC

Severity: important

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41204: closed (port-revealed count is initially > 30000)
Date: Tue, 12 May 2020 13:05:03 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 12 May 2020 15:04:16 +0200
with message-id <87ftc5b8z3.fsf <at> gnu.org>
and subject line Re: bug#41204: port-revealed count is initially > 30000
has caused the debbugs.gnu.org bug report #41204,
regarding port-revealed count is initially > 30000
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41204: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41204
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: bug-guile <at> gnu.org
Subject: port-revealed count is initially > 30000
Date: Tue, 12 May 2020 05:32:07 -0500
(port-revealed (open-input-file "/dev/null"))
=> 32539

The little investigating I've done so far suggests that this is because
scm_i_fdes_to_port calls scm_gc_malloc_pointerless and initializes only
the 'fdes' and 'options' fields, leaving 'revealed' uninitialized. The
comment above scm_gc_malloc_pointerless does a good job of explaining
why this is an issue:

/* Allocate SIZE bytes of memory whose contents should not be scanned
   for pointers (useful, e.g., for strings).  Note though that this
   memory is *not* cleared; be sure to initialize it to prevent
   information leaks.  */

This issue appears to be present both in the 2.2 and 3.0 releases
packaged in guix.

- reepca


[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
Cc: 41204-done <at> debbugs.gnu.org
Subject: Re: bug#41204: port-revealed count is initially > 30000
Date: Tue, 12 May 2020 15:04:16 +0200
Hi,

Caleb Ristvedt <caleb.ristvedt <at> cune.org> skribis:

> (port-revealed (open-input-file "/dev/null"))
> => 32539

Fixed in b1bdd791cefa1b6d113f9b3972550342d8f4aa9f.

Guile up to 2.2.7/3.0.2 included (but not 2.0) would thus leak the file
descriptors of all the file ports not explicitly closed.  It’s probably
not that common (good practice is too close file ports as soon as you’re
done with them and ‘call-with-output-file’ & co. take care of that), but
still.

Thanks a lot for finding the problem!

Ludo’.


This bug report was last modified 5 years and 9 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.