GNU bug report logs - #41198
27.0.60; [PATCH] heading cycling command for outline

Previous Next

Package: emacs;

Reported by: Yuan Fu <casouri <at> gmail.com>

Date: Tue, 12 May 2020 01:53:02 UTC

Severity: wishlist

Tags: patch

Merged with 41130

Found in version 27.0.60

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "Paul W. Rankin" <pwr <at> skeletons.cc>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 41198 <at> debbugs.gnu.org
Subject: bug#41198: 28.0.50; heading cycling command for outline
Date: Tue, 17 Nov 2020 12:47:33 +1000
[Message part 1 (text/plain, inline)]
On 2020-11-17 07:59, Lars Ingebrigtsen wrote:
> 
> The patches look OK to me, but look like they've been slightly mangled
> during transmission, so could you include them as a single patch as an
> attachment?  (And adding a ChangeLog-format text would also be nice.)

2x patches attached with changelog.

I took a more precise approach with outline--cycle-state, where the +1 
case is only handled when the subtree end is point-max, otherwise the 
overlay-end must equal end of subtree point in all other cases.

I rewrote outline-cycle-buffer; it now first checks that the buffer has 
top-level headings before attempting to show only top-level headings, 
thus avoiding the disconcerting state where all buffer content is 
reduced to "...". If buffer has no outline headings, we still get an 
annoying message toggle from "All headings" to "Show all".

Also this avoids using pcase, which is awful.
[0001-lisp-outline.el-better-handing-of-outline-overlays-w.patch (text/x-diff, attachment)]
[0002-lisp-outline.el-avoid-hiding-all-buffer-content.patch (text/x-diff, attachment)]

This bug report was last modified 4 years and 157 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.