From unknown Fri Jun 20 07:21:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41198 <41198@debbugs.gnu.org> To: bug#41198 <41198@debbugs.gnu.org> Subject: Status: 27.0.60; [PATCH] heading cycling command for outline Reply-To: bug#41198 <41198@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:21:25 +0000 retitle 41198 27.0.60; [PATCH] heading cycling command for outline reassign 41198 emacs submitter 41198 Yuan Fu severity 41198 wishlist tag 41198 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 21:52:32 2020 Received: (at submit) by debbugs.gnu.org; 12 May 2020 01:52:32 +0000 Received: from localhost ([127.0.0.1]:53735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYK5w-0002G5-DB for submit@debbugs.gnu.org; Mon, 11 May 2020 21:52:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:49162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYK5u-0002Fx-SC for submit@debbugs.gnu.org; Mon, 11 May 2020 21:52:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYK5u-0007d2-KP for bug-gnu-emacs@gnu.org; Mon, 11 May 2020 21:52:30 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:41679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYK5s-0001Km-PB for bug-gnu-emacs@gnu.org; Mon, 11 May 2020 21:52:30 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id v15so1483376qvr.8 for ; Mon, 11 May 2020 18:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=M0PZyrrzagsTrB5CODGbbD48PFhPpoNBFHgXbRzXAjM=; b=dnj9fCELEh57bkaBquzaBBuiTMezm7UwBbANUs1Y1/+XdCbTFlFtsQSE75YwDM1YSX rF6ok86/nlKDhiVcvv/LGoULjhDRlWwtIdVk/FXVbNTE+30mzJtCwrMuzlBgxrLwwCzl v+eeun7/Q65mG9w8o6lLWvvlK/j20l1PrZI9VP5enDvT4HsfWpXcqVYGHdW6DpPBBHN/ v5+eFN+qgECcvwvULaRL/A4h+Y6bo2P1YOmrs0zLZvhMrSE3ZZ7F24b8sFPVmqjx92f5 x85GYucNLAZgBZS/igip8TFQsWcTQNgi8Q5qbnOMUwFb+v4FaZDprZ4dWcJNSwBEofAq xN/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=M0PZyrrzagsTrB5CODGbbD48PFhPpoNBFHgXbRzXAjM=; b=mCVSoLNIl816OgxMhTn+W67+jkf2pO5ZdDTkOQirs75SgpV6O3iAGguY+qwFvuIEHg rLlVeGkFWLRR2XL7Pm3Scm/z+cVDPEL4DsQ0MlFYPO29LThhzgAWCxu5MimbpOBdu0Qz gKfft4bhfer8pLCoH12kAKH8rRrgWywt8yLspgvRgPk9vfDSVpUaU5kpjLwnhO30GCK3 7XCeVq+SR14OHHWdr8brF6TLG5VyAEkIeeUjt5ajHgVkZ8S1G4c5ByFrhPXQWTmzDlNu 2QBAh4umJru2hLDzyJ2M1oOtfZ6WJM57U+r1NSGCkXr6tR0jvMO1bM9ynrFnvGLgAFHl 6WCA== X-Gm-Message-State: AGi0PuZxIfwkBufNI0O2qZ3ejf2X6M7lMXHKX7sZeDaEzbPKqVE1CUQV 4kdL+Pl4BxjXvdvpzOk/wrohkNfVxLjvPQ== X-Google-Smtp-Source: APiQypJhJfJc42TYgD5v+NjAT7Hmq+JtHSZbIygEaj+QYRspdc0NclSsMhVyNsM4n2+Ib42gPLb5xQ== X-Received: by 2002:a05:6214:122e:: with SMTP id p14mr12148951qvv.168.1589248347158; Mon, 11 May 2020 18:52:27 -0700 (PDT) Received: from [192.168.1.5] (c-174-60-229-153.hsd1.pa.comcast.net. [174.60.229.153]) by smtp.gmail.com with ESMTPSA id c68sm9892054qke.129.2020.05.11.18.52.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 May 2020 18:52:26 -0700 (PDT) From: Yuan Fu Content-Type: multipart/mixed; boundary="Apple-Mail=_CC3C253A-5129-4254-A5DF-DF5C1E4BB804" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: 27.0.60; [PATCH] heading cycling command for outline Message-Id: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> Date: Mon, 11 May 2020 21:52:25 -0400 To: Bug Report Emacs X-Mailer: Apple Mail (2.3608.80.23.2.2) Received-SPF: pass client-ip=2607:f8b0:4864:20::f2d; envelope-from=casouri@gmail.com; helo=mail-qv1-xf2d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_CC3C253A-5129-4254-A5DF-DF5C1E4BB804 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Add two commands that cycles a heading (like that in Org mode) in = outline-mode: - outline-cycle: cycles between =E2=80=9Chide all=E2=80=9D, =E2=80=9Csub = headings=E2=80=9D and =E2=80=9Cshow all=E2=80=9D state. They are called = =E2=80=9CFOLDED=E2=80=9D, =E2=80=9CCHILDREN=E2=80=9D, =E2=80=9CSUBTREE=E2=80= =9D in Org mode.=20 - outline-cycle-buffer: cycles between =E2=80=9Conly top level = headings=E2=80=9D, =E2=80=9Call headings=E2=80=9D, =E2=80=9Cshow all=E2=80= =9D states Could this be useful? Yuan --Apple-Mail=_CC3C253A-5129-4254-A5DF-DF5C1E4BB804 Content-Disposition: attachment; filename=outline.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="outline.patch" Content-Transfer-Encoding: quoted-printable diff=20--git=20a/lisp/outline.el=20b/lisp/outline.el=0Aindex=20= 28ea8a86e6..99a24deed0=20100644=0A---=20a/lisp/outline.el=0A+++=20= b/lisp/outline.el=0A@@=20-1118,6=20+1118,77=20@@=20= outline-headers-as-kill=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(insert=20"\n\n"))))))=0A=20=20=20=20=20=20=20=20=20=20=20= (kill-new=20(buffer-string)))))))=0A=20=0A+(defun=20outline--cycle-state=20= ()=0A+=20=20"Return=20the=20cycle=20state=20of=20current=20heading.=0A= +Return=20either=20'hide-all,=20'headings-only,=20or=20'show-all."=0A+=20= =20(save-excursion=0A+=20=20=20=20(let=20(start=20end=20ov-list=20= heading-end)=0A+=20=20=20=20=20=20(outline-back-to-heading)=0A+=20=20=20=20= =20=20(setq=20start=20(point))=0A+=20=20=20=20=20=20= (outline-end-of-heading)=0A+=20=20=20=20=20=20(setq=20heading-end=20= (point))=0A+=20=20=20=20=20=20(outline-end-of-subtree)=0A+=20=20=20=20=20= =20(setq=20end=20(point))=0A+=20=20=20=20=20=20(setq=20ov-list=20= (cl-remove-if-not=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(lambda=20(o)=20(eq=20(overlay-get=20o=20'invisible)=20= 'outline))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(overlays-in=20start=20end)))=0A+=20=20=20=20=20=20(cond=20((eq=20= ov-list=20nil)=20'show-all)=0A+=20=20=20=20=20=20=20=20=20=20=20=20;;=20= (eq=20(length=20ov-list)=201)=20wouldn=E2=80=99t=20work:=20what=20if=20= there=20is=0A+=20=20=20=20=20=20=20=20=20=20=20=20;;=20one=20folded=20= subheading?=0A+=20=20=20=20=20=20=20=20=20=20=20=20((and=20(eq=20= (overlay-end=20(car=20ov-list))=20end)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(eq=20(overlay-start=20(car=20ov-list))=20= heading-end))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20'hide-all)=0A+=20= =20=20=20=20=20=20=20=20=20=20=20(t=20'headings-only)))))=0A+=0A+(defun=20= outline-has-subheading-p=20()=0A+=20=20"Return=20t=20if=20this=20heading=20= has=20subheadings,=20nil=20otherwise."=0A+=20=20(save-excursion=0A+=20=20= =20=20(outline-back-to-heading)=0A+=20=20=20=20(<=20(save-excursion=20= (outline-next-heading)=20(point))=0A+=20=20=20=20=20=20=20= (save-excursion=20(outline-end-of-subtree)=20(point)))))=0A+=0A+(defun=20= outline-cycle=20()=0A+=20=20"Cycle=20between=20=E2=80=9Chide=20all=E2=80=9D= ,=20=E2=80=9Cheadings=20only=E2=80=9D=20and=20=E2=80=9Cshow=20all=E2=80=9D= .=0A+=0A+=E2=80=9CHide=20all=E2=80=9D=20means=20hide=20all=20subheadings=20= and=20their=20bodies.=0A+=E2=80=9CHeadings=20only=E2=80=9D=20means=20= show=20sub=20headings=20but=20not=20their=20bodies.=0A+=E2=80=9CShow=20= all=E2=80=9D=20means=20show=20all=20subheadings=20and=20their=20bodies."=0A= +=20=20(interactive)=0A+=20=20(pcase=20(outline--cycle-state)=0A+=20=20=20= =20('hide-all=20(if=20(outline-has-subheading-p)=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(progn=20(outline-show-children)=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (message=20"Only=20headings"))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(message=20"Show=20all")))=0A+=20=20=20=20('headings-only=20= (outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(message=20"Show=20all"))=0A+=20=20=20=20('show-all=20= (outline-hide-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (message=20"Hide=20all"))))=0A+=0A+(defvar-local=20= outline--cycle-buffer-state=20'show-all=0A+=20=20"Interval=20variable=20= used=20for=20tracking=20buffer=20cycle=20state.")=0A+=0A+(defun=20= outline-cycle-buffer=20()=0A+=20=20"Cycle=20the=20whole=20buffer=20like=20= in=20=E2=80=98outline-cycle=E2=80=99."=0A+=20=20(interactive)=0A+=20=20= (pcase=20outline--cycle-buffer-state=0A+=20=20=20=20('show-all=20= (save-excursion=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (let=20((start-point=20(point)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(while=20(not=20(eq=20(point)=20start-point))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (outline-up-heading=201))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(outline-hide-sublevels=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(progn=20(outline-back-to-heading)=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (funcall=20'outline-level)))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(setq=20outline--cycle-buffer-state=20'top-level)=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(message=20"Top=20level=20headings"))=0A+=20= =20=20=20('top-level=20(outline-show-all)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(outline-hide-region-body=20(point-min)=20(point-max))=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= outline--cycle-buffer-state=20'all-heading)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(message=20"All=20headings"))=0A+=20=20=20=20= ('all-heading=20(outline-show-all)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(setq=20outline--cycle-buffer-state=20'show-all)=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(message=20"Show=20= all"))))=0A+=0A=20(provide=20'outline)=0A=20(provide=20'noutline)=0A=20=0A= --Apple-Mail=_CC3C253A-5129-4254-A5DF-DF5C1E4BB804 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_CC3C253A-5129-4254-A5DF-DF5C1E4BB804-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 18 22:45:19 2020 Received: (at 41198) by debbugs.gnu.org; 19 May 2020 02:45:19 +0000 Received: from localhost ([127.0.0.1]:48730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jasFr-0000bS-7c for submit@debbugs.gnu.org; Mon, 18 May 2020 22:45:19 -0400 Received: from mail-qk1-f179.google.com ([209.85.222.179]:39611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jasFo-0000b2-IQ; Mon, 18 May 2020 22:45:16 -0400 Received: by mail-qk1-f179.google.com with SMTP id 142so766984qkl.6; Mon, 18 May 2020 19:45:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=yMP9pSpYCmjovbXMPU5h2jN+wT3Torh3x6JBeslYFcs=; b=KKLx/xo25ZH/QAg2RZzUq/dc6nw+WwU7UqKfSxEOJpiO4Gky7s3BFVBn99XZ5EYUey FrkHJaCau1PVeWQYbGX+XjWFv6cpOyE9p7jHJMPN5hoVyzFJMRfeoNKPpBfypIhghNuo UY+qnXgCPOaW3HxJFX9e34dcnjbNaxav0S8ANYS4cmuhWTelgd/oIM3fvQkqjoQ6JCxt 5YOUoSpCeW1mMR+Hg86BLGQjq4lfQ0VB+FHKqC5p8CbovHLlJaP+Dg2+WIqRXEE4Q/so hcXpDLcSP5Emie7BEOdl1ouGrg94vqV7dyNLi5dXmdaqW1AJk+9hAofkEfRaS52E0xoE eTCw== X-Gm-Message-State: AOAM533HvBoAwk7bhdqv8oucHLqq0SLrhC0wC+nJTsWM6HxZubmHaBJ1 A6KKiJQo1xeqgZ22NpCf9qZ1k/my+TvLxo0Vfxg= X-Google-Smtp-Source: ABdhPJznylKBxdpMaBRXhOKWmBtMfymHgk2ZgRZI+NBfq6DRk97rJRkS9teSs3Y+SwSkYbf3OfqJhYlcjKL5iISKsew= X-Received: by 2002:a25:9304:: with SMTP id f4mr19287903ybo.309.1589856310837; Mon, 18 May 2020 19:45:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 18 May 2020 19:45:10 -0700 From: Stefan Kangas In-Reply-To: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> (Yuan Fu's message of "Mon, 11 May 2020 21:52:25 -0400") References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 18 May 2020 19:45:10 -0700 Message-ID: Subject: Re: bug#41198: 27.0.60; [PATCH] heading cycling command for outline To: Yuan Fu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41198 Cc: 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) forcemerge 41130 41198 thanks Yuan Fu writes: > Add two commands that cycles a heading (like that in Org mode) in outline= -mode: > > - outline-cycle: cycles between =E2=80=9Chide all=E2=80=9D, =E2=80=9Csub = headings=E2=80=9D and =E2=80=9Cshow all=E2=80=9D state. They are called =E2= =80=9CFOLDED=E2=80=9D, =E2=80=9CCHILDREN=E2=80=9D, =E2=80=9CSUBTREE=E2=80= =9D in Org mode. > - outline-cycle-buffer: cycles between =E2=80=9Conly top level headings= =E2=80=9D, =E2=80=9Call headings=E2=80=9D, =E2=80=9Cshow all=E2=80=9D state= s Thanks for working on this. I've tested your patch, and it seems to work as advertised. > Could this be useful? I think it could. I have previously sent the wishlist Bug#41130, which I have now merged with this bug. I have seen no objections to that proposal, so I hope that it is uncontroversial. In Bug#41130, I also suggest to add the same keybinding as in org-mode: TAB and S-TAB. Could you add such keybindings to outline-mode-map in your patch? I think we also need ChangeLog in the commit message, an entry in NEWS, and updates to the manual. > +(defun outline-cycle () > + "Cycle between =E2=80=9Chide all=E2=80=9D, =E2=80=9Cheadings only=E2= =80=9D and =E2=80=9Cshow all=E2=80=9D. > + > +=E2=80=9CHide all=E2=80=9D means hide all subheadings and their bodies. > +=E2=80=9CHeadings only=E2=80=9D means show sub headings but not their bo= dies. > +=E2=80=9CShow all=E2=80=9D means show all subheadings and their bodies." I can't remember seeing double quotes used like that before in doc strings. Correct me if I'm wrong, but wouldn't we normally use `single-quotes' for something like this? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 14:32:12 2020 Received: (at 41198) by debbugs.gnu.org; 19 May 2020 18:32:12 +0000 Received: from localhost ([127.0.0.1]:50951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb727-000429-Bx for submit@debbugs.gnu.org; Tue, 19 May 2020 14:32:12 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:36438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb721-0003sA-EQ; Tue, 19 May 2020 14:32:06 -0400 Received: by mail-qk1-f171.google.com with SMTP id y22so623943qki.3; Tue, 19 May 2020 11:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=qrH1UbxjXXW4oks7QAHIe9LdluTx9zGRQEMZ+Cs0qQ8=; b=MJH3GhoaGfK/Md7WbwacZJZaIIafVObQHZqgEgYMU+ilgG0sGQIPuwEDdvSdoSo8pG lXpkzmmhJvrkpm69BOXik8AV0LpFFB5F4njszflRUdVSYRaNfkVwqxAb1V0dTeBh55jc kRVFrXR6JvwsjdodUJgUBjqKEQFbd0I/HtkyV66TlFBmPWX/hEKS/3CxOaC+QHk0iCtO ms+DPGdSObGNPK7t+QF1l6L8UT+JVWb4LmX6rouher9iKofS4MNZNEdiTiSSkEXC/EQ0 t8EpiKIB2/XQ0Eh9KNytWevLkBvATHcFNAYcKMbAAdac0qZU17UA0SaSuDoDWD28NteN 68JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=qrH1UbxjXXW4oks7QAHIe9LdluTx9zGRQEMZ+Cs0qQ8=; b=aZSFCVNmMTB3e49bGMUgbzvjxiCbxngKkRdRqk3M0tVMN8vDJFrwntm0Rhw38TuA+l IHVL/xFoFqiBt0/GzZBK0S/U6ygqK5vt/8iUTxL9hUWqiX57cFl/9kNBNaVgdbZg0UdW 9YldSYFa8SorD2jpTQCqfaPanfSE4lGTHfIb4kdrMrYG3xlpq+w4YG284awAwADVXxh8 fVSpu+SjLHT+GTiKQLVuEfcwJz+PBzDBeb/briVgdnyqqFG1NF38vDC+hak4E53vtLCN Rd9Z8T+wOt6cMSJa6VSfyh2/DFtAxKE1ek7fU4kFgwIb0K3fh6DSB0UCTjMF9G9X81R5 zt9Q== X-Gm-Message-State: AOAM530igyPzb5kayQ/NrqCRB0CnmlVCS6TQ/yfue8PHIwEKuQ10azPv TgejcrzyFnhtvFZgsEB1bfB38JtlOMAJ0Q== X-Google-Smtp-Source: ABdhPJw+cp1YNXD727FPFhKiWoIL00W8yOmwWMmA/FDh2FlmVX5hDsBmBmMG/oc+BhfYH5kvos174w== X-Received: by 2002:a37:498a:: with SMTP id w132mr678106qka.221.1589913114608; Tue, 19 May 2020 11:31:54 -0700 (PDT) Received: from [192.168.1.5] (c-174-60-229-153.hsd1.pa.comcast.net. [174.60.229.153]) by smtp.gmail.com with ESMTPSA id w43sm430486qtw.68.2020.05.19.11.31.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 May 2020 11:31:54 -0700 (PDT) From: Yuan Fu Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_C326A5FC-00B3-4BF7-ACC6-56221F24B8BE" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Date: Tue, 19 May 2020 14:31:52 -0400 In-Reply-To: To: Stefan Kangas References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_C326A5FC-00B3-4BF7-ACC6-56221F24B8BE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 18, 2020, at 10:45 PM, Stefan Kangas wrote: >=20 > forcemerge 41130 41198 > thanks >=20 > Yuan Fu writes: >=20 >> Add two commands that cycles a heading (like that in Org mode) in = outline-mode: >>=20 >> - outline-cycle: cycles between =E2=80=9Chide all=E2=80=9D, =E2=80=9Csu= b headings=E2=80=9D and =E2=80=9Cshow all=E2=80=9D state. They are = called =E2=80=9CFOLDED=E2=80=9D, =E2=80=9CCHILDREN=E2=80=9D, = =E2=80=9CSUBTREE=E2=80=9D in Org mode. >> - outline-cycle-buffer: cycles between =E2=80=9Conly top level = headings=E2=80=9D, =E2=80=9Call headings=E2=80=9D, =E2=80=9Cshow all=E2=80= =9D states >=20 > Thanks for working on this. I've tested your patch, and it seems to > work as advertised. Thanks. >=20 >> Could this be useful? >=20 > I think it could. I have previously sent the wishlist Bug#41130, = which > I have now merged with this bug. I have seen no objections to that > proposal, so I hope that it is uncontroversial. >=20 > In Bug#41130, I also suggest to add the same keybinding as in = org-mode: > TAB and S-TAB. Could you add such keybindings to outline-mode-map in > your patch? It seems that the outline-mode bindings all live under C-c. Maybe C-c = TAB and C-c S-TAB? Should I ask on emacs-devel for for suggestions? >=20 > I think we also need ChangeLog in the commit message, an entry in = NEWS, > and updates to the manual. I updated NEWS and the manual. For ChangeLog, I thought that=E2=80=99s = automatically generated from commit messages? >=20 >> +(defun outline-cycle () >> + "Cycle between =E2=80=9Chide all=E2=80=9D, =E2=80=9Cheadings = only=E2=80=9D and =E2=80=9Cshow all=E2=80=9D. >> + >> +=E2=80=9CHide all=E2=80=9D means hide all subheadings and their = bodies. >> +=E2=80=9CHeadings only=E2=80=9D means show sub headings but not = their bodies. >> +=E2=80=9CShow all=E2=80=9D means show all subheadings and their = bodies." >=20 > I can't remember seeing double quotes used like that before in doc > strings. Correct me if I'm wrong, but wouldn't we normally use > `single-quotes' for something like this? >=20 Done. Yuan --Apple-Mail=_C326A5FC-00B3-4BF7-ACC6-56221F24B8BE Content-Disposition: attachment; filename=outline.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="outline.patch" Content-Transfer-Encoding: quoted-printable diff=20--git=20a/doc/emacs/text.texi=20b/doc/emacs/text.texi=0Aindex=20= 281e24421c..e2f829b7c5=20100644=0A---=20a/doc/emacs/text.texi=0A+++=20= b/doc/emacs/text.texi=0A@@=20-1207,6=20+1207,15=20@@=20Outline=20= Visibility=0A=20it=20completely=20reveals=20all=20the=20@var{n}=20top=20= levels=20and=20the=20body=20lines=0A=20before=20the=20first=20heading.=0A= =20=0A+@findex=20outline-cycle=0A+@findex=20outline-cycle-buffer=0A+=20=20= Outline=20also=20provides=20two=20convenience=20commands=20to=20cycle=20= the=0A+visibility=20of=20each=20heading=20and=20the=20whole=20buffer.=20=20= @code{outline-cycle}=0A+cycles=20the=20current=20heading=20between=20= "hide=20all",=20"subheadings",=20and=0A+"show=20all"=20state.=20=20= @code{outline-cycle-buffer}=20cycles=20the=20whole=20buffer=0A+between=20= "only=20top-level=20headings",=20"all=20headings=20and=20subheadings",=20= and=0A+"show=20all"=20states.=0A+=0A=20@anchor{Outline=20Search}=0A=20= @findex=20reveal-mode=0A=20@vindex=20search-invisible=0Adiff=20--git=20= a/etc/NEWS=20b/etc/NEWS=0Aindex=20025d5c14a7..3ecec6d0e4=20100644=0A---=20= a/etc/NEWS=0A+++=20b/etc/NEWS=0A@@=20-288,6=20+288,14=20@@=20prefix=20on=20= the=20Subject=20line=20in=20various=20languages.=0A=20These=20new=20= navigation=20commands=20are=20bound=20to=20'n'=20and=20'p'=20in=0A=20= 'apropos-mode'.=0A=20=0A+**=20Outline=0A+=0A+***=20New=20commands=20to=20= cycle=20heading=20visibility.=0A+'outline-cycle'=20cycles=20the=20= current=20heading=20between=20"hide=20all",=0A+"subheadings",=20and=20= "show=20all"=20state.=20'outline-cycle-buffer'=20cycles=20the=0A+whole=20= buffer=20between=20"only=20top-level=20headings",=20"all=20headings=20= and=0A+subheadings",=20and=20"show=20all"=20states.=0A+=0A=20=0C=0A=20*=20= New=20Modes=20and=20Packages=20in=20Emacs=2028.1=0A=20=0Adiff=20--git=20= a/lisp/outline.el=20b/lisp/outline.el=0Aindex=2028ea8a86e6..8dd1b4483c=20= 100644=0A---=20a/lisp/outline.el=0A+++=20b/lisp/outline.el=0A@@=20= -1118,6=20+1118,77=20@@=20outline-headers-as-kill=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(insert=20"\n\n"))))))=0A=20=20= =20=20=20=20=20=20=20=20=20(kill-new=20(buffer-string)))))))=0A=20=0A= +(defun=20outline--cycle-state=20()=0A+=20=20"Return=20the=20cycle=20= state=20of=20current=20heading.=0A+Return=20either=20'hide-all,=20= 'headings-only,=20or=20'show-all."=0A+=20=20(save-excursion=0A+=20=20=20=20= (let=20(start=20end=20ov-list=20heading-end)=0A+=20=20=20=20=20=20= (outline-back-to-heading)=0A+=20=20=20=20=20=20(setq=20start=20(point))=0A= +=20=20=20=20=20=20(outline-end-of-heading)=0A+=20=20=20=20=20=20(setq=20= heading-end=20(point))=0A+=20=20=20=20=20=20(outline-end-of-subtree)=0A+=20= =20=20=20=20=20(setq=20end=20(point))=0A+=20=20=20=20=20=20(setq=20= ov-list=20(cl-remove-if-not=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(lambda=20(o)=20(eq=20(overlay-get=20o=20= 'invisible)=20'outline))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(overlays-in=20start=20end)))=0A+=20=20=20=20=20=20= (cond=20((eq=20ov-list=20nil)=20'show-all)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20;;=20(eq=20(length=20ov-list)=201)=20wouldn=E2=80=99t=20work:=20= what=20if=20there=20is=0A+=20=20=20=20=20=20=20=20=20=20=20=20;;=20one=20= folded=20subheading?=0A+=20=20=20=20=20=20=20=20=20=20=20=20((and=20(eq=20= (overlay-end=20(car=20ov-list))=20end)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(eq=20(overlay-start=20(car=20ov-list))=20= heading-end))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20'hide-all)=0A+=20= =20=20=20=20=20=20=20=20=20=20=20(t=20'headings-only)))))=0A+=0A+(defun=20= outline-has-subheading-p=20()=0A+=20=20"Return=20t=20if=20this=20heading=20= has=20subheadings,=20nil=20otherwise."=0A+=20=20(save-excursion=0A+=20=20= =20=20(outline-back-to-heading)=0A+=20=20=20=20(<=20(save-excursion=20= (outline-next-heading)=20(point))=0A+=20=20=20=20=20=20=20= (save-excursion=20(outline-end-of-subtree)=20(point)))))=0A+=0A+(defun=20= outline-cycle=20()=0A+=20=20"Cycle=20between=20`hide=20all',=20`headings=20= only'=20and=20`show=20all'.=0A+=0A+`Hide=20all'=20means=20hide=20all=20= subheadings=20and=20their=20bodies.=0A+`Headings=20only'=20means=20show=20= sub=20headings=20but=20not=20their=20bodies.=0A+`Show=20all'=20means=20= show=20all=20subheadings=20and=20their=20bodies."=0A+=20=20(interactive)=0A= +=20=20(pcase=20(outline--cycle-state)=0A+=20=20=20=20('hide-all=20(if=20= (outline-has-subheading-p)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(progn=20(outline-show-children)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(message=20"Only=20= headings"))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(message=20"Show=20all")))=0A+=20=20=20=20('headings-only=20= (outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(message=20"Show=20all"))=0A+=20=20=20=20('show-all=20= (outline-hide-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (message=20"Hide=20all"))))=0A+=0A+(defvar-local=20= outline--cycle-buffer-state=20'show-all=0A+=20=20"Internal=20variable=20= used=20for=20tracking=20buffer=20cycle=20state.")=0A+=0A+(defun=20= outline-cycle-buffer=20()=0A+=20=20"Cycle=20the=20whole=20buffer=20like=20= in=20`outline-cycle'."=0A+=20=20(interactive)=0A+=20=20(pcase=20= outline--cycle-buffer-state=0A+=20=20=20=20('show-all=20(save-excursion=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(let=20((start-point=20= (point)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (while=20(not=20(eq=20(point)=20start-point))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(outline-up-heading=201))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (outline-hide-sublevels=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(progn=20(outline-back-to-heading)=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(funcall=20= 'outline-level)))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (setq=20outline--cycle-buffer-state=20'top-level)=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(message=20"Top=20level=20headings"))=0A+=20=20=20= =20('top-level=20(outline-show-all)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(outline-hide-region-body=20(point-min)=20(point-max))=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= outline--cycle-buffer-state=20'all-heading)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(message=20"All=20headings"))=0A+=20=20=20=20= ('all-heading=20(outline-show-all)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(setq=20outline--cycle-buffer-state=20'show-all)=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(message=20"Show=20= all"))))=0A+=0A=20(provide=20'outline)=0A=20(provide=20'noutline)=0A=20=0A= --Apple-Mail=_C326A5FC-00B3-4BF7-ACC6-56221F24B8BE-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 18:36:09 2020 Received: (at 41198) by debbugs.gnu.org; 19 May 2020 22:36:09 +0000 Received: from localhost ([127.0.0.1]:51376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbAqH-00048z-Jv for submit@debbugs.gnu.org; Tue, 19 May 2020 18:36:09 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:38189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbAqF-00048k-V6; Tue, 19 May 2020 18:36:08 -0400 Received: by mail-qk1-f177.google.com with SMTP id f189so1667879qkd.5; Tue, 19 May 2020 15:36:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=UpNnLmgn8vD7zUpU0fvb+3rpeFGNHmJoVsRF7gk4uZQ=; b=C1/Cx8TzFjoiPpcOcNVKkfCt41OvIyLt5vEIolw5WSfYtaSA/E9DbxZBqi04rgvgK1 J5zTqycC2hz1kBGrWYDYrm2rxDxCfuYhUFWuwCmxXZC4ewumTbczj9lLBQvd/VfeMavZ bqMOtgPMFWXOOUmwERXgIvsdvD+uawSDF3f6de6vZgUXGc/cFApBbUCNtnz9qKAB3FnX sqGegHMKVRO43kPsox2b/MGLnwEEE7JZBURkUR6q1bG8BoOJnanQZMy4BEuYgq9pbEbT bRyiMI8qK1jUC3CDaKJDac375ii80rcaBSs1RYQK+DuglWHW72KOc//G85XS6ZzbhN2V 6sow== X-Gm-Message-State: AOAM532Pev4aCo9nb7IlQBQkShY8Qw1YgT5kKM7YyerFFSRwPRyKI11l GbtWZ7VXJMHfgxbSpla/JJ8tdc4y6o2+Y2cqGDI= X-Google-Smtp-Source: ABdhPJxp+ymVu1l7rTF0w2AmHPOM3enjv+WWAnnv3mAlJ4J0cwu6MlVci5xNcv/dQgc+9vblM/X6xGvqqYn0inDWH1g= X-Received: by 2002:a25:9304:: with SMTP id f4mr2634766ybo.309.1589927762319; Tue, 19 May 2020 15:36:02 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 May 2020 15:36:01 -0700 From: Stefan Kangas In-Reply-To: References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> MIME-Version: 1.0 Date: Tue, 19 May 2020 15:36:01 -0700 Message-ID: Subject: Re: bug#41198: 27.0.60; [PATCH] heading cycling command for outline To: Yuan Fu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41198 Cc: 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Yuan Fu writes: >> In Bug#41130, I also suggest to add the same keybinding as in org-mode: >> TAB and S-TAB. Could you add such keybindings to outline-mode-map in >> your patch? > > It seems that the outline-mode bindings all live under C-c. Maybe C-c > TAB and C-c S-TAB? Should I ask on emacs-devel for for suggestions? I think it is better to use the same keys as org-mode, since one important motivation for this feature is precisely to align the outline-mode keybindings with org-mode. This aspect would be significantly diminished by using other keys, IMHO. My impression was that also there was consensus around (or at least no objections to) that idea the last time we discussed it. I would therefore propose to just add TAB and S-TAB to the patch, but allow a week or two before pushing to give others a chance to comment here. But, if you really want to, of course you could also ask on emacs-devel. Worst case, we get to have another round of bikeshedding. ;-) >> I think we also need ChangeLog in the commit message, an entry in NEWS, >> and updates to the manual. > > I updated NEWS and the manual. For ChangeLog, I thought that=E2=80=99s > automatically generated from commit messages? That is my understanding too. But I only saw a diff attached, not a patch with a commit message. That is what I tried to say, but I could've been more clear. (CONTRIBUTE suggests using `git format-patch -1' to email a patch, which includes the commit message.) > +@findex outline-cycle > +@findex outline-cycle-buffer > + Outline also provides two convenience commands to cycle the > +visibility of each heading and the whole buffer. @code{outline-cycle} > +cycles the current heading between "hide all", "subheadings", and > +"show all" state. @code{outline-cycle-buffer} cycles the whole buffer > +between "only top-level headings", "all headings and subheadings", and > +"show all" states. [...] > +*** New commands to cycle heading visibility. > +'outline-cycle' cycles the current heading between "hide all", > +"subheadings", and "show all" state. 'outline-cycle-buffer' cycles the > +whole buffer between "only top-level headings", "all headings and > +subheadings", and "show all" states. Looks good to me (but should refer to the above keybindings if they're added). Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 21:37:38 2020 Received: (at 41198) by debbugs.gnu.org; 20 May 2020 01:37:39 +0000 Received: from localhost ([127.0.0.1]:51643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbDfu-0004Pm-DN for submit@debbugs.gnu.org; Tue, 19 May 2020 21:37:38 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:37626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbDfq-0004PU-VZ; Tue, 19 May 2020 21:37:36 -0400 Received: by mail-qk1-f170.google.com with SMTP id m11so2085395qka.4; Tue, 19 May 2020 18:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=VpIr1QcZKldXX8v8VYkKPHWnRedJda5xRPXwJAK0sqs=; b=d+vqLdWDxy7xcP287Q+nS+1QuS51kLO0TShAzhNUBUGHKkJE7gt0aIdR0pvNbhsiyC Lf7V9kMk4N2ibW80Ywb8qRkshrvAzVJP5qLPOrOkYk6RxZ/XaWszzyls83gsyDh9pgKo IfL/woeVZqhBMdyVZYycbib2mlbMCI2JM0IgQdgrEPgYgcWQzzXDEoQRvi1mws44JzsI QqXOXaIumrGmHFcvCas/wZJxsRL+4DdsuWmo3rPzEYnXi78lG5GXyS+eBnlFFRuXA9KJ +ED20DulzEJ2vE57Tm3jDt9qToZUG328ybP30QNM3wRZumhPElx3hPvXkrhp9jhHlc9e Qyrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=VpIr1QcZKldXX8v8VYkKPHWnRedJda5xRPXwJAK0sqs=; b=mKXPpUdluVhjTlSzfYgkOlvvgYBwyqUlnsJaalO7YhWB0CoVXDHwFJJVIwlAwokScp 3718S22n4dnGPWLwMrKKKQlbflzPNV26bNXCgHnFZgviQUuA5WrFiaqQsAuUd/3mxlZ9 6vnanA5jFf7K1JJUxM23DY9De8toNyoPsbfcZUsJ0FBpR4H9ZZx8LygcwW1mIU6ahsmr OMjGdcrXYAehcCTXFTyp7rzB1BiY3vymYmbEak1WHDqx7wqlIZZqqKlqme/gZ/4S3hal i31nyqNSHrbO0/qWHaedG1bq9ESsfYJ2i6pVNp2eUDmCq8s9Tu7ktr0FRYBkZO/tQvT9 758Q== X-Gm-Message-State: AOAM532A6uFHDcSHOBVixcaRS0uJSLmofo1IHz6JSh4LXe5WCI00ifKd eoDUKgwOcxYR8KfP1vTEcPfTCpc49DUx2g== X-Google-Smtp-Source: ABdhPJwEbOfRR0+SBNNf7ESFlX51o43v2iVDdZM2LTDOBldNotmnD0w4bSIJtX9Epj/gYBKUZI3XgA== X-Received: by 2002:a37:7143:: with SMTP id m64mr2573475qkc.215.1589938649107; Tue, 19 May 2020 18:37:29 -0700 (PDT) Received: from [192.168.1.5] (c-174-60-229-153.hsd1.pa.comcast.net. [174.60.229.153]) by smtp.gmail.com with ESMTPSA id n31sm1486530qtc.36.2020.05.19.18.37.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 May 2020 18:37:28 -0700 (PDT) From: Yuan Fu Message-Id: <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_27772D71-6B93-4500-B432-5A6FDB60B7C8" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Date: Tue, 19 May 2020 21:37:26 -0400 In-Reply-To: To: Stefan Kangas References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_27772D71-6B93-4500-B432-5A6FDB60B7C8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 19, 2020, at 6:36 PM, Stefan Kangas wrote: >=20 > Yuan Fu writes: >=20 >>> In Bug#41130, I also suggest to add the same keybinding as in = org-mode: >>> TAB and S-TAB. Could you add such keybindings to outline-mode-map = in >>> your patch? >>=20 >> It seems that the outline-mode bindings all live under C-c. Maybe C-c >> TAB and C-c S-TAB? Should I ask on emacs-devel for for suggestions? >=20 > I think it is better to use the same keys as org-mode, since one > important motivation for this feature is precisely to align the > outline-mode keybindings with org-mode. This aspect would be > significantly diminished by using other keys, IMHO. >=20 > My impression was that also there was consensus around (or at least no > objections to) that idea the last time we discussed it. I would > therefore propose to just add TAB and S-TAB to the patch, but allow a > week or two before pushing to give others a chance to comment here. >=20 > But, if you really want to, of course you could also ask on = emacs-devel. > Worst case, we get to have another round of bikeshedding. ;-) I added TAB and S-TAB bindings. Though S-TAB appears to be on = my machine (Mac) for both terminal and GUI so I bound that instead. Is = that so for other machines? To reduce the possible allergy, I made the = TAB binding conditional=E2=80=94only invokes outline-cycle when point is = on a heading. A minor thing: if the motivation is to align with Org mode, should I = change the text message to align with Org mode? It prints =E2=80=9Cshow = all=E2=80=9D, =E2=80=9Chide all=E2=80=9D, etc (because they make sense), = but Org mode prints stuff like =E2=80=9CCHILDREN=E2=80=9D, = =E2=80=9CSUBTREE=E2=80=9D, etc. >=20 >>> I think we also need ChangeLog in the commit message, an entry in = NEWS, >>> and updates to the manual. >>=20 >> I updated NEWS and the manual. For ChangeLog, I thought that=E2=80=99s >> automatically generated from commit messages? >=20 > That is my understanding too. >=20 > But I only saw a diff attached, not a patch with a commit message. = That > is what I tried to say, but I could've been more clear. >=20 > (CONTRIBUTE suggests using `git format-patch -1' to email a patch, = which > includes the commit message.) Ah sorry, I switched to a new way to generate patches and didn=E2=80=99t = notice that the commit message is gone. It is included this time. >=20 >> +@findex outline-cycle >> +@findex outline-cycle-buffer >> + Outline also provides two convenience commands to cycle the >> +visibility of each heading and the whole buffer. = @code{outline-cycle} >> +cycles the current heading between "hide all", "subheadings", and >> +"show all" state. @code{outline-cycle-buffer} cycles the whole = buffer >> +between "only top-level headings", "all headings and subheadings", = and >> +"show all" states. > [...] >> +*** New commands to cycle heading visibility. >> +'outline-cycle' cycles the current heading between "hide all", >> +"subheadings", and "show all" state. 'outline-cycle-buffer' cycles = the >> +whole buffer between "only top-level headings", "all headings and >> +subheadings", and "show all" states. >=20 > Looks good to me (but should refer to the above keybindings if they're > added). Yuan --Apple-Mail=_27772D71-6B93-4500-B432-5A6FDB60B7C8 Content-Disposition: attachment; filename=outline.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="outline.patch" Content-Transfer-Encoding: quoted-printable =46rom=20243d6dec5c33c7add2fd12fe0da3e49a134cf0a9=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Yuan=20Fu=20=0ADate:=20Sun,=20= 10=20May=202020=2017:10:32=20-0400=0ASubject:=20[PATCH]=20Add=20cycling=20= commands=20to=20outline=0A=0A*=20lisp/outline.el=20= (outline--cycle-state,=20outline-has-subheading-p,=0Aoutline-cycle,=20= outline-cycle-buffer):=20New=20functions.=0A(outline-mode-map):=20Add=20= key=20bindings=20for=20the=20two=20new=20commands.=0A= (outline--cycle-buffer-state):=20New=20variable.=0A*=20= doc/emacs/text.text=20(Outline=20Visibility):=20Add=20'outline-cycle'=20= and=0A'outline-cycle-buffer'.=0A*=20etc/NEWS=20(Outline):=20Record=20the=20= change.=0A---=0A=20doc/emacs/text.texi=20|=2010=20++++++=0A=20etc/NEWS=20= =20=20=20=20=20=20=20=20=20=20=20|=20=209=20++++++=0A=20lisp/outline.el=20= =20=20=20=20|=2077=20+++++++++++++++++++++++++++++++++++++++++++++=0A=20= 3=20files=20changed,=2096=20insertions(+)=0A=0Adiff=20--git=20= a/doc/emacs/text.texi=20b/doc/emacs/text.texi=0Aindex=20= 281e24421c..9c2822ce15=20100644=0A---=20a/doc/emacs/text.texi=0A+++=20= b/doc/emacs/text.texi=0A@@=20-1207,6=20+1207,16=20@@=20Outline=20= Visibility=0A=20it=20completely=20reveals=20all=20the=20@var{n}=20top=20= levels=20and=20the=20body=20lines=0A=20before=20the=20first=20heading.=0A= =20=0A+@findex=20outline-cycle=0A+@findex=20outline-cycle-buffer=0A+=20=20= Outline=20also=20provides=20two=20convenience=20commands=20to=20cycle=20= the=0A+visibility=20of=20each=20section=20and=20the=20whole=20buffer.=20=20= Typing=20@kbd{TAB}=20on=0A+a=20heading=20invokes=20@code{outline-cycle},=20= which=20cycles=20the=20current=0A+section=20between=20"hide=20all",=20= "subheadings",=20and=20"show=20all"=20state.=0A+Typing=20@kbd{S-TAB}=20= invokes=20@code{outline-cycle-buffer},=20which=20cycles=0A+the=20whole=20= buffer=20between=20"only=20top-level=20headings",=20"all=20headings=20= and=0A+subheadings",=20and=20"show=20all"=20states.=0A+=0A=20= @anchor{Outline=20Search}=0A=20@findex=20reveal-mode=0A=20@vindex=20= search-invisible=0Adiff=20--git=20a/etc/NEWS=20b/etc/NEWS=0Aindex=20= 025d5c14a7..72057af94d=20100644=0A---=20a/etc/NEWS=0A+++=20b/etc/NEWS=0A= @@=20-288,6=20+288,15=20@@=20prefix=20on=20the=20Subject=20line=20in=20= various=20languages.=0A=20These=20new=20navigation=20commands=20are=20= bound=20to=20'n'=20and=20'p'=20in=0A=20'apropos-mode'.=0A=20=0A+**=20= Outline=0A+=0A+***=20New=20commands=20to=20cycle=20heading=20visibility=0A= +=0A+Typing=20'TAB'=20on=20a=20heading=20cycles=20the=20current=20= section=20between=20"hide=0A+all",=20"subheadings",=20and=20"show=20all"=20= state.=20Typing=20'S-TAB'=20anywhere=20in=0A+the=20buffer=20cycles=20the=20= whole=20buffer=20between=20"only=20top-level=20headings",=0A+"all=20= headings=20and=20subheadings",=20and=20"show=20all"=20states.=0A+=0A=20=0C= =0A=20*=20New=20Modes=20and=20Packages=20in=20Emacs=2028.1=0A=20=0Adiff=20= --git=20a/lisp/outline.el=20b/lisp/outline.el=0Aindex=20= 28ea8a86e6..0d792dd28c=20100644=0A---=20a/lisp/outline.el=0A+++=20= b/lisp/outline.el=0A@@=20-179,6=20+179,12=20@@=20outline-mode-map=0A=20=20= =20(let=20((map=20(make-sparse-keymap)))=0A=20=20=20=20=20(define-key=20= map=20"\C-c"=20outline-mode-prefix-map)=0A=20=20=20=20=20(define-key=20= map=20[menu-bar]=20outline-mode-menu-bar-map)=0A+=20=20=20=20;;=20Only=20= takes=20effect=20if=20the=20point=20is=20on=20a=20heading.=0A+=20=20=20=20= (define-key=20map=20(kbd=20"TAB")=0A+=20=20=20=20=20=20`(menu-item=20""=20= outline-cycle=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= :filter=20,(lambda=20(cmd)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(outline-on-heading-p)=20= cmd))))=0A+=20=20=20=20(define-key=20map=20(kbd=20"")=20= #'outline-cycle-buffer)=0A=20=20=20=20=20map))=0A=20=0A=20(defvar=20= outline-font-lock-keywords=0A@@=20-1118,6=20+1124,77=20@@=20= outline-headers-as-kill=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(insert=20"\n\n"))))))=0A=20=20=20=20=20=20=20=20=20=20=20= (kill-new=20(buffer-string)))))))=0A=20=0A+(defun=20outline--cycle-state=20= ()=0A+=20=20"Return=20the=20cycle=20state=20of=20current=20heading.=0A= +Return=20either=20'hide-all,=20'headings-only,=20or=20'show-all."=0A+=20= =20(save-excursion=0A+=20=20=20=20(let=20(start=20end=20ov-list=20= heading-end)=0A+=20=20=20=20=20=20(outline-back-to-heading)=0A+=20=20=20=20= =20=20(setq=20start=20(point))=0A+=20=20=20=20=20=20= (outline-end-of-heading)=0A+=20=20=20=20=20=20(setq=20heading-end=20= (point))=0A+=20=20=20=20=20=20(outline-end-of-subtree)=0A+=20=20=20=20=20= =20(setq=20end=20(point))=0A+=20=20=20=20=20=20(setq=20ov-list=20= (cl-remove-if-not=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(lambda=20(o)=20(eq=20(overlay-get=20o=20'invisible)=20= 'outline))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(overlays-in=20start=20end)))=0A+=20=20=20=20=20=20(cond=20((eq=20= ov-list=20nil)=20'show-all)=0A+=20=20=20=20=20=20=20=20=20=20=20=20;;=20= (eq=20(length=20ov-list)=201)=20wouldn=E2=80=99t=20work:=20what=20if=20= there=20is=0A+=20=20=20=20=20=20=20=20=20=20=20=20;;=20one=20folded=20= subheading?=0A+=20=20=20=20=20=20=20=20=20=20=20=20((and=20(eq=20= (overlay-end=20(car=20ov-list))=20end)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(eq=20(overlay-start=20(car=20ov-list))=20= heading-end))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20'hide-all)=0A+=20= =20=20=20=20=20=20=20=20=20=20=20(t=20'headings-only)))))=0A+=0A+(defun=20= outline-has-subheading-p=20()=0A+=20=20"Return=20t=20if=20this=20heading=20= has=20subheadings,=20nil=20otherwise."=0A+=20=20(save-excursion=0A+=20=20= =20=20(outline-back-to-heading)=0A+=20=20=20=20(<=20(save-excursion=20= (outline-next-heading)=20(point))=0A+=20=20=20=20=20=20=20= (save-excursion=20(outline-end-of-subtree)=20(point)))))=0A+=0A+(defun=20= outline-cycle=20()=0A+=20=20"Cycle=20between=20`hide=20all',=20`headings=20= only'=20and=20`show=20all'.=0A+=0A+`Hide=20all'=20means=20hide=20all=20= subheadings=20and=20their=20bodies.=0A+`Headings=20only'=20means=20show=20= sub=20headings=20but=20not=20their=20bodies.=0A+`Show=20all'=20means=20= show=20all=20subheadings=20and=20their=20bodies."=0A+=20=20(interactive)=0A= +=20=20(pcase=20(outline--cycle-state)=0A+=20=20=20=20('hide-all=20(if=20= (outline-has-subheading-p)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(progn=20(outline-show-children)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(message=20"Only=20= headings"))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(message=20"Show=20all")))=0A+=20=20=20=20('headings-only=20= (outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(message=20"Show=20all"))=0A+=20=20=20=20('show-all=20= (outline-hide-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (message=20"Hide=20all"))))=0A+=0A+(defvar-local=20= outline--cycle-buffer-state=20'show-all=0A+=20=20"Internal=20variable=20= used=20for=20tracking=20buffer=20cycle=20state.")=0A+=0A+(defun=20= outline-cycle-buffer=20()=0A+=20=20"Cycle=20the=20whole=20buffer=20like=20= in=20`outline-cycle'."=0A+=20=20(interactive)=0A+=20=20(pcase=20= outline--cycle-buffer-state=0A+=20=20=20=20('show-all=20(save-excursion=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(let=20((start-point=20= (point)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (while=20(not=20(eq=20(point)=20start-point))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(outline-up-heading=201))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (outline-hide-sublevels=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(progn=20(outline-back-to-heading)=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(funcall=20= 'outline-level)))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (setq=20outline--cycle-buffer-state=20'top-level)=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(message=20"Top=20level=20headings"))=0A+=20=20=20= =20('top-level=20(outline-show-all)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(outline-hide-region-body=20(point-min)=20(point-max))=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= outline--cycle-buffer-state=20'all-heading)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(message=20"All=20headings"))=0A+=20=20=20=20= ('all-heading=20(outline-show-all)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(setq=20outline--cycle-buffer-state=20'show-all)=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(message=20"Show=20= all"))))=0A+=0A=20(provide=20'outline)=0A=20(provide=20'noutline)=0A=20=0A= --=20=0A2.26.1=0A=0A= --Apple-Mail=_27772D71-6B93-4500-B432-5A6FDB60B7C8 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_27772D71-6B93-4500-B432-5A6FDB60B7C8-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 12 23:16:25 2020 Received: (at 41198) by debbugs.gnu.org; 13 Oct 2020 03:16:25 +0000 Received: from localhost ([127.0.0.1]:44713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSAnY-0003x3-QT for submit@debbugs.gnu.org; Mon, 12 Oct 2020 23:16:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSAnX-0003rI-21; Mon, 12 Oct 2020 23:16:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AKmYWxbuvGPLdJ7oLCjQ7LT+SrGhIBaIgfChnUFHWxk=; b=WuViK8qQrr+VjA27dLcyl4F6Dl G54sxg1TBsl46G2YM4WyAo4gF4zJ/kzZR8sEHvIRACfOQGRN2Lkjmd9LAjbr39CrUpKg7Lumz1Y/+ gsxuwiLvFKx2JBi5hD9zypXhFzo37WyTSRV3RUle+6orhBkFGiQ2Hih3icFopJdR2G8s=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSAnN-0001TQ-O1; Tue, 13 Oct 2020 05:16:16 +0200 From: Lars Ingebrigtsen To: Yuan Fu Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> X-Now-Playing: Brokeback's _Looks At The Bird_: =?utf-8?Q?=22Lup=C3=A9=22?= Date: Tue, 13 Oct 2020 05:16:12 +0200 In-Reply-To: <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> (Yuan Fu's message of "Tue, 19 May 2020 21:37:26 -0400") Message-ID: <878sca7r43.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Yuan Fu writes: > Ah sorry, I switched to a new way to generate patches and didn’t > notice that the commit message is gone. It is included this time. Skimming this thread, it seemed that everybody was in agreement that this was a good change, but the patch was never applied, so I did that now. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: 41130@debbugs.gnu.org, Stefan Kangas , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > Ah sorry, I switched to a new way to generate patches and didn=E2=80=99t > notice that the commit message is gone. It is included this time. Skimming this thread, it seemed that everybody was in agreement that this was a good change, but the patch was never applied, so I did that now. Some discussion then followed about what key(s) would be the best ones here, and I didn't see any consensus, so I left the patch as is. Feel free to change the keys as you want, but I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 12 23:16:29 2020 Received: (at control) by debbugs.gnu.org; 13 Oct 2020 03:16:30 +0000 Received: from localhost ([127.0.0.1]:44718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSAnd-00041A-Ht for submit@debbugs.gnu.org; Mon, 12 Oct 2020 23:16:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSAnc-0003va-Ge for control@debbugs.gnu.org; Mon, 12 Oct 2020 23:16:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n1RCLlrWbcYNuNxZJL5p9BsG96ggivdZzs3naZHxbTc=; b=p5HpiqiFeSAMAWQZyPl+xMGcNV 9DmICSfXP302OV54pY5Lra+zUC2fn8G/yBok3nsnyVQr87voLD/q2rydIDV9OwA/q+X8DNcEMNJVZ O5RHWjhONwuf2snd9yT+WZtONQ0p+y+tbIdj+eV8w34GkZr/NhAGj/RF0RW9D7anDBxU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSAnU-0001TZ-QE for control@debbugs.gnu.org; Tue, 13 Oct 2020 05:16:23 +0200 Date: Tue, 13 Oct 2020 05:16:19 +0200 Message-Id: <877dru7r3w.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41130 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 41130 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 41130 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 09:16:13 2020 Received: (at 41198) by debbugs.gnu.org; 13 Oct 2020 13:16:13 +0000 Received: from localhost ([127.0.0.1]:45620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSKA1-0003Lc-G1 for submit@debbugs.gnu.org; Tue, 13 Oct 2020 09:16:13 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:38819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSK9w-0003L3-0X; Tue, 13 Oct 2020 09:16:11 -0400 Received: by mail-qk1-f194.google.com with SMTP id f21so7901970qko.5; Tue, 13 Oct 2020 06:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oyMYqyHYuvHNvFFycXFmuJl3kTI9Txf28zoQ23U+QXo=; b=fBEpbiBv+I06d+634DG197W+nnEpsLlrHEU2uyYeXm8WGNN3xbQ+eQDyXxPdyjj/Oo KHGF4C76FOP4sbKXMhsXTu0B+2hjM0GglJTscGWi4sXp0q4fjmoz5ODzBRnyoGzIvwlm yyqEfPEJk2FXGL2C6+2ItUa372kNqq3/wNVw3vlFSqJM4tmcUp7d/rn3xEskJy84kAJU kEVmqMiykUi8j+eShiB+wKgCuPBZH6L8frikVwz17aQ5jOtwgBcjbZLd725zX99RTwFK Gj2jSX/S7jzT0eIQKOepphif/7wLSllP0ARhfAwXjzQ1w++Ibier21WeUz7izhPOeKBt nGfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oyMYqyHYuvHNvFFycXFmuJl3kTI9Txf28zoQ23U+QXo=; b=fAhGkFKppO//frtO9G6CJO7i9jxdSdl7C9H5aVCgeXxOhARObwasE5S48cQRal4ZyQ eZHk8ej+kjUT5skRm0dhaa0lOIalF4OR8BImraEwGEgQy9wKQf2uXJqz8QObm3xvXQAj DHWDDsDfKDhjsOoayq/zbHEwj/8q6AfrD9NpzxZINVkTZeZ5kEkaH7LVMvhKDSTKL8Uz AyNkiotIlgfhLd6CCGcLi1vTo6amJ0wsuENuHq/IrYLnLu5zWijpwgA7M9+D2Rb/q7ZC iqwOaLc8H1hmpmIAyxFwbDCmvwQWobN10eFtQ3aiTxNDgAxhXd+9b0SZp2U77pkm1LnX A1MA== X-Gm-Message-State: AOAM533qInqFwg1yhhU7rYnWjEiazm6YcwvenOVoe2cKpUJqNxH9EK8a MHm0Ttj2kpiYFan2jy1v/zPRCljVNZNr2gnx X-Google-Smtp-Source: ABdhPJy97k9lR1NSa83Bo+tFmfOp5xm9BmIemgEJM+1dN6RQnQaTJj4LMnLYojhGQYC96a7jwqplFg== X-Received: by 2002:ae9:f444:: with SMTP id z4mr14285319qkl.338.1602594962386; Tue, 13 Oct 2020 06:16:02 -0700 (PDT) Received: from ?IPv6:2601:98a:4200:9210:5973:2924:6be9:17b6? ([2601:98a:4200:9210:5973:2924:6be9:17b6]) by smtp.gmail.com with ESMTPSA id g2sm14609401qts.8.2020.10.13.06.16.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2020 06:16:01 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline From: Yuan Fu In-Reply-To: <878sca7r43.fsf@gnus.org> Date: Tue, 13 Oct 2020 09:16:00 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <21B2418C-26FB-4CDD-8396-BC30D1F8193A@gmail.com> References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: 41130@debbugs.gnu.org, Stefan Kangas , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 12, 2020, at 11:16 PM, Lars Ingebrigtsen = wrote: >=20 > Yuan Fu writes: >=20 >> Ah sorry, I switched to a new way to generate patches and didn=E2=80=99= t >> notice that the commit message is gone. It is included this time. >=20 > Skimming this thread, it seemed that everybody was in agreement that > this was a good change, but the patch was never applied, so I did that > now. >=20 > Some discussion then followed about what key(s) would be the best ones > here, and I didn't see any consensus, so I left the patch as is. Feel > free to change the keys as you want, but I'm closing this bug report. >=20 > --=20 > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no Thanks Lars :-)= From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 15:50:33 2020 Received: (at 41198) by debbugs.gnu.org; 14 Oct 2020 19:50:33 +0000 Received: from localhost ([127.0.0.1]:53053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSmnA-0004W3-TO for submit@debbugs.gnu.org; Wed, 14 Oct 2020 15:50:33 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:47379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSmn9-0004Vl-Ib; Wed, 14 Oct 2020 15:50:32 -0400 X-Originating-IP: 91.129.102.160 Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 4938F60005; Wed, 14 Oct 2020 19:50:22 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> Date: Wed, 14 Oct 2020 22:24:10 +0300 In-Reply-To: <878sca7r43.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Oct 2020 05:16:12 +0200") Message-ID: <87mu0ozntx.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Yuan Fu , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Skimming this thread, it seemed that everybody was in agreement that > this was a good change, but the patch was never applied, so I did that > now. Now finally org keys are available in etc/NEWS, nice! But typing S-TAB at the beginning of etc/NEWS signals the error: Debugger entered--Lisp error: (error "Before first heading") signal(error ("Before first heading")) This is not how org-mode works - S-TAB doesn't fail before first heading in org-mode. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 03:02:39 2020 Received: (at 41198) by debbugs.gnu.org; 15 Oct 2020 07:02:39 +0000 Received: from localhost ([127.0.0.1]:53964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSxHb-0004HY-Dh for submit@debbugs.gnu.org; Thu, 15 Oct 2020 03:02:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSxHZ-0004HI-Ir; Thu, 15 Oct 2020 03:02:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8pTd0pNLJRj13OdTzPFBb4kRw8p5i4QD6J8GEk0NBAc=; b=ZNP76IpvU6A9jJGpCKqmlpmDDi NQIpuATBp5egfu/gAfAiMJbjHyWphN17lw3NW5Z9hq6gMLrh+nAwwY3dtzYUwISRVgLgd/O0OECeq WJaH45QM2wNOSCGodaEYu7LU/v8D3imKv5Hq/FC1Ndw8VTxHAn5w2yM2vfUdXCrHLAQY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSxHP-0000QV-FH; Thu, 15 Oct 2020 09:02:30 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEU3MzBXU1C2tbP/ //95ocZ/AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QKDwYsGH0CdIkAAAFgSURBVCjPLdA9buQwDAXg J0DcWgbILXKEPYUEWE0qCSCbnCCZU6WYGWR8yjzZW8jQJ4o/MqSUil6/XsftgVRU0OrbcdxeSE7U Yc/j8YC5SKsjy/G8Q5TYS/57PF/oQbhCj9sdfYoNN4x/x31FrDBS/xyfZyQYQfr4giSzWRfePyGi WlCI/oOcVSsqMb6h2X0/USu2MkZOINJA3+bkJoMTIs/WgKzIialdvGaWU95NYhwMA4WYZtsoTK6Z zdQC4wSwq3odwkYM+Bg91f8o3KdqxJpiziLg1KgJqU02t8ZaCa3XLDmCEHTCLhjEKqsvFEIu7BeG OBHszGvbhf1EhHMfwv/VI/ra87vQL4xQokXMk4oUrfHULTZH3VrriccyCWszEtMSSzsniEYMTu0Z vG9rBEXMqemEC0JXvq3qBBslzySfPtvqwdWtY8xtjeJcgWJs4n4Ozmo7c6de8M7TaetRv+wpcBEf kEYOAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTEwLTE1VDA2OjQ0OjI0KzAwOjAwO7lkqgAAACV0 RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMC0xNVQwNjo0NDoyNCswMDowMErk3BYAAAAASUVORK5CYII= X-Now-Playing: Hookworms's _Hookworms_: "I Have Some Business Out West" Date: Thu, 15 Oct 2020 09:02:25 +0200 In-Reply-To: <87mu0ozntx.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Oct 2020 22:24:10 +0300") Message-ID: <87d01kynsu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >> Skimming this thread, it seemed that everybody was in agreement that >> this was a good change, but the patch was never applied, so I did that >> now. > > Now finally org keys are available in etc/ [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Yuan Fu , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> Skimming this thread, it seemed that everybody was in agreement that >> this was a good change, but the patch was never applied, so I did that >> now. > > Now finally org keys are available in etc/NEWS, nice! > But typing S-TAB at the beginning of etc/NEWS signals the error: > > Debugger entered--Lisp error: (error "Before first heading") > signal(error ("Before first heading")) > > This is not how org-mode works - S-TAB doesn't fail before first heading > in org-mode. How does it work in org-mode? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 03:52:18 2020 Received: (at 41198) by debbugs.gnu.org; 15 Oct 2020 07:52:19 +0000 Received: from localhost ([127.0.0.1]:54095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy3e-0007gT-MQ for submit@debbugs.gnu.org; Thu, 15 Oct 2020 03:52:18 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:50223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy3c-0007gA-UF; Thu, 15 Oct 2020 03:52:17 -0400 Received: by mail-wm1-f44.google.com with SMTP id 13so2130488wmf.0; Thu, 15 Oct 2020 00:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=4SY6TNbIoX2xfhyLIaRgUEibwXbbzjAShIMXd0qxQ98=; b=el/vwji9dOKOCUMiF7QYpNbwYPk06EOyBIyJM4AL+RgCpAu5mD4XIZu52FYKESWaEa hQkQeIJBMgfLk4ciCtWuCrTfX75jq7hnr8KAw40uJkuQbuymSrg37mFs+Z+cuhRiin1C 6A5vvKMcI2Og7FlNXnoTHWJS//Q3HKpqurnvXig2cAtFG0QxkyANB9h/3rliJXTVz1VT MpSr8f4Z6Av8fj8MaBov73Oqjqqvp5YCbY1s2/QQYgQJRdFdcw2l6YDWfoCO+XDmB1km 7BNmRi/KkepZTbC9BEE10xaApLheASJJLwUGQJN1WDGEcDIKjVg6lSkah6VRR3MdTbG3 v+UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=4SY6TNbIoX2xfhyLIaRgUEibwXbbzjAShIMXd0qxQ98=; b=O8PWJE6u3hTeHQCNAe6bkFMb9N+vSmGALAbbsXpeLeNHQcj9p4At8S2hcIcd3bH6xC J09sKEf1dKYQFK4YAtG1P8mxGh1/QLiBF2JizvcoIu2MRoYWHQy4HJC0ueIYdaagRm7M 5RfH00ORPgQLeIbepwZpxZKpihdDiWKyibYQ2OhvbKLnXi53+XTs8ncvEaTCi9OHxsYr d+oO/Gbbbx/AieD9brtRbIepMKGkJVoBOYsEG06xH7W6+gTNcz1BkwCY1li1BlMQue3g fwn/VMvj/qzSfFlUH59GBVbvt2Uuo9UVVMrD2/mj1Tob/Ql+83w1gVQf9aaTelmw1Ewv SPNg== X-Gm-Message-State: AOAM5303xxpdKufYBaTv9SZWwnRb92YAzt54S5m13vMemRcgzIu2835K 2f5K9udOq5i/B4g1gRjvD8hD1oDvSjY= X-Google-Smtp-Source: ABdhPJwsXpAaF7wT+ZXAy//5QuhMiqlnSQ4VnGnaqirAwP26Dz41YAqoejDdO+RBrsQo7y/KLQQs1w== X-Received: by 2002:a1c:dd0b:: with SMTP id u11mr2577171wmg.186.1602748330372; Thu, 15 Oct 2020 00:52:10 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:c79:b00d:5409:83f9]) by smtp.gmail.com with ESMTPSA id a82sm3228893wmc.44.2020.10.15.00.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 00:52:09 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87d01kynsu.fsf@gnus.org> Date: Thu, 15 Oct 2020 09:52:08 +0200 In-Reply-To: <87d01kynsu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 15 Oct 2020 09:02:25 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Yuan Fu , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 15 Oct 2020 09:02:25 +0200, Lars Ingebrigtsen said: Lars> Juri Linkov writes: >>> Skimming this thread, it seemed that everybody was in agreement that >>> this was a good change, but the patch was never applied, so I did that >>> now. >> >> Now finally org keys are available in etc/NEWS, nice! >> But typing S-TAB at the beginning of etc/NEWS signals the error: >> >> Debugger entered--Lisp error: (error "Before first heading") >> signal(error ("Before first heading")) >> >> This is not how org-mode works - S-TAB doesn't fail before first heading >> in org-mode. Lars> How does it work in org-mode? The same as anywhere else: it cycles the visibility of the headings downbuffer. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 19:33:49 2020 Received: (at 41198) by debbugs.gnu.org; 15 Oct 2020 23:33:49 +0000 Received: from localhost ([127.0.0.1]:56930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTCkn-0002W0-0K for submit@debbugs.gnu.org; Thu, 15 Oct 2020 19:33:49 -0400 Received: from mail-il1-f171.google.com ([209.85.166.171]:41025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTCkk-0002Vi-Ba; Thu, 15 Oct 2020 19:33:47 -0400 Received: by mail-il1-f171.google.com with SMTP id w17so507796ilg.8; Thu, 15 Oct 2020 16:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tMJICo2vs/e7hfABHB3WTBtajSZhlrorPgLCsQJx9PE=; b=jn3Oa9CFqphNWEDJm6URkUpUkywxRUi0GpZsAdwxDK4tbn+XOruz0KSsEMwxhFN049 LrcnWVFFZiDPAFBnBWU8EV4YUMvt8zCWF9+4pC7zX8E+7dcjzFqGMyQ/6a5x4hlEgkkg 1d1y7v93pDQz+8RbH5+B5iJuqUGN0QSRA+HEvnfSC/loHntLO7TZLmsfamnDcUWSJUla dWCvwy9zQ/vz+zslXQiQr+ADFmopVrcyjjmgA8IR3yJ3uN7YmQscjTaxud73wBTjUiNo a1RqNy1af681r4S5LIFdzMZN9bqRezPSN12IR9sbyE74YZwp/pnCMUrhtJt0Hlx9Kz94 hlWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tMJICo2vs/e7hfABHB3WTBtajSZhlrorPgLCsQJx9PE=; b=NnouDm/JiWRiSPScECrZtOXaBhq4d+j/tpFUKahIMsVcvG76004OVf7B5yaJJuy9JG fotlxnrtm6P4TQp3WeYWlgH7ZscP9Kfq+rkIPuwwkWwV0S/yAWajAdJ3UlesA1kRC0tM dlUIhVo1IzjvNBtdtTF7+OTQVWHQxSKucWMqjErSYxrbT8iXXENNPLBc5bfhEGgGujke YyyswfbDm+X/8TVomc6XQrjGDwMlzOtSn/yJL+J1N7U+inZSAIJRalSrLkXXs+rxKAjx U+ziLpwCoutRaPct1nUaI69gA8NX6RiArMl0uUbFMfAbjO3Rzp26qfVsvLiDK+IC0VPB EK9Q== X-Gm-Message-State: AOAM5314JFAfyYiGQIMCF2ohCOTeUdDetPpuVNRJo9qVGc7HI/3PpQpY 2R8cbURT2wOPX9wfwdLw4QExBtzh3LQ7i2aq X-Google-Smtp-Source: ABdhPJzYQzdLdmNqO60zO+5eSjbLS9CX/HGLjyeg66fGqoca4jhwk29NPrrOdrCmOr2vWdMAZ8kUPg== X-Received: by 2002:a05:6e02:e4f:: with SMTP id l15mr707834ilk.142.1602804820699; Thu, 15 Oct 2020 16:33:40 -0700 (PDT) Received: from ?IPv6:2601:98a:4200:9210:8954:af62:96c7:c6? ([2601:98a:4200:9210:8954:af62:96c7:c6]) by smtp.gmail.com with ESMTPSA id r15sm468540ilj.43.2020.10.15.16.33.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2020 16:33:40 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline From: Yuan Fu In-Reply-To: <87mu0ozntx.fsf@mail.linkov.net> Date: Thu, 15 Oct 2020 19:33:39 -0400 Content-Transfer-Encoding: 7bit Message-Id: References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> To: Juri Linkov X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Lars Ingebrigtsen , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 14, 2020, at 3:24 PM, Juri Linkov wrote: > >> Skimming this thread, it seemed that everybody was in agreement that >> this was a good change, but the patch was never applied, so I did that >> now. > > Now finally org keys are available in etc/NEWS, nice! > But typing S-TAB at the beginning of etc/NEWS signals the error: > > Debugger entered--Lisp error: (error "Before first heading") > signal(error ("Before first heading")) > > This is not how org-mode works - S-TAB doesn't fail before first heading > in org-mode. Do you suggest to change it to a user-error? Or just be silent? Yuan From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 23:12:11 2020 Received: (at 41198) by debbugs.gnu.org; 16 Oct 2020 03:12:11 +0000 Received: from localhost ([127.0.0.1]:57140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTGA7-0007iM-0Q for submit@debbugs.gnu.org; Thu, 15 Oct 2020 23:12:11 -0400 Received: from mail-il1-f169.google.com ([209.85.166.169]:40782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTGA5-0007i5-Gf; Thu, 15 Oct 2020 23:12:09 -0400 Received: by mail-il1-f169.google.com with SMTP id y16so1067409ila.7; Thu, 15 Oct 2020 20:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=BXSWIjhGvkand8H1R0Ox+YnU1FPUC38M64hcQ/VDATw=; b=gDb/avBK+R/wmLtXlCEykzjTePtX3pIakMUOnMQO5ztkFpE5t1Lj4Enj8Sc5kfb/G0 Ia5UP/yvzdyYHUk2/V/eqV+1fP4fkRQgKC2Q7l1cFiHFdiqbTo3JKLq+yla24FA62h1k tzGZs/kr5KBz9RCVrjambA6nmaaTSi9TE5OuQ2ozvQN7TAvIbKiRiue23KcgLV6sNYCX gVR1mE6weL8JuVBseyMlV6X/M5Xfi8RYe3teFLYxKz8B5qiu2jLCOuMzU891STIK9Xho iU5JjkYYx+salgknfdB+U1ZHB9BO21FZIxk0LsZqwydUVkEtI17013vpSAIa3jXOsNN8 DTwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=BXSWIjhGvkand8H1R0Ox+YnU1FPUC38M64hcQ/VDATw=; b=r6OT5uuP30gY9XTAOGWQy+ZFUJ5ApXMsoOJbR/yBZKhClKb8SIzTh3w81YFreDscOJ IbRVyI5xVmpBQ7BOslTn8VkTXYClgEJQukFB7y7KqMdeUaPiV2lJs1YKPFT17cGQOQbB +8epFC9vhmGtl0qN95pINgl8fVWZ+dhNKxM/ioHZXp6ed3HwIIVmr3pjTaLwxJvj/z7X mQGjchQVeHZ/CJBWmtyaFoBvqAU+D5KQYALSpm+SkB2r0Q2yzarbkQ7eDEt9ElJxWhOA Rxa8wGgctT80LlN0h4jl6whxTW8cNuzitaJNT5OuVYqDDql1pQ9mNza5djCSd7crAfw2 EBdw== X-Gm-Message-State: AOAM533DTvDRlkwtoZZhavgwyktiQ7nnU9jKQeis0SjXnr6RKDy7fnM1 RkI3B9kyMq2rM//qp7U17Sw= X-Google-Smtp-Source: ABdhPJyhrPwTvrBEGP8+A6zJwui9zF+A+7xRIrRsRU8WyFXqMkyAcjMCWfSzSE0uIKl87JhbVZW6rg== X-Received: by 2002:a05:6e02:582:: with SMTP id c2mr1209144ils.69.1602817923763; Thu, 15 Oct 2020 20:12:03 -0700 (PDT) Received: from ?IPv6:2601:98a:4200:9210:8954:af62:96c7:c6? ([2601:98a:4200:9210:8954:af62:96c7:c6]) by smtp.gmail.com with ESMTPSA id t26sm973580ioi.11.2020.10.15.20.12.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2020 20:12:02 -0700 (PDT) From: Yuan Fu Message-Id: <94C08AB6-E780-45E1-918A-B47FBFA72782@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_D79B5D4E-194F-4D8E-B3E5-A927D5A4BB03" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Date: Thu, 15 Oct 2020 23:12:01 -0400 In-Reply-To: To: Juri Linkov References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Lars Ingebrigtsen , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_D79B5D4E-194F-4D8E-B3E5-A927D5A4BB03 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Oct 15, 2020, at 7:33 PM, Yuan Fu wrote: >=20 >=20 >=20 >> On Oct 14, 2020, at 3:24 PM, Juri Linkov wrote: >>=20 >>> Skimming this thread, it seemed that everybody was in agreement that >>> this was a good change, but the patch was never applied, so I did = that >>> now. >>=20 >> Now finally org keys are available in etc/NEWS, nice! >> But typing S-TAB at the beginning of etc/NEWS signals the error: >>=20 >> Debugger entered--Lisp error: (error "Before first heading") >> signal(error ("Before first heading")) >>=20 >> This is not how org-mode works - S-TAB doesn't fail before first = heading >> in org-mode. >=20 > Do you suggest to change it to a user-error? Or just be silent? >=20 This patch should suppresses errors in both commands. Let me use it for = a while and see if it works ok. Yuan --Apple-Mail=_D79B5D4E-194F-4D8E-B3E5-A927D5A4BB03 Content-Disposition: attachment; filename=outline-fix.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="outline-fix.patch" Content-Transfer-Encoding: quoted-printable =46rom=20ef70c39d52a3aa53e95beb64f877da78daffb0f4=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Yuan=20Fu=20=0ADate:=20Thu,=20= 15=20Oct=202020=2022:20:20=20-0400=0ASubject:=20[PATCH]=20Suppress=20= "Before=20first=20headings"=20error=20in=20outline-cycle=0A=0A*=20= lisp/outline.el=20(outline-cycle,=20outline-cycle-buffer):=20Suppress=20= error.=0A---=0A=20lisp/outline.el=20|=2041=20= ++++++++++++++++++++++-------------------=0A=201=20file=20changed,=2022=20= insertions(+),=2019=20deletions(-)=0A=0Adiff=20--git=20a/lisp/outline.el=20= b/lisp/outline.el=0Aindex=20a4ce9afb44..5e22850292=20100644=0A---=20= a/lisp/outline.el=0A+++=20b/lisp/outline.el=0A@@=20-1167,19=20+1167,22=20= @@=20outline-cycle=0A=20`Headings=20only'=20means=20show=20sub=20= headings=20but=20not=20their=20bodies.=0A=20`Show=20all'=20means=20show=20= all=20subheadings=20and=20their=20bodies."=0A=20=20=20(interactive)=0A-=20= =20(pcase=20(outline--cycle-state)=0A-=20=20=20=20('hide-all=0A-=20=20=20= =20=20(if=20(outline-has-subheading-p)=0A-=20=20=20=20=20=20=20=20=20= (progn=20(outline-show-children)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(message=20"Only=20headings"))=0A-=20=20=20=20=20=20=20= (outline-show-subtree)=0A-=20=20=20=20=20=20=20(message=20"Show=20= all")))=0A-=20=20=20=20('headings-only=0A-=20=20=20=20=20= (outline-show-subtree)=0A-=20=20=20=20=20(message=20"Show=20all"))=0A-=20= =20=20=20('show-all=0A-=20=20=20=20=20(outline-hide-subtree)=0A-=20=20=20= =20=20(message=20"Hide=20all"))))=0A+=20=20(condition-case=20nil=0A+=20=20= =20=20=20=20(pcase=20(outline--cycle-state)=0A+=20=20=20=20=20=20=20=20= ('hide-all=0A+=20=20=20=20=20=20=20=20=20(if=20= (outline-has-subheading-p)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= (progn=20(outline-show-children)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(message=20"Only=20headings"))=0A+=20=20=20=20=20=20= =20=20=20=20=20(outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20= (message=20"Show=20all")))=0A+=20=20=20=20=20=20=20=20('headings-only=0A= +=20=20=20=20=20=20=20=20=20(outline-show-subtree)=0A+=20=20=20=20=20=20=20= =20=20(message=20"Show=20all"))=0A+=20=20=20=20=20=20=20=20('show-all=0A= +=20=20=20=20=20=20=20=20=20(outline-hide-subtree)=0A+=20=20=20=20=20=20=20= =20=20(message=20"Hide=20all")))=0A+=20=20=20=20;;=20If=20error:=20= "Before=20first=20heading"=20occurs,=20ignore=20it.=0A+=20=20=20=20= (error=20nil)))=0A=20=0A=20(defvar-local=20outline--cycle-buffer-state=20= 'show-all=0A=20=20=20"Internal=20variable=20used=20for=20tracking=20= buffer=20cycle=20state.")=0A@@=20-1190,12=20+1193,12=20@@=20= outline-cycle-buffer=0A=20=20=20(pcase=20outline--cycle-buffer-state=0A=20= =20=20=20=20('show-all=0A=20=20=20=20=20=20(save-excursion=0A-=20=20=20=20= =20=20=20(let=20((start-point=20(point)))=0A-=20=20=20=20=20=20=20=20=20= (while=20(not=20(eq=20(point)=20start-point))=0A-=20=20=20=20=20=20=20=20= =20=20=20(outline-up-heading=201))=0A-=20=20=20=20=20=20=20=20=20= (outline-hide-sublevels=0A-=20=20=20=20=20=20=20=20=20=20(progn=20= (outline-back-to-heading)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(funcall=20'outline-level)))))=0A+=20=20=20=20=20=20=20= (outline-hide-sublevels=0A+=20=20=20=20=20=20=20=20;;=20If=20error:=20= "Before=20first=20heading"=20occurs,=20ignore=20it.=0A+=20=20=20=20=20=20= =20=20(or=20(ignore-errors=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (outline-back-to-heading)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (outline-level))=0A+=20=20=20=20=20=20=20=20=20=20=20=201)))=0A=20=20=20=20= =20=20(setq=20outline--cycle-buffer-state=20'top-level)=0A=20=20=20=20=20= =20(message=20"Top=20level=20headings"))=0A=20=20=20=20=20('top-level=0A= --=20=0A2.27.0=0A=0A= --Apple-Mail=_D79B5D4E-194F-4D8E-B3E5-A927D5A4BB03-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 00:59:51 2020 Received: (at 41198) by debbugs.gnu.org; 16 Oct 2020 04:59:52 +0000 Received: from localhost ([127.0.0.1]:57220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTHqJ-0003zd-Kk for submit@debbugs.gnu.org; Fri, 16 Oct 2020 00:59:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTHqH-0003zK-SG; Fri, 16 Oct 2020 00:59:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z+diLF8trcB8br5dhRHKHiIsujxOpUzRvhl0q5lhX6I=; b=WTLLqUy7gelCqiL++JOljWNP/k oqS7hS89qqh3WbzelwksBZn8ydSMnfV4xHJ7c798hCgtkXUjqFfQ/ZylOxV7WjPfuW4EQrFoaHL/W 5e60m2MFu8kgjFUGi//yCIAB1irZBb/g+3wKsFzCEsjnsg7Fdze8qO0e51P7V9E+Djts=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTHq7-000758-SW; Fri, 16 Oct 2020 06:59:42 +0200 From: Lars Ingebrigtsen To: Yuan Fu Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXW0sqJgHMmJST/ //8NscnUAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QKEAQ0B3nvcoIAAAF6SURBVCjPRZHBTuMwEIZ/ R3FEc2KlBlGfYSX6FO4KOKeotrQ5bxHkKbrSqmezUnPgFFCK8DwlM25TRoqcb/7MzB8PkKIGlnKe 8VO4WyiBKRznXfpA33lXm72FYs4kX9Ie98QKq8oQxYYsqgVQEQ2eIis1ZjsiCopqKOtdyRDROujK oSX6oP2zRT7Ni6YjCZk51cZWrwm4da6htVRJtAEPkahPhuh+VazX7S4p1PBgFyfy7iie89ELVE1c s9dsk7PJztPqt8VEVO081UWwf6SiuvH0fxGykGDX0IC6tAK+M/QJXKYh5b+frCBPSrFaUmDzh/s7 38x7NcLSGnZiD7BA2fU4hkX5FnCKi74ea9jjW/2tKP6F1Qh5i+sfp7Kn/CrbHZvjBk+/tiPM+8/i /QTD0Axjx/nLYGI1wvbF8KquE5htKCnoR5lpTfeXV2RbcRPMx63nu56JspmTbmSTcj9o48QftoVn FWk2Qsxia457VJSyCZSUUpSd7r8ADi2IHHCSwcQAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAt MTZUMDQ6NTI6MDcrMDA6MDDNcNd0AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTEwLTE2VDA0OjUy OjA3KzAwOjAwvC1vyAAAAABJRU5ErkJggg== X-Now-Playing: Liaisons Dangereuses's _Liaisons Dangereuses_: "Los =?utf-8?Q?ni=C3=B1os?= del parque" Date: Fri, 16 Oct 2020 06:59:37 +0200 In-Reply-To: (Yuan Fu's message of "Thu, 15 Oct 2020 19:33:39 -0400") Message-ID: <87362eu5om.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Yuan Fu writes: > Do you suggest to change it to a user-error? Or just be silent? Robert suggested: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > Do you suggest to change it to a user-error? Or just be silent? Robert suggested: > Lars> How does it work in org-mode? > > The same as anywhere else: it cycles the visibility of the headings > downbuffer. I guess that makes sense? I don't use outlining, though, so I don't really know whether that would be surprising behaviour in outline mode, though. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 04:25:19 2020 Received: (at 41198) by debbugs.gnu.org; 16 Oct 2020 08:25:19 +0000 Received: from localhost ([127.0.0.1]:57571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTL39-0005T5-GG for submit@debbugs.gnu.org; Fri, 16 Oct 2020 04:25:19 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:33007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTL37-0005Sk-Jm; Fri, 16 Oct 2020 04:25:18 -0400 Received: by mail-wr1-f49.google.com with SMTP id b8so1768814wrn.0; Fri, 16 Oct 2020 01:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=W12xjwsycl2WmjGLoFIu+VNTvaPTIaz1hQNS2Ry/xFs=; b=hxD3cNnZ+UsGVhkKSRIvIcIAhfPRsGU7jT5e+d9JVrm0KOAGbdXoZ/w9gLKeJQ7dgH 7iphR9l8gy5LB7gfRzzHaKprYQ+zCKCpPoK6a7Q8MxYxiXtbj3E+e6AEA96N97DcpWm+ W3W1/lLJPdZ6HvGC6YmD4AVCrZuRNIh2/bCQNxWtgsb9E5P9iPMk1C7RhCRjfJBn75dh q5ZlmN2JcvP4Si66n+BrM0s2ZR5fr3Qwheut9CY9mVU3DboKNWQwgO0IADHx51bkSdvn sdNYLCroLoWPT8tJVHbYqzoWWbbnJsDtoWuh9qNoOuiy1M6RLDaChOw/wGS/GCndLCxk NeMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=W12xjwsycl2WmjGLoFIu+VNTvaPTIaz1hQNS2Ry/xFs=; b=DCIfWtG8bgwVCmMNXqQjWekHHwEYdOXEfbXk9qjfCszvlEBFuc0UqK14fCyW0n3Z96 3IoKABFCzEjrsvRIQDMmzYqwBnXCzOPEJJ0QNI0qLFGeS2/S05R9c7RV1lYqyFPK674g Pl2WgYX7IBviF2cCQs4b5w/ccPKknKnN0ozuX6deSriLnbTaJqyiy30HToUvxAZPr+eq YS5kgGsuZb2YR6N6gsM4RFeTj8wGN0RBWUJgrPgclzhActXe865phC4I5YGrzYDXqNp2 9KEkFFuJwvR1vizY6HP9rnDhkv9DnNZsVVaIRvwvh238O/TOmR2tSxi3WfDu4oRUc6al MizQ== X-Gm-Message-State: AOAM533Fk0Vt4lz7+BKEDZSEWEwpMkQOuaSUFWWHepmuVZwz/pl+ii7Q F0uKs7lMQokeDsijOmoVRlY= X-Google-Smtp-Source: ABdhPJzs8yBG7rjT/UzelD2ga6e4GFeJfxSBTI1t3iPykBLV1fOcT9ywOmnJOL9Ihhhj9PIOuFjg7Q== X-Received: by 2002:adf:a31c:: with SMTP id c28mr2687839wrb.351.1602836711683; Fri, 16 Oct 2020 01:25:11 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:9474:cfb2:b9a9:23d4]) by smtp.gmail.com with ESMTPSA id d30sm2536926wrc.19.2020.10.16.01.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 01:25:10 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#41198: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87362eu5om.fsf@gnus.org> Date: Fri, 16 Oct 2020 10:25:09 +0200 In-Reply-To: <87362eu5om.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 16 Oct 2020 06:59:37 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Yuan Fu , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 16 Oct 2020 06:59:37 +0200, Lars Ingebrigtsen said: Lars> Yuan Fu writes: >> Do you suggest to change it to a user-error? Or just be silent? Lars> Robert suggested: Lars> How does it work in org-mode? >>=20 >> The same as anywhere else: it cycles the visibility of the headings >> downbuffer. Lars> I guess that makes sense? I don't use outlining, though, so I do= n't Lars> really know whether that would be surprising behaviour in outline= mode, Lars> though. I don=CA=BCt think I=CA=BCd find it surprising. Of course we could fix this= by just adding "* " to the first line of NEWS :-) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 04:26:09 2020 Received: (at 41198) by debbugs.gnu.org; 16 Oct 2020 08:26:09 +0000 Received: from localhost ([127.0.0.1]:57587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTL3w-0005VP-So for submit@debbugs.gnu.org; Fri, 16 Oct 2020 04:26:09 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:46819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTL3u-0005UH-Go; Fri, 16 Oct 2020 04:26:07 -0400 X-Originating-IP: 91.129.102.160 Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A5C6820014; Fri, 16 Oct 2020 08:25:57 +0000 (UTC) From: Juri Linkov To: Yuan Fu Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> Date: Fri, 16 Oct 2020 11:20:41 +0300 In-Reply-To: (Yuan Fu's message of "Thu, 15 Oct 2020 19:33:39 -0400") Message-ID: <87v9fatwdi.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Lars Ingebrigtsen , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Now finally org keys are available in etc/NEWS, nice! >> But typing S-TAB at the beginning of etc/NEWS signals the error: >> >> Debugger entered--Lisp error: (error "Before first heading") >> signal(error ("Before first heading")) >> >> This is not how org-mode works - S-TAB doesn't fail before first heading >> in org-mode. > > Do you suggest to change it to a user-error? Or just be silent? To imitate org-mode, maybe outline-mode could temporarily (i.e. by using save-excursion) navigate to the first heading before running the rest of outline-cycle-buffer when it's before first heading? Thank you for this nice feature! From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 15:27:44 2020 Received: (at 41198) by debbugs.gnu.org; 16 Oct 2020 19:27:44 +0000 Received: from localhost ([127.0.0.1]:60919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTVOB-0004RB-WD for submit@debbugs.gnu.org; Fri, 16 Oct 2020 15:27:44 -0400 Received: from mail-io1-f52.google.com ([209.85.166.52]:35935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTVO9-0004Qs-2U; Fri, 16 Oct 2020 15:27:41 -0400 Received: by mail-io1-f52.google.com with SMTP id u19so5322144ion.3; Fri, 16 Oct 2020 12:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=sA+Ao8mphQxR1XBB4OSQEeuLe13BJroFZ6mpGxyhae4=; b=tbRImZzEn9EuY8GZS5elKWXr6rkuH6r07wJmKYgzHTvEzCDwZrOrNDW1XuwpzkN+1+ BxC/i2lkg5GnprOb7RQr8FnrvuUTyRfZMmp6GuQkp0FIJ07Q0w6hTf9R2GqAV8e7qxki plM0CsB4ArioM+c6TnmqT3VJL/2agXq/0Ll+7YPJqB9Mbk1efpbr05nk4cSXqy3SA4Bp mnFKmj50nPwNbTaQjev0XEhsRDu2Ua0H8PqreCcSBVVLFDzP8CA93JoHF+H91Mh2qYT0 huKgu4o3C6WYmGkV4E5iuvqiSN9BWHACaZlXCuhQzWCfToT9XsBYqxbJqCPM19m6M8aR +0Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=sA+Ao8mphQxR1XBB4OSQEeuLe13BJroFZ6mpGxyhae4=; b=bdf5O+QyAsz1voI+qzyU3uJUZwRw0nz4FEZO47p2qYpUk//4B19mX2EY1ZLbx/xYbO ymBLueoXh3lfnyZeyiW+Hu07mslOz1u/fvv+5mDA2yfeeHutrVr0VVm9+jyDr/dnXCDV kc7/cAw6QHLhW34Ea8fIST9XPyT0qFa0/Bw/6ksg/lrbIuD3OZmDnnf9Th01Q325Vv0e pNKNEEerkwxMmk3G3bxnng7GZ7xBDPvafH3JbOzW92BqPbrjG8LQX6FIrvevv+z3UIqd rNrtvla+pEheNW4pPF8xM/lAxNz+UiOq6qBVwA47ozaXS4y56WNhDcpdt2fjZVGgYpx4 fDyA== X-Gm-Message-State: AOAM530eK7MJRbAnlFyvQOUg2KBN2XGfkoHC6TH0jnXPGnNpUo4nXsR4 VjQDZXjNfY8xnRqHcAFfs7gGGPaF9WfipU8x X-Google-Smtp-Source: ABdhPJxX6pg404HK6AtH9mbIVUqsMAVN3436a/1cOiY6WslN0I0Jy6dsRmVBfykap5CHIcu9GslqMA== X-Received: by 2002:a5e:9b11:: with SMTP id j17mr3642317iok.176.1602876455371; Fri, 16 Oct 2020 12:27:35 -0700 (PDT) Received: from ?IPv6:2601:98a:4200:9210:8954:af62:96c7:c6? ([2601:98a:4200:9210:8954:af62:96c7:c6]) by smtp.gmail.com with ESMTPSA id i82sm3099301ill.84.2020.10.16.12.27.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Oct 2020 12:27:34 -0700 (PDT) From: Yuan Fu Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_D7EAA66F-B37A-47D0-B7F1-26BF874AD209" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Date: Fri, 16 Oct 2020 15:27:33 -0400 In-Reply-To: <87v9fatwdi.fsf@mail.linkov.net> To: Juri Linkov References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Lars Ingebrigtsen , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_D7EAA66F-B37A-47D0-B7F1-26BF874AD209 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Oct 16, 2020, at 4:20 AM, Juri Linkov wrote: >=20 >>> Now finally org keys are available in etc/NEWS, nice! >>> But typing S-TAB at the beginning of etc/NEWS signals the error: >>>=20 >>> Debugger entered--Lisp error: (error "Before first heading") >>> signal(error ("Before first heading")) >>>=20 >>> This is not how org-mode works - S-TAB doesn't fail before first = heading >>> in org-mode. >>=20 >> Do you suggest to change it to a user-error? Or just be silent? >=20 > To imitate org-mode, maybe outline-mode could temporarily (i.e. by > using save-excursion) navigate to the first heading before running > the rest of outline-cycle-buffer when it's before first heading? This patch should make outline behaves like org: S-TAB always cycle the = whole buffer, regardless where is the point. TAB cycles a heading, and = does nothing if point is before the first heading. Yuan --Apple-Mail=_D7EAA66F-B37A-47D0-B7F1-26BF874AD209 Content-Disposition: attachment; filename=outline-fix.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="outline-fix.patch" Content-Transfer-Encoding: quoted-printable =46rom=20147b547355380d134f423b44c988ff18074a4ded=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Yuan=20Fu=20=0ADate:=20Thu,=20= 15=20Oct=202020=2022:20:20=20-0400=0ASubject:=20[PATCH]=20Suppress=20= "Before=20first=20headings"=20error=20in=20outline-cycle=0A=0A*=20= lisp/outline.el=20(outline-cycle):=20Suppress=20error.=0A= (outline-cycle-buffer):=20Simply=20pass=201=20to=20= 'outline-hide-sublevels'.=0A---=0A=20lisp/outline.el=20|=2037=20= +++++++++++++++++--------------------=0A=201=20file=20changed,=2017=20= insertions(+),=2020=20deletions(-)=0A=0Adiff=20--git=20a/lisp/outline.el=20= b/lisp/outline.el=0Aindex=20a4ce9afb44..05c884fb95=20100644=0A---=20= a/lisp/outline.el=0A+++=20b/lisp/outline.el=0A@@=20-1167,19=20+1167,22=20= @@=20outline-cycle=0A=20`Headings=20only'=20means=20show=20sub=20= headings=20but=20not=20their=20bodies.=0A=20`Show=20all'=20means=20show=20= all=20subheadings=20and=20their=20bodies."=0A=20=20=20(interactive)=0A-=20= =20(pcase=20(outline--cycle-state)=0A-=20=20=20=20('hide-all=0A-=20=20=20= =20=20(if=20(outline-has-subheading-p)=0A-=20=20=20=20=20=20=20=20=20= (progn=20(outline-show-children)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(message=20"Only=20headings"))=0A-=20=20=20=20=20=20=20= (outline-show-subtree)=0A-=20=20=20=20=20=20=20(message=20"Show=20= all")))=0A-=20=20=20=20('headings-only=0A-=20=20=20=20=20= (outline-show-subtree)=0A-=20=20=20=20=20(message=20"Show=20all"))=0A-=20= =20=20=20('show-all=0A-=20=20=20=20=20(outline-hide-subtree)=0A-=20=20=20= =20=20(message=20"Hide=20all"))))=0A+=20=20(condition-case=20nil=0A+=20=20= =20=20=20=20(pcase=20(outline--cycle-state)=0A+=20=20=20=20=20=20=20=20= ('hide-all=0A+=20=20=20=20=20=20=20=20=20(if=20= (outline-has-subheading-p)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= (progn=20(outline-show-children)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(message=20"Only=20headings"))=0A+=20=20=20=20=20=20= =20=20=20=20=20(outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20= (message=20"Show=20all")))=0A+=20=20=20=20=20=20=20=20('headings-only=0A= +=20=20=20=20=20=20=20=20=20(outline-show-subtree)=0A+=20=20=20=20=20=20=20= =20=20(message=20"Show=20all"))=0A+=20=20=20=20=20=20=20=20('show-all=0A= +=20=20=20=20=20=20=20=20=20(outline-hide-subtree)=0A+=20=20=20=20=20=20=20= =20=20(message=20"Hide=20all")))=0A+=20=20=20=20;;=20If=20error:=20= "Before=20first=20heading"=20occurs,=20ignore=20it.=0A+=20=20=20=20= (error=20nil)))=0A=20=0A=20(defvar-local=20outline--cycle-buffer-state=20= 'show-all=0A=20=20=20"Internal=20variable=20used=20for=20tracking=20= buffer=20cycle=20state.")=0A@@=20-1189,13=20+1192,7=20@@=20= outline-cycle-buffer=0A=20=20=20(interactive)=0A=20=20=20(pcase=20= outline--cycle-buffer-state=0A=20=20=20=20=20('show-all=0A-=20=20=20=20=20= (save-excursion=0A-=20=20=20=20=20=20=20(let=20((start-point=20(point)))=0A= -=20=20=20=20=20=20=20=20=20(while=20(not=20(eq=20(point)=20= start-point))=0A-=20=20=20=20=20=20=20=20=20=20=20(outline-up-heading=20= 1))=0A-=20=20=20=20=20=20=20=20=20(outline-hide-sublevels=0A-=20=20=20=20= =20=20=20=20=20=20(progn=20(outline-back-to-heading)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(funcall=20'outline-level)))))=0A+=20=20= =20=20=20(outline-hide-sublevels=201)=0A=20=20=20=20=20=20(setq=20= outline--cycle-buffer-state=20'top-level)=0A=20=20=20=20=20=20(message=20= "Top=20level=20headings"))=0A=20=20=20=20=20('top-level=0A--=20=0A2.27.0=0A= =0A= --Apple-Mail=_D7EAA66F-B37A-47D0-B7F1-26BF874AD209-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 17 02:37:00 2020 Received: (at 41198) by debbugs.gnu.org; 17 Oct 2020 06:37:00 +0000 Received: from localhost ([127.0.0.1]:33095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTfps-0003t0-8L for submit@debbugs.gnu.org; Sat, 17 Oct 2020 02:37:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTfpq-0003sj-LD; Sat, 17 Oct 2020 02:36:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0J/HyxX8smqgkM3kFAKR84eh1QELEG2YOjTvM6YVcUg=; b=JCqhAELu84l2GuAUTIyOxyjngA 5GVe7tFHHZ5x1OPAN6NxBcxf+zD+Egb6HKYNLuf7fOH+0iwuK71oP5DZqJhszuFec54jaNe3LNcqD SVBQhAYhimBcVzhPp5/ef0Lb6kTLtGASkAboq5va0ZxYTLoy/s50372lfqBrTXSn1oGM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTfpg-000051-NT; Sat, 17 Oct 2020 08:36:51 +0200 From: Lars Ingebrigtsen To: Yuan Fu Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> X-Now-Playing: Various's _1-8 Split Series_: "Foehn - Shrouded" Date: Sat, 17 Oct 2020 08:36:47 +0200 In-Reply-To: (Yuan Fu's message of "Fri, 16 Oct 2020 15:27:33 -0400") Message-ID: <87sgadz7cw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Yuan Fu writes: > This patch should make outline behaves like org: S-TAB always cycle > the whole buffer, regardless where is the point. TAB cycles a heading, > and does nothing if point is before the first heading. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > This patch should make outline behaves like org: S-TAB always cycle > the whole buffer, regardless where is the point. TAB cycles a heading, > and does nothing if point is before the first heading. I think the behaviour makes sense, but the implementation isn't ideal: [...] > + (condition-case nil > + (pcase (outline--cycle-state) > + ('hide-all > + (if (outline-has-subheading-p) > + (progn (outline-show-children) > + (message "Only headings")) > + (outline-show-subtree) > + (message "Show all"))) > + ('headings-only > + (outline-show-subtree) > + (message "Show all")) > + ('show-all > + (outline-hide-subtree) > + (message "Hide all"))) > + ;; If error: "Before first heading" occurs, ignore it. > + (error nil))) This is basically an `ignore-errors' around a whole bunch of code, used as a program flow mechanism, and that's always awkward, because it hides real errors in the code. Altering the functions to not error out in these situations would be better. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 17 16:51:38 2020 Received: (at 41198) by debbugs.gnu.org; 17 Oct 2020 20:51:38 +0000 Received: from localhost ([127.0.0.1]:35648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTtAw-0006RX-K1 for submit@debbugs.gnu.org; Sat, 17 Oct 2020 16:51:38 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTtAt-0006RD-Ub; Sat, 17 Oct 2020 16:51:36 -0400 X-Originating-IP: 91.129.102.160 Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3BBD920003; Sat, 17 Oct 2020 20:51:26 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> <87sgadz7cw.fsf@gnus.org> Date: Sat, 17 Oct 2020 23:30:06 +0300 In-Reply-To: <87sgadz7cw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 17 Oct 2020 08:36:47 +0200") Message-ID: <871rhwh91d.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Yuan Fu , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> + (condition-case nil >> + (pcase (outline--cycle-state) >> + ('hide-all >> + (if (outline-has-subheading-p) >> + (progn (outline-show-children) >> + (message "Only headings")) >> + (outline-show-subtree) >> + (message "Show all"))) >> + ('headings-only >> + (outline-show-subtree) >> + (message "Show all")) >> + ('show-all >> + (outline-hide-subtree) >> + (message "Hide all"))) >> + ;; If error: "Before first heading" occurs, ignore it. >> + (error nil))) > > This is basically an `ignore-errors' around a whole bunch of code, used > as a program flow mechanism, and that's always awkward, because it hides > real errors in the code. > > Altering the functions to not error out in these situations would be > better. Like 'outline-back-to-heading' has an optional argument 'invisible-ok', maybe a new argument named 'error-ok' or 'outside-ok' could be added to not error out when point is outside of the outline tree. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 17 20:28:36 2020 Received: (at 41198) by debbugs.gnu.org; 18 Oct 2020 00:28:36 +0000 Received: from localhost ([127.0.0.1]:35801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTwYt-0005Fc-SH for submit@debbugs.gnu.org; Sat, 17 Oct 2020 20:28:36 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:45655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTwYr-0005FJ-IH; Sat, 17 Oct 2020 20:28:33 -0400 Received: by mail-io1-f45.google.com with SMTP id n6so8638813ioc.12; Sat, 17 Oct 2020 17:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PQj8PTY7A074Gu4+wE2UYND0Fjeuvf261Y+LENgyzQs=; b=jMSWxUjwlvIU771mBDPO6qxDiSuGJi2RZSwHqZNW6oWCObrR0Ucw2nQnDk1rzU41Tr X4HX9Nuj/KjgfkehQmi8qmD1zmB/dlJnKx9t9gMHT//rS1DoGh8dQOshSpmmMTOgtF2V /+Dy34rKWGAniZX5FfQie9uD2HIKw6rdaPATg5sNKL6SnUSZ+8UaYcuGEvpkB9eAYZwQ 1P1BKvFimxUeSxdcqObESZEPdlOCUPFuuSs4KdW/UaK626rT1DehIU0A50+XeYPgjhhW MSge9IT+au8kf2rMHpx+Fg+6zRpoY9H5tPFGKR7X878NmkSyQApDmI2ym37WzQIiMUPY LBEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PQj8PTY7A074Gu4+wE2UYND0Fjeuvf261Y+LENgyzQs=; b=ZnJjQIxzTS0a2522Gt8E7oQ7aGH4WYxDmBThY2uXEieM2pL7t8bR35H3BDFVDi/eht U8NKH11OzG/4GfxzJmhZl34QOQ7uPIgnf7W2a/EF+6MY0AjqJ4xlSTC7bsqr1I9A5O2C 7hDxVs3/f6gCs83peO2LBqV+nQrghd78IXg8x19CY06i1ODkply3vODH8soXnJ99PBHD G4hivTqElLXZLXCBd2Zx6kIbRGketgmC96AMWFL536iAJagQBNxNzXSp1GiJLMGJ5pXJ fLM/uaQXU+5s2GnHi33js3zyH+tjpHtAaUfauikinazuBnVuUDxjylsHzPJPot3vpZwo 1nHA== X-Gm-Message-State: AOAM533e2ixnK8LKlsTjl/onNfBYvyHrostmRrB62ap7ZxPQAQu8dw/Z m65JqseIf9BqgodkTE2Np1M= X-Google-Smtp-Source: ABdhPJwgrvVJ/26v0OQg1gqx7n4JiTNaafkg8jvthWhp+feMS30u5Hpv1Ioyt2xLuOyKA/uUquEFFg== X-Received: by 2002:a6b:4014:: with SMTP id k20mr6746408ioa.177.1602980907707; Sat, 17 Oct 2020 17:28:27 -0700 (PDT) Received: from ?IPv6:2601:98a:4200:9210:d02a:1c66:2033:eacb? ([2601:98a:4200:9210:d02a:1c66:2033:eacb]) by smtp.gmail.com with ESMTPSA id e13sm6113330iob.43.2020.10.17.17.28.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Oct 2020 17:28:27 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline From: Yuan Fu In-Reply-To: <871rhwh91d.fsf@mail.linkov.net> Date: Sat, 17 Oct 2020 20:28:25 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <3346E33F-BFF2-4DD7-8411-F852CCF3C830@gmail.com> References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> <87sgadz7cw.fsf@gnus.org> <871rhwh91d.fsf@mail.linkov.net> To: Juri Linkov X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , Lars Ingebrigtsen , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 17, 2020, at 4:30 PM, Juri Linkov wrote: >=20 >>> + (condition-case nil >>> + (pcase (outline--cycle-state) >>> + ('hide-all >>> + (if (outline-has-subheading-p) >>> + (progn (outline-show-children) >>> + (message "Only headings")) >>> + (outline-show-subtree) >>> + (message "Show all"))) >>> + ('headings-only >>> + (outline-show-subtree) >>> + (message "Show all")) >>> + ('show-all >>> + (outline-hide-subtree) >>> + (message "Hide all"))) >>> + ;; If error: "Before first heading" occurs, ignore it. >>> + (error nil))) >>=20 >> This is basically an `ignore-errors' around a whole bunch of code, = used >> as a program flow mechanism, and that's always awkward, because it = hides >> real errors in the code. >>=20 >> Altering the functions to not error out in these situations would be >> better. >=20 > Like 'outline-back-to-heading' has an optional argument = 'invisible-ok', > maybe a new argument named 'error-ok' or 'outside-ok' could > be added to not error out when point is outside of the outline tree. I can modify outline code to signal a signal (say = =E2=80=98outline-before-first-heading) rather than an error, and handle = that signal specifically. How=E2=80=99s that? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 18 04:36:34 2020 Received: (at 41198) by debbugs.gnu.org; 18 Oct 2020 08:36:34 +0000 Received: from localhost ([127.0.0.1]:36165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU4B7-0000TR-T7 for submit@debbugs.gnu.org; Sun, 18 Oct 2020 04:36:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kU4B6-0000TA-5c; Sun, 18 Oct 2020 04:36:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RgVvKUBoXG7rCIM/y1HKGJhTv3N0Y2jTjrNnt8+NgYc=; b=d6p/QtGPkyXGFFfw1QW9ggxKD3 MG50hyGS6UDFWNhke9pWh4UfSELqDK/5CSdjG8OHu/kG1gkE7ayqvz3C1+0ygozJCzF8GynAzbY19 LMipK8ppT9tFdUj4FhD8oRic1LORtPh5xlbZaPtNEX2tceqkDS5Vo+qIxIjUF914rqf0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kU4Aw-0006WO-Qc; Sun, 18 Oct 2020 10:36:25 +0200 From: Lars Ingebrigtsen To: Yuan Fu Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> <87sgadz7cw.fsf@gnus.org> <871rhwh91d.fsf@mail.linkov.net> <3346E33F-BFF2-4DD7-8411-F852CCF3C830@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVDNUhYT2KHdIYf GCT0zK+oXWX////KAn60AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QKEgciIGgyBOwAAAG7SURBVDjL XZRBcsMgDEWlquzBHvY2SfakTA/Qjr13Oub+V6mEwNAyWWT0pP9BCAMAoHV1TZQSB6z8Iv+BC9yS LECnoFVMISRdkg14FTgXbqmhCBYHsAzAdXMX1g6InTq4UwMp4VhxXzqA0eP+TQ1E7CCE+zZ386sk CLhdQCuwgu/5OmIBVk4Z2GNu5qjnsKI3jQcEBQQqlkYgyaCdWUZQmkjFy7awycXcWqBS0uJ+24oU WydJqDuKHFeA5V7AaTfAnwr6BZd05/N2ASpAlPBV8qsUJQHISv5lNN5AqWPXPNd4ATMUQNHl/Lnl LkUVPH0+TB6kSDdFbz4TXlLcQQUoIJpt8KCyW5yRwXsHFitIi8/QAceoaGGyJhszANSOTOTM8e4H DwbiFGg1x3mMB+Qbj8iPZkV77gOQKREaA1q//QM8IPNHsHB5XyC4eXossfV2yxVMqyOew96RrHfq pgViCKuFP8AKwGd4vJz1/yr4UcXw+Fmduu/b0QDPFLKWU5PcgeMR4We+Kjh3HajyDig9xV7BVywf DlAgYk7c9/OQgUYlc5m2qQJTkgWgTnpEnsM9v7wagzyoOtEK8i+W2o66dNtRxAAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMC0xMC0xOFQwNzozNDozMiswMDowMGkk31EAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjAtMTAtMThUMDc6MzQ6MzIrMDA6MDAYeWftAAAAAElFTkSuQmCC X-Now-Playing: Rocket To The Sky's _Cigars_: "Cigars" Date: Sun, 18 Oct 2020 10:36:21 +0200 In-Reply-To: <3346E33F-BFF2-4DD7-8411-F852CCF3C830@gmail.com> (Yuan Fu's message of "Sat, 17 Oct 2020 20:28:25 -0400") Message-ID: <871rhwj5h6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Yuan Fu writes: > I can modify outline code to signal a signal (say > ‘outline-before-first-heading) rather than an error, and handle that > signal specifically. How’s that? Yes, that would also work. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > I can modify outline code to signal a signal (say > =E2=80=98outline-before-first-heading) rather than an error, and handle t= hat > signal specifically. How=E2=80=99s that? Yes, that would also work. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 18 16:23:22 2020 Received: (at 41198) by debbugs.gnu.org; 18 Oct 2020 20:23:22 +0000 Received: from localhost ([127.0.0.1]:39147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUFD8-0001f7-9Q for submit@debbugs.gnu.org; Sun, 18 Oct 2020 16:23:22 -0400 Received: from mail-io1-f41.google.com ([209.85.166.41]:38627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUFD6-0001eq-6g; Sun, 18 Oct 2020 16:23:20 -0400 Received: by mail-io1-f41.google.com with SMTP id y20so10622330iod.5; Sun, 18 Oct 2020 13:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=LfNzbwf/dWwEd7Fcg+R/xoS35alz439bjkvcgJuk58I=; b=RoC0JJIlq5/H7FytHbUQ+8eb/VdYufVaeKx1Vt+AUOX2z0Q9NcVKZFsxdc50h6zoFc dKQ9QdsZvOljmCkCVzMewfXOBnfNcpa/BVbtduhRa01PJMcrdawOiDZzixUKd/+DLHMi eOgvxqPevmYNIH9Qj9nmCw+2EuFSQL3WQWLM3Phkfj3i+EWvFw6qZIyzhzDzCqJgYF7l Ezu6pYC66g2+306SJjFDDD/0Z7LDYXwE9KAM5TjqBlOje3YQxqA/1ZZ423F207WVaRrV pesKoUf/Z8oWXWQTNT8jXz3C1E8D5ZZzOrLq4SvkFSbTwI/9Zkw2TebfrurvQ32duyOw gB0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=LfNzbwf/dWwEd7Fcg+R/xoS35alz439bjkvcgJuk58I=; b=GjNJ9hdvmems2THlomcoCPHtsooDWR+wVEfY9YGJjQi65OtIUnKqLWIMcknz49gs9N WNxqxnsauYBFvApEbCaCw9I13/USkylYyA/k0fpG9jhtYnSm8y/3mCY1m+rDTppFExYJ glnnBkpcNse0Uhgo0x4VLugrt/fdnPLbJbN4WZxzvNKLdeL/GBKdN2LTTBwgXkTZW4Ls 0JTuPp+lXa9pZwv+syR0ogL/3DLnEkLumTY1Rsn7JkzQ4iPhaD6s6GDw+b3qYJ97YW+e P3l7O1IHJJNr7Rofp04CPYlPcrOVE4toYNjNLXiOBnBIHji21bjfj6yveIB3RQ63/Tod AQgQ== X-Gm-Message-State: AOAM532keQnTQqzI5ksh6Oln2ZSxPjzBGJIcZTUygDxww2ch2m0fUIuD opt91xK43rIePSKI/wKlQPw= X-Google-Smtp-Source: ABdhPJyfQ0gAdJluHs+Zk5R4zLfqgTsXw2i0WhHw6ORyXXuiqmjDkXGOoLxwNzc7lI7EfX2erfEKng== X-Received: by 2002:a02:caa1:: with SMTP id e1mr9227997jap.80.1603052594457; Sun, 18 Oct 2020 13:23:14 -0700 (PDT) Received: from ?IPv6:2601:98a:4200:9210:d02a:1c66:2033:eacb? ([2601:98a:4200:9210:d02a:1c66:2033:eacb]) by smtp.gmail.com with ESMTPSA id v9sm8496222ioq.41.2020.10.18.13.23.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Oct 2020 13:23:13 -0700 (PDT) From: Yuan Fu Message-Id: <70FAFCD6-33C6-4254-97B7-EE3DF77B6EF1@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_7B4AB68D-810C-4604-B476-F5B9D37CDCE3" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Date: Sun, 18 Oct 2020 16:23:12 -0400 In-Reply-To: <871rhwj5h6.fsf@gnus.org> To: Lars Ingebrigtsen References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> <87sgadz7cw.fsf@gnus.org> <871rhwh91d.fsf@mail.linkov.net> <3346E33F-BFF2-4DD7-8411-F852CCF3C830@gmail.com> <871rhwj5h6.fsf@gnus.org> X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_7B4AB68D-810C-4604-B476-F5B9D37CDCE3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 18, 2020, at 4:36 AM, Lars Ingebrigtsen wrote: >=20 > Yuan Fu writes: >=20 >> I can modify outline code to signal a signal (say >> =E2=80=98outline-before-first-heading) rather than an error, and = handle that >> signal specifically. How=E2=80=99s that? >=20 > Yes, that would also work. >=20 > --=20 > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no Here is the new patch. Yuan --Apple-Mail=_7B4AB68D-810C-4604-B476-F5B9D37CDCE3 Content-Disposition: attachment; filename=outline-fix.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="outline-fix.patch" Content-Transfer-Encoding: quoted-printable =46rom=20ff4722534c1e47a2536257116436b66c79db3e8b=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Yuan=20Fu=20=0ADate:=20Thu,=20= 15=20Oct=202020=2022:20:20=20-0400=0ASubject:=20[PATCH]=20Handle=20= "Before=20first=20headings"=20error=20in=20outline-cycle=0A=0A*=20= lisp/outline.el=20(outline-before-first-heading):=20New=20error.=0A= (outline-back-to-heading):=20Signal=20the=20new=20error.=0A= (outline-cycle):=20Ignore=20the=20error.=0A(outline-cycle-buffer):=20= Simply=20pass=201=20to=20'outline-hide-sublevels'.=0A---=0A=20= lisp/outline.el=20|=2040=20+++++++++++++++++++---------------------=0A=20= 1=20file=20changed,=2019=20insertions(+),=2021=20deletions(-)=0A=0Adiff=20= --git=20a/lisp/outline.el=20b/lisp/outline.el=0Aindex=20= a4ce9afb44..b9806bc187=20100644=0A---=20a/lisp/outline.el=0A+++=20= b/lisp/outline.el=0A@@=20-402,6=20+402,8=20@@=20outline-invisible-p=0A=20= If=20POS=20is=20nil,=20use=20`point'=20instead."=0A=20=20=20(eq=20= (get-char-property=20(or=20pos=20(point))=20'invisible)=20'outline))=0A=20= =0A+(define-error=20'outline-before-first-heading=20"Before=20first=20= heading")=0A+=0A=20(defun=20outline-back-to-heading=20(&optional=20= invisible-ok)=0A=20=20=20"Move=20to=20previous=20heading=20line,=20or=20= beg=20of=20this=20line=20if=20it's=20a=20heading.=0A=20Only=20visible=20= heading=20lines=20are=20considered,=20unless=20INVISIBLE-OK=20is=20= non-nil."=0A@@=20-412,7=20+414,7=20@@=20outline-back-to-heading=0A=20=09=20= =20(while=20(not=20found)=0A=20=09=20=20=20=20(or=20(re-search-backward=20= (concat=20"^\\(?:"=20outline-regexp=20"\\)")=0A=20=09=09=09=09=20=20=20=20= nil=20t)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(error=20= "Before=20first=20heading"))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(signal=20'outline-before-first-heading=20nil))=0A=20=09=20=20=20=20= (setq=20found=20(and=20(or=20invisible-ok=20(not=20= (outline-invisible-p)))=0A=20=09=09=09=20=20=20=20=20(point)))))=0A=20=09= (goto-char=20found)=0A@@=20-1167,19=20+1169,21=20@@=20outline-cycle=0A=20= `Headings=20only'=20means=20show=20sub=20headings=20but=20not=20their=20= bodies.=0A=20`Show=20all'=20means=20show=20all=20subheadings=20and=20= their=20bodies."=0A=20=20=20(interactive)=0A-=20=20(pcase=20= (outline--cycle-state)=0A-=20=20=20=20('hide-all=0A-=20=20=20=20=20(if=20= (outline-has-subheading-p)=0A-=20=20=20=20=20=20=20=20=20(progn=20= (outline-show-children)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (message=20"Only=20headings"))=0A-=20=20=20=20=20=20=20= (outline-show-subtree)=0A-=20=20=20=20=20=20=20(message=20"Show=20= all")))=0A-=20=20=20=20('headings-only=0A-=20=20=20=20=20= (outline-show-subtree)=0A-=20=20=20=20=20(message=20"Show=20all"))=0A-=20= =20=20=20('show-all=0A-=20=20=20=20=20(outline-hide-subtree)=0A-=20=20=20= =20=20(message=20"Hide=20all"))))=0A+=20=20(condition-case=20nil=0A+=20=20= =20=20=20=20(pcase=20(outline--cycle-state)=0A+=20=20=20=20=20=20=20=20= ('hide-all=0A+=20=20=20=20=20=20=20=20=20(if=20= (outline-has-subheading-p)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= (progn=20(outline-show-children)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(message=20"Only=20headings"))=0A+=20=20=20=20=20=20= =20=20=20=20=20(outline-show-subtree)=0A+=20=20=20=20=20=20=20=20=20=20=20= (message=20"Show=20all")))=0A+=20=20=20=20=20=20=20=20('headings-only=0A= +=20=20=20=20=20=20=20=20=20(outline-show-subtree)=0A+=20=20=20=20=20=20=20= =20=20(message=20"Show=20all"))=0A+=20=20=20=20=20=20=20=20('show-all=0A= +=20=20=20=20=20=20=20=20=20(outline-hide-subtree)=0A+=20=20=20=20=20=20=20= =20=20(message=20"Hide=20all")))=0A+=20=20=20=20= (outline-before-first-heading=20nil)))=0A=20=0A=20(defvar-local=20= outline--cycle-buffer-state=20'show-all=0A=20=20=20"Internal=20variable=20= used=20for=20tracking=20buffer=20cycle=20state.")=0A@@=20-1189,13=20= +1193,7=20@@=20outline-cycle-buffer=0A=20=20=20(interactive)=0A=20=20=20= (pcase=20outline--cycle-buffer-state=0A=20=20=20=20=20('show-all=0A-=20=20= =20=20=20(save-excursion=0A-=20=20=20=20=20=20=20(let=20((start-point=20= (point)))=0A-=20=20=20=20=20=20=20=20=20(while=20(not=20(eq=20(point)=20= start-point))=0A-=20=20=20=20=20=20=20=20=20=20=20(outline-up-heading=20= 1))=0A-=20=20=20=20=20=20=20=20=20(outline-hide-sublevels=0A-=20=20=20=20= =20=20=20=20=20=20(progn=20(outline-back-to-heading)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(funcall=20'outline-level)))))=0A+=20=20= =20=20=20(outline-hide-sublevels=201)=0A=20=20=20=20=20=20(setq=20= outline--cycle-buffer-state=20'top-level)=0A=20=20=20=20=20=20(message=20= "Top=20level=20headings"))=0A=20=20=20=20=20('top-level=0A--=20=0A2.27.0=0A= =0A= --Apple-Mail=_7B4AB68D-810C-4604-B476-F5B9D37CDCE3-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 04:45:48 2020 Received: (at 41198) by debbugs.gnu.org; 19 Oct 2020 08:45:48 +0000 Received: from localhost ([127.0.0.1]:39950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUQnc-0005zC-9J for submit@debbugs.gnu.org; Mon, 19 Oct 2020 04:45:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUQna-0005yv-7Z; Mon, 19 Oct 2020 04:45:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qeXfsRQSIMUj838UVbtdSVwS2+GpUCzxMigUWSU5hzE=; b=iZUhxpnthNPk39UhtLdsLtIocA D2UJHId0Nya6yaG008JEleLGBoTtQGbTpmlbkCeDFQ2WocNVZNCkmd8PdUroBzjVGvhp2qQ7xD4ss LfxI6Zm/K1QiNRWv60uXY1Xngih+hobkn7BFz+bqhhaKfHQ7ZYF0tMYWxoZRaK+0YEd4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUQnQ-0005Li-Ti; Mon, 19 Oct 2020 10:45:39 +0200 From: Lars Ingebrigtsen To: Yuan Fu Subject: Re: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> <87sgadz7cw.fsf@gnus.org> <871rhwh91d.fsf@mail.linkov.net> <3346E33F-BFF2-4DD7-8411-F852CCF3C830@gmail.com> <871rhwj5h6.fsf@gnus.org> <70FAFCD6-33C6-4254-97B7-EE3DF77B6EF1@gmail.com> X-Now-Playing: Motorpsycho's _Roadwork vol. 5 (2)_: "Taifun" Date: Mon, 19 Oct 2020 10:45:35 +0200 In-Reply-To: <70FAFCD6-33C6-4254-97B7-EE3DF77B6EF1@gmail.com> (Yuan Fu's message of "Sun, 18 Oct 2020 16:23:12 -0400") Message-ID: <87lfg2fvtc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Yuan Fu writes: > Here is the new patch. Thanks; looks good to me. I've now pushed it to the trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Stefan Kangas , 41130@debbugs.gnu.org, 41198@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > Here is the new patch. Thanks; looks good to me. I've now pushed it to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 00:50:42 2020 Received: (at 41198) by debbugs.gnu.org; 15 Nov 2020 05:50:42 +0000 Received: from localhost ([127.0.0.1]:52416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keAvy-0005wf-Gb for submit@debbugs.gnu.org; Sun, 15 Nov 2020 00:50:42 -0500 Received: from sendmail.purelymail.com ([34.202.193.197]:55898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keAvv-0005wR-QY for 41198@debbugs.gnu.org; Sun, 15 Nov 2020 00:50:41 -0500 DKIM-Signature: a=rsa-sha256; b=FNIqOMHY7tEF5F4AyNSX9anw0IQoaVnqKmyDB/DedPXMhbPWVYAbD03lo9aBHfk+/3XYflgbUH8O1oAhQ94E/2VdSijIcobO53Zv6Lb6x9kczMUrvkb4T0khNLJFirZBW96j5ws2GFW2pzMgvpOiXkhj1veXCsu9vdpgSiN6ri4Q5okKlB9yzEfgV48nocUS1wFXi9Um50p8UQS5EK5M65AF9VfonStie2Y+6uuhcjFaVRU/EXLAaFL9XTyIr4D2wIbsXg9royu1MzxtOTw/1lndtov3skkvLJrUAqiUNC2mtoSv3Jixtwk0MvkTgEds4aPZV4HVclnTtCHIVtHkFw==; s=purelymail1; d=paulwrankin.com; v=1; bh=ckQZp96dGn+F8n0sf+F2bwCnGECSxZkg6SIyOyyUy1I=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=pFK4r/2yOOlGhhQd6w9vW7DDonkOpfzRHwsffSkjzsjEfPXn5GTe/ZZ3FYO6SgUpTTIX2256CwgZ0GatyRoofBI3+eSOgWHVTxOgSMEmyvEUYlmqLA70sB4pFbU2YBBrbrmAPDWX32d7S/0WkHE3laycKHj611RKS+BF7kjfrxBZ5Tw7uiEnm15UqW5iynNAKF5gaMiqckoLqYAbN34f0sLRBBbkD433NeZlUN+FRijXdR7D24Mcgz3BMAie0NGwhJirHw8pfH6dk7lHYhsBlhzSayYO8paNWjtFkPdgfA2X7iHFIA+O72M8XUszn74lPkqV32PwhdQ22hB5GykxBQ==; s=purelymail1; d=purelymail.com; v=1; bh=ckQZp96dGn+F8n0sf+F2bwCnGECSxZkg6SIyOyyUy1I=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: 41198@debbugs.gnu.org Received: by ip-172-30-0-247.ec2.internal (JAMES SMTP Server ) with ESMTPA ID -2077965078 for <41198@debbugs.gnu.org>; Sun, 15 Nov 2020 05:50:32 +0000 (UTC) MIME-Version: 1.0 Date: Sun, 15 Nov 2020 15:50:31 +1000 From: "Paul W. Rankin" To: 41198@debbugs.gnu.org Subject: 28.0.50; heading cycling command for outline User-Agent: Purely Mail via Roundcube/1.4.7 Message-ID: <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> X-Sender: hello@paulwrankin.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by Purelymail X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41198 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Sorry to revisit this but there are a few edge cases with the new=20 outline-cycle and outline-cycle-buffer commands... 1. In command outline-hide-sublevels#L901 we see: ;; Finally unhide any trailing newline. (goto-char (point-max)) (if (and (bolp) (not (bobp)) (outline-invisible-p (1- (point)))) (outline-flag-region (1- (point)) (point) nil)))) When calling this function the overlay created to hide the buffer's=20 final subheading ends at the end-of-subtree - 1. This means that the=20 following code in outline--cycle-state#L1130 fails with an off-by-1: ((and (eq (overlay-end (car ov-list)) end) (eq (overlay-start (car ov-list)) heading-end)) The result of this is that when calling outline-cycle-buffer to set the=20 outline in a top-level state, if the user navigates to the last=20 top-level heading and presses TAB for outline-cycle, the expectation is=20 to show that heading's subheadings, but the result is show all. To fix, if leaving outline-hide-sublevels alone, a workaround would be: diff --git a/lisp/outline.el b/lisp/outline.el index 47e6528859..054d2cb62b 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -1127,7 +1127,7 @@ outline--cycle-state (cond ((eq ov-list nil) 'show-all) ;; (eq (length ov-list) 1) wouldn=E2=80=99t work: what if the= re is ;; one folded subheading? - ((and (eq (overlay-end (car ov-list)) end) + ((and (<=3D 0 (- end (overlay-end (car ov-list))) 1) (eq (overlay-start (car ov-list)) heading-end)) 'hide-all) (t 'headings-only))))) 2. This may sound strange, but overlays with an invisible property of=20 'outline are not guaranteed to be overlays for collapsed outline=20 headings. This is true if a lisp program has used outline-flag-region=20 for something other than an outline heading. I had done this for=20 collapsing a major mode's notes markup: [[ here's a note ]] -> [[...]] This is simply solved by testing each overlay-start with=20 outline-on-heading-p: diff --git a/lisp/outline.el b/lisp/outline.el index 054d2cb62b..a05cf87d4e 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -1121,10 +1121,15 @@ outline--cycle-state (setq heading-end (point)) (outline-end-of-subtree) (setq end (point)) - (setq ov-list (cl-remove-if-not - (lambda (o) (eq (overlay-get o 'invisible)=20 'outline)) - (overlays-in start end))) - (cond ((eq ov-list nil) 'show-all) + (setq ov-list + (seq-filter + (lambda (o) + (and (eq (overlay-get o 'invisible) 'outline) + (save-excursion + (goto-char (overlay-start o)) + (outline-on-heading-p t))))) + (overlays-in start end))) + (cond ((eq ov-list nil) 'show-all) ;; (eq (length ov-list) 1) wouldn=E2=80=99t work: what if the= re is ;; one folded subheading? ((and (<=3D 0 (- end (overlay-end (car ov-list))) 1) n.b. This will fail if the user/program has changed=20 outline-heading-end-regexp to have multiple newlines, because=20 outline-on-heading-p only checks if it's looking at outline-regexp from=20 the beginning of that line. 3. When a buffer contains outline headings of only < 1 (e.g. all=20 headings are level 3) calling outline-cycle-buffer to show only=20 top-level headings will results in an unexpected buffer state of: ... This is fixed with a simple test of whether the buffer has top-level=20 headings before allowing cycling to top-level. --=20 Paul W. Rankin https://www.paulwrankin.com The single best thing you can do for the world is delete your social=20 media accounts. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 17:00:02 2020 Received: (at 41198) by debbugs.gnu.org; 16 Nov 2020 22:00:02 +0000 Received: from localhost ([127.0.0.1]:57571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kemXa-0007Gx-DN for submit@debbugs.gnu.org; Mon, 16 Nov 2020 17:00:02 -0500 Received: from quimby.gnus.org ([95.216.78.240]:39386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kemXX-0007Fz-T2 for 41198@debbugs.gnu.org; Mon, 16 Nov 2020 17:00:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=klGkP64PODw7XsEQZ42iuSQerIIca8GKEchJsPP/4IM=; b=A9L5ohnYwUyMwyhbgasyqbYpEe 7f43QzzVuedc51ckgcFU7paODEhPmGzeD6HhS8p5uEP0i9BBfhRaDhjpdLnd2NnnAXaLWRBLlkfxo tY5uVM/YrlVJxeEzcFc9111PgSH9QsoPTroTSN+USKGVEm1uFQlY9CHaS+7Eo3yATNyk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kemXM-0005yz-Sa; Mon, 16 Nov 2020 22:59:53 +0100 From: Lars Ingebrigtsen To: 41198@debbugs.gnu.org Subject: Re: bug#41198: 28.0.50; heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> X-Now-Playing: Various's _Amchitka (2)_: "Joni Mitchell - Big Yellow Taxi-Bony Maroni" Date: Mon, 16 Nov 2020 22:59:47 +0100 In-Reply-To: <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> (Paul W. Rankin's message of "Sun, 15 Nov 2020 15:50:31 +1000") Message-ID: <87a6vhvu7g.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Paul W. Rankin" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Sorry to revisit this but there are a few edge cases with the new > outline-cycle and outline-cycle-buffer commands... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: "Paul W. Rankin" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Paul W. Rankin" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Sorry to revisit this but there are a few edge cases with the new > outline-cycle and outline-cycle-buffer commands... The patches look OK to me, but look like they've been slightly mangled during transmission, so could you include them as a single patch as an attachment? (And adding a ChangeLog-format text would also be nice.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 22:04:01 2020 Received: (at 41198) by debbugs.gnu.org; 17 Nov 2020 03:04:01 +0000 Received: from localhost ([127.0.0.1]:57942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kerHi-0008Pp-Up for submit@debbugs.gnu.org; Mon, 16 Nov 2020 22:04:00 -0500 Received: from sendmail.purelymail.com ([34.202.193.197]:39486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ker2D-00080O-UN for 41198@debbugs.gnu.org; Mon, 16 Nov 2020 21:48:00 -0500 DKIM-Signature: a=rsa-sha256; b=UUNrQIOTm3Dnn5AVB/EkoAkWdf2CauC731Qmsm0r26AZg2AhaE2aFVgt4Qa6oJAJ3kqd3PTvTAOPOMvvUC7Zd8hKpn/FZ26SP4Z9Pu4PSpHdimahr3kajZsMAfQoXNowQ+VpwEyH6B6sYMVuVSFK9dZ3ZlO2+Ll81QyQP3MYJqB1LiGpTicwiVeB/EQK8BuCnKimfWtudPANuKjDdX9Z7kl/XcBLmBQJ02Zwg70w1uE2svNpGyPA2sedQrMMZTHtmj8eRw8nxjGeEH32RPuBNVxE150mTCv2i76DqCqlTbGbfteJ7Qk8blEo6TZEVySZ2oBUfCLL0tGrg61+uE5rhw==; s=purelymail1; d=skeletons.cc; v=1; bh=deSgAckohWRCh39FuHH8FP0s2sjJLcg2B0xY4am8io4=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=q29aNFNGOj69coqux/mCr0wTCo+WeVklFXCPJJUuXqs0ouzMDIVx5Q//OOL6PReuLohN3fp525v13j67DM4drFNSfKMwto3QE/qgtkj3v8R3+WIsjTtbBYnLFw0n7f6OIK4fyVgHZ1GoGz2rJxg5FNS69IEAGa7MHD+XDaVDgbgT0ecppJYtdXpAhPuTPgqpX/xrg3aIu02cOuCukhFCu+j0yGpY0ssAuLxgDUvjaovq2h2aEQfP+IIJEJDur4ZLROjCiAXiJ25xupxSvK43xSWOw4waCojId0ciMo3cg1sblHC4hsOIN+Ox8kK6onzvLiCOYBzPWjPhp/yf+pq94w==; s=purelymail1; d=purelymail.com; v=1; bh=deSgAckohWRCh39FuHH8FP0s2sjJLcg2B0xY4am8io4=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: 41198@debbugs.gnu.org Received: by ip-172-30-0-247.ec2.internal (JAMES SMTP Server ) with ESMTPA ID 868856346; Tue, 17 Nov 2020 02:47:33 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 17 Nov 2020 12:47:33 +1000 From: "Paul W. Rankin" To: Lars Ingebrigtsen Subject: Re: bug#41198: 28.0.50; heading cycling command for outline In-Reply-To: <87a6vhvu7g.fsf@gnus.org> References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> User-Agent: Purely Mail via Roundcube/1.4.7 Message-ID: X-Sender: pwr@skeletons.cc Content-Type: multipart/mixed; boundary="=_e8c2e950f0899f7cbf9527053090597d" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41198 X-Mailman-Approved-At: Mon, 16 Nov 2020 22:03:57 -0500 Cc: 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=_e8c2e950f0899f7cbf9527053090597d Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2020-11-17 07:59, Lars Ingebrigtsen wrote: > > The patches look OK to me, but look like they've been slightly mangled > during transmission, so could you include them as a single patch as an > attachment? (And adding a ChangeLog-format text would also be nice.) 2x patches attached with changelog. I took a more precise approach with outline--cycle-state, where the +1 case is only handled when the subtree end is point-max, otherwise the overlay-end must equal end of subtree point in all other cases. I rewrote outline-cycle-buffer; it now first checks that the buffer has top-level headings before attempting to show only top-level headings, thus avoiding the disconcerting state where all buffer content is reduced to "...". If buffer has no outline headings, we still get an annoying message toggle from "All headings" to "Show all". Also this avoids using pcase, which is awful. --=_e8c2e950f0899f7cbf9527053090597d Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-lisp-outline.el-better-handing-of-outline-overlays-w.patch Content-Disposition: attachment; filename=0001-lisp-outline.el-better-handing-of-outline-overlays-w.patch; size=1902 RnJvbSBjNTg5ZTQwNTVhYWQ5M2FjZWVmZTBlYmIzMjgxYzAwOGM4MmEwYjQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUGF1bCBXLiBSYW5raW4iIDxwd3JAc2tlbGV0b25zLmNjPgpE YXRlOiBUdWUsIDE3IE5vdiAyMDIwIDEyOjQyOjQ3ICsxMDAwClN1YmplY3Q6IFtQQVRDSCAxLzJd ICogbGlzcC9vdXRsaW5lLmVsOiBiZXR0ZXIgaGFuZGluZyBvZiBvdXRsaW5lIG92ZXJsYXlzCiB3 aGVuIGN5Y2xpbmcKCihvdXRsaW5lLS1jeWNsZS1zdGF0ZSk6IG9ubHkgY29uc2lkZXIgb3V0bGlu ZSBvdmVybGF5cyB0aGF0IGFyZSBvbgogIG91dGxpbmUgaGVhZGluZ3M7IHdoZW4gc3VidHJlZSBl bmQgaXMgcG9pbnQtbWF4LCByZXR1cm4gb3ZlcmxheS1lbmQgKzEKICBiZWNhdXNlIGZpbmFsIHN1 YnRyZWUgb3ZlcmxheSBvbmx5IHJlYWNoZXMgcG9pbnQtbWF4IC0xLgotLS0KIGxpc3Avb3V0bGlu ZS5lbCB8IDIxICsrKysrKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEzIGluc2Vy dGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vdXRsaW5lLmVsIGIv bGlzcC9vdXRsaW5lLmVsCmluZGV4IDQ3ZTY1Mjg4NTkuLjhjYzhhM2NkODkgMTAwNjQ0Ci0tLSBh L2xpc3Avb3V0bGluZS5lbAorKysgYi9saXNwL291dGxpbmUuZWwKQEAgLTExMjEsMTQgKzExMjEs MTkgQEAgb3V0bGluZS0tY3ljbGUtc3RhdGUKICAgICAgIChzZXRxIGhlYWRpbmctZW5kIChwb2lu dCkpCiAgICAgICAob3V0bGluZS1lbmQtb2Ytc3VidHJlZSkKICAgICAgIChzZXRxIGVuZCAocG9p bnQpKQotICAgICAgKHNldHEgb3YtbGlzdCAoY2wtcmVtb3ZlLWlmLW5vdAotICAgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSAobykgKGVxIChvdmVybGF5LWdldCBvICdpbnZpc2libGUpICdvdXRs aW5lKSkKLSAgICAgICAgICAgICAgICAgICAgIChvdmVybGF5cy1pbiBzdGFydCBlbmQpKSkKLSAg ICAgIChjb25kICgoZXEgb3YtbGlzdCBuaWwpICdzaG93LWFsbCkKLSAgICAgICAgICAgIDs7IChl cSAobGVuZ3RoIG92LWxpc3QpIDEpIHdvdWxkbuKAmXQgd29yazogd2hhdCBpZiB0aGVyZSBpcwot ICAgICAgICAgICAgOzsgb25lIGZvbGRlZCBzdWJoZWFkaW5nPwotICAgICAgICAgICAgKChhbmQg KGVxIChvdmVybGF5LWVuZCAoY2FyIG92LWxpc3QpKSBlbmQpCi0gICAgICAgICAgICAgICAgICAo ZXEgKG92ZXJsYXktc3RhcnQgKGNhciBvdi1saXN0KSkgaGVhZGluZy1lbmQpKQorICAgICAgKHNl dHEgb3YtbGlzdAorICAgICAgICAgICAgKHNlcS1maWx0ZXIKKyAgICAgICAgICAgICAobGFtYmRh IChvKQorICAgICAgICAgICAgICAgKGFuZCAoZXEgKG92ZXJsYXktZ2V0IG8gJ2ludmlzaWJsZSkg J291dGxpbmUpCisgICAgICAgICAgICAgICAgICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAg ICAgICAgICAgICAgIChnb3RvLWNoYXIgKG92ZXJsYXktc3RhcnQgbykpCisgICAgICAgICAgICAg ICAgICAgICAgKG91dGxpbmUtb24taGVhZGluZy1wIHQpKSkpCisgICAgICAgICAgICAgKG92ZXJs YXlzLWluIHN0YXJ0IGVuZCkpKQorICAgICAgKGNvbmQgKChudWxsIG92LWxpc3QpICdzaG93LWFs bCkKKyAgICAgICAgICAgICgoYW5kIChvciAoPSBlbmQgKHBvaW50LW1heCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAoMSsgKG92ZXJsYXktZW5kIChjYXIgb3YtbGlzdCkpKSkKKyAgICAgICAg ICAgICAgICAgICAgICAoPSAob3ZlcmxheS1lbmQgKGNhciBvdi1saXN0KSkgZW5kKSkKKyAgICAg ICAgICAgICAgICAgICg9IChvdmVybGF5LXN0YXJ0IChjYXIgb3YtbGlzdCkpIGhlYWRpbmctZW5k KSkKICAgICAgICAgICAgICAnaGlkZS1hbGwpCiAgICAgICAgICAgICAodCAnaGVhZGluZ3Mtb25s eSkpKSkpCiAKLS0gCjIuMjkuMgoK --=_e8c2e950f0899f7cbf9527053090597d Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0002-lisp-outline.el-avoid-hiding-all-buffer-content.patch Content-Disposition: attachment; filename=0002-lisp-outline.el-avoid-hiding-all-buffer-content.patch; size=2252 RnJvbSA2ODAyMTBjNjQ1NDUzODk1MDJlN2EyZDA1ZWMwYzk4ZTdiMjVjMjRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUGF1bCBXLiBSYW5raW4iIDxwd3JAc2tlbGV0b25zLmNjPgpE YXRlOiBUdWUsIDE3IE5vdiAyMDIwIDEyOjQ0OjQ0ICsxMDAwClN1YmplY3Q6IFtQQVRDSCAyLzJd ICogbGlzcC9vdXRsaW5lLmVsOiBhdm9pZCBoaWRpbmcgYWxsIGJ1ZmZlciBjb250ZW50Cgoob3V0 bGluZS1jeWNsZS1idWZmZXIpOiBjaGVjayB0aGF0IGJ1ZmZlciBoYXMgdG9wLWxldmVsIGhlYWRp bmdzCiAgYmVmb3JlIGNhbGxpbmcgb3V0bGluZS1oaWRlLXN1YmxldmVscyAxIHRodXMgcHJldmVu dGluZyBkaXNjb25jZXJ0aW5nCiAgYnVmZmVyIHN0YXRlIG9mIGNvbnRlbnQgcmVkdWNlZCB0byBz aW5nbGUgIi4uLiIKLS0tCiBsaXNwL291dGxpbmUuZWwgfCAzOCArKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDE0 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3V0bGluZS5lbCBiL2xpc3Avb3V0bGlu ZS5lbAppbmRleCA4Y2M4YTNjZDg5Li45YjExYjg2YjlkIDEwMDY0NAotLS0gYS9saXNwL291dGxp bmUuZWwKKysrIGIvbGlzcC9vdXRsaW5lLmVsCkBAIC0xMTczLDIwICsxMTczLDMwIEBAIG91dGxp bmUtLWN5Y2xlLWJ1ZmZlci1zdGF0ZQogKGRlZnVuIG91dGxpbmUtY3ljbGUtYnVmZmVyICgpCiAg ICJDeWNsZSB0aGUgd2hvbGUgYnVmZmVyIGxpa2UgaW4gYG91dGxpbmUtY3ljbGUnLiIKICAgKGlu dGVyYWN0aXZlKQotICAocGNhc2Ugb3V0bGluZS0tY3ljbGUtYnVmZmVyLXN0YXRlCi0gICAgKCdz aG93LWFsbAotICAgICAob3V0bGluZS1oaWRlLXN1YmxldmVscyAxKQotICAgICAoc2V0cSBvdXRs aW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ3RvcC1sZXZlbCkKLSAgICAgKG1lc3NhZ2UgIlRvcCBs ZXZlbCBoZWFkaW5ncyIpKQotICAgICgndG9wLWxldmVsCi0gICAgIChvdXRsaW5lLXNob3ctYWxs KQotICAgICAob3V0bGluZS1oaWRlLXJlZ2lvbi1ib2R5IChwb2ludC1taW4pIChwb2ludC1tYXgp KQotICAgICAoc2V0cSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ2FsbC1oZWFkaW5nKQot ICAgICAobWVzc2FnZSAiQWxsIGhlYWRpbmdzIikpCi0gICAgKCdhbGwtaGVhZGluZwotICAgICAo b3V0bGluZS1zaG93LWFsbCkKLSAgICAgKHNldHEgb3V0bGluZS0tY3ljbGUtYnVmZmVyLXN0YXRl ICdzaG93LWFsbCkKLSAgICAgKG1lc3NhZ2UgIlNob3cgYWxsIikpKSkKKyAgKGxldCAoaGFzLXRv cC1sZXZlbCkKKyAgICAoc2F2ZS1leGN1cnNpb24KKyAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1p bikpCisgICAgICAod2hpbGUgKG5vdCAob3IgaGFzLXRvcC1sZXZlbCAoZW9icCkpKQorICAgICAg ICAod2hlbiAob3V0bGluZS1vbi1oZWFkaW5nLXAgdCkKKyAgICAgICAgICAod2hlbiAoPSAoZnVu Y2FsbCBvdXRsaW5lLWxldmVsKSAxKQorICAgICAgICAgICAgKHNldHEgaGFzLXRvcC1sZXZlbCB0 KSkpCisgICAgICAgIChvdXRsaW5lLW5leHQtaGVhZGluZykpKQorICAgIChjb25kCisgICAgICgo YW5kIChlcSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ3Nob3ctYWxsKQorICAgICAgICAg ICBoYXMtdG9wLWxldmVsKQorICAgICAgKG91dGxpbmUtaGlkZS1zdWJsZXZlbHMgMSkKKyAgICAg IChzZXRxIG91dGxpbmUtLWN5Y2xlLWJ1ZmZlci1zdGF0ZSAndG9wLWxldmVsKQorICAgICAgKG1l c3NhZ2UgIlRvcCBsZXZlbCBoZWFkaW5ncyIpKQorICAgICAoKG9yIChlcSBvdXRsaW5lLS1jeWNs ZS1idWZmZXItc3RhdGUgJ3Nob3ctYWxsKQorICAgICAgICAgIChlcSBvdXRsaW5lLS1jeWNsZS1i dWZmZXItc3RhdGUgJ3RvcC1sZXZlbCkpCisgICAgICAob3V0bGluZS1zaG93LWFsbCkKKyAgICAg IChvdXRsaW5lLWhpZGUtcmVnaW9uLWJvZHkgKHBvaW50LW1pbikgKHBvaW50LW1heCkpCisgICAg ICAoc2V0cSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ2FsbC1oZWFkaW5nKQorICAgICAg KG1lc3NhZ2UgIkFsbCBoZWFkaW5ncyIpKQorICAgICAodAorICAgICAgKG91dGxpbmUtc2hvdy1h bGwpCisgICAgICAoc2V0cSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ3Nob3ctYWxsKQor ICAgICAgKG1lc3NhZ2UgIlNob3cgYWxsIikpKSkpCiAKIChwcm92aWRlICdvdXRsaW5lKQogKHBy b3ZpZGUgJ25vdXRsaW5lKQotLSAKMi4yOS4yCgo= --=_e8c2e950f0899f7cbf9527053090597d-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 00:09:40 2020 Received: (at 41198) by debbugs.gnu.org; 24 Nov 2020 05:09:40 +0000 Received: from localhost ([127.0.0.1]:52097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khQaC-0003KB-MY for submit@debbugs.gnu.org; Tue, 24 Nov 2020 00:09:40 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khQaA-0003Jr-VM for 41198@debbugs.gnu.org; Tue, 24 Nov 2020 00:09:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HJOnE4KN+SKVa/ok4Jl1NeIKRfOMvNEu3Ym3B3ZfngI=; b=RKRvC+GxEa6BMHNnX6U/cCSXu8 pBqF0E79oVML8MFzHQjJK/WldFMsXPk1CkM00glZWbyZaqHc80GccFAfeJNUzhErV7YqHcGEgL0xN Ig2SH2mALQrnKj9Gvgik51BVkyot2DhtHs0T8YbuHdmSrIVRfZhwjdo/pDwaINRwilRw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khQa1-0008AX-V5; Tue, 24 Nov 2020 06:09:32 +0100 From: Lars Ingebrigtsen To: "Paul W. Rankin" Subject: Re: bug#41198: 28.0.50; heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> X-Now-Playing: The B-52's's _Wild Planet_: "53 Miles West Of Venus" Date: Tue, 24 Nov 2020 06:09:28 +0100 In-Reply-To: (Paul W. Rankin's message of "Tue, 17 Nov 2020 12:47:33 +1000") Message-ID: <87ft4ze3xz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Paul W. Rankin" writes: > 2x patches attached with changelog. Thanks; looks OK to me, so I've applied it to Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Paul W. Rankin" writes: > 2x patches attached with changelog. Thanks; looks OK to me, so I've applied it to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 14:30:50 2020 Received: (at 41198) by debbugs.gnu.org; 25 Nov 2020 19:30:50 +0000 Received: from localhost ([127.0.0.1]:37102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki0V8-00073f-HK for submit@debbugs.gnu.org; Wed, 25 Nov 2020 14:30:50 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki0V8-00073T-25 for 41198@debbugs.gnu.org; Wed, 25 Nov 2020 14:30:50 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BFA3BE0006; Wed, 25 Nov 2020 19:30:42 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> Date: Wed, 25 Nov 2020 21:24:02 +0200 In-Reply-To: <87ft4ze3xz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 24 Nov 2020 06:09:28 +0100") Message-ID: <87h7pdbgvd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: "Paul W. Rankin" , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> 2x patches attached with changelog. > > Thanks; looks OK to me, so I've applied it to Emacs 28. BTW, since now S-TAB cycles headings nicely in etc/NEWS, what about enabling outline-minor-mode in the output Help buffer of 'C-h b'? Currently its section "Key translations" is so long that it takes too much time to scroll down to the most interesting section "Major Mode Bindings". With outline-minor-mode it would be possible to collapse "Key translations" initially. Then typing S-TAB would show such nice overview: * Key translations * `override-global-mode' Minor Mode Bindings * `outline-minor-mode' Minor Mode Bindings * recentf-mode Minor Mode Bindings * Major Mode Bindings * Global Bindings * Function key map translations * Input decoding map translations From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 05:13:49 2020 Received: (at 41198) by debbugs.gnu.org; 26 Nov 2020 10:13:49 +0000 Received: from localhost ([127.0.0.1]:38550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiEHd-0007Pf-Gw for submit@debbugs.gnu.org; Thu, 26 Nov 2020 05:13:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiEHb-0007PS-Ns for 41198@debbugs.gnu.org; Thu, 26 Nov 2020 05:13:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bLzysHNLscVMbhp1H0JiF5pb5woyqVpQcqlhB22sTB8=; b=Nb9aBeroKHMA9OR8mnJQ3KOhnE nmxYakQw5/lsyovUoW8BCNus952DvERrJ6TO/hhzFhtx3OgPWNis8QBRqYPm8SF9A/vtyvuh+yYgh xMFSgj+AeRzqU/eP+auLUfZuH35rrGwr/3zRY53Am6IrLXmASCZfqnm/gqDPD/BFSK64=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiEHQ-00006T-0J; Thu, 26 Nov 2020 11:13:41 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#41198: 28.0.50; heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUZKTEZKTIkOkUt SVdNU2JJc4v////jk2ZGAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QLGgkqG+OqS5UAAAG6SURBVDjL lZNNkhoxDIVl4ACWMgdoyxwgWMwesDlAKvT9rzKS7G7oYbKIiuqFPz/9WA8A4lzYgiJsgkmYRWoi ZJp2EeK0m/R8l1QgIn+v5SYfUuRWc5HrpILMWUG9nv6U/eGSW91fjucISJZfQZMsR9HbWT+/JkDM DiQjEMbDbxXsLwyQhkIYrZVju7Xc2g2AnKxAPq6H1upFFcheXIHNcaz13Ko0AEwdFEaThEi7PuiS iDm5JPjPBnfACwjaZnwB/loYgycLAb8BtDyKY3QgJS+59BA1VsDSNdqXA5cq8LaMJAQc0WuMQZTE odDOeBTRjyULq4T6g4iM6VeAG5D+BTgtuXQfBnhh6UXhgy+At+AZRSW0gPxKVEKsWzWXrIe2u6K3 bWZT8BO0nsvBWKG2aqDKBvSQdp8ftbyDfL7PcxsSCOMUEzp4SJk6oL5VDRIFc5WTXX4HXmULMH8q mFvVKk8AagQ6z060PkP/D/qWYYCHnAzgSGVey/cOigPivjiT2PA6vSQCL5LMBObcvL6xefIJujWK Ld+AEregVfHEaqQEneh1B2BWhNGL+zVCQHiLfj3AT/Hz6X/FFzD4giiy6Z5hAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIwLTExLTI2VDA5OjQyOjI3KzAwOjAwjY+0awAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMC0xMS0yNlQwOTo0MjoyNyswMDowMPzSDNcAAAAASUVORK5CYII= X-Now-Playing: Tuxedomoon's _Desire_: "In the Name of Talent" Date: Thu, 26 Nov 2020 11:13:34 +0100 In-Reply-To: <87h7pdbgvd.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 25 Nov 2020 21:24:02 +0200") Message-ID: <87sg8wxw6p.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > BTW, since now S-TAB cycles headings nicely in etc/NEWS, > what about enabling outline-minor-mode in the output > Help buffer of 'C-h b'? Currently its section > "Key translations" is so long that i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: "Paul W. Rankin" , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > BTW, since now S-TAB cycles headings nicely in etc/NEWS, > what about enabling outline-minor-mode in the output > Help buffer of 'C-h b'? Currently its section > "Key translations" is so long that it takes too much time > to scroll down to the most interesting section > "Major Mode Bindings". Yes, that's a general problem, I think -- I'm often tapping `C-h b' to look for something, but then getting a wall of stuff that's never what I'm interested in (i.e., the "Key translation" stuff), and no easy way to navigate to the sections that I'm looking far. > With outline-minor-mode it would > be possible to collapse "Key translations" initially. > Then typing S-TAB would show such nice overview: > > * Key translations > * `override-global-mode' Minor Mode Bindings > * `outline-minor-mode' Minor Mode Bindings > * recentf-mode Minor Mode Bindings > * Major Mode Bindings > * Global Bindings > * Function key map translations > * Input decoding map translations I think this is a good idea. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 27 03:54:27 2020 Received: (at 41198) by debbugs.gnu.org; 27 Nov 2020 08:54:28 +0000 Received: from localhost ([127.0.0.1]:43926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiZWN-0004uk-LG for submit@debbugs.gnu.org; Fri, 27 Nov 2020 03:54:27 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:36039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiZWI-0004uR-VI for 41198@debbugs.gnu.org; Fri, 27 Nov 2020 03:54:26 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id EF1252000B; Fri, 27 Nov 2020 08:54:14 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> Date: Fri, 27 Nov 2020 10:29:52 +0200 In-Reply-To: <87sg8wxw6p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 26 Nov 2020 11:13:34 +0100") Message-ID: <87k0u7kxrz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: "Paul W. Rankin" , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> With outline-minor-mode it would >> be possible to collapse "Key translations" initially. >> Then typing S-TAB would show such nice overview: >> >> * Key translations >> * `override-global-mode' Minor Mode Bindings >> * `outline-minor-mode' Minor Mode Bindings >> * recentf-mode Minor Mode Bindings >> * Major Mode Bindings >> * Global Bindings >> * Function key map translations >> * Input decoding map translations > > I think this is a good idea. I tried to modify the format of `C-h b' to output '*' headings, but unfortunately after enabling `outline-minor-mode' TAB has no effect on such headings. I wonder why heading cycling implemented in this bug report supports only `outline-mode', but not `outline-minor-mode'? It would make sense in `outline-minor-mode' if TAB typed on a heading then cycle outline heading. If TAB is typed outside of a heading, then use the default TAB binding, e.g. in case of the Help buffer navigate to the next link. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 27 13:40:16 2020 Received: (at 41198) by debbugs.gnu.org; 27 Nov 2020 18:40:16 +0000 Received: from localhost ([127.0.0.1]:46185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiifI-0000nK-EL for submit@debbugs.gnu.org; Fri, 27 Nov 2020 13:40:16 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:56718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiifE-0000n0-9E for 41198@debbugs.gnu.org; Fri, 27 Nov 2020 13:40:14 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0ARITF54169404; Fri, 27 Nov 2020 18:40:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=7PPbuN0kttwwYoQvAtzs6u45HMu20bxBRqDuRhW2eQo=; b=WC1u5It36HpqLLTGHkTqkTSp0OzCnAqftwUPoY8TmIxqNC+DAIcefmzVZDxV+a5q5ZVK 22DexTx/86nTjhJPN4GwWQhbzj/mzH7ktfFZFazr1I2CA55npU1qSbNI3C8jpoW9IWVa T373CjlztwN3JgtmJzg4Rhsm+gXqJ8qN/1yvYqVpRNfYPPVJYnrollSJGVrvCrC4wUFk IdpqfUtzicDRK8miGz+jmQctrY+/o6GwijbApXyG45r41Ri97mA00E0coBU5Z/PEBL0b TUiBfdUBZOjfPnUboO1bk1L7q6HIll6XsZ7osayY+qMc41OkJ3VY/UElEiSnJG8DY+Gl wA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 351kwhtbqh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Nov 2020 18:40:06 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0ARIV6xL096061; Fri, 27 Nov 2020 18:40:06 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 351kwhqw9s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Nov 2020 18:40:05 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0ARIe0Rd028807; Fri, 27 Nov 2020 18:40:00 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 27 Nov 2020 10:39:59 -0800 (PST) From: Drew Adams To: Juri Linkov , Lars Ingebrigtsen Subject: RE: bug#41198: 28.0.50; heading cycling command for outline References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> In-Reply-To: <87k0u7kxrz.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9818 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=993 adultscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011270109 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9818 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 clxscore=1011 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011270109 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41198 Cc: "Paul W. Rankin" , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I wonder why heading cycling implemented in this bug report > supports only `outline-mode', but not `outline-minor-mode'? `outline-minor-mode' is a thousand times more useful than `outline-mode', IMO. There should probably be few cases where no other major mode makes sense, and we really want to use `outline-mode'. (Just a guess.) From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 27 20:59:26 2020 Received: (at 41198) by debbugs.gnu.org; 28 Nov 2020 01:59:26 +0000 Received: from localhost ([127.0.0.1]:46687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kipWI-0002qo-3i for submit@debbugs.gnu.org; Fri, 27 Nov 2020 20:59:26 -0500 Received: from sendmail.purelymail.com ([34.202.193.197]:59142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kipWG-0002qc-EO for 41198@debbugs.gnu.org; Fri, 27 Nov 2020 20:59:25 -0500 DKIM-Signature: a=rsa-sha256; b=D91zBL4aqDq39UgtaY3CJcNLJMUdsQixGYH+c/gB3OTrvDv1X0gl4Wt+GrYAD0aQWaEAM9epW0Z0vtze9bQ5uaAQ9Fvs4mEtCz3KibhnChSquaYlCcu/WVvMxJjsUeaMw2vlQCWMJifTRH1ha0EpICIhNgQ93lT4y8Z0dAk+Cnw3D6fuKw+Y917CuVGqdD69KtPjxk7SVLtWVdml91dIzyQRCQmYOOHh2gFq3gftqoVUElBsoGMT7iminpl1izOpI99oKc0TELXl+lE09PJoUK9JrKqVWg3lZAWf1qs8GCUxAKmvurPDRWcMpgmDfWijqiZcxPVJbqbB21K8c/PizA==; s=purelymail3; d=skeletons.cc; v=1; bh=h5kzDWLWc94D+qSGauvFBqm6A7wzthOFlCiWy8mBfqs=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=Dge+GyMAdCLikP9kdKBLmUHB9f34NfO+cYnLZyVSvUGStg30Svk7tbatXmftyg6m+SvvtsC8spvsQBU7DtlifI+fIyZPN4vk+I9/KWaraIJloVBwEhOnnsJ41gqjjd3igg4smmwPLA1a1pNMo7+lv3n9sZDjyVVAkq7F+QGmVzQ3N8IiULgUlKw4BNUH6AL+9OSTVJ664n2TXXLhSJL0+TEHy6Xp1NP6EgTlSBj2LLqBGwwVG/frah/k9gAiYF77K1DHyqMOA17CAxcxBCkwuTs8yv55DRhyhHq2Pk7V1oGB6nVSd4Fj+5peVw2Zl/W1KkMGsFKZ6x2lLCoIGI/4Gw==; s=purelymail3; d=purelymail.com; v=1; bh=h5kzDWLWc94D+qSGauvFBqm6A7wzthOFlCiWy8mBfqs=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: 41198@debbugs.gnu.org Received: by ip-172-30-0-124.ec2.internal (JAMES SMTP Server ) with ESMTPA ID 1934417705; Sat, 28 Nov 2020 01:58:51 +0000 (UTC) MIME-Version: 1.0 Date: Sat, 28 Nov 2020 11:58:51 +1000 From: "Paul W. Rankin" To: Juri Linkov Subject: Re: bug#41198: 28.0.50; heading cycling command for outline In-Reply-To: <87k0u7kxrz.fsf@mail.linkov.net> References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> User-Agent: Purely Mail via Roundcube/1.4.7 Message-ID: X-Sender: pwr@skeletons.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41198 Cc: Lars Ingebrigtsen , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-11-27 18:29, Juri Linkov wrote: > I tried to modify the format of `C-h b' to output '*' headings, > but unfortunately after enabling `outline-minor-mode' > TAB has no effect on such headings. > > I wonder why heading cycling implemented in this bug report > supports only `outline-mode', but not `outline-minor-mode'? > > It would make sense in `outline-minor-mode' if TAB typed on a heading > then cycle outline heading. If TAB is typed outside of a heading, > then use the default TAB binding, e.g. in case of the Help buffer > navigate to the next link. This is because it's not possible to know how the underlying major mode implements TAB. For just one example, I maintain a major mode where TAB performs outline cycling when at a heading, but calls completion-at-point when at a heading but at eolp. The assumption of outline-on-heading-p is insufficient to allow outline-minor-mode to hijack TAB. The correct way to implement what you're suggesting is for the major mode to require outline as a library, then alias the cycling commands prefixed as MODE-outline-cycle[-buffer] mapped them to TAB/S-TAB in their own keymaps. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 10 14:08:38 2020 Received: (at submit) by debbugs.gnu.org; 10 Dec 2020 19:08:38 +0000 Received: from localhost ([127.0.0.1]:39295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knRIs-0004Ww-Gv for submit@debbugs.gnu.org; Thu, 10 Dec 2020 14:08:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:56414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knRIq-0004Wo-Nz for submit@debbugs.gnu.org; Thu, 10 Dec 2020 14:08:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knRIo-00004s-To for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 14:08:35 -0500 Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:56864 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knRIn-0004jJ-3G for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 14:08:34 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1knRIe-0007lv-8e for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 20:08:24 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Howard Melman Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Date: Thu, 10 Dec 2020 14:08:17 -0500 Message-ID: References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cancel-Lock: sha1:n3eFvIVdNmQvzMMYn2gD2GPNyn4= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) "Paul W. Rankin" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > On 2020-11-27 18:29, Juri Linkov wrote: >> I wonder why heading cycling implemented in this bug >> report supports only `outline-mode', but not >> `outline-minor-mode'? It would make sense in >> `outline-minor-mode' if TAB typed on a heading then cycle >> outline heading. If TAB is typed outside of a heading, >> then use the default TAB binding, e.g. in case of the >> Help buffer navigate to the next link. > > This is because it's not possible to know how the underlying major > mode implements TAB. > > For just one example, I maintain a major mode where TAB performs > outline cycling when at a heading, but calls completion-at-point when > at a heading but at eolp. The assumption of outline-on-heading-p is > insufficient to allow outline-minor-mode to hijack TAB. > > The correct way to implement what you're suggesting is for the major > mode to require outline as a library, then alias the cycling commands > prefixed as MODE-outline-cycle[-buffer] mapped them to TAB/S-TAB in > their own keymaps. I don't follow master so I'm not quite sure what's implemented, but my original suggestion for this was: (define-key outline-minor-mode-map (kbd "C-") 'outline-cycle) (define-key outline-minor-mode-map (kbd "S-") 'outline-global-cycle) It's definitely very useful in outline-minor-mode. I use this for code folding in prog-modes amongst other things and that's one of the reasons I used C-TAB for outline-cycle (since TAB often has other uses in prog-modes). AFAIR people commented that C-TAB wasn't always available in some terminals and said it should just be on TAB. Fine. Either way S-TAB should work. I'd argue that if you're enabling outline-minor-mode in a major mode that has a binding for TAB, you want it to be overridden. If not, don't enable the minor mode or change one keymap to not conflict. Maybe outline-minor-mode should support a variable option a major mode could set to change the TAB keybinding or at least not override it with a minor-mode binding? -- Howard From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 16:08:56 2020 Received: (at 41198) by debbugs.gnu.org; 12 Dec 2020 21:08:56 +0000 Received: from localhost ([127.0.0.1]:46923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC8N-0004vP-R6 for submit@debbugs.gnu.org; Sat, 12 Dec 2020 16:08:56 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC8J-0004uo-Qf for 41198@debbugs.gnu.org; Sat, 12 Dec 2020 16:08:52 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B0A5420005; Sat, 12 Dec 2020 21:08:45 +0000 (UTC) From: Juri Linkov To: Howard Melman Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> Date: Sat, 12 Dec 2020 22:57:02 +0200 In-Reply-To: (Howard Melman's message of "Thu, 10 Dec 2020 14:08:17 -0500") Message-ID: <87360a68v5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41198 Cc: 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I don't follow master so I'm not quite sure what's > implemented, but my original suggestion for this was: > > (define-key outline-minor-mode-map (kbd "C-") 'outline-cycle) > (define-key outline-minor-mode-map (kbd "S-") 'outline-global-cycle) > > It's definitely very useful in outline-minor-mode. I use > this for code folding in prog-modes amongst other things and > that's one of the reasons I used C-TAB for outline-cycle > (since TAB often has other uses in prog-modes). > > AFAIR people commented that C-TAB wasn't always available in > some terminals and said it should just be on TAB. Fine. > Either way S-TAB should work. > > I'd argue that if you're enabling outline-minor-mode in a > major mode that has a binding for TAB, you want it to be > overridden. If not, don't enable the minor mode or change > one keymap to not conflict. Maybe outline-minor-mode should > support a variable option a major mode could set to change > the TAB keybinding or at least not override it with a > minor-mode binding? This feature request was closed, so in a new feature request in https://debbugs.gnu.org/45147#8 this is implemented as a new variable 'outline-minor-mode-cycle' that you can set to t to allow cycling keys in 'outline-minor-mode', and a keymap 'outline-mode-cycle-map' where you can define your bindings such as C-TAB instead of the default key TAB. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 15:38:05 2020 Received: (at 41198) by debbugs.gnu.org; 14 Dec 2020 20:38:05 +0000 Received: from localhost ([127.0.0.1]:54667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koubc-0002uX-K8 for submit@debbugs.gnu.org; Mon, 14 Dec 2020 15:38:05 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:36853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koubX-0002tO-0c for 41198@debbugs.gnu.org; Mon, 14 Dec 2020 15:38:02 -0500 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id DD50E100006; Mon, 14 Dec 2020 20:37:51 +0000 (UTC) From: Juri Linkov To: Howard Melman Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> Date: Mon, 14 Dec 2020 22:31:57 +0200 In-Reply-To: (Howard Melman's message of "Thu, 10 Dec 2020 14:08:17 -0500") Message-ID: <87eejs164i.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41198 Cc: 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I don't follow master so I'm not quite sure what's > implemented, but my original suggestion for this was: > > (define-key outline-minor-mode-map (kbd "C-") 'outline-cycle) > (define-key outline-minor-mode-map (kbd "S-") 'outline-global-cycle) This is what's implemented in master: (define-key outline-minor-mode-map (kbd "") 'outline-cycle) (define-key outline-minor-mode-map (kbd "") 'outline-cycle-buffer) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 19:10:10 2020 Received: (at submit) by debbugs.gnu.org; 15 Dec 2020 00:10:10 +0000 Received: from localhost ([127.0.0.1]:54880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koxur-0001ql-Us for submit@debbugs.gnu.org; Mon, 14 Dec 2020 19:10:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:53938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koxuq-0001qc-H4 for submit@debbugs.gnu.org; Mon, 14 Dec 2020 19:10:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koxuq-0008N5-BX for bug-gnu-emacs@gnu.org; Mon, 14 Dec 2020 19:10:08 -0500 Received: from ciao.gmane.io ([116.202.254.214]:50678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koxuo-0002Z6-H7 for bug-gnu-emacs@gnu.org; Mon, 14 Dec 2020 19:10:08 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1koxuk-0009XL-KB for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2020 01:10:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Howard Melman Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Date: Mon, 14 Dec 2020 19:09:58 -0500 Message-ID: References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> <87eejs164i.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cancel-Lock: sha1:n6lTI9c1yMKbTGx1OPLcJ+8uakU= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Juri Linkov writes: >> I don't follow master so I'm not quite sure what's >> implemented, but my original suggestion for this was: >> >> (define-key outline-minor-mode-map (kbd "C-") 'outline-cycle) >> (define-key outline-minor-mode-map (kbd "S-") 'outline-global-cycle) > > This is what's implemented in master: > > (define-key outline-minor-mode-map (kbd "") 'outline-cycle) > (define-key outline-minor-mode-map (kbd "") 'outline-cycle-buffer) Sounds great. I look forward to Emacs 28. -- Howard From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 22:46:17 2020 Received: (at 41198) by debbugs.gnu.org; 15 Dec 2020 03:46:17 +0000 Received: from localhost ([127.0.0.1]:55025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kp1I1-0000t6-1x for submit@debbugs.gnu.org; Mon, 14 Dec 2020 22:46:17 -0500 Received: from mail-pg1-f182.google.com ([209.85.215.182]:43152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kp1Hy-0000ss-66 for 41198@debbugs.gnu.org; Mon, 14 Dec 2020 22:46:14 -0500 Received: by mail-pg1-f182.google.com with SMTP id n10so6302891pgl.10 for <41198@debbugs.gnu.org>; Mon, 14 Dec 2020 19:46:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeisgreat-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yxECdLt/J0N3PvdbD0uOwfUk78F9e/L3I6SRoTm/NL8=; b=H2YkXHTvRmlBuRVgWbsRw5eS8duecNMBJ7USZ6WcuEF6vv2TWl13/HmXHTOGNE3cGd nNA81lhFiJB6ADoZIvMVfgXxMWepaMlxXbZPZbSm8OvtgcUHH4B+1xPgcKgjj+aYnE46 SLZZWq8L5kG+IVPAcGo/0kcCR7VosSvV7PXBKskKhDUck55mlkTYNpgjlWv7Ib59xb0c etiupBUrPCSv16G8n7uscJAdJpe3eCH0FuaiJWCPtDbPFjboqUDVOiFfiUw8ol3TTHu2 jQ5G256mkVYdDw0ZZckx/WIsG2bswnFCl9PjooxSCDhNN3gT1Nf2y+W2hFnfVP0URSiU a7Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=yxECdLt/J0N3PvdbD0uOwfUk78F9e/L3I6SRoTm/NL8=; b=Uci61R98BZVitVYMhReZjiwaQPeJJrDQmC3ZFMSkyCrBcopf8TcT8ltbjLYopeThEk Z1AbztiTAcKpEJqCG+F7rt9aaC3iwEam4iKDfJwVIz9Jw5Uq65KcVsK/7M2IE6xy1FLh 560WmprjFb6GGRwosxNwlb9nM314kXjnW7gngJ6lhFPXokb9Du2lFyDKZPt5gn0TB2R5 pSaqGLjVZQ0BxoomEy8sQWAWR5pjJmSCV/Tkt5pr93lNZu0+JUcY8lixr6Q44c1dM+Va MkTw2Rmpc3XkjkTbCtG9KzYppbwzQgHRpL58J18PkHhus5Jg903JNiqmGrCP/QktzIt8 xXNQ== X-Gm-Message-State: AOAM530OKlDhORAHDI7GvVfMvkTBeD8jg5LjeYKdiFVyNUfsTqQETNhu XphOHCfhmKIX+UdjoxFmQdZYLxeB66CepQ== X-Google-Smtp-Source: ABdhPJyyXn5v/p4pQFQBDmbnl5R0DgnHITAMTNB3O5V+VEwSBMy69IcFq6IVw2F2hWQu4LhoGK3atQ== X-Received: by 2002:a05:6a00:2382:b029:198:15a2:aaf9 with SMTP id f2-20020a056a002382b029019815a2aaf9mr26236589pfc.39.1608003968015; Mon, 14 Dec 2020 19:46:08 -0800 (PST) Received: from lt ([2405:201:5c06:70bb:a64e:31ff:fe0c:338c]) by smtp.gmail.com with ESMTPSA id s24sm16043671pfh.47.2020.12.14.19.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 19:46:07 -0800 (PST) From: Pankaj Jangid To: Juri Linkov Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: Code Is Great Foundation References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> <87eejs164i.fsf@mail.linkov.net> Date: Tue, 15 Dec 2020 09:16:04 +0530 In-Reply-To: <87eejs164i.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 14 Dec 2020 22:31:57 +0200") Message-ID: <87lfdzlojn.fsf@codeisgreat.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41198 Cc: Howard Melman , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Juri Linkov writes: >> I don't follow master so I'm not quite sure what's >> implemented, but my original suggestion for this was: >> >> (define-key outline-minor-mode-map (kbd "C-") 'outline-cycle) >> (define-key outline-minor-mode-map (kbd "S-") 'outline-global-cycle) > > This is what's implemented in master: > > (define-key outline-minor-mode-map (kbd "") 'outline-cycle) > (define-key outline-minor-mode-map (kbd "") 'outline-cycle-buffe= r) 1. and have same binding on master i.e. both invoking =E2=80=98outline-cycle=E2=80=99. 2. Body of last heading doesn=E2=80=99t hide when using the above command. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 15 04:20:26 2020 Received: (at 41198) by debbugs.gnu.org; 15 Dec 2020 09:20:26 +0000 Received: from localhost ([127.0.0.1]:55603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kp6VN-0006BR-TN for submit@debbugs.gnu.org; Tue, 15 Dec 2020 04:20:26 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kp6VM-0006BE-FJ for 41198@debbugs.gnu.org; Tue, 15 Dec 2020 04:20:24 -0500 X-Originating-IP: 91.129.99.98 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A3D80FF80F; Tue, 15 Dec 2020 09:20:17 +0000 (UTC) From: Juri Linkov To: Pankaj Jangid Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> <87eejs164i.fsf@mail.linkov.net> <87lfdzlojn.fsf@codeisgreat.org> Date: Tue, 15 Dec 2020 11:10:40 +0200 In-Reply-To: <87lfdzlojn.fsf@codeisgreat.org> (Pankaj Jangid's message of "Tue, 15 Dec 2020 09:16:04 +0530") Message-ID: <87blev4epb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41198 Cc: Howard Melman , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> I don't follow master so I'm not quite sure what's >>> implemented, but my original suggestion for this was: >>> >>> (define-key outline-minor-mode-map (kbd "C-") 'outline-cycle) >>> (define-key outline-minor-mode-map (kbd "S-") 'outline-global-cycle) >> >> This is what's implemented in master: >> >> (define-key outline-minor-mode-map (kbd "") 'outline-cycle) >> (define-key outline-minor-mode-map (kbd "") 'outline-cycle-buffer) > > 1. and have same binding on master i.e. both invoking > ‘outline-cycle’. I meant that with current master it's possible to add these bindings in the init file because C-TAB and S-TAB they can't be bound by default in outline-minor-mode to not interfere with major mode key bindings. In outline-mode (not minor) in current master, TAB is bound to outline-cycle, and S-TAB is bound to outline-cycle-buffer, but C-TAB is unbound in outline-mode to not interfere with other uses of C-TAB. > 2. Body of last heading doesn’t hide when using the above command. This sounds like a bug. Please provide a recipe for reproducing it. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 15 05:42:20 2020 Received: (at 41198) by debbugs.gnu.org; 15 Dec 2020 10:42:20 +0000 Received: from localhost ([127.0.0.1]:55733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kp7me-0008NG-5K for submit@debbugs.gnu.org; Tue, 15 Dec 2020 05:42:20 -0500 Received: from mail-pg1-f171.google.com ([209.85.215.171]:46628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kp7mc-0008N3-Gr for 41198@debbugs.gnu.org; Tue, 15 Dec 2020 05:42:19 -0500 Received: by mail-pg1-f171.google.com with SMTP id w4so14919881pgg.13 for <41198@debbugs.gnu.org>; Tue, 15 Dec 2020 02:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeisgreat-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rPymQ9ddfvMgGCZQoVgizCDUKs7wNNL0EjzwqTOdE48=; b=tWEPvyERHmpl4JKG4ppYkXSU25xd2NM8PkDySnChsiLUdVguHlzuBKS9DwyVGS7Tys 3qd2LRmJVS7dE5Pbd8L7i+i/S77RHiYTZpRel0Hs22kC61ShuQ/4E1PcVpjqTgrCjqJD Ziove2hDh4kDmamuvEgG3/Bj7bayVNC1rbn9seoQ6l0dEjuzzwhicWBcm2gbeghmYnli +VBEEY1tbeHxjgjuRvrvMsSZTookOe/dtc7nxIfqO31+gGvJ2aKBG3fX31OsN9TFrZ35 LaVanb8FewGZsH4n7ioXEMm0ZXoLLBqlNiUzGfG7LtqLMiIUP83DYCPyE5fb9kmy/eIc XJJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=rPymQ9ddfvMgGCZQoVgizCDUKs7wNNL0EjzwqTOdE48=; b=dlai1sASRVQ5HwYpODLiAtFHVZnylJ13ngSSsrYNbACCAq4ZCRbDLmQ2JjZic2v9rv 26v/zWg6PHbKsswVIgZZyO0aoUj4AmQp1+EUzx8h5Jh7v9bwcwBkSnr+/GrWkgOwhINr 9bnDy/bcNojnZVC2xsc+V4+w2fMUQ1bJFVts4x3hw8gxqnYqkKlhGdta91hAI7o9Di4X AboNIbmhjWdbta1dNnngPbognPSr3p4HSxRnVbY9CykpY7irrn+iJRbfv6m/Z0DjjCZx dhnYy/0d/niWTb+klGFQ5/PosxLtnM+tM9RsOrafGoCP20IwR+Uml5HzhB44zRIw+sMR 9Xdw== X-Gm-Message-State: AOAM530HdpBQWE50bkh1fCjpRuJhkDeFtRrwATtwFZIBaBmaz5tKL1Xh a40waD6sSqif2DlhLa0KUPhANTxQAbajgA== X-Google-Smtp-Source: ABdhPJwv51em6kBl4ISbGmkA2ceisBIx966jr+X+wHW8RcouGqBmEAEBMmTx1feRPydLH8wc1uGUVQ== X-Received: by 2002:a63:6344:: with SMTP id x65mr1456006pgb.172.1608028932318; Tue, 15 Dec 2020 02:42:12 -0800 (PST) Received: from lt ([2405:201:5c06:70bb:a64e:31ff:fe0c:338c]) by smtp.gmail.com with ESMTPSA id j15sm18743621pfn.180.2020.12.15.02.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 02:42:11 -0800 (PST) From: Pankaj Jangid To: Juri Linkov Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: Code Is Great Foundation References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> <87eejs164i.fsf@mail.linkov.net> <87lfdzlojn.fsf@codeisgreat.org> <87blev4epb.fsf@mail.linkov.net> Date: Tue, 15 Dec 2020 16:12:08 +0530 In-Reply-To: <87blev4epb.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 15 Dec 2020 11:10:40 +0200") Message-ID: <87tusn8i67.fsf@codeisgreat.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41198 Cc: Howard Melman , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Juri Linkov writes: >> 2. Body of last heading doesn=E2=80=99t hide when using the above comman= d. > > This sounds like a bug. Please provide a recipe for reproducing it. Sorry. This was my fault. Somehow I was expecting all headings to collapse with TAB key. TAB and S-TAB are perfectly working. Not related. At present, I am on a text base virtual terminal on Debian. And S-TAB is invoking C-M-i which triggers ispell-complete-word. Is this a bug? To test the above thing,I had to startx. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 15 15:23:50 2020 Received: (at 41198) by debbugs.gnu.org; 15 Dec 2020 20:23:50 +0000 Received: from localhost ([127.0.0.1]:59226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpGrO-0005WS-6d for submit@debbugs.gnu.org; Tue, 15 Dec 2020 15:23:50 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:41481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpGrK-0005Vk-7p for 41198@debbugs.gnu.org; Tue, 15 Dec 2020 15:23:47 -0500 Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 502C6240005; Tue, 15 Dec 2020 20:23:37 +0000 (UTC) From: Juri Linkov To: Pankaj Jangid Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: LINKOV.NET References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> <87eejs164i.fsf@mail.linkov.net> <87lfdzlojn.fsf@codeisgreat.org> <87blev4epb.fsf@mail.linkov.net> <87tusn8i67.fsf@codeisgreat.org> Date: Tue, 15 Dec 2020 22:23:19 +0200 In-Reply-To: <87tusn8i67.fsf@codeisgreat.org> (Pankaj Jangid's message of "Tue, 15 Dec 2020 16:12:08 +0530") Message-ID: <87v9d23mc8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41198 Cc: Howard Melman , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Not related. At present, I am on a text base virtual terminal on > Debian. And S-TAB is invoking C-M-i which triggers > ispell-complete-word. Is this a bug? To test the above thing,I had to > startx. Doesn't look like a bug. S-TAB is unavailable on some terminals. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 15 23:02:35 2020 Received: (at 41198) by debbugs.gnu.org; 16 Dec 2020 04:02:35 +0000 Received: from localhost ([127.0.0.1]:59567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpO1K-0002Zf-Vk for submit@debbugs.gnu.org; Tue, 15 Dec 2020 23:02:35 -0500 Received: from mail-pj1-f54.google.com ([209.85.216.54]:33078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpO1K-0002ZT-2s for 41198@debbugs.gnu.org; Tue, 15 Dec 2020 23:02:34 -0500 Received: by mail-pj1-f54.google.com with SMTP id w1so941467pjc.0 for <41198@debbugs.gnu.org>; Tue, 15 Dec 2020 20:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeisgreat-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OS/XqASfxIqSLfzP29Lz1YaCYWYYi+RhUKvMZNTa6LQ=; b=h1RIhnKScOS2NICPaPd+NuxLrr1F9q49oSeWJNott8T/BwddPgkAN3HFG2pR5+mWGn q3zxsIcAyyvCaNStikx3pmesQSe1Uu9saRuiVphjPO44pKwO34ChspAjsLLHl8ZTwC6R +OP/NVLX638EmYGBw1SHcprV0zgVC9zSq8+2/jZayoYiHwRKxI2utINPM/iprhizHfLU TBey6VisnDnP7nmLhT75cJyANtMJD/e3GVScH9jaF8JiyDtwhoNiZlagKSHz98+Dm1DK QU64h/J++vNmia/Bw0nxoTLU8bHAF8SRF8wsqHZ88zKi+V9Vg3/LMRkL4kfIC4DM+lHe p8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=OS/XqASfxIqSLfzP29Lz1YaCYWYYi+RhUKvMZNTa6LQ=; b=M/PUqZye/gvFXdjOaVo6Kc8mV0JFvZ/pZ4ojp2Kr+mlL1dGonywNXKJC9PIovUmCLs kPu+pqHXbT1GP48QejFzO/Ul37AZwqy4j3LswcC/rj0mXnuqEuIWnV8BItGsi8fC9CRW mmqZNAHU0+4moAsT6LU2U1RgWzPEXxdBY+t/a6S2hZK/NKYXtudwgc1bE7mimx7Oxk1J qVFMVOr78nCsl0m053eugononqYzi8YCYA68/XRE3NPPRcYhNmUNNDOWzQsxxhXEkiUu aZy/h0F7wGhlFj9AnKcVhpbSvpWT5gyawZNlCXteD1QMK2OXS35ht5/ir9Q6R+8AfSbV IQ9A== X-Gm-Message-State: AOAM530ylDZ1ktA0dgOHrYJwd+tZ312sXg6aoQ5aRJPs6h4VmeHU25BB 2ICSoLXt5zs/PIaUOIuYOcOzPTZYfJEw0g== X-Google-Smtp-Source: ABdhPJzYrexp8uvs5/rTJ8zwJDro3ShhA0wjw/S/hBMO0bKvhc8iTYoaPMVFY/v/dpcQsXd38l3kJg== X-Received: by 2002:a17:902:b606:b029:da:c8ed:7c2e with SMTP id b6-20020a170902b606b02900dac8ed7c2emr29855808pls.5.1608091347640; Tue, 15 Dec 2020 20:02:27 -0800 (PST) Received: from lt ([2405:201:5c06:70bb:a64e:31ff:fe0c:338c]) by smtp.gmail.com with ESMTPSA id t135sm529775pfc.39.2020.12.15.20.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 20:02:27 -0800 (PST) From: Pankaj Jangid To: Juri Linkov Subject: Re: bug#41198: 28.0.50; heading cycling command for outline Organization: Code Is Great Foundation References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> <87ft4ze3xz.fsf@gnus.org> <87h7pdbgvd.fsf@mail.linkov.net> <87sg8wxw6p.fsf@gnus.org> <87k0u7kxrz.fsf@mail.linkov.net> <87eejs164i.fsf@mail.linkov.net> <87lfdzlojn.fsf@codeisgreat.org> <87blev4epb.fsf@mail.linkov.net> <87tusn8i67.fsf@codeisgreat.org> <87v9d23mc8.fsf@mail.linkov.net> Date: Wed, 16 Dec 2020 09:32:24 +0530 In-Reply-To: <87v9d23mc8.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 15 Dec 2020 22:23:19 +0200") Message-ID: <87sg86v1nz.fsf@codeisgreat.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41198 Cc: Howard Melman , 41198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Juri Linkov writes: >> Not related. At present, I am on a text base virtual terminal on >> Debian. And S-TAB is invoking C-M-i which triggers >> ispell-complete-word. Is this a bug? To test the above thing,I had to >> startx. > > Doesn't look like a bug. S-TAB is unavailable on some terminals. I guess, I was not clear enough. By text based virtual terminal I meant when X is not running. The default text console of debian. From unknown Fri Jun 20 07:21:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Jan 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator